Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/814296/?format=api
{ "id": 814296, "url": "http://patchwork.ozlabs.org/api/patches/814296/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/patch/20170915140411.31716-6-romain.izard.pro@gmail.com/", "project": { "id": 3, "url": "http://patchwork.ozlabs.org/api/projects/3/?format=api", "name": "Linux MTD development", "link_name": "linux-mtd", "list_id": "linux-mtd.lists.infradead.org", "list_email": "linux-mtd@lists.infradead.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170915140411.31716-6-romain.izard.pro@gmail.com>", "list_archive_url": null, "date": "2017-09-15T14:04:07", "name": "[v2,5/9] mtd: nand: atmel: Report PMECC failures as errors", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "6e55509c1e4579dc3e4fb3dd7803ca05eb9665af", "submitter": { "id": 8236, "url": "http://patchwork.ozlabs.org/api/people/8236/?format=api", "name": "Romain Izard", "email": "romain.izard.pro@gmail.com" }, "delegate": { "id": 58324, "url": "http://patchwork.ozlabs.org/api/users/58324/?format=api", "username": "bbrezillon", "first_name": "Boris", "last_name": "Brezillon", "email": "boris.brezillon@free-electrons.com" }, "mbox": "http://patchwork.ozlabs.org/project/linux-mtd/patch/20170915140411.31716-6-romain.izard.pro@gmail.com/mbox/", "series": [ { "id": 3316, "url": "http://patchwork.ozlabs.org/api/series/3316/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/list/?series=3316", "date": "2017-09-15T14:04:02", "name": "Various patches for SAMA5D2 backup mode", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/3316/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/814296/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/814296/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"k+IfxLst\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"OqgyhTsS\"; dkim-atps=neutral" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xty0m6tm9z9s7m\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 16 Sep 2017 00:08:08 +1000 (AEST)", "from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dsrHk-0007A0-8A; Fri, 15 Sep 2017 14:08:00 +0000", "from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dsrFN-0004JC-A7; Fri, 15 Sep 2017 14:05:37 +0000", "by mail-wm0-x242.google.com with SMTP id f4so2879123wmh.4;\n\tFri, 15 Sep 2017 07:05:09 -0700 (PDT)", "from localhost.localdomain (146.187.3.109.rev.sfr.net.\n\t[109.3.187.146]) by smtp.gmail.com with ESMTPSA id\n\t55sm1399225wrw.60.2017.09.15.07.04.58\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 15 Sep 2017 07:05:07 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References:\n\tIn-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Owner;\n\tbh=B14KBsFptgoCrFKlgdF3/XtK8oPediLw1bhtTQ5qHD4=;\n\tb=k+IfxLstnedmbbXjbzSwNyPI8c\n\tHHRbCAwCQH/O8cOA39m1GiZROGYeIXXgGotqSu64rRqXW2J+gHdFvSVeMFcc/iiTO34A9oaWUmNyG\n\tcGQ77uYI74s8WwHI3H0xn4Abqo7bdhjmI1up5f5ZdrqKCupphsEJv3vBG22WKOGSsLKGwXF9pTcWc\n\tsSCb2wuaNbFkJyOyMMNNZhj5Wt4dYg+CrNSB87J48zv0SLYL9qKy9hcwpSK86k6W/i/aE1J2Fxn0k\n\t0a3j3W1BLFoaoKrB7ft+OKC1LlAs1hU8tKpL0G3bFRfpZOOrZC+HXjwJ+K5V+mo9X4WrsQKzZHlMF\n\tjyx9811g==;", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=aaNnsNahYIjh+1Ks16UeHfn5wML1ytVR6uApSlam0ak=;\n\tb=OqgyhTsSOUMP1mVjyu/obvgk3bNOtKuna5CRZtg9kBCdhq7TnEgjhGITEIisIEQAW7\n\tMut/LLFCccw82cWRFBQRWeWN9egZpx86KwadjaGsCrevoyWSCp3nnrpQIIkbnEg5iVgz\n\tU6K7wLmk9ApCXK2EyUySCYTAPIuICMYbKpNGC2lqX6+lY/rJL0V1aZWkzZKaz1eYJdQ9\n\tryBJ+fI+RurDDJoy2zGUcUtN+PqZqmuT1zq4twvNm1r9GKLuMKycO5hzY6m2B7h5M1xl\n\toUekFS6p52VqfHfHPARmjvjiVTDWbhmIRYdNhOYbu96axJ/Uh+UgpoyFKyMSbo1RtoRk\n\t/tbw==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=aaNnsNahYIjh+1Ks16UeHfn5wML1ytVR6uApSlam0ak=;\n\tb=muB9Op0x1uXfRJcCLEFtiaZVkHkAVakRChwWnwvyTopE41XP1HaWUhqKsSPNTKq4bN\n\tkWowA5aTTcQQM262BC5kUHTpUhaSAAkLARqaO5pqVQZDJd/A2s3AsYBeOLHzfgzb2K1Y\n\tC6Vc+VdIvRsZUULo+ma26oVJOlVt12uJ9zTHqhW7g6SY9JFvCO+clibcTEcAKcQqcJe2\n\td9LvTCeBD+pChEzI5FBvNLtpcUw/tP8VjcMYgfPf4GxA7BB08P+CBzftaEJ9IZFJnZAL\n\tHJ0cchaNC23nzxfCbrt8imDWoGe/uijGiNx2kfxBOgM9utoAHsvacqzDA2xfRUXjESWf\n\tuKaw==", "X-Gm-Message-State": "AHPjjUin4LnbuSOOJllrW61WbL968wxaHkQOypNPSiwowu/dro0EPqPN\n\tmSXimiZ3UeVv5NjzL21bdsw=", "X-Google-Smtp-Source": "AOwi7QBnCD+VHqUcD6q/tJCH+iN6CxlbVr6SP3fS133oqL63dNXiXTxV1nTYTt8BdvqglV3ugcBYFA==", "X-Received": "by 10.28.30.133 with SMTP id e127mr2668086wme.8.1505484307983;\n\tFri, 15 Sep 2017 07:05:07 -0700 (PDT)", "From": "Romain Izard <romain.izard.pro@gmail.com>", "To": "Nicolas Ferre <nicolas.ferre@microchip.com>,\n\tAlexandre Belloni <alexandre.belloni@free-electrons.com>,\n\tBoris Brezillon <boris.brezillon@free-electrons.com>,\n\tMichael Turquette <mturquette@baylibre.com>,\n\tStephen Boyd <sboyd@codeaurora.org>,\n\tLudovic Desroches <ludovic.desroches@microchip.com>,\n\tWenyou Yang <wenyou.yang@atmel.com>, Josh Wu <rainyfeeling@outlook.com>, \n\tDavid Woodhouse <dwmw2@infradead.org>,\n\tBrian Norris <computersforpeace@gmail.com>,\n\tMarek Vasut <marek.vasut@gmail.com>,\n\tCyrille Pitchen <cyrille.pitchen@wedev4u.fr>,\n\tThierry Reding <thierry.reding@gmail.com>,\n\tRichard Genoud <richard.genoud@gmail.com>,\n\tGreg Kroah-Hartman <gregkh@linuxfoundation.org>,\n\tAlan Stern <stern@rowland.harvard.edu>", "Subject": "[PATCH v2 5/9] mtd: nand: atmel: Report PMECC failures as errors", "Date": "Fri, 15 Sep 2017 16:04:07 +0200", "Message-Id": "<20170915140411.31716-6-romain.izard.pro@gmail.com>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": "<20170915140411.31716-1-romain.izard.pro@gmail.com>", "References": "<20170915140411.31716-1-romain.izard.pro@gmail.com>", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20170915_070534_103491_1662E939 ", "X-CRM114-Status": "GOOD ( 10.49 )", "X-Spam-Score": "-2.0 (--)", "X-Spam-Report": "SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2a00:1450:400c:c09:0:0:0:242 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (romain.izard.pro[at]gmail.com)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain", "X-BeenThere": "linux-mtd@lists.infradead.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-mtd>,\n\t<mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-mtd/>", "List-Post": "<mailto:linux-mtd@lists.infradead.org>", "List-Help": "<mailto:linux-mtd-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-mtd>,\n\t<mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>", "Cc": "linux-pwm@vger.kernel.org, linux-usb@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,\n\tlinux-serial@vger.kernel.org, Romain Izard <romain.izard.pro@gmail.com>, \n\tlinux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"linux-mtd\" <linux-mtd-bounces@lists.infradead.org>", "Errors-To": "linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "It is not normal for the PMECC to fail when trying to fix ECC errors.\nReport these cases as errors.\n\nSigned-off-by: Romain Izard <romain.izard.pro@gmail.com>\n---\n drivers/mtd/nand/atmel/pmecc.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/mtd/nand/atmel/pmecc.c b/drivers/mtd/nand/atmel/pmecc.c\nindex 8d1208f38025..2a23f1ff945f 100644\n--- a/drivers/mtd/nand/atmel/pmecc.c\n+++ b/drivers/mtd/nand/atmel/pmecc.c\n@@ -687,6 +687,8 @@ static int atmel_pmecc_err_location(struct atmel_pmecc_user *user)\n \t * Number of roots does not match the degree of smu\n \t * unable to correct error.\n \t */\n+\tdev_err(pmecc->dev,\n+\t\t\"PMECC: Impossible to calculate error location.\\n\");\n \treturn -EBADMSG;\n }\n \n@@ -729,7 +731,7 @@ int atmel_pmecc_correct_sector(struct atmel_pmecc_user *user, int sector,\n \t\t\tptr = ecc + byte - sectorsize;\n \t\t\tarea = \"ECC\";\n \t\t} else {\n-\t\t\tdev_dbg(pmecc->dev,\n+\t\t\tdev_err(pmecc->dev,\n \t\t\t\t\"Invalid errpos value (%d, max is %d)\\n\",\n \t\t\t\terrpos, (sectorsize + eccbytes) * 8);\n \t\t\treturn -EINVAL;\n", "prefixes": [ "v2", "5/9" ] }