[{"id":1770050,"web_url":"http://patchwork.ozlabs.org/comment/1770050/","msgid":"<20170918120051.298bdabf@bbrezillon>","list_archive_url":null,"date":"2017-09-18T10:00:51","subject":"Re: [PATCH v2 5/9] mtd: nand: atmel: Report PMECC failures as errors","submitter":{"id":63120,"url":"http://patchwork.ozlabs.org/api/people/63120/","name":"Boris Brezillon","email":"boris.brezillon@free-electrons.com"},"content":"Hi Romain,\n\nOn Fri, 15 Sep 2017 16:04:07 +0200\nRomain Izard wrote:\n\n> It is not normal for the PMECC to fail when trying to fix ECC errors.\n> Report these cases as errors.\n\nI'm not sure we want to have ECC error messages at this level. ECC\nerrors are rather unusual but not impossible, and sometimes it's even\nnot a real error (I'm thinking of bitflips in erased pages for\nexample, which are not necessarily detected/fixed in hardware).\n\nIf we decide to print error messages when unfixable bitflips are\ndetected, it should be done in the nand-controller driver (somewhere\nalong those lines [1]).\n\nRegards,\n\nBoris\n\n[1]http://elixir.free-electrons.com/linux/latest/source/drivers/mtd/nand/atmel/nand-controller.c#L827\n\n> \n> Signed-off-by: Romain Izard \n> ---\n> drivers/mtd/nand/atmel/pmecc.c | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/drivers/mtd/nand/atmel/pmecc.c b/drivers/mtd/nand/atmel/pmecc.c\n> index 8d1208f38025..2a23f1ff945f 100644\n> --- a/drivers/mtd/nand/atmel/pmecc.c\n> +++ b/drivers/mtd/nand/atmel/pmecc.c\n> @@ -687,6 +687,8 @@ static int atmel_pmecc_err_location(struct atmel_pmecc_user *user)\n> \t * Number of roots does not match the degree of smu\n> \t * unable to correct error.\n> \t */\n> +\tdev_err(pmecc->dev,\n> +\t\t\"PMECC: Impossible to calculate error location.\\n\");\n> \treturn -EBADMSG;\n> }\n> \n> @@ -729,7 +731,7 @@ int atmel_pmecc_correct_sector(struct atmel_pmecc_user *user, int sector,\n> \t\t\tptr = ecc + byte - sectorsize;\n> \t\t\tarea = \"ECC\";\n> \t\t} else {\n> -\t\t\tdev_dbg(pmecc->dev,\n> +\t\t\tdev_err(pmecc->dev,\n> \t\t\t\t\"Invalid errpos value (%d, max is %d)\\n\",\n> \t\t\t\terrpos, (sectorsize + eccbytes) * 8);\n> \t\t\treturn -EINVAL;","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"AEo1SlTM\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwhYv3vNwz9s7c\n\tfor ;\n\tMon, 18 Sep 2017 20:09:23 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtszQ-00055O-LZ; Mon, 18 Sep 2017 10:09:20 +0000","from mail.free-electrons.com ([62.4.15.54])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtsrj-0008Uw-O2; Mon, 18 Sep 2017 10:01:25 +0000","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 7B43B2084A; Mon, 18 Sep 2017 12:01:02 +0200 (CEST)","from bbrezillon (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr\n\t[90.63.216.87])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id E319F20828;\n\tMon, 18 Sep 2017 12:00:51 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=L10tlo8CFCoGbkPklZueG2ynH0N6tqPC05cNl0UGxA4=;\n\tb=AEo1SlTMsSY2/u\n\tvkf2LYmtts9r2S8WcEZZSaVV7PiUVta4TPjgEKtoai4E6/ffCw7pLDK3kC/NgBoIbv9O8Q2I7k42R\n\t0qfJ+KDAIwuyHSmLMy52ihu3TUlOfMaQPlqy6AUCNuxwHOjzkXdrPX4Ww369E6KelinXS3yu+xPsq\n\tF0LapZlsjjFyUwG+J6VZh0d14+JG0QLRr7UwKkVEwpetAoG5+8s8SiCOwSzAyNZf6s6V37qgH0FBg\n\tEzmE/L5o7dXfcH8Wb5+HjsT/RxYj7tgKzDkOScak2Yjk77lvZ5rjGyc0bWSc0mgB+gphtWpc+sd3f\n\tSdRbOl+NCbiPVNQt5Ibw==;","X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Date":"Mon, 18 Sep 2017 12:00:51 +0200","From":"Boris Brezillon ","To":"Romain Izard ","Subject":"Re: [PATCH v2 5/9] mtd: nand: atmel: Report PMECC failures as errors","Message-ID":"<20170918120051.298bdabf@bbrezillon>","In-Reply-To":"<20170915140411.31716-6-romain.izard.pro@gmail.com>","References":"<20170915140411.31716-1-romain.izard.pro@gmail.com>\n\t<20170915140411.31716-6-romain.izard.pro@gmail.com>","X-Mailer":"Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu)","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170918_030123_997991_F0B479BC ","X-CRM114-Status":"GOOD ( 17.44 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Michael Turquette , linux-kernel@vger.kernel.org,\n\tThierry Reding ,\n\tAlexandre Belloni ,\n\tlinux-clk@vger.kernel.org, Josh Wu ,\n\tMarek Vasut ,\n\tLudovic Desroches ,\n\tAlan Stern , linux-serial@vger.kernel.org, \n\tlinux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tRichard Genoud ,\n\tGreg Kroah-Hartman ,\n\tlinux-usb@vger.kernel.org, Stephen Boyd ,\n\tNicolas Ferre ,\n\tWenyou Yang ,\n\tCyrille Pitchen ,\n\tlinux-mtd@lists.infradead.org, \n\tBrian Norris ,\n\tDavid Woodhouse ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1772608,"web_url":"http://patchwork.ozlabs.org/comment/1772608/","msgid":"","list_archive_url":null,"date":"2017-09-21T09:22:42","subject":"Re: [PATCH v2 5/9] mtd: nand: atmel: Report PMECC failures as errors","submitter":{"id":8236,"url":"http://patchwork.ozlabs.org/api/people/8236/","name":"Romain Izard","email":"romain.izard.pro@gmail.com"},"content":"2017-09-18 12:00 GMT+02:00 Boris Brezillon :\n> Hi Romain,\n>\n> On Fri, 15 Sep 2017 16:04:07 +0200\n> Romain Izard wrote:\n>\n>> It is not normal for the PMECC to fail when trying to fix ECC errors.\n>> Report these cases as errors.\n>\n> I'm not sure we want to have ECC error messages at this level. ECC\n> errors are rather unusual but not impossible, and sometimes it's even\n> not a real error (I'm thinking of bitflips in erased pages for\n> example, which are not necessarily detected/fixed in hardware).\n>\n> If we decide to print error messages when unfixable bitflips are\n> detected, it should be done in the nand-controller driver (somewhere\n> along those lines [1]).\n>\n> Regards,\n>\n> Boris\n>\n> [1]http://elixir.free-electrons.com/linux/latest/source/drivers/mtd/nand/atmel/nand-controller.c#L827\n>\n>>\n>> Signed-off-by: Romain Izard \n>> ---\n>> drivers/mtd/nand/atmel/pmecc.c | 4 +++-\n>> 1 file changed, 3 insertions(+), 1 deletion(-)\n>>\n>> diff --git a/drivers/mtd/nand/atmel/pmecc.c b/drivers/mtd/nand/atmel/pmecc.c\n>> index 8d1208f38025..2a23f1ff945f 100644\n>> --- a/drivers/mtd/nand/atmel/pmecc.c\n>> +++ b/drivers/mtd/nand/atmel/pmecc.c\n>> @@ -687,6 +687,8 @@ static int atmel_pmecc_err_location(struct atmel_pmecc_user *user)\n>> * Number of roots does not match the degree of smu\n>> * unable to correct error.\n>> */\n>> + dev_err(pmecc->dev,\n>> + \"PMECC: Impossible to calculate error location.\\n\");\n>> return -EBADMSG;\n>> }\n>>\n>> @@ -729,7 +731,7 @@ int atmel_pmecc_correct_sector(struct atmel_pmecc_user *user, int sector,\n>> ptr = ecc + byte - sectorsize;\n>> area = \"ECC\";\n>> } else {\n>> - dev_dbg(pmecc->dev,\n>> + dev_err(pmecc->dev,\n>> \"Invalid errpos value (%d, max is %d)\\n\",\n>> errpos, (sectorsize + eccbytes) * 8);\n>> return -EINVAL;\n>\n\nOk, I will drop this patch.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"Ympmtwt3\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tsecure) header.d=mobile-devices.fr header.i=@mobile-devices.fr\n\theader.b=\"ncVrtRfv\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"XqO9p0rv\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyWQD4Jprz9t42\n\tfor ;\n\tThu, 21 Sep 2017 19:24:04 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duxi3-0003Nt-Cd; Thu, 21 Sep 2017 09:23:51 +0000","from mail-qt0-x22e.google.com ([2607:f8b0:400d:c0d::22e])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duxhd-0002zd-MM\n\tfor linux-mtd@lists.infradead.org; Thu, 21 Sep 2017 09:23:29 +0000","by mail-qt0-x22e.google.com with SMTP id o52so5285639qtc.9\n\tfor ;\n\tThu, 21 Sep 2017 02:23:03 -0700 (PDT)","by 10.200.48.120 with HTTP; Thu, 21 Sep 2017 02:22:42 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:\n\tReferences:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=E5MHH8fJ18gRc2qbqmHeBtPnHZT4pkS9fP1aB/OhdIM=;\n\tb=Ympmtwt3EGlyeB\n\tkTRwsp0iiXXcy1+q+xaSvIWxV47yXCUvVsr20ilZczte8snyjSBdMDCn4OQkFFZ5+1eGmDCIO4v/S\n\tCdYfUDA6xMqOaK6OdrgDe5/tH9JkptxJu3FjuBnMtZNOQwWiOoG4FSs45QMgGTjENysj/q0QAYUiA\n\t6t++EK6bpx7ENcXjDS/gNqtmjWMtN2mXzPSSgmdbYx4hOn3uE7q1QKZdcUw6UnKiscACuJgTjjyjO\n\tHJ3gD9HcqcFeLWZbX1PSv6dSb5RRyeqDSsW6Qc9nWocjyJQzaw2/SSWXGWEQx+kxkRrNHBPQi9YQq\n\tX0+dwup6Q4PPaWNeo0iw==;","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=mobile-devices.fr; s=google;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=c6X7dVqosB2yW1uzf9F6jergbkgC2nFFJvtWgvnJX/8=;\n\tb=ncVrtRfvzt/Nb31nIMMG1/rrAGcD6wNBfSNXVDyVklbWSXXY+VNcgCe9WDTbf7HyVO\n\tYjgKfRlX2cCITChs2aQ1H2LRMElumFJi2eY++1d1+wOpS17bPTkWBBXv/V9IH1bY5Q/t\n\tyxHJP6tSb8UM8zd6OVTkSicGp816nVCyTc+DU=","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=c6X7dVqosB2yW1uzf9F6jergbkgC2nFFJvtWgvnJX/8=;\n\tb=XqO9p0rvrIPDSw/Q16GnZiVe9ISKsdmopYx5DhRpcOWGEZNgMARwZ+EOn9/2HHEtqM\n\tzUwMdqO8G1+WnTholBc5QIBAndgG9N+9bUwNaakTMbnH/C1oftH1ircAorxc0TPYXAB0\n\tbcohRfaUGwjRm0o0RxOTu/4TDGelp9kH658WNDkczLPNfHrxUwVAwXd2IXzhXQOlf/sF\n\tktgRwFlfYVP2F3R8gV08atrfPdcXjKpyl0iHi047gsuJIuaGxOFRpFbItx0AzI9lG+kx\n\tq7yI5o0WNviP5d768SwPlghIJS9hJ1iR6s9a9lG65g2tyJy89DgY/HZ2stuUQNOLNLcg\n\tac9Q=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=c6X7dVqosB2yW1uzf9F6jergbkgC2nFFJvtWgvnJX/8=;\n\tb=KdLr0NihyltJaojNP6TIMlJVswZPip+mezAvOy4+XxoKBJ4JSzV6RVDNmNRT6yZ7Ji\n\tIWGZyQlwv1sCHURt6lwzmInOA8pMyZ+abEnNaaAuaj9+dOlWXoyAgIqY9kJdUlRSw5ka\n\tZJWriJgEA66Z1hjV6F+eYUvdKy0TnqRYlzy9bYnckn3sO4JruWB9LO7vJ94QkqJDjHJs\n\tS67A8MG0q4okW/4kP3hecV/p5ydeRb0l1/kB6Gh3A/75dQIUDSR/ZRvev4iTHWzqcFtf\n\tWmME57g2TCIMcSGIimQCUkmdNXRmfmxr4lGcz6Z0JrCIwq0jlhapOPkKqhChOhyVCg2E\n\th+1w==","X-Gm-Message-State":"AHPjjUg5gfMPGgXhrdpqrPhgrOFFLLv3v+9FVsORJFjPnQO/fTe49L1f\n\tGNxeFJrTFQblM0YLaF3zb3HSm9Hkbo8hOz5lZlXE2A==","X-Google-Smtp-Source":"AOwi7QBa08wLJpC1KuwCqMB2ZOyG6KnMfw7GRokjfDY56VHJ68fKkoT+6AiAJfwwDilYqvgUyefAujgvanJKrGeN/PA=","X-Received":"by 10.237.62.79 with SMTP id m15mr2280325qtf.244.1505985782749; \n\tThu, 21 Sep 2017 02:23:02 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170918120051.298bdabf@bbrezillon>","References":"<20170915140411.31716-1-romain.izard.pro@gmail.com>\n\t<20170915140411.31716-6-romain.izard.pro@gmail.com>\n\t<20170918120051.298bdabf@bbrezillon>","From":"Romain Izard ","Date":"Thu, 21 Sep 2017 11:22:42 +0200","X-Google-Sender-Auth":"duAPxT4kaog8s8NZhWo0-mJIgx0","Message-ID":"","Subject":"Re: [PATCH v2 5/9] mtd: nand: atmel: Report PMECC failures as errors","To":"Boris Brezillon ","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170921_022325_896864_BBC97A14 ","X-CRM114-Status":"GOOD ( 18.97 )","X-Spam-Score":"-1.8 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.8 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2607:f8b0:400d:c0d:0:0:0:22e listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (romain.izard.pro[at]gmail.com)\n\t0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level\n\tmail domains are different\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain\n\t0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and\n\tEnvelopeFrom freemail headers are different","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Michael Turquette ,\n\tLKML ,\n\tThierry Reding , \n\tAlexandre Belloni ,\n\tlinux-clk@vger.kernel.org, Josh Wu ,\n\tMarek Vasut ,\n\tLudovic Desroches ,\n\tAlan Stern , linux-serial@vger.kernel.org, \n\tlinux-pwm@vger.kernel.org,\n\tlinux-arm-kernel ,\n\tRichard Genoud ,\n\tGreg Kroah-Hartman ,\n\tlinux-usb@vger.kernel.org, Stephen Boyd ,\n\tNicolas Ferre ,\n\tWenyou Yang ,\n\tCyrille Pitchen ,\n\tlinux-mtd ,\n\tBrian Norris ,\n\tDavid Woodhouse ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]