Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 813893,
    "url": "http://patchwork.ozlabs.org/api/patches/813893/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20170914160125.11007-1-colin.king@canonical.com/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<20170914160125.11007-1-colin.king@canonical.com>",
    "list_archive_url": null,
    "date": "2017-09-14T16:01:25",
    "name": "tg3: clean up redundant initialization of tnapi",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "043151a1e27bbb80cb05b95d4011feade0383b15",
    "submitter": {
        "id": 2900,
        "url": "http://patchwork.ozlabs.org/api/people/2900/?format=api",
        "name": "Colin Ian King",
        "email": "colin.king@canonical.com"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20170914160125.11007-1-colin.king@canonical.com/mbox/",
    "series": [
        {
            "id": 3131,
            "url": "http://patchwork.ozlabs.org/api/series/3131/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=3131",
            "date": "2017-09-14T16:01:25",
            "name": "tg3: clean up redundant initialization of tnapi",
            "version": 1,
            "mbox": "http://patchwork.ozlabs.org/series/3131/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/813893/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/813893/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xtNZh3rz6z9sPs\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 15 Sep 2017 02:02:04 +1000 (AEST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752052AbdINQBa (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 14 Sep 2017 12:01:30 -0400",
            "from youngberry.canonical.com ([91.189.89.112]:33014 \"EHLO\n\tyoungberry.canonical.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751907AbdINQB1 (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Thu, 14 Sep 2017 12:01:27 -0400",
            "from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost)\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76)\n\t(envelope-from <colin.king@canonical.com>)\n\tid 1dsWZy-0005HJ-8F; Thu, 14 Sep 2017 16:01:26 +0000"
        ],
        "From": "Colin King <colin.king@canonical.com>",
        "To": "Siva Reddy Kallam <siva.kallam@broadcom.com>,\n\tPrashant Sreedharan <prashant@broadcom.com>,\n\tMichael Chan <mchan@broadcom.com>, netdev@vger.kernel.org",
        "Cc": "kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org",
        "Subject": "[PATCH] tg3: clean up redundant initialization of tnapi",
        "Date": "Thu, 14 Sep 2017 17:01:25 +0100",
        "Message-Id": "<20170914160125.11007-1-colin.king@canonical.com>",
        "X-Mailer": "git-send-email 2.14.1",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain; charset=\"utf-8\"",
        "Content-Transfer-Encoding": "8bit",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "From: Colin Ian King <colin.king@canonical.com>\n\ntnapi is being initialized and then immediately updated and\nhence the initialiation is redundant.  Clean up the warning\nby moving the declaration and initialization to the inside\nof the for-loop.\n\nCleans up clang scan-build warning:\nwarning: Value stored to 'tnapi' during its initialization is never read\n\nSigned-off-by: Colin Ian King <colin.king@canonical.com>\n---\n drivers/net/ethernet/broadcom/tg3.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c\nindex af33dc15c55f..54588809b867 100644\n--- a/drivers/net/ethernet/broadcom/tg3.c\n+++ b/drivers/net/ethernet/broadcom/tg3.c\n@@ -11536,11 +11536,11 @@ static int tg3_start(struct tg3 *tp, bool reset_phy, bool test_irq,\n \ttg3_napi_enable(tp);\n \n \tfor (i = 0; i < tp->irq_cnt; i++) {\n-\t\tstruct tg3_napi *tnapi = &tp->napi[i];\n \t\terr = tg3_request_irq(tp, i);\n \t\tif (err) {\n \t\t\tfor (i--; i >= 0; i--) {\n-\t\t\t\ttnapi = &tp->napi[i];\n+\t\t\t\tstruct tg3_napi *tnapi = &tp->napi[i];\n+\n \t\t\t\tfree_irq(tnapi->irq_vec, tnapi);\n \t\t\t}\n \t\t\tgoto out_napi_fini;\n",
    "prefixes": []
}