[{"id":1768740,"web_url":"http://patchwork.ozlabs.org/comment/1768740/","msgid":"<20170914.100041.1507992015904111255.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-14T17:00:41","subject":"Re: [PATCH] tg3: clean up redundant initialization of tnapi","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Colin King \nDate: Thu, 14 Sep 2017 17:01:25 +0100\n\n> From: Colin Ian King \n> \n> tnapi is being initialized and then immediately updated and\n> hence the initialiation is redundant. Clean up the warning\n> by moving the declaration and initialization to the inside\n> of the for-loop.\n> \n> Cleans up clang scan-build warning:\n> warning: Value stored to 'tnapi' during its initialization is never read\n> \n> Signed-off-by: Colin Ian King \n\nApplied.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xtPv7418sz9sPt\n\tfor ;\n\tFri, 15 Sep 2017 03:01:23 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751593AbdINRAn (ORCPT );\n\tThu, 14 Sep 2017 13:00:43 -0400","from shards.monkeyblade.net ([184.105.139.130]:52208 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751484AbdINRAm (ORCPT\n\t); Thu, 14 Sep 2017 13:00:42 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id C0A0E10271286;\n\tThu, 14 Sep 2017 10:00:41 -0700 (PDT)"],"Date":"Thu, 14 Sep 2017 10:00:41 -0700 (PDT)","Message-Id":"<20170914.100041.1507992015904111255.davem@davemloft.net>","To":"colin.king@canonical.com","Cc":"siva.kallam@broadcom.com, prashant@broadcom.com,\n\tmchan@broadcom.com, netdev@vger.kernel.org,\n\tkernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH] tg3: clean up redundant initialization of tnapi","From":"David Miller ","In-Reply-To":"<20170914160125.11007-1-colin.king@canonical.com>","References":"<20170914160125.11007-1-colin.king@canonical.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Thu, 14 Sep 2017 10:00:42 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]