Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/813556/?format=api
{ "id": 813556, "url": "http://patchwork.ozlabs.org/api/patches/813556/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170913181910.29688-4-mreitz@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170913181910.29688-4-mreitz@redhat.com>", "list_archive_url": null, "date": "2017-09-13T18:18:55", "name": "[03/18] blockjob: Make drained_{begin, end} public", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "0322f9be6748420c5051e3aeed31430ad35c2dc0", "submitter": { "id": 36836, "url": "http://patchwork.ozlabs.org/api/people/36836/?format=api", "name": "Max Reitz", "email": "mreitz@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170913181910.29688-4-mreitz@redhat.com/mbox/", "series": [ { "id": 2960, "url": "http://patchwork.ozlabs.org/api/series/2960/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2960", "date": "2017-09-13T18:18:52", "name": "block/mirror: Add active-sync mirroring", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/2960/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/813556/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/813556/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=mreitz@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsqj76VsGz9s7g\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 14 Sep 2017 04:20:43 +1000 (AEST)", "from localhost ([::1]:43984 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dsCHB-0007qx-Fu\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 14:20:41 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:36534)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <mreitz@redhat.com>) id 1dsCGN-0007ou-3r\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 14:19:52 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <mreitz@redhat.com>) id 1dsCGM-0004nc-5t\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 14:19:51 -0400", "from mx1.redhat.com ([209.132.183.28]:39198)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <mreitz@redhat.com>)\n\tid 1dsCGJ-0004m2-S1; Wed, 13 Sep 2017 14:19:48 -0400", "from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 9CB0F356D8;\n\tWed, 13 Sep 2017 18:19:46 +0000 (UTC)", "from localhost (ovpn-204-23.brq.redhat.com [10.40.204.23])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 88A4C5C545;\n\tWed, 13 Sep 2017 18:19:39 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com 9CB0F356D8", "From": "Max Reitz <mreitz@redhat.com>", "To": "qemu-block@nongnu.org", "Date": "Wed, 13 Sep 2017 20:18:55 +0200", "Message-Id": "<20170913181910.29688-4-mreitz@redhat.com>", "In-Reply-To": "<20170913181910.29688-1-mreitz@redhat.com>", "References": "<20170913181910.29688-1-mreitz@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.16", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tWed, 13 Sep 2017 18:19:46 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH 03/18] blockjob: Make drained_{begin,\n\tend} public", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>,\n\tqemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,\n\tStefan Hajnoczi <stefanha@redhat.com>, John Snow <jsnow@redhat.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "When a block job decides to be represented as a BDS and track its\nassociated child nodes itself instead of having the BlockJob object\ntrack them, it needs to implement the drained_begin/drained_end child\noperations. In order to do that, it has to be able to control drainage\nof the block job (i.e. to pause and resume it). Therefore, we need to\nmake these operations public.\n\nSigned-off-by: Max Reitz <mreitz@redhat.com>\n---\n include/block/blockjob.h | 15 +++++++++++++++\n blockjob.c | 20 ++++++++++++++------\n 2 files changed, 29 insertions(+), 6 deletions(-)", "diff": "diff --git a/include/block/blockjob.h b/include/block/blockjob.h\nindex 67c0968fa5..a59f316788 100644\n--- a/include/block/blockjob.h\n+++ b/include/block/blockjob.h\n@@ -339,6 +339,21 @@ void block_job_ref(BlockJob *job);\n void block_job_unref(BlockJob *job);\n \n /**\n+ * block_job_drained_begin:\n+ *\n+ * Inhibit I/O requests initiated by the block job.\n+ */\n+void block_job_drained_begin(BlockJob *job);\n+\n+/**\n+ * block_job_drained_end:\n+ *\n+ * Resume I/O after it has been paused through\n+ * block_job_drained_begin().\n+ */\n+void block_job_drained_end(BlockJob *job);\n+\n+/**\n * block_job_txn_unref:\n *\n * Release a reference that was previously acquired with block_job_txn_add_job\ndiff --git a/blockjob.c b/blockjob.c\nindex 3a0c49137e..4312a121fa 100644\n--- a/blockjob.c\n+++ b/blockjob.c\n@@ -217,21 +217,29 @@ static const BdrvChildRole child_job = {\n .stay_at_node = true,\n };\n \n-static void block_job_drained_begin(void *opaque)\n+void block_job_drained_begin(BlockJob *job)\n {\n- BlockJob *job = opaque;\n block_job_pause(job);\n }\n \n-static void block_job_drained_end(void *opaque)\n+static void block_job_drained_begin_op(void *opaque)\n+{\n+ block_job_drained_begin(opaque);\n+}\n+\n+void block_job_drained_end(BlockJob *job)\n {\n- BlockJob *job = opaque;\n block_job_resume(job);\n }\n \n+static void block_job_drained_end_op(void *opaque)\n+{\n+ block_job_drained_end(opaque);\n+}\n+\n static const BlockDevOps block_job_dev_ops = {\n- .drained_begin = block_job_drained_begin,\n- .drained_end = block_job_drained_end,\n+ .drained_begin = block_job_drained_begin_op,\n+ .drained_end = block_job_drained_end_op,\n };\n \n void block_job_remove_all_bdrv(BlockJob *job)\n", "prefixes": [ "03/18" ] }