[{"id":1769849,"web_url":"http://patchwork.ozlabs.org/comment/1769849/","msgid":"<20170918034639.GB15551@lemon.lan>","list_archive_url":null,"date":"2017-09-18T03:46:39","subject":"Re: [Qemu-devel] [PATCH 03/18] blockjob: Make drained_{begin,\n\tend} public","submitter":{"id":24872,"url":"http://patchwork.ozlabs.org/api/people/24872/","name":"Fam Zheng","email":"famz@redhat.com"},"content":"On Wed, 09/13 20:18, Max Reitz wrote:\n> When a block job decides to be represented as a BDS and track its\n> associated child nodes itself instead of having the BlockJob object\n> track them, it needs to implement the drained_begin/drained_end child\n> operations. In order to do that, it has to be able to control drainage\n> of the block job (i.e. to pause and resume it). Therefore, we need to\n> make these operations public.\n> \n> Signed-off-by: Max Reitz \n> ---\n> include/block/blockjob.h | 15 +++++++++++++++\n> blockjob.c | 20 ++++++++++++++------\n> 2 files changed, 29 insertions(+), 6 deletions(-)\n> \n> diff --git a/include/block/blockjob.h b/include/block/blockjob.h\n> index 67c0968fa5..a59f316788 100644\n> --- a/include/block/blockjob.h\n> +++ b/include/block/blockjob.h\n> @@ -339,6 +339,21 @@ void block_job_ref(BlockJob *job);\n> void block_job_unref(BlockJob *job);\n> \n> /**\n> + * block_job_drained_begin:\n> + *\n> + * Inhibit I/O requests initiated by the block job.\n> + */\n> +void block_job_drained_begin(BlockJob *job);\n> +\n> +/**\n> + * block_job_drained_end:\n> + *\n> + * Resume I/O after it has been paused through\n> + * block_job_drained_begin().\n> + */\n> +void block_job_drained_end(BlockJob *job);\n> +\n> +/**\n> * block_job_txn_unref:\n> *\n> * Release a reference that was previously acquired with block_job_txn_add_job\n> diff --git a/blockjob.c b/blockjob.c\n> index 3a0c49137e..4312a121fa 100644\n> --- a/blockjob.c\n> +++ b/blockjob.c\n> @@ -217,21 +217,29 @@ static const BdrvChildRole child_job = {\n> .stay_at_node = true,\n> };\n> \n> -static void block_job_drained_begin(void *opaque)\n> +void block_job_drained_begin(BlockJob *job)\n> {\n> - BlockJob *job = opaque;\n> block_job_pause(job);\n> }\n> \n> -static void block_job_drained_end(void *opaque)\n> +static void block_job_drained_begin_op(void *opaque)\n> +{\n> + block_job_drained_begin(opaque);\n> +}\n> +\n> +void block_job_drained_end(BlockJob *job)\n> {\n> - BlockJob *job = opaque;\n> block_job_resume(job);\n> }\n> \n> +static void block_job_drained_end_op(void *opaque)\n> +{\n> + block_job_drained_end(opaque);\n> +}\n> +\n> static const BlockDevOps block_job_dev_ops = {\n> - .drained_begin = block_job_drained_begin,\n> - .drained_end = block_job_drained_end,\n> + .drained_begin = block_job_drained_begin_op,\n> + .drained_end = block_job_drained_end_op,\n> };\n> \n> void block_job_remove_all_bdrv(BlockJob *job)\n> -- \n> 2.13.5\n> \n> \n\nReviewed-by: Fam Zheng ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=famz@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwX5D51KKz9rxj\n\tfor ;\n\tMon, 18 Sep 2017 13:47:28 +1000 (AEST)","from localhost ([::1]:34518 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dtn1q-0001EA-RA\n\tfor incoming@patchwork.ozlabs.org; Sun, 17 Sep 2017 23:47:26 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:49844)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtn1I-0001C6-DC\n\tfor qemu-devel@nongnu.org; Sun, 17 Sep 2017 23:46:53 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dtn1H-0002u7-F6\n\tfor qemu-devel@nongnu.org; Sun, 17 Sep 2017 23:46:52 -0400","from mx1.redhat.com ([209.132.183.28]:58602)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dtn1C-0002rN-QP; Sun, 17 Sep 2017 23:46:47 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C6B0D267C5;\n\tMon, 18 Sep 2017 03:46:45 +0000 (UTC)","from localhost (ovpn-12-141.pek2.redhat.com [10.72.12.141])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 3FE745D6A8;\n\tMon, 18 Sep 2017 03:46:40 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com C6B0D267C5","Date":"Mon, 18 Sep 2017 11:46:39 +0800","From":"Fam Zheng ","To":"Max Reitz ","Message-ID":"<20170918034639.GB15551@lemon.lan>","References":"<20170913181910.29688-1-mreitz@redhat.com>\n\t<20170913181910.29688-4-mreitz@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170913181910.29688-4-mreitz@redhat.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tMon, 18 Sep 2017 03:46:45 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 03/18] blockjob: Make drained_{begin,\n\tend} public","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf , John Snow ,\n\tStefan Hajnoczi , qemu-devel@nongnu.org,\n\tqemu-block@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]