Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/813472/?format=api
{ "id": 813472, "url": "http://patchwork.ozlabs.org/api/patches/813472/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170913142036.2469-4-lvivier@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170913142036.2469-4-lvivier@redhat.com>", "list_archive_url": null, "date": "2017-09-13T14:20:35", "name": "[v4,3/4] dump: do not dump non-existent guest memory", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "0e306afb0cb759aff76651f1819eee350678363b", "submitter": { "id": 66421, "url": "http://patchwork.ozlabs.org/api/people/66421/?format=api", "name": "Laurent Vivier", "email": "lvivier@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170913142036.2469-4-lvivier@redhat.com/mbox/", "series": [ { "id": 2928, "url": "http://patchwork.ozlabs.org/api/series/2928/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2928", "date": "2017-09-13T14:20:32", "name": "hmp: fix \"dump-quest-memory\" segfault", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/2928/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/813472/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/813472/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=lvivier@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xskVb1596z9sNr\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 14 Sep 2017 00:26:15 +1000 (AEST)", "from localhost ([::1]:42803 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1ds8cH-0000v1-8y\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 10:26:13 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:35643)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <lvivier@redhat.com>) id 1ds8XJ-0004jW-NB\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 10:21:07 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <lvivier@redhat.com>) id 1ds8XG-0003bN-Qj\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 10:21:05 -0400", "from mx1.redhat.com ([209.132.183.28]:56052)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <lvivier@redhat.com>)\n\tid 1ds8X6-0003RA-Hs; Wed, 13 Sep 2017 10:20:52 -0400", "from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 9DE69C04B94B;\n\tWed, 13 Sep 2017 14:20:51 +0000 (UTC)", "from thinkpad.redhat.com (ovpn-116-49.ams2.redhat.com\n\t[10.36.116.49])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 3F2096F993;\n\tWed, 13 Sep 2017 14:20:47 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com 9DE69C04B94B", "From": "Laurent Vivier <lvivier@redhat.com>", "To": "\"Dr . David Alan Gilbert\" <dgilbert@redhat.com>,\n\tqemu-devel@nongnu.org", "Date": "Wed, 13 Sep 2017 16:20:35 +0200", "Message-Id": "<20170913142036.2469-4-lvivier@redhat.com>", "In-Reply-To": "<20170913142036.2469-1-lvivier@redhat.com>", "References": "<20170913142036.2469-1-lvivier@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.13", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tWed, 13 Sep 2017 14:20:51 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH v4 3/4] dump: do not dump non-existent guest\n\tmemory", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Peter Maydell <peter.maydell@linaro.org>, Thomas Huth <thuth@redhat.com>,\n\tCornelia Huck <cohuck@redhat.com>, Greg Kurz <groug@kaod.org>,\n\tqemu-arm@nongnu.org, qemu-ppc@nongnu.org,\n\tDavid Gibson <david@gibson.dropbear.id.au>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "From: Cornelia Huck <cohuck@redhat.com>\n\nIt does not really make sense to dump memory that is not there.\n\nMoreover, that fixes a segmentation fault when calling dump-guest-memory\nwith no filter for a machine with no memory defined.\n\nNew behaviour is:\n\n(qemu) dump-guest-memory /dev/null\ndump: no guest memory to dump\n(qemu) dump-guest-memory /dev/null 0 4096\ndump: no guest memory to dump\n\nSigned-off-by: Cornelia Huck <cohuck@redhat.com>\nTested-by: Laurent Vivier <lvivier@redhat.com>\nReviewed-by: Laurent Vivier <lvivier@redhat.com>\nReviewed-by: Greg Kurz <groug@kaod.org>\nReviewed-by: Peter Xu <peterx@redhat.com>\n---\n dump.c | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/dump.c b/dump.c\nindex a79773d0f7..d2093e141b 100644\n--- a/dump.c\n+++ b/dump.c\n@@ -1536,6 +1536,12 @@ static void dump_init(DumpState *s, int fd, bool has_format,\n fprintf(stderr, \"DUMP: total memory to dump: %lu\\n\", s->total_size);\n #endif\n \n+ /* it does not make sense to dump non-existent memory */\n+ if (!s->total_size) {\n+ error_setg(errp, \"dump: no guest memory to dump\");\n+ goto cleanup;\n+ }\n+\n s->start = get_start_block(s);\n if (s->start == -1) {\n error_setg(errp, QERR_INVALID_PARAMETER, \"begin\");\n", "prefixes": [ "v4", "3/4" ] }