[{"id":1767924,"web_url":"http://patchwork.ozlabs.org/comment/1767924/","msgid":"<20170913162709.3933352d.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-13T14:27:09","subject":"Re: [Qemu-devel] [PATCH v4 3/4] dump: do not dump non-existent\n\tguest memory","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Wed, 13 Sep 2017 16:20:35 +0200\nLaurent Vivier wrote:\n\n> From: Cornelia Huck \n> \n> It does not really make sense to dump memory that is not there.\n> \n> Moreover, that fixes a segmentation fault when calling dump-guest-memory\n> with no filter for a machine with no memory defined.\n> \n> New behaviour is:\n> \n> (qemu) dump-guest-memory /dev/null\n> dump: no guest memory to dump\n> (qemu) dump-guest-memory /dev/null 0 4096\n> dump: no guest memory to dump\n> \n> Signed-off-by: Cornelia Huck \n> Tested-by: Laurent Vivier \n> Reviewed-by: Laurent Vivier \n> Reviewed-by: Greg Kurz \n> Reviewed-by: Peter Xu \n> ---\n> dump.c | 6 ++++++\n> 1 file changed, 6 insertions(+)\n\nYou need to supply your s-o-b as well, no?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xskZ40hvmz9sNr\n\tfor ;\n\tThu, 14 Sep 2017 00:29:16 +1000 (AEST)","from localhost ([::1]:42821 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1ds8fC-0003BR-6O\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 10:29:14 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:38136)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1ds8dS-00029d-7G\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 10:27:27 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1ds8dR-0000IU-Cm\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 10:27:26 -0400","from mx1.redhat.com ([209.132.183.28]:43700)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1ds8dJ-0000DD-T7; Wed, 13 Sep 2017 10:27:18 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id E2A345F742;\n\tWed, 13 Sep 2017 14:27:16 +0000 (UTC)","from gondolin (ovpn-117-3.ams2.redhat.com [10.36.117.3])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 3B5565FCD6;\n\tWed, 13 Sep 2017 14:27:12 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com E2A345F742","Date":"Wed, 13 Sep 2017 16:27:09 +0200","From":"Cornelia Huck ","To":"Laurent Vivier ","Message-ID":"<20170913162709.3933352d.cohuck@redhat.com>","In-Reply-To":"<20170913142036.2469-4-lvivier@redhat.com>","References":"<20170913142036.2469-1-lvivier@redhat.com>\n\t<20170913142036.2469-4-lvivier@redhat.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tWed, 13 Sep 2017 14:27:17 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v4 3/4] dump: do not dump non-existent\n\tguest memory","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell , Thomas Huth ,\n\t\"Dr . David Alan Gilbert\" ,\n\tqemu-devel@nongnu.org, Greg Kurz ,\n\tqemu-arm@nongnu.org, qemu-ppc@nongnu.org,\n\tDavid Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1767928,"web_url":"http://patchwork.ozlabs.org/comment/1767928/","msgid":"<32c345ab-ce02-fe29-1587-db863fb21209@redhat.com>","list_archive_url":null,"date":"2017-09-13T14:30:20","subject":"Re: [Qemu-devel] [PATCH v4 3/4] dump: do not dump non-existent\n\tguest memory","submitter":{"id":66421,"url":"http://patchwork.ozlabs.org/api/people/66421/","name":"Laurent Vivier","email":"lvivier@redhat.com"},"content":"On 13/09/2017 16:27, Cornelia Huck wrote:\n> On Wed, 13 Sep 2017 16:20:35 +0200\n> Laurent Vivier wrote:\n> \n>> From: Cornelia Huck \n>>\n>> It does not really make sense to dump memory that is not there.\n>>\n>> Moreover, that fixes a segmentation fault when calling dump-guest-memory\n>> with no filter for a machine with no memory defined.\n>>\n>> New behaviour is:\n>>\n>> (qemu) dump-guest-memory /dev/null\n>> dump: no guest memory to dump\n>> (qemu) dump-guest-memory /dev/null 0 4096\n>> dump: no guest memory to dump\n>>\n>> Signed-off-by: Cornelia Huck \n>> Tested-by: Laurent Vivier \n>> Reviewed-by: Laurent Vivier \n>> Reviewed-by: Greg Kurz \n>> Reviewed-by: Peter Xu \n>> ---\n>> dump.c | 6 ++++++\n>> 1 file changed, 6 insertions(+)\n> \n> You need to supply your s-o-b as well, no?\n> \n\nI was wondering... theoretically, yes, so:\n\nSigned-off-by: Laurent Vivier \n\nThanks,\nLaurent","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=lvivier@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xskdD44Scz9sNr\n\tfor ;\n\tThu, 14 Sep 2017 00:31:59 +1000 (AEST)","from localhost ([::1]:42836 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1ds8ho-0005OJ-Ue\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 10:31:56 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:39515)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1ds8gd-0004pk-Df\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 10:30:49 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1ds8gY-00037y-ER\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 10:30:43 -0400","from mx1.redhat.com ([209.132.183.28]:27961)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1ds8gM-0002zY-Hz; Wed, 13 Sep 2017 10:30:26 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 8E656A710;\n\tWed, 13 Sep 2017 14:30:25 +0000 (UTC)","from [10.36.116.49] (ovpn-116-49.ams2.redhat.com [10.36.116.49])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 5F5D077D69;\n\tWed, 13 Sep 2017 14:30:21 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 8E656A710","To":"Cornelia Huck ","References":"<20170913142036.2469-1-lvivier@redhat.com>\n\t<20170913142036.2469-4-lvivier@redhat.com>\n\t<20170913162709.3933352d.cohuck@redhat.com>","From":"Laurent Vivier ","Message-ID":"<32c345ab-ce02-fe29-1587-db863fb21209@redhat.com>","Date":"Wed, 13 Sep 2017 16:30:20 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170913162709.3933352d.cohuck@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tWed, 13 Sep 2017 14:30:25 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v4 3/4] dump: do not dump non-existent\n\tguest memory","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell , Thomas Huth ,\n\t\"Dr . David Alan Gilbert\" ,\n\tqemu-devel@nongnu.org, Greg Kurz ,\n\tqemu-arm@nongnu.org, qemu-ppc@nongnu.org,\n\tDavid Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1768478,"web_url":"http://patchwork.ozlabs.org/comment/1768478/","msgid":"<20170914094838.GA3982@work-vm>","list_archive_url":null,"date":"2017-09-14T09:48:38","subject":"Re: [Qemu-devel] [PATCH v4 3/4] dump: do not dump non-existent\n\tguest memory","submitter":{"id":48102,"url":"http://patchwork.ozlabs.org/api/people/48102/","name":"Dr. David Alan Gilbert","email":"dgilbert@redhat.com"},"content":"* Laurent Vivier (lvivier@redhat.com) wrote:\n> On 13/09/2017 16:27, Cornelia Huck wrote:\n> > On Wed, 13 Sep 2017 16:20:35 +0200\n> > Laurent Vivier wrote:\n> > \n> >> From: Cornelia Huck \n> >>\n> >> It does not really make sense to dump memory that is not there.\n> >>\n> >> Moreover, that fixes a segmentation fault when calling dump-guest-memory\n> >> with no filter for a machine with no memory defined.\n> >>\n> >> New behaviour is:\n> >>\n> >> (qemu) dump-guest-memory /dev/null\n> >> dump: no guest memory to dump\n> >> (qemu) dump-guest-memory /dev/null 0 4096\n> >> dump: no guest memory to dump\n> >>\n> >> Signed-off-by: Cornelia Huck \n> >> Tested-by: Laurent Vivier \n> >> Reviewed-by: Laurent Vivier \n> >> Reviewed-by: Greg Kurz \n> >> Reviewed-by: Peter Xu \n> >> ---\n> >> dump.c | 6 ++++++\n> >> 1 file changed, 6 insertions(+)\n> > \n> > You need to supply your s-o-b as well, no?\n> > \n> \n> I was wondering... theoretically, yes, so:\n> \n> Signed-off-by: Laurent Vivier \n\nThanks.\n\nDave\n\n> Thanks,\n> Laurent\n--\nDr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=dgilbert@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtDJv5Y1sz9s9Y\n\tfor ;\n\tThu, 14 Sep 2017 19:49:33 +1000 (AEST)","from localhost ([::1]:46646 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsQm1-0006fd-QN\n\tfor incoming@patchwork.ozlabs.org; Thu, 14 Sep 2017 05:49:29 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:53035)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsQlV-0006eH-1Y\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 05:48:58 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsQlU-0001uu-4o\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 05:48:57 -0400","from mx1.redhat.com ([209.132.183.28]:50622)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dsQlN-0001h2-HQ; Thu, 14 Sep 2017 05:48:49 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 2EB54356D4;\n\tThu, 14 Sep 2017 09:48:48 +0000 (UTC)","from work-vm (ovpn-117-192.ams2.redhat.com [10.36.117.192])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 429E252357;\n\tThu, 14 Sep 2017 09:48:41 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 2EB54356D4","Date":"Thu, 14 Sep 2017 10:48:38 +0100","From":"\"Dr. David Alan Gilbert\" ","To":"Laurent Vivier ","Message-ID":"<20170914094838.GA3982@work-vm>","References":"<20170913142036.2469-1-lvivier@redhat.com>\n\t<20170913142036.2469-4-lvivier@redhat.com>\n\t<20170913162709.3933352d.cohuck@redhat.com>\n\t<32c345ab-ce02-fe29-1587-db863fb21209@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<32c345ab-ce02-fe29-1587-db863fb21209@redhat.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tThu, 14 Sep 2017 09:48:48 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v4 3/4] dump: do not dump non-existent\n\tguest memory","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell , Thomas Huth ,\n\tCornelia Huck , qemu-devel@nongnu.org,\n\tGreg Kurz , qemu-arm@nongnu.org,\n\tqemu-ppc@nongnu.org, David Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]