Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/813468/?format=api
{ "id": 813468, "url": "http://patchwork.ozlabs.org/api/patches/813468/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170913142036.2469-3-lvivier@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170913142036.2469-3-lvivier@redhat.com>", "list_archive_url": null, "date": "2017-09-13T14:20:34", "name": "[v4,2/4] hmp: fix \"dump-quest-memory\" segfault (arm)", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "a054279de878dc1b0d42093426d24951b596f6c0", "submitter": { "id": 66421, "url": "http://patchwork.ozlabs.org/api/people/66421/?format=api", "name": "Laurent Vivier", "email": "lvivier@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170913142036.2469-3-lvivier@redhat.com/mbox/", "series": [ { "id": 2928, "url": "http://patchwork.ozlabs.org/api/series/2928/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2928", "date": "2017-09-13T14:20:32", "name": "hmp: fix \"dump-quest-memory\" segfault", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/2928/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/813468/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/813468/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=lvivier@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xskPY5gcLz9sNr\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 14 Sep 2017 00:21:53 +1000 (AEST)", "from localhost ([::1]:42777 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1ds8Y3-0004hb-Pr\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 10:21:51 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:35599)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <lvivier@redhat.com>) id 1ds8XD-0004eq-5U\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 10:21:00 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <lvivier@redhat.com>) id 1ds8XC-0003Xj-6o\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 10:20:59 -0400", "from mx1.redhat.com ([209.132.183.28]:55396)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <lvivier@redhat.com>)\n\tid 1ds8X1-0003Nn-S2; Wed, 13 Sep 2017 10:20:48 -0400", "from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id DD5E47EA84;\n\tWed, 13 Sep 2017 14:20:46 +0000 (UTC)", "from thinkpad.redhat.com (ovpn-116-49.ams2.redhat.com\n\t[10.36.116.49])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 4DC866062A;\n\tWed, 13 Sep 2017 14:20:44 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com DD5E47EA84", "From": "Laurent Vivier <lvivier@redhat.com>", "To": "\"Dr . David Alan Gilbert\" <dgilbert@redhat.com>,\n\tqemu-devel@nongnu.org", "Date": "Wed, 13 Sep 2017 16:20:34 +0200", "Message-Id": "<20170913142036.2469-3-lvivier@redhat.com>", "In-Reply-To": "<20170913142036.2469-1-lvivier@redhat.com>", "References": "<20170913142036.2469-1-lvivier@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.13", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tWed, 13 Sep 2017 14:20:47 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH v4 2/4] hmp: fix \"dump-quest-memory\" segfault\n\t(arm)", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Laurent Vivier <lvivier@redhat.com>,\n\tPeter Maydell <peter.maydell@linaro.org>,\n\tThomas Huth <thuth@redhat.com>, \n\tCornelia Huck <cohuck@redhat.com>, Greg Kurz <groug@kaod.org>,\n\tqemu-arm@nongnu.org, qemu-ppc@nongnu.org,\n\tDavid Gibson <david@gibson.dropbear.id.au>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Running QEMU with\n qemu-system-aarch64 -M none -nographic -m 256\nand executing\n dump-guest-memory /dev/null 0 8192\nresults in segfault\n\nFix by checking if we have CPU, and exit with\nerror if there is no CPU:\n\n (qemu) dump-guest-memory /dev/null\n this feature or command is not currently supported\n\nSigned-off-by: Laurent Vivier <lvivier@redhat.com>\nReviewed-by: Thomas Huth <thuth@redhat.com>\nReviewed-by: Greg Kurz <groug@kaod.org>\n---\n target/arm/arch_dump.c | 11 +++++++++--\n 1 file changed, 9 insertions(+), 2 deletions(-)", "diff": "diff --git a/target/arm/arch_dump.c b/target/arm/arch_dump.c\nindex 1a9861f69b..9e5b2fb31c 100644\n--- a/target/arm/arch_dump.c\n+++ b/target/arm/arch_dump.c\n@@ -273,11 +273,18 @@ int arm_cpu_write_elf32_note(WriteCoreDumpFunction f, CPUState *cs,\n int cpu_get_dump_info(ArchDumpInfo *info,\n const GuestPhysBlockList *guest_phys_blocks)\n {\n- ARMCPU *cpu = ARM_CPU(first_cpu);\n- CPUARMState *env = &cpu->env;\n+ ARMCPU *cpu;\n+ CPUARMState *env;\n GuestPhysBlock *block;\n hwaddr lowest_addr = ULLONG_MAX;\n \n+ if (first_cpu == NULL) {\n+ return -1;\n+ }\n+\n+ cpu = ARM_CPU(first_cpu);\n+ env = &cpu->env;\n+\n /* Take a best guess at the phys_base. If we get it wrong then crash\n * will need '--machdep phys_offset=<phys-offset>' added to its command\n * line, which isn't any worse than assuming we can use zero, but being\n", "prefixes": [ "v4", "2/4" ] }