[{"id":1768361,"web_url":"http://patchwork.ozlabs.org/comment/1768361/","msgid":"","list_archive_url":null,"date":"2017-09-14T06:41:05","subject":"Re: [Qemu-devel] [PATCH v4 2/4] hmp: fix \"dump-quest-memory\"\n\tsegfault (arm)","submitter":{"id":69187,"url":"http://patchwork.ozlabs.org/api/people/69187/","name":"Eric Auger","email":"eric.auger@redhat.com"},"content":"Hi Laurent,\n\nOn 13/09/2017 16:20, Laurent Vivier wrote:\n> Running QEMU with\n> qemu-system-aarch64 -M none -nographic -m 256\n> and executing\n> dump-guest-memory /dev/null 0 8192\n> results in segfault\n> \n> Fix by checking if we have CPU, and exit with\n> error if there is no CPU:\n> \n> (qemu) dump-guest-memory /dev/null\n> this feature or command is not currently supported\n> \n> Signed-off-by: Laurent Vivier \n> Reviewed-by: Thomas Huth \n> Reviewed-by: Greg Kurz \nReviewed-by: Eric Auger \nTested-by: Eric Auger \n\nThanks\n\nEric\n\n> ---\n> target/arm/arch_dump.c | 11 +++++++++--\n> 1 file changed, 9 insertions(+), 2 deletions(-)\n> \n> diff --git a/target/arm/arch_dump.c b/target/arm/arch_dump.c\n> index 1a9861f69b..9e5b2fb31c 100644\n> --- a/target/arm/arch_dump.c\n> +++ b/target/arm/arch_dump.c\n> @@ -273,11 +273,18 @@ int arm_cpu_write_elf32_note(WriteCoreDumpFunction f, CPUState *cs,\n> int cpu_get_dump_info(ArchDumpInfo *info,\n> const GuestPhysBlockList *guest_phys_blocks)\n> {\n> - ARMCPU *cpu = ARM_CPU(first_cpu);\n> - CPUARMState *env = &cpu->env;\n> + ARMCPU *cpu;\n> + CPUARMState *env;\n> GuestPhysBlock *block;\n> hwaddr lowest_addr = ULLONG_MAX;\n> \n> + if (first_cpu == NULL) {\n> + return -1;\n> + }\n> +\n> + cpu = ARM_CPU(first_cpu);\n> + env = &cpu->env;\n> +\n> /* Take a best guess at the phys_base. If we get it wrong then crash\n> * will need '--machdep phys_offset=' added to its command\n> * line, which isn't any worse than assuming we can use zero, but being\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eric.auger@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xt88G6rhmz9t2V\n\tfor ;\n\tThu, 14 Sep 2017 16:41:47 +1000 (AEST)","from localhost ([::1]:45991 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsNqI-0003aV-Ti\n\tfor incoming@patchwork.ozlabs.org; Thu, 14 Sep 2017 02:41:42 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:47010)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsNpu-0003YY-95\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 02:41:19 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsNpt-0005Nv-E2\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 02:41:18 -0400","from mx1.redhat.com ([209.132.183.28]:36808)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dsNpo-0005Ie-4Z; Thu, 14 Sep 2017 02:41:12 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 5D8214E4D4;\n\tThu, 14 Sep 2017 06:41:10 +0000 (UTC)","from localhost.localdomain (ovpn-117-228.ams2.redhat.com\n\t[10.36.117.228])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 3865B619A8;\n\tThu, 14 Sep 2017 06:41:06 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 5D8214E4D4","To":"Laurent Vivier ,\n\t\"Dr . David Alan Gilbert\" , qemu-devel@nongnu.org","References":"<20170913142036.2469-1-lvivier@redhat.com>\n\t<20170913142036.2469-3-lvivier@redhat.com>","From":"Auger Eric ","Message-ID":"","Date":"Thu, 14 Sep 2017 08:41:05 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.4.0","MIME-Version":"1.0","In-Reply-To":"<20170913142036.2469-3-lvivier@redhat.com>","Content-Type":"text/plain; charset=windows-1252","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tThu, 14 Sep 2017 06:41:11 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v4 2/4] hmp: fix \"dump-quest-memory\"\n\tsegfault (arm)","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell , Thomas Huth ,\n\tCornelia Huck , Greg Kurz ,\n\tqemu-arm@nongnu.org, qemu-ppc@nongnu.org,\n\tDavid Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]