Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/813462/?format=api
{ "id": 813462, "url": "http://patchwork.ozlabs.org/api/patches/813462/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/patch/1505311498-13843-1-git-send-email-roid@mellanox.com/", "project": { "id": 47, "url": "http://patchwork.ozlabs.org/api/projects/47/?format=api", "name": "Open vSwitch", "link_name": "openvswitch", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "git@github.com:openvswitch/ovs.git", "webscm_url": "https://github.com/openvswitch/ovs", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1505311498-13843-1-git-send-email-roid@mellanox.com>", "list_archive_url": null, "date": "2017-09-13T14:04:58", "name": "[ovs-dev,V2] netdev-tc-offloads: Fix vxlan tunnel offloading", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "eed09c160223977f24d5153ed0ce9226c4b16697", "submitter": { "id": 70307, "url": "http://patchwork.ozlabs.org/api/people/70307/?format=api", "name": "Roi Dayan", "email": "roid@mellanox.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/openvswitch/patch/1505311498-13843-1-git-send-email-roid@mellanox.com/mbox/", "series": [ { "id": 2924, "url": "http://patchwork.ozlabs.org/api/series/2924/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/list/?series=2924", "date": "2017-09-13T14:04:58", "name": "[ovs-dev,V2] netdev-tc-offloads: Fix vxlan tunnel offloading", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/2924/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/813462/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/813462/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "ovs-dev@mail.linuxfoundation.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsk2G475Nz9sNr\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 14 Sep 2017 00:05:10 +1000 (AEST)", "from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 729C8B15;\n\tWed, 13 Sep 2017 14:05:07 +0000 (UTC)", "from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 07260B12\n\tfor <dev@openvswitch.org>; Wed, 13 Sep 2017 14:05:06 +0000 (UTC)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTP id D8F9F195\n\tfor <dev@openvswitch.org>; Wed, 13 Sep 2017 14:05:04 +0000 (UTC)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n\troid@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 13 Sep 2017 17:05:01 +0300", "from dev-r-vrt-189.mtr.labs.mlnx (dev-r-vrt-189.mtr.labs.mlnx\n\t[10.212.189.1])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id v8DE50KI028494;\n\tWed, 13 Sep 2017 17:05:00 +0300" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Roi Dayan <roid@mellanox.com>", "To": "dev@openvswitch.org", "Date": "Wed, 13 Sep 2017 17:04:58 +0300", "Message-Id": "<1505311498-13843-1-git-send-email-roid@mellanox.com>", "X-Mailer": "git-send-email 2.7.5", "X-Spam-Status": "No, score=0.0 required=5.0 tests=RP_MATCHES_RCVD,\n\tUNPARSEABLE_RELAY autolearn=disabled version=3.3.1", "X-Spam-Checker-Version": "SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org", "Cc": "Simon Horman <simon.horman@netronome.com>", "Subject": "[ovs-dev] [PATCH V2] netdev-tc-offloads: Fix vxlan tunnel offloading", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.12", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "ovs-dev-bounces@openvswitch.org", "Errors-To": "ovs-dev-bounces@openvswitch.org" }, "content": "From: Paul Blakey <paulb@mellanox.com>\n\nThis commit fixes offloading when tunnel id is 0 by checking\nfor valid tunnel dst ipv4 or ipv6, like done in the normal flow.\n\nAlso need to reset the tunnel mask outside the condition\nbecause in the special case, when adding a port with key=flow,\nthe match for tunnel_set gets a tunnel key id 0 with a mask.\nIf we don't reset the mask we'll fail later when we check\nfor unknown attributes that the mask was not reset.\n\nFixes: 8f283af89298 (\"netdev-tc-offloads: Implement netdev flow put using tc interface\")\nSigned-off-by: Paul Blakey <paulb@mellanox.com>\nReviewed-by: Roi Dayan <roid@mellanox.com>\n---\nHi,\n\nThis is V2 for the prev patch with\ntitle \"netdev-tc-offloads: Fix offloading when tunnel id is 0\"\n\nV1->V2:\n - Use flow_tnl_dst_is_set() instead of checking mask\n - Move memset of maks tunnel to outside the condition\n - Update commit message\n\nThanks,\nRoi\n\n\n lib/netdev-tc-offloads.c | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/netdev-tc-offloads.c b/lib/netdev-tc-offloads.c\nindex 3c145c2..524c7dc 100644\n--- a/lib/netdev-tc-offloads.c\n+++ b/lib/netdev-tc-offloads.c\n@@ -683,7 +683,7 @@ netdev_tc_flow_put(struct netdev *netdev, struct match *match,\n \n memset(&flower, 0, sizeof flower);\n \n- if (tnl->tun_id) {\n+ if (flow_tnl_dst_is_set(&key->tunnel)) {\n VLOG_DBG_RL(&rl,\n \"tunnel: id %#\" PRIx64 \" src \" IP_FMT\n \" dst \" IP_FMT \" tp_src %d tp_dst %d\",\n@@ -698,9 +698,8 @@ netdev_tc_flow_put(struct netdev *netdev, struct match *match,\n flower.tunnel.tp_src = tnl->tp_src;\n flower.tunnel.tp_dst = tnl->tp_dst;\n flower.tunnel.tunnel = true;\n-\n- memset(&mask->tunnel, 0, sizeof mask->tunnel);\n }\n+ memset(&mask->tunnel, 0, sizeof mask->tunnel);\n \n flower.key.eth_type = key->dl_type;\n flower.mask.eth_type = mask->dl_type;\n", "prefixes": [ "ovs-dev", "V2" ] }