[{"id":1771641,"web_url":"http://patchwork.ozlabs.org/comment/1771641/","msgid":"<20170920071743.GA23454@vergenet.net>","list_archive_url":null,"date":"2017-09-20T07:17:47","subject":"Re: [ovs-dev] [PATCH V2] netdev-tc-offloads: Fix vxlan tunnel\n\toffloading","submitter":{"id":64714,"url":"http://patchwork.ozlabs.org/api/people/64714/","name":"Simon Horman","email":"simon.horman@netronome.com"},"content":"On Wed, Sep 13, 2017 at 05:04:58PM +0300, Roi Dayan wrote:\n> From: Paul Blakey \n> \n> This commit fixes offloading when tunnel id is 0 by checking\n> for valid tunnel dst ipv4 or ipv6, like done in the normal flow.\n> \n> Also need to reset the tunnel mask outside the condition\n> because in the special case, when adding a port with key=flow,\n> the match for tunnel_set gets a tunnel key id 0 with a mask.\n> If we don't reset the mask we'll fail later when we check\n> for unknown attributes that the mask was not reset.\n> \n> Fixes: 8f283af89298 (\"netdev-tc-offloads: Implement netdev flow put using tc interface\")\n> Signed-off-by: Paul Blakey \n> Reviewed-by: Roi Dayan \n> ---\n> Hi,\n> \n> This is V2 for the prev patch with\n> title \"netdev-tc-offloads: Fix offloading when tunnel id is 0\"\n> \n> V1->V2:\n> - Use flow_tnl_dst_is_set() instead of checking mask\n> - Move memset of maks tunnel to outside the condition\n> - Update commit message\n\nThanks, applied to master and branch-2.8.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=netronome-com.20150623.gappssmtp.com\n\theader.i=@netronome-com.20150623.gappssmtp.com\n\theader.b=\"HIDMWWsr\"; dkim-atps=neutral"],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxrgG0nFfz9s81\n\tfor ;\n\tWed, 20 Sep 2017 17:18:01 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id CCB07C9B;\n\tWed, 20 Sep 2017 07:17:58 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 40649B7E\n\tfor ; Wed, 20 Sep 2017 07:17:58 +0000 (UTC)","from mail-qt0-f169.google.com (mail-qt0-f169.google.com\n\t[209.85.216.169])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id BEC81CA\n\tfor ; Wed, 20 Sep 2017 07:17:57 +0000 (UTC)","by mail-qt0-f169.google.com with SMTP id o13so1929387qtf.1\n\tfor ; Wed, 20 Sep 2017 00:17:57 -0700 (PDT)","from vergenet.net ([217.111.208.18])\n\tby smtp.gmail.com with ESMTPSA id\n\tv92sm851728qte.69.2017.09.20.00.17.50\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 20 Sep 2017 00:17:56 -0700 (PDT)"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=netronome-com.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=u6c/ERGraSVcNIy/aFIbqrTe+MhWA19I8wq4uxD6Ndg=;\n\tb=HIDMWWsrH9zNxhqE2Awg7hrEe7isn9z7lZlgQh99N8LrzPGErBUP2GvGsaUZL2RME6\n\tMmzJLA95wXZHkrM/c0PiA23fb1mf31pxP9ojqaDdp6wymgm0ZiCn/AcWEp3Hyo0/0VWp\n\tp4AXdiRpaaG2F3dhkVf/BtvguIuB4TQZANs6BmAskNjtpPYwgYGqXNhJvPunxqWPPEaM\n\th0Do4UXKwsEe1PHxdThoie/UjNNxBq8yYZedvUI933Q2rWCNVpvw7OpyizEi2MTTDlzs\n\t1z2q8mo1bzXeuD0U1WxuxsLLZPodSjazDvPl+keEtQmC2pDwU08Qfm/aaGNy+PU4M291\n\tI10A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=u6c/ERGraSVcNIy/aFIbqrTe+MhWA19I8wq4uxD6Ndg=;\n\tb=IdJYxTBKhmk4EQWfGpi4F1rFX9D83PJVwRNMBpGIY8oe6SFHhYHkNRaTaNWsUO60oO\n\tg3UroY1HqqpxTIrtjuTS6bHddbcEC6KXkhj16aq949zktKkzHT4srGWwKXoAz/raAYd5\n\tMgSbI5alu32FP39PMSR116m64272fzBzHsAk9+rePaTjVwU5FqJwblw+ITEdLp1Oheey\n\tQhNPK7xp5qdyDtFxp9eOCtSqaw/pU/APnRicPNEnu3nQ3ObUC+1O8AycXcSLr0Zw+0Pi\n\tJ755ly2BiUY+5KtClsR9CUuFhur50T9QVlYt3Q96KrPvIqT2m82S6sBZyyRMl+SSaYe4\n\tRFyA==","X-Gm-Message-State":"AHPjjUjrouPR1iXEnU02kzYhjR/06zej9ZfLZo6XLt+NgVaPgl6prPX6\n\tl4WbrccdY/S7fhdWrTSJuyY/2g==","X-Google-Smtp-Source":"AOwi7QC6qd6XWGW7hARz6a1MbI0391bQ7m4tTe4glbLu3gH6kp1OvqlVw0AI94d314c5GV/lGHeD0A==","X-Received":"by 10.200.54.88 with SMTP id n24mr5969534qtb.223.1505891876837; \n\tWed, 20 Sep 2017 00:17:56 -0700 (PDT)","Date":"Wed, 20 Sep 2017 09:17:47 +0200","From":"Simon Horman ","To":"Roi Dayan ","Message-ID":"<20170920071743.GA23454@vergenet.net>","References":"<1505311498-13843-1-git-send-email-roid@mellanox.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<1505311498-13843-1-git-send-email-roid@mellanox.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-Spam-Status":"No, score=0.5 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_NONE,\n\tRCVD_IN_SORBS_SPAM autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"dev@openvswitch.org","Subject":"Re: [ovs-dev] [PATCH V2] netdev-tc-offloads: Fix vxlan tunnel\n\toffloading","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}}]