Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/813120/?format=api
{ "id": 813120, "url": "http://patchwork.ozlabs.org/api/patches/813120/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/1505268023-23047-1-git-send-email-bmeng.cn@gmail.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1505268023-23047-1-git-send-email-bmeng.cn@gmail.com>", "list_archive_url": null, "date": "2017-09-13T02:00:23", "name": "[U-Boot,v2] blk: Remove various places that do flush cache after read", "commit_ref": "723b43daec7ee2ddb600cfcb9b0253d4a71c3915", "pull_url": null, "state": "accepted", "archived": false, "hash": "7a8d702a75176663db2877575198280efcc35eba", "submitter": { "id": 64981, "url": "http://patchwork.ozlabs.org/api/people/64981/?format=api", "name": "Bin Meng", "email": "bmeng.cn@gmail.com" }, "delegate": { "id": 3651, "url": "http://patchwork.ozlabs.org/api/users/3651/?format=api", "username": "trini", "first_name": "Tom", "last_name": "Rini", "email": "trini@ti.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/1505268023-23047-1-git-send-email-bmeng.cn@gmail.com/mbox/", "series": [ { "id": 2792, "url": "http://patchwork.ozlabs.org/api/series/2792/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=2792", "date": "2017-09-13T02:00:23", "name": "[U-Boot,v2] blk: Remove various places that do flush cache after read", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/2792/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/813120/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/813120/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"rlKvjnS/\"; dkim-atps=neutral" ], "Received": [ "from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xsPs613BGz9sPs\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Sep 2017 11:56:10 +1000 (AEST)", "by lists.denx.de (Postfix, from userid 105)\n\tid C900BC22143; Wed, 13 Sep 2017 01:56:06 +0000 (UTC)", "from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 8205DC21E71;\n\tWed, 13 Sep 2017 01:56:03 +0000 (UTC)", "by lists.denx.de (Postfix, from userid 105)\n\tid CEBE7C21E71; Wed, 13 Sep 2017 01:56:02 +0000 (UTC)", "from mail-io0-f195.google.com (mail-io0-f195.google.com\n\t[209.85.223.195])\n\tby lists.denx.de (Postfix) with ESMTPS id 7FCF6C21C57\n\tfor <u-boot@lists.denx.de>; Wed, 13 Sep 2017 01:56:01 +0000 (UTC)", "by mail-io0-f195.google.com with SMTP id g32so8222287ioj.1\n\tfor <u-boot@lists.denx.de>; Tue, 12 Sep 2017 18:56:01 -0700 (PDT)", "from ala-d2121-lx1.wrs.com (unknown-156-139.windriver.com.\n\t[147.11.156.139]) by smtp.gmail.com with ESMTPSA id\n\tv5sm3575372iob.5.2017.09.12.18.55.58\n\t(version=TLS1_1 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tTue, 12 Sep 2017 18:55:59 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:subject:date:message-id;\n\tbh=HBER6l0qCexV5odyi1fxgKl4m9m+C/VIheyfScb5B9U=;\n\tb=rlKvjnS/OSg7gFqdXo3DYzdnv+stg3qcF16K45OVQ1ZUcs0DKmF6wm9vqOkyLVhLD7\n\tgjqZX/dPpZB6BL5orZnL4pcjKvMk9tXc+E4KAHD6PNlaSLYy9gSIWSXRDSfEWY1shpIj\n\t0bLc8kHyEtXhnd8BH0hGFTCR+asz9yXtyQ3mVB3PsQQaubl2KI3V8bcCyWjS7c98Ek0U\n\teSwnVpzMdeUvMdIGhPtyZ7O2qeQo5bjEW4gSwj9HLw/9EQHLouVSL2GfSw152UCJINXH\n\ttDo2gLG7tGBpHzMazbjY6KhJIXr8isO+TbZkv5S+q3Qynemr/E3OLgZqVP6H167NMXTu\n\tNMHQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:subject:date:message-id;\n\tbh=HBER6l0qCexV5odyi1fxgKl4m9m+C/VIheyfScb5B9U=;\n\tb=nAM2BPRk7eBKDtISvuuR/vmOTOpJOpDDVL2fCooxvKn+Vs8SS8E5RUQDxRqtUrZM+I\n\todrv6/Pu3MZyxTfZ/7EFfSFIsRu28LMoTBJh7k6dhwhnq2Uhiizobo1aZi+YfQtu0DBM\n\tMbgjld7P8VX4QJeLXOUWH7KsT7z01jVJiHS/V0geIt7yu4cuZvJreJ8ak7W/HCOgqOoq\n\tu+SLqobZLxV3Gw0TbxiFJGOBsogBPmoUdfkQvY+VyddN2cF5fZzKS8CcQFC33cjt7aom\n\tLljolEi7c9kGqB/sU9Cpxj2fw5LDWJUOMNaQXib43rZxka+AYhw6bDfHaxxwRzQa8UzB\n\tbDNw==", "X-Gm-Message-State": "AHPjjUixWbwVTnfExMWyq3+nYlqONDNxXuIYETLBm4oL+5myfnKS5WM0\n\tVdeYhAYXXMLy4w==", "X-Google-Smtp-Source": "AOwi7QDMs07gHdz5ryU1MWexPUR2hDbQCXgFCGsO2Hsxh8I9TzwIQMp5aSuvfeKMJ000t0lPIPT3XQ==", "X-Received": "by 10.107.84.3 with SMTP id i3mr6072466iob.52.1505267760016;\n\tTue, 12 Sep 2017 18:56:00 -0700 (PDT)", "From": "Bin Meng <bmeng.cn@gmail.com>", "To": "Tom Rini <trini@konsulko.com>, U-Boot Mailing List <u-boot@lists.denx.de>", "Date": "Tue, 12 Sep 2017 19:00:23 -0700", "Message-Id": "<1505268023-23047-1-git-send-email-bmeng.cn@gmail.com>", "X-Mailer": "git-send-email 1.7.9.5", "Subject": "[U-Boot] [PATCH v2] blk: Remove various places that do flush cache\n\tafter read", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.18", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<http://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>" }, "content": "All these places seem to inherit the codes from the MMC driver where\na FIXME was put in the comment. However the correct operation after\nread should be cache invalidate, not flush.\n\nThe underlying drivers should be responsible for the cache operation.\nRemove these codes completely.\n\nSigned-off-by: Bin Meng <bmeng.cn@gmail.com>\nReviewed-by: Stefan Roese <sr@denx.de>\nReviewed-by: York Sun <york.sun@nxp.com>\nReviewed-by: Joe Hershberger <joe.hershberger@ni.com>\nReviewed-by: Simon Glass <sjg@chromium.org>\nTested-by: York Sun <york.sun@nxp.com>\n\n---\n\nChanges in v2:\n- rebase on top of u-boot/master\n\n arch/arm/cpu/armv8/fsl-layerscape/ppa.c | 15 ---------------\n board/toradex/common/tdx-cfg-block.c | 2 --\n cmd/mmc.c | 2 --\n drivers/block/blk-uclass.c | 3 ---\n drivers/block/blk_legacy.c | 3 ---\n drivers/net/fm/fm.c | 2 --\n drivers/net/phy/cortina.c | 2 --\n drivers/qe/qe.c | 2 --\n 8 files changed, 31 deletions(-)", "diff": "diff --git a/arch/arm/cpu/armv8/fsl-layerscape/ppa.c b/arch/arm/cpu/armv8/fsl-layerscape/ppa.c\nindex 24ddb5d..bbf8bba 100644\n--- a/arch/arm/cpu/armv8/fsl-layerscape/ppa.c\n+++ b/arch/arm/cpu/armv8/fsl-layerscape/ppa.c\n@@ -107,9 +107,6 @@ int ppa_init(void)\n \t\treturn -EIO;\n \t}\n \n-\t/* flush cache after read */\n-\tflush_cache((ulong)fitp, cnt * 512);\n-\n \tret = fdt_check_header(fitp);\n \tif (ret) {\n \t\tfree(fitp);\n@@ -134,9 +131,6 @@ int ppa_init(void)\n \t}\n \tdebug(\"Read PPA header to 0x%p\\n\", ppa_hdr_ddr);\n \n-\t/* flush cache after read */\n-\tflush_cache((ulong)ppa_hdr_ddr, cnt * 512);\n-\n \tppa_esbc_hdr = (uintptr_t)ppa_hdr_ddr;\n #endif\n \n@@ -164,9 +158,6 @@ int ppa_init(void)\n \t\treturn -EIO;\n \t}\n \n-\t/* flush cache after read */\n-\tflush_cache((ulong)ppa_fit_addr, cnt * 512);\n-\n #elif defined(CONFIG_SYS_LS_PPA_FW_IN_NAND)\n \tstruct fdt_header fit;\n \n@@ -208,9 +199,6 @@ int ppa_init(void)\n \t}\n \tdebug(\"Read PPA header to 0x%p\\n\", ppa_hdr_ddr);\n \n-\t/* flush cache after read */\n-\tflush_cache((ulong)ppa_hdr_ddr, fw_length);\n-\n \tppa_esbc_hdr = (uintptr_t)ppa_hdr_ddr;\n #endif\n \n@@ -232,9 +220,6 @@ int ppa_init(void)\n \t\t CONFIG_SYS_LS_PPA_FW_ADDR);\n \t\treturn -EIO;\n \t}\n-\n-\t/* flush cache after read */\n-\tflush_cache((ulong)ppa_fit_addr, fw_length);\n #else\n #error \"No CONFIG_SYS_LS_PPA_FW_IN_xxx defined\"\n #endif\ndiff --git a/board/toradex/common/tdx-cfg-block.c b/board/toradex/common/tdx-cfg-block.c\nindex 328c4c0..f850a3c 100644\n--- a/board/toradex/common/tdx-cfg-block.c\n+++ b/board/toradex/common/tdx-cfg-block.c\n@@ -129,8 +129,6 @@ static int tdx_cfg_block_mmc_storage(u8 *config_block, int write)\n \t\t\tret = -EIO;\n \t\t\tgoto out;\n \t\t}\n-\t\t/* Flush cache after read */\n-\t\tflush_cache((ulong)(unsigned char *)config_block, 512);\n \t} else {\n \t\t/* Just writing one 512 byte block */\n \t\tif (blk_dwrite(mmc_get_blk_desc(mmc), blk_start, 1,\ndiff --git a/cmd/mmc.c b/cmd/mmc.c\nindex 00697fc..5def4ea 100644\n--- a/cmd/mmc.c\n+++ b/cmd/mmc.c\n@@ -293,8 +293,6 @@ static int do_mmc_read(cmd_tbl_t *cmdtp, int flag,\n \t curr_device, blk, cnt);\n \n \tn = blk_dread(mmc_get_blk_desc(mmc), blk, cnt, addr);\n-\t/* flush cache after read */\n-\tflush_cache((ulong)addr, cnt * 512); /* FIXME */\n \tprintf(\"%d blocks read: %s\\n\", n, (n == cnt) ? \"OK\" : \"ERROR\");\n \n \treturn (n == cnt) ? CMD_RET_SUCCESS : CMD_RET_FAILURE;\ndiff --git a/drivers/block/blk-uclass.c b/drivers/block/blk-uclass.c\nindex aee2a50..537cf5f 100644\n--- a/drivers/block/blk-uclass.c\n+++ b/drivers/block/blk-uclass.c\n@@ -294,9 +294,6 @@ ulong blk_read_devnum(enum if_type if_type, int devnum, lbaint_t start,\n \tif (IS_ERR_VALUE(n))\n \t\treturn n;\n \n-\t/* flush cache after read */\n-\tflush_cache((ulong)buffer, blkcnt * desc->blksz);\n-\n \treturn n;\n }\n \ndiff --git a/drivers/block/blk_legacy.c b/drivers/block/blk_legacy.c\nindex 981872e..16d3bfe 100644\n--- a/drivers/block/blk_legacy.c\n+++ b/drivers/block/blk_legacy.c\n@@ -232,9 +232,6 @@ ulong blk_read_devnum(enum if_type if_type, int devnum, lbaint_t start,\n \tif (IS_ERR_VALUE(n))\n \t\treturn n;\n \n-\t/* flush cache after read */\n-\tflush_cache((ulong)buffer, blkcnt * desc->blksz);\n-\n \treturn n;\n }\n \ndiff --git a/drivers/net/fm/fm.c b/drivers/net/fm/fm.c\nindex 451dfde..261f1b9 100644\n--- a/drivers/net/fm/fm.c\n+++ b/drivers/net/fm/fm.c\n@@ -405,8 +405,6 @@ int fm_init_common(int index, struct ccsr_fman *reg)\n \t\tmmc_init(mmc);\n \t\t(void)mmc->block_dev.block_read(&mmc->block_dev, blk, cnt,\n \t\t\t\t\t\taddr);\n-\t\t/* flush cache after read */\n-\t\tflush_cache((ulong)addr, cnt * 512);\n \t}\n #elif defined(CONFIG_SYS_QE_FMAN_FW_IN_REMOTE)\n \tvoid *addr = (void *)CONFIG_SYS_FMAN_FW_ADDR;\ndiff --git a/drivers/net/phy/cortina.c b/drivers/net/phy/cortina.c\nindex e0e9ed9..637d89a 100644\n--- a/drivers/net/phy/cortina.c\n+++ b/drivers/net/phy/cortina.c\n@@ -177,8 +177,6 @@ void cs4340_upload_firmware(struct phy_device *phydev)\n \t\tmmc_init(mmc);\n \t\t(void)mmc->block_dev.block_read(&mmc->block_dev, blk, cnt,\n \t\t\t\t\t\taddr);\n-\t\t/* flush cache after read */\n-\t\tflush_cache((ulong)addr, cnt * 512);\n \t}\n #endif\n \ndiff --git a/drivers/qe/qe.c b/drivers/qe/qe.c\nindex 8151068..5366a1e 100644\n--- a/drivers/qe/qe.c\n+++ b/drivers/qe/qe.c\n@@ -221,8 +221,6 @@ void u_qe_init(void)\n \t\tmmc_init(mmc);\n \t\t(void)mmc->block_dev.block_read(&mmc->block_dev, blk, cnt,\n \t\t\t\t\t\taddr);\n-\t\t/* flush cache after read */\n-\t\tflush_cache((ulong)addr, cnt * 512);\n \t}\n #endif\n \tif (!u_qe_upload_firmware(addr))\n", "prefixes": [ "U-Boot", "v2" ] }