[{"id":1768914,"web_url":"http://patchwork.ozlabs.org/comment/1768914/","msgid":"","list_archive_url":null,"date":"2017-09-15T01:25:32","subject":"Re: [U-Boot] [PATCH v2] blk: Remove various places that do flush\n\tcache after read","submitter":{"id":64981,"url":"http://patchwork.ozlabs.org/api/people/64981/","name":"Bin Meng","email":"bmeng.cn@gmail.com"},"content":"Hi Tom,\n\nOn Wed, Sep 13, 2017 at 10:00 AM, Bin Meng wrote:\n> All these places seem to inherit the codes from the MMC driver where\n> a FIXME was put in the comment. However the correct operation after\n> read should be cache invalidate, not flush.\n>\n> The underlying drivers should be responsible for the cache operation.\n> Remove these codes completely.\n>\n> Signed-off-by: Bin Meng \n> Reviewed-by: Stefan Roese \n> Reviewed-by: York Sun \n> Reviewed-by: Joe Hershberger \n> Reviewed-by: Simon Glass \n> Tested-by: York Sun \n>\n> ---\n>\n> Changes in v2:\n> - rebase on top of u-boot/master\n>\n> arch/arm/cpu/armv8/fsl-layerscape/ppa.c | 15 ---------------\n> board/toradex/common/tdx-cfg-block.c | 2 --\n> cmd/mmc.c | 2 --\n> drivers/block/blk-uclass.c | 3 ---\n> drivers/block/blk_legacy.c | 3 ---\n> drivers/net/fm/fm.c | 2 --\n> drivers/net/phy/cortina.c | 2 --\n> drivers/qe/qe.c | 2 --\n> 8 files changed, 31 deletions(-)\n>\n\nWill you apply this one?\n\nRegards,\nBin","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"n8PmfGs2\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xtd533422z9t2V\n\tfor ;\n\tFri, 15 Sep 2017 11:25:43 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 29528C21F54; Fri, 15 Sep 2017 01:25:37 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id E9C4EC21D72;\n\tFri, 15 Sep 2017 01:25:34 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 75217C21D72; Fri, 15 Sep 2017 01:25:33 +0000 (UTC)","from mail-wm0-f65.google.com (mail-wm0-f65.google.com\n\t[74.125.82.65])\n\tby lists.denx.de (Postfix) with ESMTPS id 1CDCBC21D6A\n\tfor ; Fri, 15 Sep 2017 01:25:33 +0000 (UTC)","by mail-wm0-f65.google.com with SMTP id r136so1497396wmf.3\n\tfor ; Thu, 14 Sep 2017 18:25:33 -0700 (PDT)","by 10.223.145.3 with HTTP; Thu, 14 Sep 2017 18:25:32 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to;\n\tbh=PGJv6x+pY/0IjUt/qhE0mS8S3QqnLlsTpfg5yful/g8=;\n\tb=n8PmfGs2LGt9KKp3VhexWuRA4+7tEavr0VcLQbnyLe7OXWMfYpOj94WePpa3Wf5L0i\n\tl2Qo9mHs2p1IkHgoh75WRl1vPLEOD23eczaR5ytavplpTrYsd+c9unQP/qzWtAveA5Ju\n\ts3iGeJlKqaRS+mfd3ysrvg8ucrru5xfvQoSST3WZcniQwksgU08cycYXtaf653n3faNz\n\tpzM2rx0BZX1yA2esOCLLsVK6rfuTSiIxg1Cx1qnNgy+4hHQ7KLVZeX6xmSqXQ76XHU9Z\n\tBB7y8v/b01IJBt+4kJuaOi+qgARyCK5jsaGKdfPwi2fu93XFrG+qLR8auP07yUmjX1Pr\n\t5KEw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to;\n\tbh=PGJv6x+pY/0IjUt/qhE0mS8S3QqnLlsTpfg5yful/g8=;\n\tb=Gol9tgKSX5rLSSyZGjbJN68ZJQHYr/zcaWXorYyn6cnniJ8RrC1d/J8nTn9W3xPDbE\n\tDrFfUGpMesa/qotG++0DN5SnaLhAh35tEySO7yPqgYW9RXtP/f+74YIG2u6t9K3imRcT\n\t6SWA7Yn9CyBQQRP1bPw3RHArItWSeUXWEKlGKq4e//cllVpxRnfVLnZUHi4w0bQtVnGU\n\t8LX7n/133/+CserN3EL9EgJgitcITRRkWWZPxQv5aCf+6kXrbW6pi8qS+cmFezoikkBG\n\trkZSc9McmgOSWh6D6LXAIsquFZLOP4HYP0sQK4j5DZy+Grei1EtGkmVH3PgKd5MnHlK5\n\tIyGg==","X-Gm-Message-State":"AHPjjUhpdgwLLbFQkC4tmotqgNk2BpTi+VaxQvDZznOImeRNFsct8fQM\n\tZyjoKPI/mnlWYxsBONFvls3smYKKt33zKqkDr/o=","X-Google-Smtp-Source":"AOwi7QCClGg99wBha/yzjS77+/8FhfTmFk4Tptzn/LwroJ8Dja88XIJJ3iyOl+7ZziIrB/0mw3qhEwEPd83DlfKZm8M=","X-Received":"by 10.28.64.6 with SMTP id n6mr1436232wma.61.1505438732772; Thu,\n\t14 Sep 2017 18:25:32 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1505268023-23047-1-git-send-email-bmeng.cn@gmail.com>","References":"<1505268023-23047-1-git-send-email-bmeng.cn@gmail.com>","From":"Bin Meng ","Date":"Fri, 15 Sep 2017 09:25:32 +0800","Message-ID":"","To":"Tom Rini , U-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH v2] blk: Remove various places that do flush\n\tcache after read","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1769150,"web_url":"http://patchwork.ozlabs.org/comment/1769150/","msgid":"<20170915123145.GZ4560@bill-the-cat>","list_archive_url":null,"date":"2017-09-15T12:31:45","subject":"Re: [U-Boot] [U-Boot,\n\tv2] blk: Remove various places that do flush cache after read","submitter":{"id":65875,"url":"http://patchwork.ozlabs.org/api/people/65875/","name":"Tom Rini","email":"trini@konsulko.com"},"content":"On Tue, Sep 12, 2017 at 07:00:23PM -0700, Bin Meng wrote:\n\n> All these places seem to inherit the codes from the MMC driver where\n> a FIXME was put in the comment. However the correct operation after\n> read should be cache invalidate, not flush.\n> \n> The underlying drivers should be responsible for the cache operation.\n> Remove these codes completely.\n> \n> Signed-off-by: Bin Meng \n> Reviewed-by: Stefan Roese \n> Reviewed-by: York Sun \n> Reviewed-by: Joe Hershberger \n> Reviewed-by: Simon Glass \n> Tested-by: York Sun \n\nApplied to u-boot/master, thanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=konsulko.com header.i=@konsulko.com\n\theader.b=\"M9QCO5I4\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xtvtS73VLz9s7C\n\tfor ;\n\tFri, 15 Sep 2017 22:32:32 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 87E3AC22004; Fri, 15 Sep 2017 12:32:30 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 57CBAC21F73;\n\tFri, 15 Sep 2017 12:32:27 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 71876C21F73; Fri, 15 Sep 2017 12:32:19 +0000 (UTC)","from mail-yw0-f169.google.com (mail-yw0-f169.google.com\n\t[209.85.161.169])\n\tby lists.denx.de (Postfix) with ESMTPS id D70E6C2200C\n\tfor ; Fri, 15 Sep 2017 12:32:18 +0000 (UTC)","by mail-yw0-f169.google.com with SMTP id w22so1324421ywa.13\n\tfor ; Fri, 15 Sep 2017 05:32:18 -0700 (PDT)","from bill-the-cat (cpe-65-184-142-68.ec.res.rr.com.\n\t[65.184.142.68]) by smtp.gmail.com with ESMTPSA id\n\tx81sm255079ywc.35.2017.09.15.05.32.16\n\t(version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tFri, 15 Sep 2017 05:32:17 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com;\n\ts=google; \n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=Qy0S1jqXyThzHh6fVaM3RDeXiQjp3Zz8x6fmTYMhgtQ=;\n\tb=M9QCO5I41FJNtClVEtiG9C4Bn0U6WLrszRnA5qxFeglPPjZfzvhBN5ymRIbvnLetO4\n\tv3ZVgXGtViWeJ5Ske5AaHUfmFThIweM3Zo1sFKVDvn+DQXHcKV2i/fmvm64+/Ju+V6LU\n\tggZBqX9j4gb1MOuVvKwhnO0IgfUY65YQtgv8I=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=Qy0S1jqXyThzHh6fVaM3RDeXiQjp3Zz8x6fmTYMhgtQ=;\n\tb=XErOdj3WSyiGtAfdwONgW3jkrng7drgeAkFDYc+Frr5WeNxXpIsVqoUbSLpVrvmpKl\n\txK2qNTpey1m/wCzJkKPyirB1LpyeKp3wZFKXDtbSQHT7EgYX6ynTES3HK/nFHxnt7zU0\n\tSop9+d7VK/6A3ons1EBlxnsNb8ABIDBJ4zDooLaGxxIPnFDyTcuoi0wF2EjniHfVx56H\n\tuvUwu7j5aVi8F0vE3lrw0kt+lRp0eYxpp9+KzdqXbPN6G3ghQIFzcom8rP6vOy7XHU9k\n\t5Xc4BH8sGUpWnYYQBjWsA//jQPJ6O9WNuEnuyvCxCGzJJ42pQWXQT1cXgxCuMhO+y/tm\n\t6UhQ==","X-Gm-Message-State":"AHPjjUirnyvPVWEHyejaUwBgoba9Y+bby6toE7IWoYTwelamRvVMCeh4\n\tRph9VHbozDnWFr2oCEQyFw==","X-Google-Smtp-Source":"AOwi7QBS7wXn8N/dYikIVwmCcBjJswaFSPQqIBdt3gE+Q2KCRmvGiUeYNwlIWEAu3SeIkRSHMABokg==","X-Received":"by 10.37.128.76 with SMTP id a12mr21071039ybn.160.1505478737676; \n\tFri, 15 Sep 2017 05:32:17 -0700 (PDT)","Date":"Fri, 15 Sep 2017 08:31:45 -0400","From":"Tom Rini ","To":"Bin Meng ","Message-ID":"<20170915123145.GZ4560@bill-the-cat>","References":"<1505268023-23047-1-git-send-email-bmeng.cn@gmail.com>","MIME-Version":"1.0","In-Reply-To":"<1505268023-23047-1-git-send-email-bmeng.cn@gmail.com>","User-Agent":"Mutt/1.5.21 (2010-09-15)","Cc":"U-Boot Mailing List ","Subject":"Re: [U-Boot] [U-Boot,\n\tv2] blk: Remove various places that do flush cache after read","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============0755106190476363101==\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]