Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/812974/?format=api
{ "id": 812974, "url": "http://patchwork.ozlabs.org/api/patches/812974/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20170912170725.29733-6-marek.vasut+renesas@gmail.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170912170725.29733-6-marek.vasut+renesas@gmail.com>", "list_archive_url": null, "date": "2017-09-12T17:07:25", "name": "[U-Boot,6/6] usb: Drop the EHCI RCar Gen3", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "062b52bf01a3bfaced277f927dbf2b623104a020", "submitter": { "id": 1124, "url": "http://patchwork.ozlabs.org/api/people/1124/?format=api", "name": "Marek Vasut", "email": "marek.vasut@gmail.com" }, "delegate": { "id": 1750, "url": "http://patchwork.ozlabs.org/api/users/1750/?format=api", "username": "iwamatsu", "first_name": "Nobuhiro", "last_name": "Iwamatsu", "email": "iwamatsu@nigauri.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20170912170725.29733-6-marek.vasut+renesas@gmail.com/mbox/", "series": [ { "id": 2744, "url": "http://patchwork.ozlabs.org/api/series/2744/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=2744", "date": "2017-09-12T17:07:21", "name": "[U-Boot,1/6] ARM: rmobile: dts: Add EHCI USB nodes to r8a7796", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/2744/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/812974/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/812974/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"onGOwz1g\"; dkim-atps=neutral" ], "Received": [ "from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xsBBJ0S46z9s3T\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Sep 2017 03:10:15 +1000 (AEST)", "by lists.denx.de (Postfix, from userid 105)\n\tid 9BF1BC21FE6; Tue, 12 Sep 2017 17:09:04 +0000 (UTC)", "from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 6BDD6C22044;\n\tTue, 12 Sep 2017 17:08:14 +0000 (UTC)", "by lists.denx.de (Postfix, from userid 105)\n\tid 73B85C21EC6; Tue, 12 Sep 2017 17:08:04 +0000 (UTC)", "from mail-wm0-f67.google.com (mail-wm0-f67.google.com\n\t[74.125.82.67])\n\tby lists.denx.de (Postfix) with ESMTPS id B3B4BC21FE6\n\tfor <u-boot@lists.denx.de>; Tue, 12 Sep 2017 17:08:00 +0000 (UTC)", "by mail-wm0-f67.google.com with SMTP id 187so9490939wmn.0\n\tfor <u-boot@lists.denx.de>; Tue, 12 Sep 2017 10:08:00 -0700 (PDT)", "from kurokawa.lan (ip-86-49-107-50.net.upcbroadband.cz.\n\t[86.49.107.50]) by smtp.gmail.com with ESMTPSA id\n\tv82sm17241085wmd.44.2017.09.12.10.07.59\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 12 Sep 2017 10:07:59 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=iQn2MwcwQQCrRIjsikYokNAm9G6G2bZ7cjgxAOSgp4U=;\n\tb=onGOwz1guphYkhWiNoHPiNXE3Qg6h5TOXmgZwTFPgoCRW3uR49GXUkNm2XlHE/Iz+5\n\tqkCWjgXq/H0JdYvBjEvwsbXYzO8c6GNh2JaWrqBzvpt5YuewsLqO1Rt8bRaZFd/R6CbY\n\tjKKj1QowFYWETeXBARBfMwB1Oz5Twnk5HwVBCF8Dnf5dq1Xn2NeklqpCZi/k45ML71iF\n\tY8BOsgSNZV2K+WAfEHVl74Xq4TG/cFHR/8btvdW091MBaEHUat3O1bDutfdjldV8+vFF\n\tqr+B/n3C3c8kftHLkau6ti+JVhpLhO70BSpg7HS8CYKJDlyPcNWZOepjxKF21SwjUmmv\n\t6bCw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=iQn2MwcwQQCrRIjsikYokNAm9G6G2bZ7cjgxAOSgp4U=;\n\tb=Cu35FnrLhzfXPjmKhxH4XoGPGSK0ztFh2XOIPuhKvjiDDNeZybYzfHp7UdhRhArWc+\n\tOFiqcUpV5TXR2zmLeTqYUSsQMmTlSiSzx43o0lvLXCV1E3GAU9vBim9IOCdeRggl4XeN\n\tLfHI/mhOq7v/dpB85R42NKDccEiBDVcpzck88QYgA7t06ngqJJDelD5BxyUyr7AdICs1\n\t4Ghr6fOo1FsMJRapQmP+E6PutfghGQUvydPGB1lgh7N5U/CBwPCBgc22fNI0POsCeoSA\n\tnrjQYFXJVO0sLAOAC9YP5PAbgtBVW6EjpxLFnbIeeNhammd5m8SE77shPuH1BrRlEHz0\n\tCu5g==", "X-Gm-Message-State": "AHPjjUiXWoMOORu/1hUXGMGk8sdKSUA2RYXN49RalRCfP743HDly00nD\n\te2O8hUc1T8sMYIC31N0=", "X-Google-Smtp-Source": "AOwi7QCxeAlA6QBxXUAHPye/0d5cA7Hs3orErHtuxH7jHMVgDsujhrU8rHUyZ3ubgYaW4yplv0NLmg==", "X-Received": "by 10.28.17.19 with SMTP id 19mr204707wmr.38.1505236080144;\n\tTue, 12 Sep 2017 10:08:00 -0700 (PDT)", "From": "Marek Vasut <marek.vasut@gmail.com>", "X-Google-Original-From": "Marek Vasut <marek.vasut+renesas@gmail.com>", "To": "u-boot@lists.denx.de", "Date": "Tue, 12 Sep 2017 19:07:25 +0200", "Message-Id": "<20170912170725.29733-6-marek.vasut+renesas@gmail.com>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": "<20170912170725.29733-1-marek.vasut+renesas@gmail.com>", "References": "<20170912170725.29733-1-marek.vasut+renesas@gmail.com>", "Cc": "Marek Vasut <marek.vasut+renesas@gmail.com>", "Subject": "[U-Boot] [PATCH 6/6] usb: Drop the EHCI RCar Gen3", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.18", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<http://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>" }, "content": "Since we use EHCI generic driver on RCar Gen3 , this driver is useless.\nRemove it.\n\nSigned-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>\nCc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>\n---\n drivers/usb/host/Kconfig | 8 ---\n drivers/usb/host/Makefile | 1 -\n drivers/usb/host/ehci-rcar_gen3.c | 106 --------------------------------------\n 3 files changed, 115 deletions(-)\n delete mode 100644 drivers/usb/host/ehci-rcar_gen3.c", "diff": "diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig\nindex eb035a476b..5438feb8f5 100644\n--- a/drivers/usb/host/Kconfig\n+++ b/drivers/usb/host/Kconfig\n@@ -148,14 +148,6 @@ config USB_EHCI_PCI\n \thelp\n \t Enables support for the PCI-based EHCI controller.\n \n-config USB_EHCI_RCAR_GEN3\n-\tbool \"Support for Renesas RCar M3/H3 EHCI USB controller\"\n-\tdepends on RCAR_GEN3\n-\tdefault y\n-\t---help---\n-\t Enables support for the on-chip EHCI controller on Renesas\n-\t R8A7795 and R8A7796 SoCs.\n-\n config USB_EHCI_ZYNQ\n \tbool \"Support for Xilinx Zynq on-chip EHCI USB controller\"\n \tdepends on ARCH_ZYNQ\ndiff --git a/drivers/usb/host/Makefile b/drivers/usb/host/Makefile\nindex ab5a99faa8..d3ff591a71 100644\n--- a/drivers/usb/host/Makefile\n+++ b/drivers/usb/host/Makefile\n@@ -46,7 +46,6 @@ obj-$(CONFIG_USB_EHCI_TEGRA) += ehci-tegra.o\n obj-$(CONFIG_USB_EHCI_VCT) += ehci-vct.o\n obj-$(CONFIG_USB_EHCI_VF) += ehci-vf.o\n obj-$(CONFIG_USB_EHCI_RMOBILE) += ehci-rmobile.o\n-obj-$(CONFIG_USB_EHCI_RCAR_GEN3) += ehci-rcar_gen3.o\n obj-$(CONFIG_USB_EHCI_ZYNQ) += ehci-zynq.o\n \n # xhci\ndiff --git a/drivers/usb/host/ehci-rcar_gen3.c b/drivers/usb/host/ehci-rcar_gen3.c\ndeleted file mode 100644\nindex 525e7f3573..0000000000\n--- a/drivers/usb/host/ehci-rcar_gen3.c\n+++ /dev/null\n@@ -1,106 +0,0 @@\n-/*\n- * drivers/usb/host/ehci-rcar_gen3.\n- *\tThis file is EHCI HCD (Host Controller Driver) for USB.\n- *\n- * Copyright (C) 2015-2017 Renesas Electronics Corporation\n- *\n- * SPDX-License-Identifier: GPL-2.0+\n- */\n-\n-#include <common.h>\n-#include <errno.h>\n-#include <wait_bit.h>\n-#include <asm/io.h>\n-#include <usb/ehci-ci.h>\n-#include \"ehci.h\"\n-\n-#define RCAR_GEN3_USB_BASE(n)\t(0xEE080000 + ((n) * 0x20000))\n-\n-#define EHCI_USBCMD\t\t0x120\n-\n-#define CORE_SPD_RSM_TIMSET\t0x30c\n-#define CORE_OC_TIMSET\t\t0x310\n-\n-/* Register offset */\n-#define AHB_OFFSET\t\t0x200\n-\n-#define BASE_HSUSB\t\t0xE6590000\n-#define REG_LPSTS\t\t(BASE_HSUSB + 0x0102)\t/* 16bit */\n-#define SUSPM\t\t\t0x4000\n-#define SUSPM_NORMAL\t\tBIT(14)\n-#define REG_UGCTRL2\t\t(BASE_HSUSB + 0x0184)\t/* 32bit */\n-#define USB0SEL\t\t\t0x00000030\n-#define USB0SEL_EHCI\t\t0x00000010\n-\n-#define SMSTPCR7\t\t0xE615014C\n-#define SMSTPCR700\t\tBIT(0)\t/* EHCI3 */\n-#define SMSTPCR701\t\tBIT(1)\t/* EHCI2 */\n-#define SMSTPCR702\t\tBIT(2)\t/* EHCI1 */\n-#define SMSTPCR703\t\tBIT(3)\t/* EHCI0 */\n-#define SMSTPCR704\t\tBIT(4)\t/* HSUSB */\n-\n-#define AHB_PLL_RST\t\tBIT(1)\n-\n-#define USBH_INTBEN\t\tBIT(2)\n-#define USBH_INTAEN\t\tBIT(1)\n-\n-#define AHB_INT_ENABLE\t\t0x200\n-#define AHB_USBCTR\t\t0x20c\n-\n-int ehci_hcd_stop(int index)\n-{\n-#if defined(CONFIG_R8A7795)\n-\tconst u32 mask = SMSTPCR703 | SMSTPCR702 | SMSTPCR701 | SMSTPCR700;\n-#else\n-\tconst u32 mask = SMSTPCR703 | SMSTPCR702;\n-#endif\n-\tconst u32 base = RCAR_GEN3_USB_BASE(index);\n-\tint ret;\n-\n-\t/* Reset EHCI */\n-\tsetbits_le32((uintptr_t)(base + EHCI_USBCMD), CMD_RESET);\n-\tret = wait_for_bit(\"ehci-rcar\", (void *)(uintptr_t)base + EHCI_USBCMD,\n-\t\t\t CMD_RESET, false, 10, true);\n-\tif (ret) {\n-\t\tprintf(\"ehci-rcar: reset failed (index=%i, ret=%i).\\n\",\n-\t\t index, ret);\n-\t}\n-\n-\tsetbits_le32(SMSTPCR7, BIT(3 - index));\n-\n-\tif ((readl(SMSTPCR7) & mask) == mask)\n-\t\tsetbits_le32(SMSTPCR7, SMSTPCR704);\n-\n-\treturn 0;\n-}\n-\n-int ehci_hcd_init(int index, enum usb_init_type init,\n-\t\t struct ehci_hccr **hccr, struct ehci_hcor **hcor)\n-{\n-\tconst void __iomem *base =\n-\t\t(void __iomem *)(uintptr_t)RCAR_GEN3_USB_BASE(index);\n-\tstruct usb_ehci *ehci = (struct usb_ehci *)(uintptr_t)base;\n-\n-\tclrbits_le32(SMSTPCR7, BIT(3 - index));\n-\tclrbits_le32(SMSTPCR7, SMSTPCR704);\n-\n-\t*hccr = (struct ehci_hccr *)((uintptr_t)&ehci->caplength);\n-\t*hcor = (struct ehci_hcor *)((uintptr_t)*hccr +\n-\t\t\tHC_LENGTH(ehci_readl(&(*hccr)->cr_capbase)));\n-\n-\t/* Enable interrupt */\n-\tsetbits_le32(base + AHB_INT_ENABLE, USBH_INTBEN | USBH_INTAEN);\n-\twritel(0x014e029b, base + CORE_SPD_RSM_TIMSET);\n-\twritel(0x000209ab, base + CORE_OC_TIMSET);\n-\n-\t/* Choice USB0SEL */\n-\tclrsetbits_le32(REG_UGCTRL2, USB0SEL, USB0SEL_EHCI);\n-\n-\t/* Clock & Reset */\n-\tclrbits_le32(base + AHB_USBCTR, AHB_PLL_RST);\n-\n-\t/* low power status */\n-\tclrsetbits_le16(REG_LPSTS, SUSPM, SUSPM_NORMAL);\n-\n-\treturn 0;\n-}\n", "prefixes": [ "U-Boot", "6/6" ] }