[{"id":1774105,"web_url":"http://patchwork.ozlabs.org/comment/1774105/","msgid":"","list_archive_url":null,"date":"2017-09-24T05:46:13","subject":"Re: [U-Boot] [PATCH 6/6] usb: Drop the EHCI RCar Gen3","submitter":{"id":1028,"url":"http://patchwork.ozlabs.org/api/people/1028/","name":"Nobuhiro Iwamatsu","email":"iwamatsu@nigauri.org"},"content":"Hi,\n\n2017-09-13 2:07 GMT+09:00 Marek Vasut :\n> Since we use EHCI generic driver on RCar Gen3 , this driver is useless.\n> Remove it.\n>\n> Signed-off-by: Marek Vasut \n> Cc: Nobuhiro Iwamatsu \n\nAcked-by: Nobuhiro Iwamatsu \n\nBest regards,\n Nobuhiro\n\n> ---\n> drivers/usb/host/Kconfig | 8 ---\n> drivers/usb/host/Makefile | 1 -\n> drivers/usb/host/ehci-rcar_gen3.c | 106 --------------------------------------\n> 3 files changed, 115 deletions(-)\n> delete mode 100644 drivers/usb/host/ehci-rcar_gen3.c\n>\n> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig\n> index eb035a476b..5438feb8f5 100644\n> --- a/drivers/usb/host/Kconfig\n> +++ b/drivers/usb/host/Kconfig\n> @@ -148,14 +148,6 @@ config USB_EHCI_PCI\n> help\n> Enables support for the PCI-based EHCI controller.\n>\n> -config USB_EHCI_RCAR_GEN3\n> - bool \"Support for Renesas RCar M3/H3 EHCI USB controller\"\n> - depends on RCAR_GEN3\n> - default y\n> - ---help---\n> - Enables support for the on-chip EHCI controller on Renesas\n> - R8A7795 and R8A7796 SoCs.\n> -\n> config USB_EHCI_ZYNQ\n> bool \"Support for Xilinx Zynq on-chip EHCI USB controller\"\n> depends on ARCH_ZYNQ\n> diff --git a/drivers/usb/host/Makefile b/drivers/usb/host/Makefile\n> index ab5a99faa8..d3ff591a71 100644\n> --- a/drivers/usb/host/Makefile\n> +++ b/drivers/usb/host/Makefile\n> @@ -46,7 +46,6 @@ obj-$(CONFIG_USB_EHCI_TEGRA) += ehci-tegra.o\n> obj-$(CONFIG_USB_EHCI_VCT) += ehci-vct.o\n> obj-$(CONFIG_USB_EHCI_VF) += ehci-vf.o\n> obj-$(CONFIG_USB_EHCI_RMOBILE) += ehci-rmobile.o\n> -obj-$(CONFIG_USB_EHCI_RCAR_GEN3) += ehci-rcar_gen3.o\n> obj-$(CONFIG_USB_EHCI_ZYNQ) += ehci-zynq.o\n>\n> # xhci\n> diff --git a/drivers/usb/host/ehci-rcar_gen3.c b/drivers/usb/host/ehci-rcar_gen3.c\n> deleted file mode 100644\n> index 525e7f3573..0000000000\n> --- a/drivers/usb/host/ehci-rcar_gen3.c\n> +++ /dev/null\n> @@ -1,106 +0,0 @@\n> -/*\n> - * drivers/usb/host/ehci-rcar_gen3.\n> - * This file is EHCI HCD (Host Controller Driver) for USB.\n> - *\n> - * Copyright (C) 2015-2017 Renesas Electronics Corporation\n> - *\n> - * SPDX-License-Identifier: GPL-2.0+\n> - */\n> -\n> -#include \n> -#include \n> -#include \n> -#include \n> -#include \n> -#include \"ehci.h\"\n> -\n> -#define RCAR_GEN3_USB_BASE(n) (0xEE080000 + ((n) * 0x20000))\n> -\n> -#define EHCI_USBCMD 0x120\n> -\n> -#define CORE_SPD_RSM_TIMSET 0x30c\n> -#define CORE_OC_TIMSET 0x310\n> -\n> -/* Register offset */\n> -#define AHB_OFFSET 0x200\n> -\n> -#define BASE_HSUSB 0xE6590000\n> -#define REG_LPSTS (BASE_HSUSB + 0x0102) /* 16bit */\n> -#define SUSPM 0x4000\n> -#define SUSPM_NORMAL BIT(14)\n> -#define REG_UGCTRL2 (BASE_HSUSB + 0x0184) /* 32bit */\n> -#define USB0SEL 0x00000030\n> -#define USB0SEL_EHCI 0x00000010\n> -\n> -#define SMSTPCR7 0xE615014C\n> -#define SMSTPCR700 BIT(0) /* EHCI3 */\n> -#define SMSTPCR701 BIT(1) /* EHCI2 */\n> -#define SMSTPCR702 BIT(2) /* EHCI1 */\n> -#define SMSTPCR703 BIT(3) /* EHCI0 */\n> -#define SMSTPCR704 BIT(4) /* HSUSB */\n> -\n> -#define AHB_PLL_RST BIT(1)\n> -\n> -#define USBH_INTBEN BIT(2)\n> -#define USBH_INTAEN BIT(1)\n> -\n> -#define AHB_INT_ENABLE 0x200\n> -#define AHB_USBCTR 0x20c\n> -\n> -int ehci_hcd_stop(int index)\n> -{\n> -#if defined(CONFIG_R8A7795)\n> - const u32 mask = SMSTPCR703 | SMSTPCR702 | SMSTPCR701 | SMSTPCR700;\n> -#else\n> - const u32 mask = SMSTPCR703 | SMSTPCR702;\n> -#endif\n> - const u32 base = RCAR_GEN3_USB_BASE(index);\n> - int ret;\n> -\n> - /* Reset EHCI */\n> - setbits_le32((uintptr_t)(base + EHCI_USBCMD), CMD_RESET);\n> - ret = wait_for_bit(\"ehci-rcar\", (void *)(uintptr_t)base + EHCI_USBCMD,\n> - CMD_RESET, false, 10, true);\n> - if (ret) {\n> - printf(\"ehci-rcar: reset failed (index=%i, ret=%i).\\n\",\n> - index, ret);\n> - }\n> -\n> - setbits_le32(SMSTPCR7, BIT(3 - index));\n> -\n> - if ((readl(SMSTPCR7) & mask) == mask)\n> - setbits_le32(SMSTPCR7, SMSTPCR704);\n> -\n> - return 0;\n> -}\n> -\n> -int ehci_hcd_init(int index, enum usb_init_type init,\n> - struct ehci_hccr **hccr, struct ehci_hcor **hcor)\n> -{\n> - const void __iomem *base =\n> - (void __iomem *)(uintptr_t)RCAR_GEN3_USB_BASE(index);\n> - struct usb_ehci *ehci = (struct usb_ehci *)(uintptr_t)base;\n> -\n> - clrbits_le32(SMSTPCR7, BIT(3 - index));\n> - clrbits_le32(SMSTPCR7, SMSTPCR704);\n> -\n> - *hccr = (struct ehci_hccr *)((uintptr_t)&ehci->caplength);\n> - *hcor = (struct ehci_hcor *)((uintptr_t)*hccr +\n> - HC_LENGTH(ehci_readl(&(*hccr)->cr_capbase)));\n> -\n> - /* Enable interrupt */\n> - setbits_le32(base + AHB_INT_ENABLE, USBH_INTBEN | USBH_INTAEN);\n> - writel(0x014e029b, base + CORE_SPD_RSM_TIMSET);\n> - writel(0x000209ab, base + CORE_OC_TIMSET);\n> -\n> - /* Choice USB0SEL */\n> - clrsetbits_le32(REG_UGCTRL2, USB0SEL, USB0SEL_EHCI);\n> -\n> - /* Clock & Reset */\n> - clrbits_le32(base + AHB_USBCTR, AHB_PLL_RST);\n> -\n> - /* low power status */\n> - clrsetbits_le16(REG_LPSTS, SUSPM, SUSPM_NORMAL);\n> -\n> - return 0;\n> -}\n> --\n> 2.11.0\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=nigauri-org.20150623.gappssmtp.com\n\theader.i=@nigauri-org.20150623.gappssmtp.com\n\theader.b=\"wLlkuznm\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y0GST3q0Rz9t4b\n\tfor ;\n\tSun, 24 Sep 2017 15:47:04 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 3820FC22055; Sun, 24 Sep 2017 05:46:51 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id D88FEC21F17;\n\tSun, 24 Sep 2017 05:46:48 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 9E561C21F17; Sun, 24 Sep 2017 05:46:46 +0000 (UTC)","from mail-io0-f195.google.com (mail-io0-f195.google.com\n\t[209.85.223.195])\n\tby lists.denx.de (Postfix) with ESMTPS id A29A8C21E21\n\tfor ; Sun, 24 Sep 2017 05:46:45 +0000 (UTC)","by mail-io0-f195.google.com with SMTP id d16so1499015ioj.2\n\tfor ; Sat, 23 Sep 2017 22:46:45 -0700 (PDT)","by 10.107.29.5 with HTTP; Sat, 23 Sep 2017 22:46:13 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H2,\n\tT_DKIM_INVALID autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=nigauri-org.20150623.gappssmtp.com; s=20150623;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=EAtylrV0/UEatQmxwp1WpzjqmdW21ScFuxs7USpplTk=;\n\tb=wLlkuznmdMlz/BMAeAbVmF3WaBQm3tl2TbxYpvthIAlOyNBbgBMqHaPnQOrj1r/X0Q\n\ts//sFuAXPnx/5mKSW+v5O87s+wlrko+4yuF8MUjAyUf+xMT9wWlC0pHhbxGjUA0ROcp+\n\txT4Q9Z103iAHrhds22WQonMKIXg9dm0BUiKxHmJikVSTpEqKeD9iOgkCxFm71KZp6Fyw\n\trKEJnIdzT1aumW/JoAKakEUzafMcd7raK9Dgj1NpkG/eYuk/hn8MkkkoY2jMs+CyNn01\n\t56Cd1QBWgIIZ1d+DrTgYLH6X5Ex5x67rhvp2+13s3qu6H3/LCwAx2uM99s8U5oaA4gUG\n\tdUhQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=EAtylrV0/UEatQmxwp1WpzjqmdW21ScFuxs7USpplTk=;\n\tb=jfsMTXAV+XHDvMbRJs3E/ua2aQt+AvoFDME+pulo98uM2jEefy3OLRGy4tosc4FOKl\n\tEtqxkjB8qHX1k00ORx5hbrW61RUuWpwJepSrCucAXbnDuFwlKzYX3PeuwTnPCflJy2z7\n\tXzhqAc4KJTxWXI0CuLemlUJARIfNer5Qu7Tiy24sUMvjIjaRwVhgioKX8lApml8vJJx0\n\tMKV56rhnOTTtF/INxT3ZXWEOKBFROc3vDa4Jm8ATDOADTb+JiotBMHO8odVj8qdL2oJm\n\tvCYlMcYdQ+CdwR9Oo4Vud9Sx0cH/lz4WHEiDrAWpalpjdmQxhXSrVIXoCaFwiNNa+Slr\n\tNbCA==","X-Gm-Message-State":"AHPjjUhs7uEilKLU5cYulyVRiOJD5Baa+LnikEAQJKrXSpQmVmxiZD29\n\tzTRYQ2M4XAnrB8SR11DA5q7/1uL6UsCoJxJvaVxs","X-Google-Smtp-Source":"AOwi7QD7RQgsT7Xd9dF8NnV7FrIkTDq7AC5JJYlae4F2dLndmtqgUJjivpEBSP0XbxCVHAqKth9WKwbtQnTmhMHfJic=","X-Received":"by 10.107.82.14 with SMTP id g14mr4912947iob.137.1506232004147; \n\tSat, 23 Sep 2017 22:46:44 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170912170725.29733-6-marek.vasut+renesas@gmail.com>","References":"<20170912170725.29733-1-marek.vasut+renesas@gmail.com>\n\t<20170912170725.29733-6-marek.vasut+renesas@gmail.com>","From":"Nobuhiro Iwamatsu ","Date":"Sun, 24 Sep 2017 14:46:13 +0900","Message-ID":"","To":"Marek Vasut ","Cc":"U-Boot ,\n\tMarek Vasut ","Subject":"Re: [U-Boot] [PATCH 6/6] usb: Drop the EHCI RCar Gen3","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]