Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/812864/?format=api
{ "id": 812864, "url": "http://patchwork.ozlabs.org/api/patches/812864/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170912140149.7692-2-lvivier@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170912140149.7692-2-lvivier@redhat.com>", "list_archive_url": null, "date": "2017-09-12T14:01:47", "name": "[v3,1/3] hmp: fix \"dump-quest-memory\" segfault (ppc)", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "7b0f822e7c8148cd9625756adcf69561a44b4f4d", "submitter": { "id": 66421, "url": "http://patchwork.ozlabs.org/api/people/66421/?format=api", "name": "Laurent Vivier", "email": "lvivier@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170912140149.7692-2-lvivier@redhat.com/mbox/", "series": [ { "id": 2710, "url": "http://patchwork.ozlabs.org/api/series/2710/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2710", "date": "2017-09-12T14:01:46", "name": "hmp: fix \"dump-quest-memory\" segfault", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/2710/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/812864/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/812864/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=lvivier@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs65k6cq7z9sNV\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Sep 2017 00:06:02 +1000 (AEST)", "from localhost ([::1]:36073 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1drlpA-0000xs-Ut\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 10:06:01 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:55711)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <lvivier@redhat.com>) id 1drllX-0006Lc-FR\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 10:02:20 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <lvivier@redhat.com>) id 1drllR-0002iS-MF\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 10:02:15 -0400", "from mx1.redhat.com ([209.132.183.28]:47212)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <lvivier@redhat.com>)\n\tid 1drllG-0002QU-F5; Tue, 12 Sep 2017 10:01:58 -0400", "from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 68485C04B317;\n\tTue, 12 Sep 2017 14:01:57 +0000 (UTC)", "from thinkpad.redhat.com (ovpn-116-239.ams2.redhat.com\n\t[10.36.116.239])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 2AA0017DF4;\n\tTue, 12 Sep 2017 14:01:53 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com 68485C04B317", "From": "Laurent Vivier <lvivier@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Tue, 12 Sep 2017 16:01:47 +0200", "Message-Id": "<20170912140149.7692-2-lvivier@redhat.com>", "In-Reply-To": "<20170912140149.7692-1-lvivier@redhat.com>", "References": "<20170912140149.7692-1-lvivier@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.13", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tTue, 12 Sep 2017 14:01:57 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH v3 1/3] hmp: fix \"dump-quest-memory\" segfault\n\t(ppc)", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Laurent Vivier <lvivier@redhat.com>,\n\tPeter Maydell <peter.maydell@linaro.org>,\n\tThomas Huth <thuth@redhat.com>, Cornelia Huck <cohuck@redhat.com>,\n\t\"Dr . David Alan Gilbert\" <dgilbert@redhat.com>,\n\tGreg Kurz <groug@kaod.org>, qemu-arm@nongnu.org,\n\tqemu-ppc@nongnu.org, David Gibson <david@gibson.dropbear.id.au>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Running QEMU with\n qemu-system-ppc64 -M none -nographic -m 256\nand executing\n dump-guest-memory /dev/null 0 8192\nresults in segfault\n\nFix by checking if we have CPU, and exit with\nerror if there is no CPU:\n\n (qemu) dump-guest-memory /dev/null\n this feature or command is not currently supported\n\nSigned-off-by: Laurent Vivier <lvivier@redhat.com>\n---\n target/ppc/arch_dump.c | 11 +++++++++--\n 1 file changed, 9 insertions(+), 2 deletions(-)", "diff": "diff --git a/target/ppc/arch_dump.c b/target/ppc/arch_dump.c\nindex 8e9397aa58..95b9ab6f29 100644\n--- a/target/ppc/arch_dump.c\n+++ b/target/ppc/arch_dump.c\n@@ -224,8 +224,15 @@ typedef struct NoteFuncDescStruct NoteFuncDesc;\n int cpu_get_dump_info(ArchDumpInfo *info,\n const struct GuestPhysBlockList *guest_phys_blocks)\n {\n- PowerPCCPU *cpu = POWERPC_CPU(first_cpu);\n- PowerPCCPUClass *pcc = POWERPC_CPU_GET_CLASS(cpu);\n+ PowerPCCPU *cpu;\n+ PowerPCCPUClass *pcc;\n+\n+ if (first_cpu == NULL) {\n+ return -1;\n+ }\n+\n+ cpu = POWERPC_CPU(first_cpu);\n+ pcc = POWERPC_CPU_GET_CLASS(cpu);\n \n info->d_machine = PPC_ELF_MACHINE;\n info->d_class = ELFCLASS;\n", "prefixes": [ "v3", "1/3" ] }