[{"id":1767101,"web_url":"http://patchwork.ozlabs.org/comment/1767101/","msgid":"<01253a14-2254-dc47-c4ac-dbcb87bfd5ad@redhat.com>","list_archive_url":null,"date":"2017-09-12T14:10:48","subject":"Re: [Qemu-devel] [PATCH v3 1/3] hmp: fix \"dump-quest-memory\"\n\tsegfault (ppc)","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 12.09.2017 16:01, Laurent Vivier wrote:\n> Running QEMU with\n>     qemu-system-ppc64 -M none -nographic -m 256\n> and executing\n>     dump-guest-memory /dev/null 0 8192\n> results in segfault\n> \n> Fix by checking if we have CPU, and exit with\n> error if there is no CPU:\n> \n>     (qemu) dump-guest-memory /dev/null\n>     this feature or command is not currently supported\n> \n> Signed-off-by: Laurent Vivier <lvivier@redhat.com>\n> ---\n>  target/ppc/arch_dump.c | 11 +++++++++--\n>  1 file changed, 9 insertions(+), 2 deletions(-)\n> \n> diff --git a/target/ppc/arch_dump.c b/target/ppc/arch_dump.c\n> index 8e9397aa58..95b9ab6f29 100644\n> --- a/target/ppc/arch_dump.c\n> +++ b/target/ppc/arch_dump.c\n> @@ -224,8 +224,15 @@ typedef struct NoteFuncDescStruct NoteFuncDesc;\n>  int cpu_get_dump_info(ArchDumpInfo *info,\n>                        const struct GuestPhysBlockList *guest_phys_blocks)\n>  {\n> -    PowerPCCPU *cpu = POWERPC_CPU(first_cpu);\n> -    PowerPCCPUClass *pcc = POWERPC_CPU_GET_CLASS(cpu);\n> +    PowerPCCPU *cpu;\n> +    PowerPCCPUClass *pcc;\n> +\n> +    if (first_cpu == NULL) {\n> +        return -1;\n> +    }\n> +\n> +    cpu = POWERPC_CPU(first_cpu);\n> +    pcc = POWERPC_CPU_GET_CLASS(cpu);\n>  \n>      info->d_machine = PPC_ELF_MACHINE;\n>      info->d_class = ELFCLASS;\n> \n\nReviewed-by: Thomas Huth <thuth@redhat.com>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs6DJ6Slqz9s0Z\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Sep 2017 00:11:44 +1000 (AEST)","from localhost ([::1]:36117 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1drluh-0005nQ-05\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 10:11:43 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:34870)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <thuth@redhat.com>) id 1drlu6-0005kj-8k\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 10:11:07 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <thuth@redhat.com>) id 1drlu2-0001sP-7p\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 10:11:06 -0400","from mx1.redhat.com ([209.132.183.28]:35176)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <thuth@redhat.com>)\n\tid 1drltv-0001kF-DN; Tue, 12 Sep 2017 10:10:55 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 7B1A4267D8;\n\tTue, 12 Sep 2017 14:10:54 +0000 (UTC)","from [10.40.204.137] (ovpn-204-137.brq.redhat.com [10.40.204.137])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id D86F966835;\n\tTue, 12 Sep 2017 14:10:50 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 7B1A4267D8","To":"Laurent Vivier <lvivier@redhat.com>, qemu-devel@nongnu.org","References":"<20170912140149.7692-1-lvivier@redhat.com>\n\t<20170912140149.7692-2-lvivier@redhat.com>","From":"Thomas Huth <thuth@redhat.com>","Message-ID":"<01253a14-2254-dc47-c4ac-dbcb87bfd5ad@redhat.com>","Date":"Tue, 12 Sep 2017 16:10:48 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170912140149.7692-2-lvivier@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tTue, 12 Sep 2017 14:10:54 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v3 1/3] hmp: fix \"dump-quest-memory\"\n\tsegfault (ppc)","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Peter Maydell <peter.maydell@linaro.org>,\n\tCornelia Huck <cohuck@redhat.com>, \n\t\"Dr . David Alan Gilbert\" <dgilbert@redhat.com>,\n\tGreg Kurz <groug@kaod.org>, qemu-arm@nongnu.org,\n\tqemu-ppc@nongnu.org, David Gibson <david@gibson.dropbear.id.au>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1767144,"web_url":"http://patchwork.ozlabs.org/comment/1767144/","msgid":"<20170912164832.35b68417@bahia.lan>","list_archive_url":null,"date":"2017-09-12T14:48:32","subject":"Re: [Qemu-devel] [PATCH v3 1/3] hmp: fix \"dump-quest-memory\"\n\tsegfault (ppc)","submitter":{"id":69178,"url":"http://patchwork.ozlabs.org/api/people/69178/","name":"Greg Kurz","email":"groug@kaod.org"},"content":"On Tue, 12 Sep 2017 16:01:47 +0200\nLaurent Vivier <lvivier@redhat.com> wrote:\n\n> Running QEMU with\n>     qemu-system-ppc64 -M none -nographic -m 256\n> and executing\n>     dump-guest-memory /dev/null 0 8192\n> results in segfault\n> \n> Fix by checking if we have CPU, and exit with\n> error if there is no CPU:\n> \n>     (qemu) dump-guest-memory /dev/null\n>     this feature or command is not currently supported\n> \n> Signed-off-by: Laurent Vivier <lvivier@redhat.com>\n> ---\n\nReviewed-by: Greg Kurz <groug@kaod.org>\n\n>  target/ppc/arch_dump.c | 11 +++++++++--\n>  1 file changed, 9 insertions(+), 2 deletions(-)\n> \n> diff --git a/target/ppc/arch_dump.c b/target/ppc/arch_dump.c\n> index 8e9397aa58..95b9ab6f29 100644\n> --- a/target/ppc/arch_dump.c\n> +++ b/target/ppc/arch_dump.c\n> @@ -224,8 +224,15 @@ typedef struct NoteFuncDescStruct NoteFuncDesc;\n>  int cpu_get_dump_info(ArchDumpInfo *info,\n>                        const struct GuestPhysBlockList *guest_phys_blocks)\n>  {\n> -    PowerPCCPU *cpu = POWERPC_CPU(first_cpu);\n> -    PowerPCCPUClass *pcc = POWERPC_CPU_GET_CLASS(cpu);\n> +    PowerPCCPU *cpu;\n> +    PowerPCCPUClass *pcc;\n> +\n> +    if (first_cpu == NULL) {\n> +        return -1;\n> +    }\n> +\n> +    cpu = POWERPC_CPU(first_cpu);\n> +    pcc = POWERPC_CPU_GET_CLASS(cpu);\n>  \n>      info->d_machine = PPC_ELF_MACHINE;\n>      info->d_class = ELFCLASS;","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs77W59MCz9s4s\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Sep 2017 00:52:39 +1000 (AEST)","from localhost ([::1]:36338 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1drmYH-0001NL-O7\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 10:52:37 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:53262)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <groug@kaod.org>) id 1drmUe-00079v-FR\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 10:48:53 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <groug@kaod.org>) id 1drmUZ-0003fw-LP\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 10:48:52 -0400","from 10.mo1.mail-out.ovh.net ([178.32.96.102]:36458)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <groug@kaod.org>) id 1drmUZ-0003fM-EM\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 10:48:47 -0400","from player691.ha.ovh.net (b9.ovh.net [213.186.33.59])\n\tby mo1.mail-out.ovh.net (Postfix) with ESMTP id 6817D939A4\n\tfor <qemu-devel@nongnu.org>; Tue, 12 Sep 2017 16:48:44 +0200 (CEST)","from bahia.lan (deibp9eh1--blueice1n3.emea.ibm.com\n\t[195.212.29.165]) (Authenticated sender: groug@kaod.org)\n\tby player691.ha.ovh.net (Postfix) with ESMTPSA id 39F77260080;\n\tTue, 12 Sep 2017 16:48:34 +0200 (CEST)"],"Date":"Tue, 12 Sep 2017 16:48:32 +0200","From":"Greg Kurz <groug@kaod.org>","To":"Laurent Vivier <lvivier@redhat.com>","Message-ID":"<20170912164832.35b68417@bahia.lan>","In-Reply-To":"<20170912140149.7692-2-lvivier@redhat.com>","References":"<20170912140149.7692-1-lvivier@redhat.com>\n\t<20170912140149.7692-2-lvivier@redhat.com>","X-Mailer":"Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tboundary=\"Sig_/jqtcadcRQMkQGk4UPCRiE62\";\n\tprotocol=\"application/pgp-signature\"","X-Ovh-Tracer-Id":"17567416247460075814","X-VR-SPAMSTATE":"OK","X-VR-SPAMSCORE":"-100","X-VR-SPAMCAUSE":"gggruggvucftvghtrhhoucdtuddrfeelledrgedvgdejkecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"178.32.96.102","Subject":"Re: [Qemu-devel] [PATCH v3 1/3] hmp: fix \"dump-quest-memory\"\n\tsegfault (ppc)","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Peter Maydell <peter.maydell@linaro.org>, Thomas Huth <thuth@redhat.com>,\n\tCornelia Huck <cohuck@redhat.com>, qemu-devel@nongnu.org,\n\t\"Dr . David Alan Gilbert\" <dgilbert@redhat.com>,\n\tqemu-arm@nongnu.org, qemu-ppc@nongnu.org,\n\tDavid Gibson <david@gibson.dropbear.id.au>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1767584,"web_url":"http://patchwork.ozlabs.org/comment/1767584/","msgid":"<20170913053533.GF7550@umbus.fritz.box>","list_archive_url":null,"date":"2017-09-13T05:35:33","subject":"Re: [Qemu-devel] [PATCH v3 1/3] hmp: fix \"dump-quest-memory\"\n\tsegfault (ppc)","submitter":{"id":47,"url":"http://patchwork.ozlabs.org/api/people/47/","name":"David Gibson","email":"david@gibson.dropbear.id.au"},"content":"On Tue, Sep 12, 2017 at 04:01:47PM +0200, Laurent Vivier wrote:\n> Running QEMU with\n>     qemu-system-ppc64 -M none -nographic -m 256\n> and executing\n>     dump-guest-memory /dev/null 0 8192\n> results in segfault\n> \n> Fix by checking if we have CPU, and exit with\n> error if there is no CPU:\n> \n>     (qemu) dump-guest-memory /dev/null\n>     this feature or command is not currently supported\n> \n> Signed-off-by: Laurent Vivier <lvivier@redhat.com>\n\nApplied to ppc-for-2.11.  I'm not really sure what to do with the rest\nof the series though.\n\n> ---\n>  target/ppc/arch_dump.c | 11 +++++++++--\n>  1 file changed, 9 insertions(+), 2 deletions(-)\n> \n> diff --git a/target/ppc/arch_dump.c b/target/ppc/arch_dump.c\n> index 8e9397aa58..95b9ab6f29 100644\n> --- a/target/ppc/arch_dump.c\n> +++ b/target/ppc/arch_dump.c\n> @@ -224,8 +224,15 @@ typedef struct NoteFuncDescStruct NoteFuncDesc;\n>  int cpu_get_dump_info(ArchDumpInfo *info,\n>                        const struct GuestPhysBlockList *guest_phys_blocks)\n>  {\n> -    PowerPCCPU *cpu = POWERPC_CPU(first_cpu);\n> -    PowerPCCPUClass *pcc = POWERPC_CPU_GET_CLASS(cpu);\n> +    PowerPCCPU *cpu;\n> +    PowerPCCPUClass *pcc;\n> +\n> +    if (first_cpu == NULL) {\n> +        return -1;\n> +    }\n> +\n> +    cpu = POWERPC_CPU(first_cpu);\n> +    pcc = POWERPC_CPU_GET_CLASS(cpu);\n>  \n>      info->d_machine = PPC_ELF_MACHINE;\n>      info->d_class = ELFCLASS;","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=gibson.dropbear.id.au\n\theader.i=@gibson.dropbear.id.au header.b=\"qNIK1r6w\"; \n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsVns51Plz9ryT\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Sep 2017 15:38:41 +1000 (AEST)","from localhost ([::1]:40224 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1ds0Nj-00088s-RV\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 01:38:39 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:57441)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <dgibson@ozlabs.org>) id 1ds0L9-0005kY-QX\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 01:36:00 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <dgibson@ozlabs.org>) id 1ds0L8-0004P7-LG\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 01:35:59 -0400","from ozlabs.org ([103.22.144.67]:33225)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <dgibson@ozlabs.org>)\n\tid 1ds0L2-0004EV-47; Wed, 13 Sep 2017 01:35:53 -0400","by ozlabs.org (Postfix, from userid 1007)\n\tid 3xsVkR2v09z9t1G; Wed, 13 Sep 2017 15:35:43 +1000 (AEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n\td=gibson.dropbear.id.au; s=201602; t=1505280943;\n\tbh=iPqLdahyJx0rSwpUNNAyP8RDJx+fw/jNJ44vKr4qTek=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=qNIK1r6wGA/DL6r4ApqEZFNHLkw4nzRbczpyIiGYdK4fUdqZxsrVF59iaYYDMhItF\n\t+Y6bk6rfvCdq4hyUhXweIDPbLtM3udODihZSt7qez6HZBHlZlsrd/jQNqDNsMiecJn\n\tx13WTfSLGQ3zQ0ufVxL/BASKi/SvQHu2xz1kIrDE=","Date":"Wed, 13 Sep 2017 15:35:33 +1000","From":"David Gibson <david@gibson.dropbear.id.au>","To":"Laurent Vivier <lvivier@redhat.com>","Message-ID":"<20170913053533.GF7550@umbus.fritz.box>","References":"<20170912140149.7692-1-lvivier@redhat.com>\n\t<20170912140149.7692-2-lvivier@redhat.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"s5/bjXLgkIwAv6Hi\"","Content-Disposition":"inline","In-Reply-To":"<20170912140149.7692-2-lvivier@redhat.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"103.22.144.67","Subject":"Re: [Qemu-devel] [PATCH v3 1/3] hmp: fix \"dump-quest-memory\"\n\tsegfault (ppc)","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Peter Maydell <peter.maydell@linaro.org>, Thomas Huth <thuth@redhat.com>,\n\tCornelia Huck <cohuck@redhat.com>, qemu-devel@nongnu.org,\n\t\"Dr . David Alan Gilbert\" <dgilbert@redhat.com>,\n\tGreg Kurz <groug@kaod.org>, qemu-arm@nongnu.org, qemu-ppc@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1767857,"web_url":"http://patchwork.ozlabs.org/comment/1767857/","msgid":"<20170913124456.GB2096@work-vm>","list_archive_url":null,"date":"2017-09-13T12:44:57","subject":"Re: [Qemu-devel] [PATCH v3 1/3] hmp: fix \"dump-quest-memory\"\n\tsegfault (ppc)","submitter":{"id":48102,"url":"http://patchwork.ozlabs.org/api/people/48102/","name":"Dr. David Alan Gilbert","email":"dgilbert@redhat.com"},"content":"* David Gibson (david@gibson.dropbear.id.au) wrote:\n> On Tue, Sep 12, 2017 at 04:01:47PM +0200, Laurent Vivier wrote:\n> > Running QEMU with\n> >     qemu-system-ppc64 -M none -nographic -m 256\n> > and executing\n> >     dump-guest-memory /dev/null 0 8192\n> > results in segfault\n> > \n> > Fix by checking if we have CPU, and exit with\n> > error if there is no CPU:\n> > \n> >     (qemu) dump-guest-memory /dev/null\n> >     this feature or command is not currently supported\n> > \n> > Signed-off-by: Laurent Vivier <lvivier@redhat.com>\n> \n> Applied to ppc-for-2.11.  I'm not really sure what to do with the rest\n> of the series though.\n\nI can take the whole set through HMP.\n\nDave\n\n> > ---\n> >  target/ppc/arch_dump.c | 11 +++++++++--\n> >  1 file changed, 9 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/target/ppc/arch_dump.c b/target/ppc/arch_dump.c\n> > index 8e9397aa58..95b9ab6f29 100644\n> > --- a/target/ppc/arch_dump.c\n> > +++ b/target/ppc/arch_dump.c\n> > @@ -224,8 +224,15 @@ typedef struct NoteFuncDescStruct NoteFuncDesc;\n> >  int cpu_get_dump_info(ArchDumpInfo *info,\n> >                        const struct GuestPhysBlockList *guest_phys_blocks)\n> >  {\n> > -    PowerPCCPU *cpu = POWERPC_CPU(first_cpu);\n> > -    PowerPCCPUClass *pcc = POWERPC_CPU_GET_CLASS(cpu);\n> > +    PowerPCCPU *cpu;\n> > +    PowerPCCPUClass *pcc;\n> > +\n> > +    if (first_cpu == NULL) {\n> > +        return -1;\n> > +    }\n> > +\n> > +    cpu = POWERPC_CPU(first_cpu);\n> > +    pcc = POWERPC_CPU_GET_CLASS(cpu);\n> >  \n> >      info->d_machine = PPC_ELF_MACHINE;\n> >      info->d_class = ELFCLASS;\n> \n> -- \n> David Gibson\t\t\t| I'll have my music baroque, and my code\n> david AT gibson.dropbear.id.au\t| minimalist, thank you.  NOT _the_ _other_\n> \t\t\t\t| _way_ _around_!\n> http://www.ozlabs.org/~dgibson\n\n\n--\nDr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=dgilbert@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xshGf4lywz9s76\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Sep 2017 22:45:46 +1000 (AEST)","from localhost ([::1]:42293 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1ds732-0005my-Op\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 08:45:44 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:49525)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <dgilbert@redhat.com>) id 1ds72Z-0005lm-RB\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 08:45:19 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <dgilbert@redhat.com>) id 1ds72T-0000QQ-Vv\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 08:45:15 -0400","from mx1.redhat.com ([209.132.183.28]:47072)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <dgilbert@redhat.com>)\n\tid 1ds72O-0000Hv-A1; Wed, 13 Sep 2017 08:45:04 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 471BE81DE4;\n\tWed, 13 Sep 2017 12:45:03 +0000 (UTC)","from work-vm (ovpn-117-158.ams2.redhat.com [10.36.117.158])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 06BE55C6D2;\n\tWed, 13 Sep 2017 12:44:59 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 471BE81DE4","Date":"Wed, 13 Sep 2017 13:44:57 +0100","From":"\"Dr. David Alan Gilbert\" <dgilbert@redhat.com>","To":"David Gibson <david@gibson.dropbear.id.au>","Message-ID":"<20170913124456.GB2096@work-vm>","References":"<20170912140149.7692-1-lvivier@redhat.com>\n\t<20170912140149.7692-2-lvivier@redhat.com>\n\t<20170913053533.GF7550@umbus.fritz.box>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170913053533.GF7550@umbus.fritz.box>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tWed, 13 Sep 2017 12:45:03 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v3 1/3] hmp: fix \"dump-quest-memory\"\n\tsegfault (ppc)","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Laurent Vivier <lvivier@redhat.com>,\n\tPeter Maydell <peter.maydell@linaro.org>,\n\tThomas Huth <thuth@redhat.com>, \n\tCornelia Huck <cohuck@redhat.com>, qemu-devel@nongnu.org,\n\tGreg Kurz <groug@kaod.org>, qemu-arm@nongnu.org, qemu-ppc@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1767859,"web_url":"http://patchwork.ozlabs.org/comment/1767859/","msgid":"<20170913144825.48cad531.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-13T12:48:25","subject":"Re: [Qemu-devel] [PATCH v3 1/3] hmp: fix \"dump-quest-memory\"\n\tsegfault (ppc)","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Wed, 13 Sep 2017 13:44:57 +0100\n\"Dr. David Alan Gilbert\" <dgilbert@redhat.com> wrote:\n\n> * David Gibson (david@gibson.dropbear.id.au) wrote:\n> > On Tue, Sep 12, 2017 at 04:01:47PM +0200, Laurent Vivier wrote:  \n> > > Running QEMU with\n> > >     qemu-system-ppc64 -M none -nographic -m 256\n> > > and executing\n> > >     dump-guest-memory /dev/null 0 8192\n> > > results in segfault\n> > > \n> > > Fix by checking if we have CPU, and exit with\n> > > error if there is no CPU:\n> > > \n> > >     (qemu) dump-guest-memory /dev/null\n> > >     this feature or command is not currently supported\n> > > \n> > > Signed-off-by: Laurent Vivier <lvivier@redhat.com>  \n> > \n> > Applied to ppc-for-2.11.  I'm not really sure what to do with the rest\n> > of the series though.  \n> \n> I can take the whole set through HMP.\n\nIf you do so, you should probably take \"dump: do not dump non-existent\nguest memory\" as well.","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xshN371y7z9sNr\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Sep 2017 22:50:27 +1000 (AEST)","from localhost ([::1]:42306 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1ds77a-0008UO-3w\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 08:50:26 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:51737)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <cohuck@redhat.com>) id 1ds75q-00078t-5M\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 08:48:39 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <cohuck@redhat.com>) id 1ds75p-0004C1-7d\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 08:48:38 -0400","from mx1.redhat.com ([209.132.183.28]:42788)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <cohuck@redhat.com>)\n\tid 1ds75i-00042d-7U; Wed, 13 Sep 2017 08:48:30 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 303025F7A6;\n\tWed, 13 Sep 2017 12:48:29 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 8B6EE6179F;\n\tWed, 13 Sep 2017 12:48:27 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 303025F7A6","Date":"Wed, 13 Sep 2017 14:48:25 +0200","From":"Cornelia Huck <cohuck@redhat.com>","To":"\"Dr. David Alan Gilbert\" <dgilbert@redhat.com>","Message-ID":"<20170913144825.48cad531.cohuck@redhat.com>","In-Reply-To":"<20170913124456.GB2096@work-vm>","References":"<20170912140149.7692-1-lvivier@redhat.com>\n\t<20170912140149.7692-2-lvivier@redhat.com>\n\t<20170913053533.GF7550@umbus.fritz.box>\n\t<20170913124456.GB2096@work-vm>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tWed, 13 Sep 2017 12:48:29 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v3 1/3] hmp: fix \"dump-quest-memory\"\n\tsegfault (ppc)","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Laurent Vivier <lvivier@redhat.com>,\n\tPeter Maydell <peter.maydell@linaro.org>,\n\tThomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org,\n\tGreg Kurz <groug@kaod.org>, qemu-arm@nongnu.org,\n\tqemu-ppc@nongnu.org, David Gibson <david@gibson.dropbear.id.au>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1767860,"web_url":"http://patchwork.ozlabs.org/comment/1767860/","msgid":"<770fc286-a566-920a-9aba-16c3b5264806@redhat.com>","list_archive_url":null,"date":"2017-09-13T12:49:52","subject":"Re: [Qemu-devel] [PATCH v3 1/3] hmp: fix \"dump-quest-memory\"\n\tsegfault (ppc)","submitter":{"id":66421,"url":"http://patchwork.ozlabs.org/api/people/66421/","name":"Laurent Vivier","email":"lvivier@redhat.com"},"content":"On 13/09/2017 14:44, Dr. David Alan Gilbert wrote:\n> * David Gibson (david@gibson.dropbear.id.au) wrote:\n>> On Tue, Sep 12, 2017 at 04:01:47PM +0200, Laurent Vivier wrote:\n>>> Running QEMU with\n>>>     qemu-system-ppc64 -M none -nographic -m 256\n>>> and executing\n>>>     dump-guest-memory /dev/null 0 8192\n>>> results in segfault\n>>>\n>>> Fix by checking if we have CPU, and exit with\n>>> error if there is no CPU:\n>>>\n>>>     (qemu) dump-guest-memory /dev/null\n>>>     this feature or command is not currently supported\n>>>\n>>> Signed-off-by: Laurent Vivier <lvivier@redhat.com>\n>>\n>> Applied to ppc-for-2.11.  I'm not really sure what to do with the rest\n>> of the series though.\n> \n> I can take the whole set through HMP.\n\nCould you update the comment in last patch as asked by Cornelia?\n(PATCH v3 3/3] tests/hmp: test \"none\" machine with memory)\n\nThanks,\nLaurent\n\n> \n> Dave\n> \n>>> ---\n>>>  target/ppc/arch_dump.c | 11 +++++++++--\n>>>  1 file changed, 9 insertions(+), 2 deletions(-)\n>>>\n>>> diff --git a/target/ppc/arch_dump.c b/target/ppc/arch_dump.c\n>>> index 8e9397aa58..95b9ab6f29 100644\n>>> --- a/target/ppc/arch_dump.c\n>>> +++ b/target/ppc/arch_dump.c\n>>> @@ -224,8 +224,15 @@ typedef struct NoteFuncDescStruct NoteFuncDesc;\n>>>  int cpu_get_dump_info(ArchDumpInfo *info,\n>>>                        const struct GuestPhysBlockList *guest_phys_blocks)\n>>>  {\n>>> -    PowerPCCPU *cpu = POWERPC_CPU(first_cpu);\n>>> -    PowerPCCPUClass *pcc = POWERPC_CPU_GET_CLASS(cpu);\n>>> +    PowerPCCPU *cpu;\n>>> +    PowerPCCPUClass *pcc;\n>>> +\n>>> +    if (first_cpu == NULL) {\n>>> +        return -1;\n>>> +    }\n>>> +\n>>> +    cpu = POWERPC_CPU(first_cpu);\n>>> +    pcc = POWERPC_CPU_GET_CLASS(cpu);\n>>>  \n>>>      info->d_machine = PPC_ELF_MACHINE;\n>>>      info->d_class = ELFCLASS;\n>>\n>> -- \n>> David Gibson\t\t\t| I'll have my music baroque, and my code\n>> david AT gibson.dropbear.id.au\t| minimalist, thank you.  NOT _the_ _other_\n>> \t\t\t\t| _way_ _around_!\n>> http://www.ozlabs.org/~dgibson\n> \n> \n> --\n> Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK\n>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=lvivier@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xshPq4WBDz9sNr\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Sep 2017 22:51:59 +1000 (AEST)","from localhost ([::1]:42324 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1ds793-0001Wf-P4\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 08:51:57 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:52576)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <lvivier@redhat.com>) id 1ds77E-0008Vw-5R\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 08:50:08 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <lvivier@redhat.com>) id 1ds77D-0006AL-0D\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 08:50:04 -0400","from mx1.redhat.com ([209.132.183.28]:53508)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <lvivier@redhat.com>)\n\tid 1ds777-00062X-8C; Wed, 13 Sep 2017 08:49:57 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 776BB5D4;\n\tWed, 13 Sep 2017 12:49:55 +0000 (UTC)","from [10.36.116.239] (ovpn-116-239.ams2.redhat.com [10.36.116.239])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 4520160C53;\n\tWed, 13 Sep 2017 12:49:53 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 776BB5D4","To":"\"Dr. David Alan Gilbert\" <dgilbert@redhat.com>,\n\tDavid Gibson <david@gibson.dropbear.id.au>","References":"<20170912140149.7692-1-lvivier@redhat.com>\n\t<20170912140149.7692-2-lvivier@redhat.com>\n\t<20170913053533.GF7550@umbus.fritz.box>\n\t<20170913124456.GB2096@work-vm>","From":"Laurent Vivier <lvivier@redhat.com>","Message-ID":"<770fc286-a566-920a-9aba-16c3b5264806@redhat.com>","Date":"Wed, 13 Sep 2017 14:49:52 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170913124456.GB2096@work-vm>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tWed, 13 Sep 2017 12:49:55 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v3 1/3] hmp: fix \"dump-quest-memory\"\n\tsegfault (ppc)","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Peter Maydell <peter.maydell@linaro.org>, Thomas Huth <thuth@redhat.com>,\n\tCornelia Huck <cohuck@redhat.com>, qemu-devel@nongnu.org,\n\tGreg Kurz <groug@kaod.org>, qemu-arm@nongnu.org, qemu-ppc@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1767863,"web_url":"http://patchwork.ozlabs.org/comment/1767863/","msgid":"<20170913125404.GE3972@umbus.fritz.box>","list_archive_url":null,"date":"2017-09-13T12:54:04","subject":"Re: [Qemu-devel] [PATCH v3 1/3] hmp: fix \"dump-quest-memory\"\n\tsegfault (ppc)","submitter":{"id":47,"url":"http://patchwork.ozlabs.org/api/people/47/","name":"David Gibson","email":"david@gibson.dropbear.id.au"},"content":"On Wed, Sep 13, 2017 at 01:44:57PM +0100, Dr. David Alan Gilbert wrote:\n> * David Gibson (david@gibson.dropbear.id.au) wrote:\n> > On Tue, Sep 12, 2017 at 04:01:47PM +0200, Laurent Vivier wrote:\n> > > Running QEMU with\n> > >     qemu-system-ppc64 -M none -nographic -m 256\n> > > and executing\n> > >     dump-guest-memory /dev/null 0 8192\n> > > results in segfault\n> > > \n> > > Fix by checking if we have CPU, and exit with\n> > > error if there is no CPU:\n> > > \n> > >     (qemu) dump-guest-memory /dev/null\n> > >     this feature or command is not currently supported\n> > > \n> > > Signed-off-by: Laurent Vivier <lvivier@redhat.com>\n> > \n> > Applied to ppc-for-2.11.  I'm not really sure what to do with the rest\n> > of the series though.\n> \n> I can take the whole set through HMP.\n\nGreat, thanks.\n\n> \n> Dave\n> \n> > > ---\n> > >  target/ppc/arch_dump.c | 11 +++++++++--\n> > >  1 file changed, 9 insertions(+), 2 deletions(-)\n> > > \n> > > diff --git a/target/ppc/arch_dump.c b/target/ppc/arch_dump.c\n> > > index 8e9397aa58..95b9ab6f29 100644\n> > > --- a/target/ppc/arch_dump.c\n> > > +++ b/target/ppc/arch_dump.c\n> > > @@ -224,8 +224,15 @@ typedef struct NoteFuncDescStruct NoteFuncDesc;\n> > >  int cpu_get_dump_info(ArchDumpInfo *info,\n> > >                        const struct GuestPhysBlockList *guest_phys_blocks)\n> > >  {\n> > > -    PowerPCCPU *cpu = POWERPC_CPU(first_cpu);\n> > > -    PowerPCCPUClass *pcc = POWERPC_CPU_GET_CLASS(cpu);\n> > > +    PowerPCCPU *cpu;\n> > > +    PowerPCCPUClass *pcc;\n> > > +\n> > > +    if (first_cpu == NULL) {\n> > > +        return -1;\n> > > +    }\n> > > +\n> > > +    cpu = POWERPC_CPU(first_cpu);\n> > > +    pcc = POWERPC_CPU_GET_CLASS(cpu);\n> > >  \n> > >      info->d_machine = PPC_ELF_MACHINE;\n> > >      info->d_class = ELFCLASS;\n> > \n> \n>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=gibson.dropbear.id.au\n\theader.i=@gibson.dropbear.id.au header.b=\"oUl4oGep\"; \n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xshWJ0Krzz9sNr\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Sep 2017 22:56:44 +1000 (AEST)","from localhost ([::1]:42344 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1ds7De-0006Xg-5p\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 08:56:42 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:55529)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <dgibson@ozlabs.org>) id 1ds7BY-0003hL-VD\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 08:54:34 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <dgibson@ozlabs.org>) id 1ds7BY-0003rx-1d\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 08:54:33 -0400","from ozlabs.org ([103.22.144.67]:54361)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <dgibson@ozlabs.org>)\n\tid 1ds7BS-0003jQ-7D; Wed, 13 Sep 2017 08:54:26 -0400","by ozlabs.org (Postfix, from userid 1007)\n\tid 3xshSb1Smpz9sNr; Wed, 13 Sep 2017 22:54:23 +1000 (AEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n\td=gibson.dropbear.id.au; s=201602; t=1505307263;\n\tbh=5nnesn5c52zszyYAu2HRH6+ikLQJK8yMQbKTeWos8WU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=oUl4oGepxXkk+IFTWdAtg0uY+tfKfK1ahkyAD5MhLmVEgatZbnJROFiQzyy/mXnVj\n\t+FsC9pj+hXe31oAdx091zi4UADhSNTR8KFtdG1LdtWXPt5233zm2bPwDFSBQGOUg/X\n\tsj65AIIU29nRunyhvhAAg0eepp0JUffOKf20rn+A=","Date":"Wed, 13 Sep 2017 22:54:04 +1000","From":"David Gibson <david@gibson.dropbear.id.au>","To":"\"Dr. David Alan Gilbert\" <dgilbert@redhat.com>","Message-ID":"<20170913125404.GE3972@umbus.fritz.box>","References":"<20170912140149.7692-1-lvivier@redhat.com>\n\t<20170912140149.7692-2-lvivier@redhat.com>\n\t<20170913053533.GF7550@umbus.fritz.box>\n\t<20170913124456.GB2096@work-vm>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"gDGSpKKIBgtShtf+\"","Content-Disposition":"inline","In-Reply-To":"<20170913124456.GB2096@work-vm>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"103.22.144.67","Subject":"Re: [Qemu-devel] [PATCH v3 1/3] hmp: fix \"dump-quest-memory\"\n\tsegfault (ppc)","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Laurent Vivier <lvivier@redhat.com>,\n\tPeter Maydell <peter.maydell@linaro.org>,\n\tThomas Huth <thuth@redhat.com>, \n\tCornelia Huck <cohuck@redhat.com>, qemu-devel@nongnu.org,\n\tGreg Kurz <groug@kaod.org>, qemu-arm@nongnu.org, qemu-ppc@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1767877,"web_url":"http://patchwork.ozlabs.org/comment/1767877/","msgid":"<20170913131948.GD2096@work-vm>","list_archive_url":null,"date":"2017-09-13T13:19:48","subject":"Re: [Qemu-devel] [PATCH v3 1/3] hmp: fix \"dump-quest-memory\"\n\tsegfault (ppc)","submitter":{"id":48102,"url":"http://patchwork.ozlabs.org/api/people/48102/","name":"Dr. David Alan Gilbert","email":"dgilbert@redhat.com"},"content":"* Laurent Vivier (lvivier@redhat.com) wrote:\n> On 13/09/2017 14:44, Dr. David Alan Gilbert wrote:\n> > * David Gibson (david@gibson.dropbear.id.au) wrote:\n> >> On Tue, Sep 12, 2017 at 04:01:47PM +0200, Laurent Vivier wrote:\n> >>> Running QEMU with\n> >>>     qemu-system-ppc64 -M none -nographic -m 256\n> >>> and executing\n> >>>     dump-guest-memory /dev/null 0 8192\n> >>> results in segfault\n> >>>\n> >>> Fix by checking if we have CPU, and exit with\n> >>> error if there is no CPU:\n> >>>\n> >>>     (qemu) dump-guest-memory /dev/null\n> >>>     this feature or command is not currently supported\n> >>>\n> >>> Signed-off-by: Laurent Vivier <lvivier@redhat.com>\n> >>\n> >> Applied to ppc-for-2.11.  I'm not really sure what to do with the rest\n> >> of the series though.\n> > \n> > I can take the whole set through HMP.\n> \n> Could you update the comment in last patch as asked by Cornelia?\n> (PATCH v3 3/3] tests/hmp: test \"none\" machine with memory)\n\nSure, do we understand what the error that patchew caught was?\n\nDave\n\n> Thanks,\n> Laurent\n> \n> > \n> > Dave\n> > \n> >>> ---\n> >>>  target/ppc/arch_dump.c | 11 +++++++++--\n> >>>  1 file changed, 9 insertions(+), 2 deletions(-)\n> >>>\n> >>> diff --git a/target/ppc/arch_dump.c b/target/ppc/arch_dump.c\n> >>> index 8e9397aa58..95b9ab6f29 100644\n> >>> --- a/target/ppc/arch_dump.c\n> >>> +++ b/target/ppc/arch_dump.c\n> >>> @@ -224,8 +224,15 @@ typedef struct NoteFuncDescStruct NoteFuncDesc;\n> >>>  int cpu_get_dump_info(ArchDumpInfo *info,\n> >>>                        const struct GuestPhysBlockList *guest_phys_blocks)\n> >>>  {\n> >>> -    PowerPCCPU *cpu = POWERPC_CPU(first_cpu);\n> >>> -    PowerPCCPUClass *pcc = POWERPC_CPU_GET_CLASS(cpu);\n> >>> +    PowerPCCPU *cpu;\n> >>> +    PowerPCCPUClass *pcc;\n> >>> +\n> >>> +    if (first_cpu == NULL) {\n> >>> +        return -1;\n> >>> +    }\n> >>> +\n> >>> +    cpu = POWERPC_CPU(first_cpu);\n> >>> +    pcc = POWERPC_CPU_GET_CLASS(cpu);\n> >>>  \n> >>>      info->d_machine = PPC_ELF_MACHINE;\n> >>>      info->d_class = ELFCLASS;\n> >>\n> >> -- \n> >> David Gibson\t\t\t| I'll have my music baroque, and my code\n> >> david AT gibson.dropbear.id.au\t| minimalist, thank you.  NOT _the_ _other_\n> >> \t\t\t\t| _way_ _around_!\n> >> http://www.ozlabs.org/~dgibson\n> > \n> > \n> > --\n> > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK\n> > \n> \n--\nDr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=dgilbert@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsj2w5C8Wz9sMN\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Sep 2017 23:20:39 +1000 (AEST)","from localhost ([::1]:42499 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1ds7al-0001MT-Lt\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 09:20:35 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:37257)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <dgilbert@redhat.com>) id 1ds7aG-0001CK-Jy\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 09:20:10 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <dgilbert@redhat.com>) id 1ds7aB-0007CV-I3\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 09:20:04 -0400","from mx1.redhat.com ([209.132.183.28]:59408)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <dgilbert@redhat.com>)\n\tid 1ds7a6-000784-VL; Wed, 13 Sep 2017 09:19:55 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id B1C4E356F3;\n\tWed, 13 Sep 2017 13:19:53 +0000 (UTC)","from work-vm (ovpn-117-158.ams2.redhat.com [10.36.117.158])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 800265D966;\n\tWed, 13 Sep 2017 13:19:50 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com B1C4E356F3","Date":"Wed, 13 Sep 2017 14:19:48 +0100","From":"\"Dr. David Alan Gilbert\" <dgilbert@redhat.com>","To":"Laurent Vivier <lvivier@redhat.com>","Message-ID":"<20170913131948.GD2096@work-vm>","References":"<20170912140149.7692-1-lvivier@redhat.com>\n\t<20170912140149.7692-2-lvivier@redhat.com>\n\t<20170913053533.GF7550@umbus.fritz.box>\n\t<20170913124456.GB2096@work-vm>\n\t<770fc286-a566-920a-9aba-16c3b5264806@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<770fc286-a566-920a-9aba-16c3b5264806@redhat.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tWed, 13 Sep 2017 13:19:54 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v3 1/3] hmp: fix \"dump-quest-memory\"\n\tsegfault (ppc)","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Peter Maydell <peter.maydell@linaro.org>, Thomas Huth <thuth@redhat.com>,\n\tCornelia Huck <cohuck@redhat.com>, qemu-devel@nongnu.org,\n\tGreg Kurz <groug@kaod.org>, qemu-arm@nongnu.org,\n\tqemu-ppc@nongnu.org, David Gibson <david@gibson.dropbear.id.au>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1767879,"web_url":"http://patchwork.ozlabs.org/comment/1767879/","msgid":"<5accd02c-f116-22ef-99ef-1ddd9e58fc21@redhat.com>","list_archive_url":null,"date":"2017-09-13T13:23:32","subject":"Re: [Qemu-devel] [PATCH v3 1/3] hmp: fix \"dump-quest-memory\"\n\tsegfault (ppc)","submitter":{"id":66421,"url":"http://patchwork.ozlabs.org/api/people/66421/","name":"Laurent Vivier","email":"lvivier@redhat.com"},"content":"On 13/09/2017 15:19, Dr. David Alan Gilbert wrote:\n> * Laurent Vivier (lvivier@redhat.com) wrote:\n>> On 13/09/2017 14:44, Dr. David Alan Gilbert wrote:\n>>> * David Gibson (david@gibson.dropbear.id.au) wrote:\n>>>> On Tue, Sep 12, 2017 at 04:01:47PM +0200, Laurent Vivier wrote:\n>>>>> Running QEMU with\n>>>>>     qemu-system-ppc64 -M none -nographic -m 256\n>>>>> and executing\n>>>>>     dump-guest-memory /dev/null 0 8192\n>>>>> results in segfault\n>>>>>\n>>>>> Fix by checking if we have CPU, and exit with\n>>>>> error if there is no CPU:\n>>>>>\n>>>>>     (qemu) dump-guest-memory /dev/null\n>>>>>     this feature or command is not currently supported\n>>>>>\n>>>>> Signed-off-by: Laurent Vivier <lvivier@redhat.com>\n>>>>\n>>>> Applied to ppc-for-2.11.  I'm not really sure what to do with the rest\n>>>> of the series though.\n>>>\n>>> I can take the whole set through HMP.\n>>\n>> Could you update the comment in last patch as asked by Cornelia?\n>> (PATCH v3 3/3] tests/hmp: test \"none\" machine with memory)\n> \n> Sure, do we understand what the error that patchew caught was?\n\nWe need the fix from Cornelia, otherwise the new test fails.\n\nDo you want I resend the series including the fix from Cornelia to be\nsure patchew works?\n\nThanks,\nLaurent","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=lvivier@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsj8N0l0Zz9sNr\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Sep 2017 23:25:24 +1000 (AEST)","from localhost ([::1]:42516 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1ds7fO-0004MA-4R\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 09:25:22 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:38409)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <lvivier@redhat.com>) id 1ds7dl-0003UU-Fh\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 09:23:42 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <lvivier@redhat.com>) id 1ds7dk-0001e2-Gj\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 09:23:41 -0400","from mx1.redhat.com ([209.132.183.28]:33402)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <lvivier@redhat.com>)\n\tid 1ds7dg-0001c3-NS; Wed, 13 Sep 2017 09:23:36 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 9CC2B4E341;\n\tWed, 13 Sep 2017 13:23:35 +0000 (UTC)","from [10.36.116.239] (ovpn-116-239.ams2.redhat.com [10.36.116.239])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 737855C545;\n\tWed, 13 Sep 2017 13:23:33 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 9CC2B4E341","To":"\"Dr. David Alan Gilbert\" <dgilbert@redhat.com>","References":"<20170912140149.7692-1-lvivier@redhat.com>\n\t<20170912140149.7692-2-lvivier@redhat.com>\n\t<20170913053533.GF7550@umbus.fritz.box>\n\t<20170913124456.GB2096@work-vm>\n\t<770fc286-a566-920a-9aba-16c3b5264806@redhat.com>\n\t<20170913131948.GD2096@work-vm>","From":"Laurent Vivier <lvivier@redhat.com>","Message-ID":"<5accd02c-f116-22ef-99ef-1ddd9e58fc21@redhat.com>","Date":"Wed, 13 Sep 2017 15:23:32 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170913131948.GD2096@work-vm>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tWed, 13 Sep 2017 13:23:35 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v3 1/3] hmp: fix \"dump-quest-memory\"\n\tsegfault (ppc)","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Peter Maydell <peter.maydell@linaro.org>, Thomas Huth <thuth@redhat.com>,\n\tCornelia Huck <cohuck@redhat.com>, qemu-devel@nongnu.org,\n\tGreg Kurz <groug@kaod.org>, qemu-arm@nongnu.org,\n\tqemu-ppc@nongnu.org, David Gibson <david@gibson.dropbear.id.au>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1767895,"web_url":"http://patchwork.ozlabs.org/comment/1767895/","msgid":"<20170913134050.GE2096@work-vm>","list_archive_url":null,"date":"2017-09-13T13:40:50","subject":"Re: [Qemu-devel] [PATCH v3 1/3] hmp: fix \"dump-quest-memory\"\n\tsegfault (ppc)","submitter":{"id":48102,"url":"http://patchwork.ozlabs.org/api/people/48102/","name":"Dr. David Alan Gilbert","email":"dgilbert@redhat.com"},"content":"* Laurent Vivier (lvivier@redhat.com) wrote:\n> On 13/09/2017 15:19, Dr. David Alan Gilbert wrote:\n> > * Laurent Vivier (lvivier@redhat.com) wrote:\n> >> On 13/09/2017 14:44, Dr. David Alan Gilbert wrote:\n> >>> * David Gibson (david@gibson.dropbear.id.au) wrote:\n> >>>> On Tue, Sep 12, 2017 at 04:01:47PM +0200, Laurent Vivier wrote:\n> >>>>> Running QEMU with\n> >>>>>     qemu-system-ppc64 -M none -nographic -m 256\n> >>>>> and executing\n> >>>>>     dump-guest-memory /dev/null 0 8192\n> >>>>> results in segfault\n> >>>>>\n> >>>>> Fix by checking if we have CPU, and exit with\n> >>>>> error if there is no CPU:\n> >>>>>\n> >>>>>     (qemu) dump-guest-memory /dev/null\n> >>>>>     this feature or command is not currently supported\n> >>>>>\n> >>>>> Signed-off-by: Laurent Vivier <lvivier@redhat.com>\n> >>>>\n> >>>> Applied to ppc-for-2.11.  I'm not really sure what to do with the rest\n> >>>> of the series though.\n> >>>\n> >>> I can take the whole set through HMP.\n> >>\n> >> Could you update the comment in last patch as asked by Cornelia?\n> >> (PATCH v3 3/3] tests/hmp: test \"none\" machine with memory)\n> > \n> > Sure, do we understand what the error that patchew caught was?\n> \n> We need the fix from Cornelia, otherwise the new test fails.\n> \n> Do you want I resend the series including the fix from Cornelia to be\n> sure patchew works?\n\nYes, that's best because I think you're saying we need to put\nCornelia's fix in before your 3/3 to ensure it's bisectable.\n\nDave\n\n> Thanks,\n> Laurent\n--\nDr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=dgilbert@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsjWH05PGz9s78\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Sep 2017 23:41:46 +1000 (AEST)","from localhost ([::1]:42597 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1ds7vD-0005V9-NV\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 09:41:43 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:45885)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <dgilbert@redhat.com>) id 1ds7ub-0005QX-ID\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 09:41:08 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <dgilbert@redhat.com>) id 1ds7uX-0008Be-Kr\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 09:41:05 -0400","from mx1.redhat.com ([209.132.183.28]:21531)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <dgilbert@redhat.com>)\n\tid 1ds7uS-000873-7I; Wed, 13 Sep 2017 09:40:56 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 3D655883A0;\n\tWed, 13 Sep 2017 13:40:55 +0000 (UTC)","from work-vm (ovpn-117-158.ams2.redhat.com [10.36.117.158])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 0C0B36C509;\n\tWed, 13 Sep 2017 13:40:52 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 3D655883A0","Date":"Wed, 13 Sep 2017 14:40:50 +0100","From":"\"Dr. David Alan Gilbert\" <dgilbert@redhat.com>","To":"Laurent Vivier <lvivier@redhat.com>","Message-ID":"<20170913134050.GE2096@work-vm>","References":"<20170912140149.7692-1-lvivier@redhat.com>\n\t<20170912140149.7692-2-lvivier@redhat.com>\n\t<20170913053533.GF7550@umbus.fritz.box>\n\t<20170913124456.GB2096@work-vm>\n\t<770fc286-a566-920a-9aba-16c3b5264806@redhat.com>\n\t<20170913131948.GD2096@work-vm>\n\t<5accd02c-f116-22ef-99ef-1ddd9e58fc21@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<5accd02c-f116-22ef-99ef-1ddd9e58fc21@redhat.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tWed, 13 Sep 2017 13:40:55 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v3 1/3] hmp: fix \"dump-quest-memory\"\n\tsegfault (ppc)","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Peter Maydell <peter.maydell@linaro.org>, Thomas Huth <thuth@redhat.com>,\n\tCornelia Huck <cohuck@redhat.com>, qemu-devel@nongnu.org,\n\tGreg Kurz <groug@kaod.org>, qemu-arm@nongnu.org,\n\tqemu-ppc@nongnu.org, David Gibson <david@gibson.dropbear.id.au>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}}]