Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/812430/?format=api
{ "id": 812430, "url": "http://patchwork.ozlabs.org/api/patches/812430/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170911152150.12535-15-david@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170911152150.12535-15-david@redhat.com>", "list_archive_url": null, "date": "2017-09-11T15:21:43", "name": "[v4,14/21] target/s390x: rename next_cpu_id to next_core_id", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "09be341b5b929e7d3cc0a05e98e59bd3d42d2cbe", "submitter": { "id": 70402, "url": "http://patchwork.ozlabs.org/api/people/70402/?format=api", "name": "David Hildenbrand", "email": "david@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170911152150.12535-15-david@redhat.com/mbox/", "series": [ { "id": 2516, "url": "http://patchwork.ozlabs.org/api/series/2516/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2516", "date": "2017-09-11T15:21:29", "name": "s390x cleanups and CPU hotplug via device_add", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/2516/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/812430/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/812430/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrXBp6Gsjz9s7B\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 12 Sep 2017 01:38:26 +1000 (AEST)", "from localhost ([::1]:58475 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1drQn3-00012g-03\n\tfor incoming@patchwork.ozlabs.org; Mon, 11 Sep 2017 11:38:25 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:49346)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <david@redhat.com>) id 1drQYB-0004nD-C0\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 11:23:04 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <david@redhat.com>) id 1drQYA-00021u-22\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 11:23:03 -0400", "from mx1.redhat.com ([209.132.183.28]:25220)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <david@redhat.com>) id 1drQY9-0001ze-Rg\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 11:23:01 -0400", "from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 016D1EEF26;\n\tMon, 11 Sep 2017 15:23:01 +0000 (UTC)", "from t460s.redhat.com (ovpn-116-48.ams2.redhat.com [10.36.116.48])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 46E496B273;\n\tMon, 11 Sep 2017 15:22:55 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com 016D1EEF26", "From": "David Hildenbrand <david@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Mon, 11 Sep 2017 17:21:43 +0200", "Message-Id": "<20170911152150.12535-15-david@redhat.com>", "In-Reply-To": "<20170911152150.12535-1-david@redhat.com>", "References": "<20170911152150.12535-1-david@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.15", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tMon, 11 Sep 2017 15:23:01 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH v4 14/21] target/s390x: rename next_cpu_id to\n\tnext_core_id", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Matthew Rosato <mjrosato@linux.vnet.ibm.com>, thuth@redhat.com,\n\tEduardo Habkost <ehabkost@redhat.com>, david@redhat.com,\n\tcohuck@redhat.com, Richard Henderson <richard.henderson@linaro.org>,\n\tAlexander Graf <agraf@suse.de>,\n\tMarkus Armbruster <armbru@redhat.com>, borntraeger@de.ibm.com,\n\tPaolo Bonzini <pbonzini@redhat.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Adapt to the new term \"core_id\". While at it, fix the type and drop the\ninitialization to 0 (which is superfluous).\n\nReviewed-by: Matthew Rosato <mjrosato@linux.vnet.ibm.com>\nSigned-off-by: David Hildenbrand <david@redhat.com>\n---\n target/s390x/cpu-qom.h | 2 +-\n target/s390x/cpu.c | 11 +++++------\n 2 files changed, 6 insertions(+), 7 deletions(-)", "diff": "diff --git a/target/s390x/cpu-qom.h b/target/s390x/cpu-qom.h\nindex 2435cd8390..2e446fab51 100644\n--- a/target/s390x/cpu-qom.h\n+++ b/target/s390x/cpu-qom.h\n@@ -54,7 +54,7 @@ typedef struct S390CPUClass {\n bool is_migration_safe;\n const char *desc;\n \n- int64_t next_cpu_id;\n+ uint32_t next_core_id;\n \n DeviceRealize parent_realize;\n void (*parent_reset)(CPUState *cpu);\ndiff --git a/target/s390x/cpu.c b/target/s390x/cpu.c\nindex 87ebbe5b28..8c1c644057 100644\n--- a/target/s390x/cpu.c\n+++ b/target/s390x/cpu.c\n@@ -198,7 +198,7 @@ static void s390_cpu_realizefn(DeviceState *dev, Error **errp)\n }\n #else\n /* implicitly set for linux-user only */\n- cpu->env.core_id = scc->next_cpu_id;\n+ cpu->env.core_id = scc->next_core_id;\n #endif\n \n if (cpu_exists(cpu->env.core_id)) {\n@@ -206,10 +206,10 @@ static void s390_cpu_realizefn(DeviceState *dev, Error **errp)\n \", it already exists\", cpu->env.core_id);\n goto out;\n }\n- if (cpu->env.core_id != scc->next_cpu_id) {\n+ if (cpu->env.core_id != scc->next_core_id) {\n error_setg(&err, \"Unable to add CPU with core-id: %\" PRIu32\n- \", the next available core-id is %\" PRIi64, cpu->env.core_id,\n- scc->next_cpu_id);\n+ \", the next available core-id is %\" PRIu32, cpu->env.core_id,\n+ scc->next_core_id);\n goto out;\n }\n \n@@ -219,7 +219,7 @@ static void s390_cpu_realizefn(DeviceState *dev, Error **errp)\n if (err != NULL) {\n goto out;\n }\n- scc->next_cpu_id++;\n+ scc->next_core_id++;\n \n #if !defined(CONFIG_USER_ONLY)\n qemu_register_reset(s390_cpu_machine_reset_cb, cpu);\n@@ -464,7 +464,6 @@ static void s390_cpu_class_init(ObjectClass *oc, void *data)\n CPUClass *cc = CPU_CLASS(scc);\n DeviceClass *dc = DEVICE_CLASS(oc);\n \n- scc->next_cpu_id = 0;\n scc->parent_realize = dc->realize;\n dc->realize = s390_cpu_realizefn;\n dc->props = s390x_cpu_properties;\n", "prefixes": [ "v4", "14/21" ] }