[{"id":1767021,"web_url":"http://patchwork.ozlabs.org/comment/1767021/","msgid":"<20170912150947.70cf9b71@nial.brq.redhat.com>","list_archive_url":null,"date":"2017-09-12T13:09:47","subject":"Re: [Qemu-devel] [PATCH v4 14/21] target/s390x: rename next_cpu_id\n\tto next_core_id","submitter":{"id":11305,"url":"http://patchwork.ozlabs.org/api/people/11305/","name":"Igor Mammedov","email":"imammedo@redhat.com"},"content":"On Mon, 11 Sep 2017 17:21:43 +0200\nDavid Hildenbrand wrote:\n\n> Adapt to the new term \"core_id\". While at it, fix the type and drop the\n> initialization to 0 (which is superfluous).\n> \n> Reviewed-by: Matthew Rosato \n> Signed-off-by: David Hildenbrand \n> ---\n> target/s390x/cpu-qom.h | 2 +-\n> target/s390x/cpu.c | 11 +++++------\n> 2 files changed, 6 insertions(+), 7 deletions(-)\n> \n> diff --git a/target/s390x/cpu-qom.h b/target/s390x/cpu-qom.h\n> index 2435cd8390..2e446fab51 100644\n> --- a/target/s390x/cpu-qom.h\n> +++ b/target/s390x/cpu-qom.h\n> @@ -54,7 +54,7 @@ typedef struct S390CPUClass {\n> bool is_migration_safe;\n> const char *desc;\n> \n> - int64_t next_cpu_id;\n> + uint32_t next_core_id;\nis it possible to hotplug cpus in out of order in real hw?\n\n> \n> DeviceRealize parent_realize;\n> void (*parent_reset)(CPUState *cpu);\n> diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c\n> index 87ebbe5b28..8c1c644057 100644\n> --- a/target/s390x/cpu.c\n> +++ b/target/s390x/cpu.c\n> @@ -198,7 +198,7 @@ static void s390_cpu_realizefn(DeviceState *dev, Error **errp)\n> }\n> #else\n> /* implicitly set for linux-user only */\n> - cpu->env.core_id = scc->next_cpu_id;\n> + cpu->env.core_id = scc->next_core_id;\n> #endif\n> \n> if (cpu_exists(cpu->env.core_id)) {\n> @@ -206,10 +206,10 @@ static void s390_cpu_realizefn(DeviceState *dev, Error **errp)\n> \", it already exists\", cpu->env.core_id);\n> goto out;\n> }\n> - if (cpu->env.core_id != scc->next_cpu_id) {\n> + if (cpu->env.core_id != scc->next_core_id) {\n> error_setg(&err, \"Unable to add CPU with core-id: %\" PRIu32\n> - \", the next available core-id is %\" PRIi64, cpu->env.core_id,\n> - scc->next_cpu_id);\n> + \", the next available core-id is %\" PRIu32, cpu->env.core_id,\n> + scc->next_core_id);\n> goto out;\n> }\n> \n> @@ -219,7 +219,7 @@ static void s390_cpu_realizefn(DeviceState *dev, Error **errp)\n> if (err != NULL) {\n> goto out;\n> }\n> - scc->next_cpu_id++;\n> + scc->next_core_id++;\n> \n> #if !defined(CONFIG_USER_ONLY)\n> qemu_register_reset(s390_cpu_machine_reset_cb, cpu);\n> @@ -464,7 +464,6 @@ static void s390_cpu_class_init(ObjectClass *oc, void *data)\n> CPUClass *cc = CPU_CLASS(scc);\n> DeviceClass *dc = DEVICE_CLASS(oc);\n> \n> - scc->next_cpu_id = 0;\n> scc->parent_realize = dc->realize;\n> dc->realize = s390_cpu_realizefn;\n> dc->props = s390x_cpu_properties;","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=imammedo@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs4t73XZdz9s0g\n\tfor ;\n\tTue, 12 Sep 2017 23:10:55 +1000 (AEST)","from localhost ([::1]:35780 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drkxo-0001YT-AM\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 09:10:52 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:36688)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drkxT-0001YI-Nn\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 09:10:32 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drkxO-0004sQ-08\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 09:10:31 -0400","from mx1.redhat.com ([209.132.183.28]:34096)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1drkxN-0004s0-Nn\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 09:10:25 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id BCEA95F739;\n\tTue, 12 Sep 2017 13:10:24 +0000 (UTC)","from nial.brq.redhat.com (unknown [10.43.2.209])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 3DDDE77C10;\n\tTue, 12 Sep 2017 13:09:48 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com BCEA95F739","Date":"Tue, 12 Sep 2017 15:09:47 +0200","From":"Igor Mammedov ","To":"David Hildenbrand ","Message-ID":"<20170912150947.70cf9b71@nial.brq.redhat.com>","In-Reply-To":"<20170911152150.12535-15-david@redhat.com>","References":"<20170911152150.12535-1-david@redhat.com>\n\t<20170911152150.12535-15-david@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tTue, 12 Sep 2017 13:10:24 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v4 14/21] target/s390x: rename next_cpu_id\n\tto next_core_id","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato , thuth@redhat.com,\n\tEduardo Habkost ,\n\tMarkus Armbruster , cohuck@redhat.com,\n\tRichard Henderson ,\n\tqemu-devel@nongnu.org, Alexander Graf ,\n\tborntraeger@de.ibm.com, Paolo Bonzini ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1767027,"web_url":"http://patchwork.ozlabs.org/comment/1767027/","msgid":"<933e6e9a-aea1-1d8e-210c-e1837e414bdf@redhat.com>","list_archive_url":null,"date":"2017-09-12T13:16:15","subject":"Re: [Qemu-devel] [PATCH v4 14/21] target/s390x: rename next_cpu_id\n\tto next_core_id","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":"On 12.09.2017 15:09, Igor Mammedov wrote:\n> On Mon, 11 Sep 2017 17:21:43 +0200\n> David Hildenbrand wrote:\n> \n>> Adapt to the new term \"core_id\". While at it, fix the type and drop the\n>> initialization to 0 (which is superfluous).\n>>\n>> Reviewed-by: Matthew Rosato \n>> Signed-off-by: David Hildenbrand \n>> ---\n>> target/s390x/cpu-qom.h | 2 +-\n>> target/s390x/cpu.c | 11 +++++------\n>> 2 files changed, 6 insertions(+), 7 deletions(-)\n>>\n>> diff --git a/target/s390x/cpu-qom.h b/target/s390x/cpu-qom.h\n>> index 2435cd8390..2e446fab51 100644\n>> --- a/target/s390x/cpu-qom.h\n>> +++ b/target/s390x/cpu-qom.h\n>> @@ -54,7 +54,7 @@ typedef struct S390CPUClass {\n>> bool is_migration_safe;\n>> const char *desc;\n>> \n>> - int64_t next_cpu_id;\n>> + uint32_t next_core_id;\n> is it possible to hotplug cpus in out of order in real hw?\n\nYes, at least under z/VM. See last two patches in this series.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs5143V3Xz9s0g\n\tfor ;\n\tTue, 12 Sep 2017 23:16:56 +1000 (AEST)","from localhost ([::1]:35804 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drl3e-00040N-Ia\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 09:16:54 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:39010)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drl38-0003y3-Mx\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 09:16:25 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drl35-0007pn-H7\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 09:16:22 -0400","from mx1.redhat.com ([209.132.183.28]:46056)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1drl35-0007pT-A0\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 09:16:19 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 6B5A07EBDC;\n\tTue, 12 Sep 2017 13:16:18 +0000 (UTC)","from [10.36.117.114] (ovpn-117-114.ams2.redhat.com [10.36.117.114])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id D5B6A66851;\n\tTue, 12 Sep 2017 13:16:15 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 6B5A07EBDC","To":"Igor Mammedov ","References":"<20170911152150.12535-1-david@redhat.com>\n\t<20170911152150.12535-15-david@redhat.com>\n\t<20170912150947.70cf9b71@nial.brq.redhat.com>","From":"David Hildenbrand ","Organization":"Red Hat GmbH","Message-ID":"<933e6e9a-aea1-1d8e-210c-e1837e414bdf@redhat.com>","Date":"Tue, 12 Sep 2017 15:16:15 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170912150947.70cf9b71@nial.brq.redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tTue, 12 Sep 2017 13:16:18 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v4 14/21] target/s390x: rename next_cpu_id\n\tto next_core_id","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato , thuth@redhat.com,\n\tEduardo Habkost ,\n\tMarkus Armbruster , cohuck@redhat.com,\n\tRichard Henderson ,\n\tqemu-devel@nongnu.org, Alexander Graf ,\n\tborntraeger@de.ibm.com, Paolo Bonzini ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]