Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/811781/?format=api
{ "id": 811781, "url": "http://patchwork.ozlabs.org/api/patches/811781/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/patch/1504893565-110166-13-git-send-email-bhanuprakash.bodireddy@intel.com/", "project": { "id": 47, "url": "http://patchwork.ozlabs.org/api/projects/47/?format=api", "name": "Open vSwitch", "link_name": "openvswitch", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "git@github.com:openvswitch/ovs.git", "webscm_url": "https://github.com/openvswitch/ovs", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1504893565-110166-13-git-send-email-bhanuprakash.bodireddy@intel.com>", "list_archive_url": null, "date": "2017-09-08T17:59:24", "name": "[ovs-dev,12/13] conntrack: Fix dead assignment reported by clang.", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d7fa5557083ab64bfa587b9abe8920b4bff15055", "submitter": { "id": 68557, "url": "http://patchwork.ozlabs.org/api/people/68557/?format=api", "name": "Bodireddy, Bhanuprakash", "email": "bhanuprakash.bodireddy@intel.com" }, "delegate": { "id": 67810, "url": "http://patchwork.ozlabs.org/api/users/67810/?format=api", "username": "darball1", "first_name": "Darrell", "last_name": "Ball", "email": "dlu998@gmail.com" }, "mbox": "http://patchwork.ozlabs.org/project/openvswitch/patch/1504893565-110166-13-git-send-email-bhanuprakash.bodireddy@intel.com/mbox/", "series": [ { "id": 2268, "url": "http://patchwork.ozlabs.org/api/series/2268/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/list/?series=2268", "date": "2017-09-08T17:59:12", "name": "Rearrange structure members for memory efficiency.", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/2268/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/811781/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/811781/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "ovs-dev@mail.linuxfoundation.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xplrH2b6lz9sPk\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 9 Sep 2017 04:16:15 +1000 (AEST)", "from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 96564C79;\n\tFri, 8 Sep 2017 18:09:21 +0000 (UTC)", "from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 58438C9D\n\tfor <dev@openvswitch.org>; Fri, 8 Sep 2017 18:09:17 +0000 (UTC)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id EA9F2E5\n\tfor <dev@openvswitch.org>; Fri, 8 Sep 2017 18:09:16 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga105.fm.intel.com with ESMTP; 08 Sep 2017 11:09:16 -0700", "from silpixa00393942.ir.intel.com (HELO\n\tsilpixa00393942.ger.corp.intel.com) ([10.237.223.42])\n\tby fmsmga002.fm.intel.com with ESMTP; 08 Sep 2017 11:09:16 -0700" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.42,362,1500966000\"; d=\"scan'208\";\n\ta=\"1216435691\"", "From": "Bhanuprakash Bodireddy <bhanuprakash.bodireddy@intel.com>", "To": "dev@openvswitch.org", "Date": "Fri, 8 Sep 2017 18:59:24 +0100", "Message-Id": "<1504893565-110166-13-git-send-email-bhanuprakash.bodireddy@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1504893565-110166-1-git-send-email-bhanuprakash.bodireddy@intel.com>", "References": "<1504893565-110166-1-git-send-email-bhanuprakash.bodireddy@intel.com>", "X-Spam-Status": "No, score=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED,\n\tRP_MATCHES_RCVD autolearn=disabled version=3.3.1", "X-Spam-Checker-Version": "SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org", "Subject": "[ovs-dev] [PATCH 12/13] conntrack: Fix dead assignment reported by\n\tclang.", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.12", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "ovs-dev-bounces@openvswitch.org", "Errors-To": "ovs-dev-bounces@openvswitch.org" }, "content": "Clang reports that value stored to ftp, seq_skew_dir never read inside\nthe function.\n\nSigned-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodireddy@intel.com>\n---\n lib/conntrack.c | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/conntrack.c b/lib/conntrack.c\nindex 419cb1d..a0838ee 100644\n--- a/lib/conntrack.c\n+++ b/lib/conntrack.c\n@@ -2615,7 +2615,7 @@ process_ftp_ctl_v4(struct conntrack *ct,\n char ftp_msg[LARGEST_FTP_MSG_OF_INTEREST + 1] = {0};\n get_ftp_ctl_msg(pkt, ftp_msg);\n \n- char *ftp = ftp_msg;\n+ char *ftp;\n enum ct_alg_mode mode;\n if (!strncasecmp(ftp_msg, FTP_PORT_CMD, strlen(FTP_PORT_CMD))) {\n ftp = ftp_msg + strlen(FTP_PORT_CMD);\n@@ -2761,7 +2761,7 @@ process_ftp_ctl_v6(struct conntrack *ct,\n get_ftp_ctl_msg(pkt, ftp_msg);\n *ftp_data_start = tcp_hdr + tcp_hdr_len;\n \n- char *ftp = ftp_msg;\n+ char *ftp;\n struct in6_addr ip6_addr;\n if (!strncasecmp(ftp_msg, FTP_EPRT_CMD, strlen(FTP_EPRT_CMD))) {\n ftp = ftp_msg + strlen(FTP_EPRT_CMD);\n@@ -2909,7 +2909,6 @@ handle_ftp_ctl(struct conntrack *ct, const struct conn_lookup_ctx *ctx,\n bool seq_skew_dir;\n if (ftp_ctl == CT_FTP_CTL_OTHER) {\n seq_skew = conn_for_expectation->seq_skew;\n- seq_skew_dir = conn_for_expectation->seq_skew_dir;\n } else if (ftp_ctl == CT_FTP_CTL_INTEREST) {\n enum ftp_ctl_pkt rc;\n if (ctx->key.dl_type == htons(ETH_TYPE_IPV6)) {\n", "prefixes": [ "ovs-dev", "12/13" ] }