[{"id":1765600,"web_url":"http://patchwork.ozlabs.org/comment/1765600/","msgid":"<3C84A0E3-87FC-4E4A-9AF6-5C2B5A0DD452@vmware.com>","list_archive_url":null,"date":"2017-09-08T19:41:24","subject":"Re: [ovs-dev] [PATCH 12/13] conntrack: Fix dead assignment reported\n\tby clang.","submitter":{"id":68212,"url":"http://patchwork.ozlabs.org/api/people/68212/","name":"Darrell Ball","email":"dball@vmware.com"},"content":"Hi Bhanu\n\nWhat version of clang are you using and in what environment ?\n\nThanks Darrell\n\n\nOn 9/8/17, 10:59 AM, \"ovs-dev-bounces@openvswitch.org on behalf of Bhanuprakash Bodireddy\" wrote:\n\n Clang reports that value stored to ftp, seq_skew_dir never read inside\n the function.\n \n Signed-off-by: Bhanuprakash Bodireddy \n ---\n lib/conntrack.c | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)\n \n diff --git a/lib/conntrack.c b/lib/conntrack.c\n index 419cb1d..a0838ee 100644\n --- a/lib/conntrack.c\n +++ b/lib/conntrack.c\n @@ -2615,7 +2615,7 @@ process_ftp_ctl_v4(struct conntrack *ct,\n char ftp_msg[LARGEST_FTP_MSG_OF_INTEREST + 1] = {0};\n get_ftp_ctl_msg(pkt, ftp_msg);\n \n - char *ftp = ftp_msg;\n + char *ftp;\n enum ct_alg_mode mode;\n if (!strncasecmp(ftp_msg, FTP_PORT_CMD, strlen(FTP_PORT_CMD))) {\n ftp = ftp_msg + strlen(FTP_PORT_CMD);\n @@ -2761,7 +2761,7 @@ process_ftp_ctl_v6(struct conntrack *ct,\n get_ftp_ctl_msg(pkt, ftp_msg);\n *ftp_data_start = tcp_hdr + tcp_hdr_len;\n \n - char *ftp = ftp_msg;\n + char *ftp;\n struct in6_addr ip6_addr;\n if (!strncasecmp(ftp_msg, FTP_EPRT_CMD, strlen(FTP_EPRT_CMD))) {\n ftp = ftp_msg + strlen(FTP_EPRT_CMD);\n @@ -2909,7 +2909,6 @@ handle_ftp_ctl(struct conntrack *ct, const struct conn_lookup_ctx *ctx,\n bool seq_skew_dir;\n if (ftp_ctl == CT_FTP_CTL_OTHER) {\n seq_skew = conn_for_expectation->seq_skew;\n - seq_skew_dir = conn_for_expectation->seq_skew_dir;\n } else if (ftp_ctl == CT_FTP_CTL_INTEREST) {\n enum ftp_ctl_pkt rc;\n if (ctx->key.dl_type == htons(ETH_TYPE_IPV6)) {\n -- \n 2.4.11\n \n _______________________________________________\n dev mailing list\n dev@openvswitch.org\n https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=LE5PLIlvBSFThteUGJevgTlRlFesohyngSzGDqpvk5k&s=BsQfIBSohBfsM_UTvU-fZeE6EswgpKmd9tz0snT8usc&e=","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"kD+QLYSm\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=dball@vmware.com; "],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpnlQ01DCz9t2r\n\tfor ;\n\tSat, 9 Sep 2017 05:42:09 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 04922CDB;\n\tFri, 8 Sep 2017 19:41:29 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 80A2BCC5\n\tfor ; Fri, 8 Sep 2017 19:41:27 +0000 (UTC)","from NAM01-BN3-obe.outbound.protection.outlook.com\n\t(mail-bn3nam01on0079.outbound.protection.outlook.com [104.47.33.79])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id DF5963D4\n\tfor ; Fri, 8 Sep 2017 19:41:26 +0000 (UTC)","from BLUPR05MB611.namprd05.prod.outlook.com (10.141.204.27) by\n\tBLUPR05MB484.namprd05.prod.outlook.com (10.141.29.28) with Microsoft\n\tSMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.56.4; Fri, 8 Sep 2017 19:41:24 +0000","from BLUPR05MB611.namprd05.prod.outlook.com ([10.141.204.27]) by\n\tBLUPR05MB611.namprd05.prod.outlook.com ([10.141.204.27]) with mapi id\n\t15.20.0056.003; Fri, 8 Sep 2017 19:41:24 +0000"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=onevmw.onmicrosoft.com; s=selector1-vmware-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=Qcave7Aws74gODHWMnqOSxrSm3GWCoJwH9RfvcXOXJM=;\n\tb=kD+QLYSmA/sG0JlRNlkLfwJMonav8D0sOBRn4kPPMtxtMyQ5BspFhpl2r/Z3tmB6YaqQFKf3SefRRxgZCnLlBHLX/mjZPyTA2/Fz1xZlxvMYOdXb91faqJEK0H0vz85HmCNP+I6ve2bo4n1GvBh0O8iRDH+rqY4FJU1lvIcC7+w=","From":"Darrell Ball ","To":"Bhanuprakash Bodireddy ,\n\t\"dev@openvswitch.org\" ","Thread-Topic":"[ovs-dev] [PATCH 12/13] conntrack: Fix dead assignment reported\n\tby clang.","Thread-Index":"AQHTKNp09CKScVLmUUm+fgreu0z9Mg==","Date":"Fri, 8 Sep 2017 19:41:24 +0000","Message-ID":"<3C84A0E3-87FC-4E4A-9AF6-5C2B5A0DD452@vmware.com>","References":"<1504893565-110166-1-git-send-email-bhanuprakash.bodireddy@intel.com>\n\t<1504893565-110166-13-git-send-email-bhanuprakash.bodireddy@intel.com>","In-Reply-To":"<1504893565-110166-13-git-send-email-bhanuprakash.bodireddy@intel.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","user-agent":"Microsoft-MacOutlook/f.23.0.170610","authentication-results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"kD+QLYSm\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=dball@vmware.com; "],"x-originating-ip":"[73.162.236.45]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; BLUPR05MB484;\n\t20:zJk/YQ6To+XjVjjDrSF41Tjw/dElLEgJMgVLlQzwWxGNqT7fSMgz7TFFUEYCni52wiK3WvSHAhWCDdrqHEpBl7Z8HmjgU60FR5k7fy4SfmDNINQ0cCTxFtU7mfhNXnJqgGlpIe4Zbn4x40G6TmRtYqxfEgB8+3ngq2qWDkBu+Lc=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;","x-ms-office365-filtering-correlation-id":"6f1200a4-1d35-4bf5-f938-08d4f6f1971c","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:BLUPR05MB484; ","x-ms-traffictypediagnostic":"BLUPR05MB484:","x-exchange-antispam-report-test":"UriScan:(20558992708506)(10436049006162)(216315784871565)(228905959029699)(17755550239193);","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(3002001)(6041248)(20161123558100)(20161123562025)(20161123564025)(20161123560025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:BLUPR05MB484; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:BLUPR05MB484; ","x-forefront-prvs":"04244E0DC5","x-forefront-antispam-report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(39860400002)(199003)(189002)(377454003)(24454002)(66066001)(6506006)(14454004)(106356001)(25786009)(7736002)(6512007)(6306002)(6436002)(189998001)(99286003)(2950100002)(53546010)(305945005)(50986999)(76176999)(53936002)(54356999)(101416001)(83716003)(83506001)(105586002)(33656002)(2900100001)(6246003)(2501003)(2906002)(82746002)(8936002)(229853002)(6116002)(102836003)(966005)(5660300001)(81156014)(81166006)(3846002)(478600001)(3280700002)(68736007)(4001350100001)(3660700001)(97736004)(6486002)(77096006)(86362001)(8676002)(36756003)(575784001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR05MB484;\n\tH:BLUPR05MB611.namprd05.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; A:1; MX:1; LANG:en; ","received-spf":"None (protection.outlook.com: vmware.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","Content-ID":"","MIME-Version":"1.0","X-OriginatorOrg":"vmware.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"08 Sep 2017 19:41:24.6079\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"BLUPR05MB484","X-Spam-Status":"No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"Re: [ovs-dev] [PATCH 12/13] conntrack: Fix dead assignment reported\n\tby clang.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1765976,"web_url":"http://patchwork.ozlabs.org/comment/1765976/","msgid":"<7EE4206A5F421D4FBA0A4623185DE2BD3750C818@IRSMSX104.ger.corp.intel.com>","list_archive_url":null,"date":"2017-09-10T17:25:33","subject":"Re: [ovs-dev] [PATCH 12/13] conntrack: Fix dead assignment reported\n\tby clang.","submitter":{"id":68557,"url":"http://patchwork.ozlabs.org/api/people/68557/","name":"Bodireddy, Bhanuprakash","email":"bhanuprakash.bodireddy@intel.com"},"content":"Hi Darrell,\n\n>What version of clang are you using and in what environment ?\n\nThe clang version is 3.5.0. This was seen with clang static analysis.\n\n- Bhanuprakash.\n\n>\n>On 9/8/17, 10:59 AM, \"ovs-dev-bounces@openvswitch.org on behalf of\n>Bhanuprakash Bodireddy\" bhanuprakash.bodireddy@intel.com> wrote:\n>\n> Clang reports that value stored to ftp, seq_skew_dir never read inside\n> the function.\n>\n> Signed-off-by: Bhanuprakash Bodireddy\n>\n> ---\n> lib/conntrack.c | 5 ++---\n> 1 file changed, 2 insertions(+), 3 deletions(-)\n>\n> diff --git a/lib/conntrack.c b/lib/conntrack.c\n> index 419cb1d..a0838ee 100644\n> --- a/lib/conntrack.c\n> +++ b/lib/conntrack.c\n> @@ -2615,7 +2615,7 @@ process_ftp_ctl_v4(struct conntrack *ct,\n> char ftp_msg[LARGEST_FTP_MSG_OF_INTEREST + 1] = {0};\n> get_ftp_ctl_msg(pkt, ftp_msg);\n>\n> - char *ftp = ftp_msg;\n> + char *ftp;\n> enum ct_alg_mode mode;\n> if (!strncasecmp(ftp_msg, FTP_PORT_CMD, strlen(FTP_PORT_CMD))) {\n> ftp = ftp_msg + strlen(FTP_PORT_CMD);\n> @@ -2761,7 +2761,7 @@ process_ftp_ctl_v6(struct conntrack *ct,\n> get_ftp_ctl_msg(pkt, ftp_msg);\n> *ftp_data_start = tcp_hdr + tcp_hdr_len;\n>\n> - char *ftp = ftp_msg;\n> + char *ftp;\n> struct in6_addr ip6_addr;\n> if (!strncasecmp(ftp_msg, FTP_EPRT_CMD, strlen(FTP_EPRT_CMD))) {\n> ftp = ftp_msg + strlen(FTP_EPRT_CMD);\n> @@ -2909,7 +2909,6 @@ handle_ftp_ctl(struct conntrack *ct, const struct\n>conn_lookup_ctx *ctx,\n> bool seq_skew_dir;\n> if (ftp_ctl == CT_FTP_CTL_OTHER) {\n> seq_skew = conn_for_expectation->seq_skew;\n> - seq_skew_dir = conn_for_expectation->seq_skew_dir;\n> } else if (ftp_ctl == CT_FTP_CTL_INTEREST) {\n> enum ftp_ctl_pkt rc;\n> if (ctx->key.dl_type == htons(ETH_TYPE_IPV6)) {\n> --\n> 2.4.11\n>\n> _______________________________________________\n> dev mailing list\n> dev@openvswitch.org\n> https://urldefense.proofpoint.com/v2/url?u=https-\n>3A__mail.openvswitch.org_mailman_listinfo_ovs-\n>2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-\n>uZnsw&m=LE5PLIlvBSFThteUGJevgTlRlFesohyngSzGDqpvk5k&s=BsQfIBSohBf\n>sM_UTvU-fZeE6EswgpKmd9tz0snT8usc&e=\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xqyd40z6zz9s7M\n\tfor ;\n\tMon, 11 Sep 2017 03:25:43 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 6D934A7F;\n\tSun, 10 Sep 2017 17:25:39 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 8A1E7A7F\n\tfor ; Sun, 10 Sep 2017 17:25:38 +0000 (UTC)","from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id BDBEF1BB\n\tfor ; Sun, 10 Sep 2017 17:25:36 +0000 (UTC)","from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga105.fm.intel.com with ESMTP; 10 Sep 2017 10:25:36 -0700","from irsmsx105.ger.corp.intel.com ([163.33.3.28])\n\tby fmsmga002.fm.intel.com with ESMTP; 10 Sep 2017 10:25:35 -0700","from irsmsx104.ger.corp.intel.com ([169.254.5.248]) by\n\tirsmsx105.ger.corp.intel.com ([169.254.7.75]) with mapi id\n\t14.03.0319.002; Sun, 10 Sep 2017 18:25:34 +0100"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos; i=\"5.42,374,1500966000\"; d=\"scan'208\";\n\ta=\"1216935547\"","From":"\"Bodireddy, Bhanuprakash\" ","To":"Darrell Ball , \"dev@openvswitch.org\"\n\t","Thread-Topic":"[ovs-dev] [PATCH 12/13] conntrack: Fix dead assignment\n\treported by clang.","Thread-Index":"AQHTKNp8NMH2pdj3skaRGIwQBN0X9KKuX9SQ","Date":"Sun, 10 Sep 2017 17:25:33 +0000","Message-ID":"<7EE4206A5F421D4FBA0A4623185DE2BD3750C818@IRSMSX104.ger.corp.intel.com>","References":"<1504893565-110166-1-git-send-email-bhanuprakash.bodireddy@intel.com>\n\t<1504893565-110166-13-git-send-email-bhanuprakash.bodireddy@intel.com>\n\t<3C84A0E3-87FC-4E4A-9AF6-5C2B5A0DD452@vmware.com>","In-Reply-To":"<3C84A0E3-87FC-4E4A-9AF6-5C2B5A0DD452@vmware.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","dlp-product":"dlpe-windows","dlp-version":"11.0.0.116","dlp-reaction":"no-action","x-originating-ip":"[163.33.239.180]","MIME-Version":"1.0","X-Spam-Status":"No, score=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED,\n\tRP_MATCHES_RCVD autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"Re: [ovs-dev] [PATCH 12/13] conntrack: Fix dead assignment reported\n\tby clang.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1769326,"web_url":"http://patchwork.ozlabs.org/comment/1769326/","msgid":"","list_archive_url":null,"date":"2017-09-15T17:39:42","subject":"Re: [ovs-dev] [PATCH 12/13] conntrack: Fix dead assignment reported\n\tby clang.","submitter":{"id":69140,"url":"http://patchwork.ozlabs.org/api/people/69140/","name":"Gregory Rose","email":"gvrose8192@gmail.com"},"content":"On 09/08/2017 10:59 AM, Bhanuprakash Bodireddy wrote:\n> Clang reports that value stored to ftp, seq_skew_dir never read inside\n> the function.\n> \n> Signed-off-by: Bhanuprakash Bodireddy \n> ---\n> lib/conntrack.c | 5 ++---\n> 1 file changed, 2 insertions(+), 3 deletions(-)\n> \n> diff --git a/lib/conntrack.c b/lib/conntrack.c\n> index 419cb1d..a0838ee 100644\n> --- a/lib/conntrack.c\n> +++ b/lib/conntrack.c\n> @@ -2615,7 +2615,7 @@ process_ftp_ctl_v4(struct conntrack *ct,\n> char ftp_msg[LARGEST_FTP_MSG_OF_INTEREST + 1] = {0};\n> get_ftp_ctl_msg(pkt, ftp_msg);\n> \n> - char *ftp = ftp_msg;\n> + char *ftp;\n> enum ct_alg_mode mode;\n> if (!strncasecmp(ftp_msg, FTP_PORT_CMD, strlen(FTP_PORT_CMD))) {\n> ftp = ftp_msg + strlen(FTP_PORT_CMD);\n> @@ -2761,7 +2761,7 @@ process_ftp_ctl_v6(struct conntrack *ct,\n> get_ftp_ctl_msg(pkt, ftp_msg);\n> *ftp_data_start = tcp_hdr + tcp_hdr_len;\n> \n> - char *ftp = ftp_msg;\n> + char *ftp;\n> struct in6_addr ip6_addr;\n> if (!strncasecmp(ftp_msg, FTP_EPRT_CMD, strlen(FTP_EPRT_CMD))) {\n> ftp = ftp_msg + strlen(FTP_EPRT_CMD);\n> @@ -2909,7 +2909,6 @@ handle_ftp_ctl(struct conntrack *ct, const struct conn_lookup_ctx *ctx,\n> bool seq_skew_dir;\n> if (ftp_ctl == CT_FTP_CTL_OTHER) {\n> seq_skew = conn_for_expectation->seq_skew;\n> - seq_skew_dir = conn_for_expectation->seq_skew_dir;\n> } else if (ftp_ctl == CT_FTP_CTL_INTEREST) {\n> enum ftp_ctl_pkt rc;\n> if (ctx->key.dl_type == htons(ETH_TYPE_IPV6)) {\n> \n\nLooks good.\n\nReviewed-by: Greg Rose ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Nyv7I8Tl\"; dkim-atps=neutral"],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xv2j06Wylz9s7c\n\tfor ;\n\tSat, 16 Sep 2017 03:39:48 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 1BD6BAD5;\n\tFri, 15 Sep 2017 17:39:47 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id F09ADAB8\n\tfor ; Fri, 15 Sep 2017 17:39:45 +0000 (UTC)","from mail-pf0-f195.google.com (mail-pf0-f195.google.com\n\t[209.85.192.195])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 9F70B3CB\n\tfor ; Fri, 15 Sep 2017 17:39:45 +0000 (UTC)","by mail-pf0-f195.google.com with SMTP id h4so1534171pfk.0\n\tfor ; Fri, 15 Sep 2017 10:39:45 -0700 (PDT)","from gizo.bigblue.kilchis.com (67-5-132-83.ptld.qwest.net.\n\t[67.5.132.83]) by smtp.gmail.com with ESMTPSA id\n\tn19sm4409650pfj.114.2017.09.15.10.39.43\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 15 Sep 2017 10:39:43 -0700 (PDT)"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:references:from:message-id:date:user-agent:mime-version\n\t:in-reply-to:content-language:content-transfer-encoding;\n\tbh=sEElGLZmD3k0hl5ZFaJqG+AogHqQAhpOWvWNAlaRRuM=;\n\tb=Nyv7I8TlxjwftdIO6ElutVUAXccuOysIjEr7xJ4xqtajXaR8IwgWsXEqowd971PmME\n\tXjqEGNcyUgHm1xE2ASz978+3qYVPIjOVB5sS0PIXjoocQP+wg0AvVJpESsBgcpGodMr3\n\tNuBLcMOOcL2+PS2YJcpCBcdi+i9gIn/rZy11KakbDrp6xaf2Rrrho30RhL+mXjPuA3gI\n\tWbtyIK7Wq6cD5/uwUYpoOG0KSGeYudhJH6NVDIQOtHQCw60WuCITNRRdxCYmfAANaLbq\n\tz/8VzGsFTs8MIwbbBsZQOC8TrQ3NwZjuEVXA6apMJiWzGbdxwkcmpULHNlKQ0ntkrn2U\n\tvyLA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=sEElGLZmD3k0hl5ZFaJqG+AogHqQAhpOWvWNAlaRRuM=;\n\tb=sdVcN2WJ6/DDyu4NKtry7ZBb81gT41HmmM42jTdVgxu807axa+djlhoUM1UsRhpdzZ\n\tjNi0hM9KoKogHNwweUiwe4Pg4lM0zmU6SQTIG7B8vNbuhUIr2tMhoOMPLjKhh5LzwQAO\n\tT59aWuG2X5E8fKbJa2HLD1iYlkxYc/hPK8IgtYhgdSJAFwyyz0ddeqMFjsdK7s+zfGPi\n\t7YVDHJOe11v9i8FwveFAjDK7Vso1N92Rl2TpLY7fuNiYU6Cz9nyGvYT1jfUfvChRrP10\n\t++XtkYI7C8V+lRi+L6ng2gN81dxzaXyknj+0zr1XDl0R150sLyqMZVsJR0kA+V56p732\n\tRYlQ==","X-Gm-Message-State":"AHPjjUh49aa9AyeSKjICpLxTP1rEevWZ3GCxtOzA0VhgStz3C57iqwna\n\tsPaYE6DZ/wSi4h7tAXQ=","X-Google-Smtp-Source":"ADKCNb7e3ZYVM6WdCwazRhR8G6StjHZ988rMAjvmwMHi1bycWz24KnKNSc0r7lrKVBaEobk6+plMgA==","X-Received":"by 10.98.43.67 with SMTP id r64mr25275214pfr.233.1505497184881; \n\tFri, 15 Sep 2017 10:39:44 -0700 (PDT)","To":"Bhanuprakash Bodireddy ,\n\tdev@openvswitch.org","References":"<1504893565-110166-1-git-send-email-bhanuprakash.bodireddy@intel.com>\n\t<1504893565-110166-13-git-send-email-bhanuprakash.bodireddy@intel.com>","From":"Greg Rose ","Message-ID":"","Date":"Fri, 15 Sep 2017 10:39:42 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.1.0","MIME-Version":"1.0","In-Reply-To":"<1504893565-110166-13-git-send-email-bhanuprakash.bodireddy@intel.com>","Content-Language":"en-US","X-Spam-Status":"No, score=0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, \n\tRCVD_IN_SORBS_SPAM autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"Re: [ovs-dev] [PATCH 12/13] conntrack: Fix dead assignment reported\n\tby clang.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1771367,"web_url":"http://patchwork.ozlabs.org/comment/1771367/","msgid":"","list_archive_url":null,"date":"2017-09-19T20:29:36","subject":"Re: [ovs-dev] [PATCH 12/13] conntrack: Fix dead assignment reported\n\tby clang.","submitter":{"id":68212,"url":"http://patchwork.ozlabs.org/api/people/68212/","name":"Darrell Ball","email":"dball@vmware.com"},"content":"Thanks Bhanu\r\n\r\nIt seems my scan-build usage was not catching these.\r\nI decided to do something a little different which I’ll send out later today as part of some other changes\r\n\r\nDarrell\r\n\r\nOn 9/10/17, 10:25 AM, \"Bodireddy, Bhanuprakash\" wrote:\r\n\r\n Hi Darrell,\r\n \r\n >What version of clang are you using and in what environment ?\r\n \r\n The clang version is 3.5.0. This was seen with clang static analysis.\r\n \r\n - Bhanuprakash.\r\n \r\n >\r\n >On 9/8/17, 10:59 AM, \"ovs-dev-bounces@openvswitch.org on behalf of\r\n >Bhanuprakash Bodireddy\" bhanuprakash.bodireddy@intel.com> wrote:\r\n >\r\n > Clang reports that value stored to ftp, seq_skew_dir never read inside\r\n > the function.\r\n >\r\n > Signed-off-by: Bhanuprakash Bodireddy\r\n >\r\n > ---\r\n > lib/conntrack.c | 5 ++---\r\n > 1 file changed, 2 insertions(+), 3 deletions(-)\r\n >\r\n > diff --git a/lib/conntrack.c b/lib/conntrack.c\r\n > index 419cb1d..a0838ee 100644\r\n > --- a/lib/conntrack.c\r\n > +++ b/lib/conntrack.c\r\n > @@ -2615,7 +2615,7 @@ process_ftp_ctl_v4(struct conntrack *ct,\r\n > char ftp_msg[LARGEST_FTP_MSG_OF_INTEREST + 1] = {0};\r\n > get_ftp_ctl_msg(pkt, ftp_msg);\r\n >\r\n > - char *ftp = ftp_msg;\r\n > + char *ftp;\r\n > enum ct_alg_mode mode;\r\n > if (!strncasecmp(ftp_msg, FTP_PORT_CMD, strlen(FTP_PORT_CMD))) {\r\n > ftp = ftp_msg + strlen(FTP_PORT_CMD);\r\n > @@ -2761,7 +2761,7 @@ process_ftp_ctl_v6(struct conntrack *ct,\r\n > get_ftp_ctl_msg(pkt, ftp_msg);\r\n > *ftp_data_start = tcp_hdr + tcp_hdr_len;\r\n >\r\n > - char *ftp = ftp_msg;\r\n > + char *ftp;\r\n > struct in6_addr ip6_addr;\r\n > if (!strncasecmp(ftp_msg, FTP_EPRT_CMD, strlen(FTP_EPRT_CMD))) {\r\n > ftp = ftp_msg + strlen(FTP_EPRT_CMD);\r\n > @@ -2909,7 +2909,6 @@ handle_ftp_ctl(struct conntrack *ct, const struct\r\n >conn_lookup_ctx *ctx,\r\n > bool seq_skew_dir;\r\n > if (ftp_ctl == CT_FTP_CTL_OTHER) {\r\n > seq_skew = conn_for_expectation->seq_skew;\r\n > - seq_skew_dir = conn_for_expectation->seq_skew_dir;\r\n > } else if (ftp_ctl == CT_FTP_CTL_INTEREST) {\r\n > enum ftp_ctl_pkt rc;\r\n > if (ctx->key.dl_type == htons(ETH_TYPE_IPV6)) {\r\n > --\r\n > 2.4.11\r\n >\r\n > _______________________________________________\r\n > dev mailing list\r\n > dev@openvswitch.org\r\n > https://urldefense.proofpoint.com/v2/url?u=https-\r\n >3A__mail.openvswitch.org_mailman_listinfo_ovs-\r\n >2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-\r\n >uZnsw&m=LE5PLIlvBSFThteUGJevgTlRlFesohyngSzGDqpvk5k&s=BsQfIBSohBf\r\n >sM_UTvU-fZeE6EswgpKmd9tz0snT8usc&e=\r\n >","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"FLvKPeQi\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=dball@vmware.com; "],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxZHB5ftRz9s81\n\tfor ;\n\tWed, 20 Sep 2017 06:29:42 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 1908ABC0;\n\tTue, 19 Sep 2017 20:29:41 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 8C036B47\n\tfor ; Tue, 19 Sep 2017 20:29:39 +0000 (UTC)","from NAM03-CO1-obe.outbound.protection.outlook.com\n\t(mail-co1nam03on0049.outbound.protection.outlook.com [104.47.40.49])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 86DEA442\n\tfor ; Tue, 19 Sep 2017 20:29:38 +0000 (UTC)","from MWHPR05MB3406.namprd05.prod.outlook.com (10.174.175.155) by\n\tMWHPR05MB3550.namprd05.prod.outlook.com (10.174.250.153) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.77.5; Tue, 19 Sep 2017 20:29:37 +0000","from MWHPR05MB3406.namprd05.prod.outlook.com ([10.174.175.155]) by\n\tMWHPR05MB3406.namprd05.prod.outlook.com ([10.174.175.155]) with\n\tmapi id 15.20.0077.007; Tue, 19 Sep 2017 20:29:37 +0000"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=onevmw.onmicrosoft.com; s=selector1-vmware-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=T2Ve/lptrdUmygWG03spvXDvNXSNyIcs9LYDovXASS8=;\n\tb=FLvKPeQiay+SB+IrGfgp91W8cfpu/D6r44I3ZDhwHU/cHAJ3LUdDWJq4DrAKlbGTdQSbTQ8potE6o2u/66ztwS0TVGUUCaZyrILCP0qLO0tBe49+pTj1e043uOzUojvoPR4QVeBU50c+H+UiNXi2/ADOqYu7d9qpQudjUS1wHTo=","From":"Darrell Ball ","To":"\"Bodireddy, Bhanuprakash\" ,\n\t\"dev@openvswitch.org\" ","Thread-Topic":"[ovs-dev] [PATCH 12/13] conntrack: Fix dead assignment reported\n\tby clang.","Thread-Index":"AQHTKNp09CKScVLmUUm+fgreu0z9MqKuYeiAgA5YZwA=","Date":"Tue, 19 Sep 2017 20:29:36 +0000","Message-ID":"","References":"<1504893565-110166-1-git-send-email-bhanuprakash.bodireddy@intel.com>\n\t<1504893565-110166-13-git-send-email-bhanuprakash.bodireddy@intel.com>\n\t<3C84A0E3-87FC-4E4A-9AF6-5C2B5A0DD452@vmware.com>\n\t<7EE4206A5F421D4FBA0A4623185DE2BD3750C818@IRSMSX104.ger.corp.intel.com>","In-Reply-To":"<7EE4206A5F421D4FBA0A4623185DE2BD3750C818@IRSMSX104.ger.corp.intel.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","user-agent":"Microsoft-MacOutlook/f.26.0.170902","authentication-results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"FLvKPeQi\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=dball@vmware.com; "],"x-originating-ip":"[73.162.236.45]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; MWHPR05MB3550;\n\t20:ltrrg6aefXCXWLL3fOOB0SEmtacO91tPUiCIH3D5rr4BYc8J2hGYTXLsHezUCXV6r6xYU3QzKxEs+7q+QBt2AqNb50+BETApulG2SvQNV4A+BTlXR+6R8v0Za3b19xC7jqg48IiepH2fLMA9/wmSLiDgXkqLOVgN/C5Uu3vDZ0U=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;","x-ms-office365-filtering-correlation-id":"e96ba2af-9f8b-40fd-3bac-08d4ff9d2590","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:MWHPR05MB3550; ","x-ms-traffictypediagnostic":"MWHPR05MB3550:","x-exchange-antispam-report-test":"UriScan:(20558992708506)(10436049006162)(216315784871565)(228905959029699)(17755550239193);","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(100000703101)(100105400095)(6041248)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123564025)(20161123558100)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:MWHPR05MB3550; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:MWHPR05MB3550; ","x-forefront-prvs":"04359FAD81","x-forefront-antispam-report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(376002)(346002)(199003)(189002)(24454002)(377454003)(97736004)(99286003)(101416001)(81156014)(81166006)(7736002)(77096006)(53936002)(966005)(6486002)(50986999)(54356999)(229853002)(76176999)(33656002)(110136005)(189998001)(58126008)(2906002)(316002)(106356001)(6306002)(3660700001)(105586002)(6512007)(66066001)(8676002)(53546010)(3280700002)(14454004)(102836003)(6116002)(3846002)(2950100002)(25786009)(8936002)(83506001)(6506006)(68736007)(83716003)(2501003)(6246003)(478600001)(5660300001)(93886005)(36756003)(2900100001)(305945005)(575784001)(6436002)(86362001)(82746002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR05MB3550;\n\tH:MWHPR05MB3406.namprd05.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; A:1; MX:1; LANG:en; ","received-spf":"None (protection.outlook.com: vmware.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","Content-ID":"<70C7058DE160934CAFDF3D90F49FA805@namprd05.prod.outlook.com>","MIME-Version":"1.0","X-OriginatorOrg":"vmware.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"19 Sep 2017 20:29:36.9209\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"MWHPR05MB3550","X-Spam-Status":"No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"Re: [ovs-dev] [PATCH 12/13] conntrack: Fix dead assignment reported\n\tby clang.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1771549,"web_url":"http://patchwork.ozlabs.org/comment/1771549/","msgid":"","list_archive_url":null,"date":"2017-09-20T04:09:48","subject":"Re: [ovs-dev] [PATCH 12/13] conntrack: Fix dead assignment reported\n\tby clang.","submitter":{"id":68212,"url":"http://patchwork.ozlabs.org/api/people/68212/","name":"Darrell Ball","email":"dball@vmware.com"},"content":"Hi Bhanu\r\n\r\nThanks for the report.\r\nI sent a different patch here:\r\nhttps://patchwork.ozlabs.org/patch/815998/\r\n\r\nPls let me know if it makes sense and more importantly if it does not.\r\n\r\nThanks Darrell\r\n\r\nOn 9/19/17, 1:29 PM, \"Darrell Ball\" wrote:\r\n\r\n Thanks Bhanu\r\n \r\n It seems my scan-build usage was not catching these.\r\n I decided to do something a little different which I’ll send out later today as part of some other changes\r\n \r\n Darrell\r\n \r\n On 9/10/17, 10:25 AM, \"Bodireddy, Bhanuprakash\" wrote:\r\n \r\n Hi Darrell,\r\n \r\n >What version of clang are you using and in what environment ?\r\n \r\n The clang version is 3.5.0. This was seen with clang static analysis.\r\n \r\n - Bhanuprakash.\r\n \r\n >\r\n >On 9/8/17, 10:59 AM, \"ovs-dev-bounces@openvswitch.org on behalf of\r\n >Bhanuprakash Bodireddy\" bhanuprakash.bodireddy@intel.com> wrote:\r\n >\r\n > Clang reports that value stored to ftp, seq_skew_dir never read inside\r\n > the function.\r\n >\r\n > Signed-off-by: Bhanuprakash Bodireddy\r\n >\r\n > ---\r\n > lib/conntrack.c | 5 ++---\r\n > 1 file changed, 2 insertions(+), 3 deletions(-)\r\n >\r\n > diff --git a/lib/conntrack.c b/lib/conntrack.c\r\n > index 419cb1d..a0838ee 100644\r\n > --- a/lib/conntrack.c\r\n > +++ b/lib/conntrack.c\r\n > @@ -2615,7 +2615,7 @@ process_ftp_ctl_v4(struct conntrack *ct,\r\n > char ftp_msg[LARGEST_FTP_MSG_OF_INTEREST + 1] = {0};\r\n > get_ftp_ctl_msg(pkt, ftp_msg);\r\n >\r\n > - char *ftp = ftp_msg;\r\n > + char *ftp;\r\n > enum ct_alg_mode mode;\r\n > if (!strncasecmp(ftp_msg, FTP_PORT_CMD, strlen(FTP_PORT_CMD))) {\r\n > ftp = ftp_msg + strlen(FTP_PORT_CMD);\r\n > @@ -2761,7 +2761,7 @@ process_ftp_ctl_v6(struct conntrack *ct,\r\n > get_ftp_ctl_msg(pkt, ftp_msg);\r\n > *ftp_data_start = tcp_hdr + tcp_hdr_len;\r\n >\r\n > - char *ftp = ftp_msg;\r\n > + char *ftp;\r\n > struct in6_addr ip6_addr;\r\n > if (!strncasecmp(ftp_msg, FTP_EPRT_CMD, strlen(FTP_EPRT_CMD))) {\r\n > ftp = ftp_msg + strlen(FTP_EPRT_CMD);\r\n > @@ -2909,7 +2909,6 @@ handle_ftp_ctl(struct conntrack *ct, const struct\r\n >conn_lookup_ctx *ctx,\r\n > bool seq_skew_dir;\r\n > if (ftp_ctl == CT_FTP_CTL_OTHER) {\r\n > seq_skew = conn_for_expectation->seq_skew;\r\n > - seq_skew_dir = conn_for_expectation->seq_skew_dir;\r\n > } else if (ftp_ctl == CT_FTP_CTL_INTEREST) {\r\n > enum ftp_ctl_pkt rc;\r\n > if (ctx->key.dl_type == htons(ETH_TYPE_IPV6)) {\r\n > --\r\n > 2.4.11\r\n >\r\n > _______________________________________________\r\n > dev mailing list\r\n > dev@openvswitch.org\r\n > https://urldefense.proofpoint.com/v2/url?u=https-\r\n >3A__mail.openvswitch.org_mailman_listinfo_ovs-\r\n >2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-\r\n >uZnsw&m=LE5PLIlvBSFThteUGJevgTlRlFesohyngSzGDqpvk5k&s=BsQfIBSohBf\r\n >sM_UTvU-fZeE6EswgpKmd9tz0snT8usc&e=\r\n >","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"ePPDDGKn\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=dball@vmware.com; "],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxmVB51dKz9s0Z\n\tfor ;\n\tWed, 20 Sep 2017 14:09:54 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id E2CEE92F;\n\tWed, 20 Sep 2017 04:09:52 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 2737140A\n\tfor ; Wed, 20 Sep 2017 04:09:52 +0000 (UTC)","from NAM03-CO1-obe.outbound.protection.outlook.com\n\t(mail-co1nam03on0089.outbound.protection.outlook.com [104.47.40.89])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 222F7204\n\tfor ; Wed, 20 Sep 2017 04:09:51 +0000 (UTC)","from MWHPR05MB3406.namprd05.prod.outlook.com (10.174.175.155) by\n\tMWHPR05MB3053.namprd05.prod.outlook.com (10.173.228.135) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.77.5; Wed, 20 Sep 2017 04:09:48 +0000","from MWHPR05MB3406.namprd05.prod.outlook.com ([10.174.175.155]) by\n\tMWHPR05MB3406.namprd05.prod.outlook.com ([10.174.175.155]) with\n\tmapi id 15.20.0077.007; Wed, 20 Sep 2017 04:09:49 +0000"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=onevmw.onmicrosoft.com; s=selector1-vmware-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=f56P7xK8iVcfFUJ8st93M/wQxZp5zfeNtHmlPY6/kso=;\n\tb=ePPDDGKn2gO4kXSQtvlQ3+PQdCn8W+iiXBgAla+asQ8NMOiPfR3W98DkIjrlWSx2PdPooqrrXiSH/Svszvy9/ImR8f1CQ8w4wonDHzHR8SjhXR0v6K5aGfJY13Ceq2D+0ryTqXrfkIjHNW+w0HrS3Qyrl2ovAUzRVvdZGRzwEuc=","From":"Darrell Ball ","To":"\"Bodireddy, Bhanuprakash\" ,\n\t\"dev@openvswitch.org\" ","Thread-Topic":"[ovs-dev] [PATCH 12/13] conntrack: Fix dead assignment reported\n\tby clang.","Thread-Index":"AQHTKNp09CKScVLmUUm+fgreu0z9MqKuYeiAgA5YZwCAAICVAA==","Date":"Wed, 20 Sep 2017 04:09:48 +0000","Message-ID":"","References":"<1504893565-110166-1-git-send-email-bhanuprakash.bodireddy@intel.com>\n\t<1504893565-110166-13-git-send-email-bhanuprakash.bodireddy@intel.com>\n\t<3C84A0E3-87FC-4E4A-9AF6-5C2B5A0DD452@vmware.com>\n\t<7EE4206A5F421D4FBA0A4623185DE2BD3750C818@IRSMSX104.ger.corp.intel.com>\n\t","In-Reply-To":"","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","user-agent":"Microsoft-MacOutlook/f.26.0.170902","authentication-results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"ePPDDGKn\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=dball@vmware.com; "],"x-originating-ip":"[208.91.2.2]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; MWHPR05MB3053;\n\t20:jXJYCWH4zeaCkXhzhsUd83woBZnAvZlxfKCx+JgwuXH2N9KuqZf9FQdvU7Op2M3EreuWvbg0JF9VewKFPviPx/Ealu7mZ46HXP1fdkEEHlefsdnQqXVF6p6fjDvsjESdxBNmT0xSUTujnBjf3yS8hZkH43G/Bzc64ga6srnVLoE=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;","x-ms-office365-filtering-correlation-id":"3159c587-aaaf-4d96-58f4-08d4ffdd6f89","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:MWHPR05MB3053; ","x-ms-traffictypediagnostic":"MWHPR05MB3053:","x-exchange-antispam-report-test":"UriScan:(61668805478150)(20558992708506)(10436049006162)(216315784871565)(228905959029699)(17755550239193);","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(3002001)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123555025)(20161123558100)(20161123560025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:MWHPR05MB3053; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:MWHPR05MB3053; ","x-forefront-prvs":"04362AC73B","x-forefront-antispam-report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(346002)(376002)(377454003)(51914003)(199003)(24454002)(189002)(86362001)(575784001)(229853002)(83716003)(966005)(2906002)(66066001)(93886005)(33656002)(6246003)(6486002)(77096006)(6116002)(2950100002)(3660700001)(478600001)(102836003)(3280700002)(3846002)(14454004)(2900100001)(5660300001)(6506006)(82746002)(6436002)(53546010)(54356999)(36756003)(76176999)(50986999)(305945005)(105586002)(7736002)(106356001)(68736007)(2501003)(101416001)(189998001)(6512007)(6306002)(97736004)(316002)(25786009)(58126008)(81156014)(53936002)(81166006)(83506001)(8936002)(99286003)(8676002)(110136005);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR05MB3053;\n\tH:MWHPR05MB3406.namprd05.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; A:1; MX:1; LANG:en; ","received-spf":"None (protection.outlook.com: vmware.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","Content-ID":"","MIME-Version":"1.0","X-OriginatorOrg":"vmware.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"20 Sep 2017 04:09:48.9897\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"MWHPR05MB3053","X-Spam-Status":"No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"Re: [ovs-dev] [PATCH 12/13] conntrack: Fix dead assignment reported\n\tby clang.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}}]