Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/810964/?format=api
{ "id": 810964, "url": "http://patchwork.ozlabs.org/api/patches/810964/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/150478201163.24662.6473874525961508125.stgit@anamdev.jf.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<150478201163.24662.6473874525961508125.stgit@anamdev.jf.intel.com>", "list_archive_url": null, "date": "2017-09-07T11:00:11", "name": "[RFC,v3,2/6] i40e: Add macro for PF reset bit", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "04b2dd1f3ad03b75ebcf7010ab6ffd28c1058b21", "submitter": { "id": 68504, "url": "http://patchwork.ozlabs.org/api/people/68504/?format=api", "name": "Nambiar, Amritha", "email": "amritha.nambiar@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/150478201163.24662.6473874525961508125.stgit@anamdev.jf.intel.com/mbox/", "series": [ { "id": 1979, "url": "http://patchwork.ozlabs.org/api/series/1979/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=1979", "date": "2017-09-07T11:00:01", "name": "Configuring traffic classes via new hardware offload mechanism in tc/mqprio", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/1979/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/810964/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/810964/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnyF40z3Qz9s7C\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 7 Sep 2017 21:01:27 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 4F41B875B6;\n\tThu, 7 Sep 2017 11:01:26 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id jjB2PNCWV0ki; Thu, 7 Sep 2017 11:01:24 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 21E07874F0;\n\tThu, 7 Sep 2017 11:01:24 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 27FDD1C2121\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Sep 2017 11:01:23 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 216F72F807\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Sep 2017 11:01:23 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Xij0v5t7c09I for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Sep 2017 11:01:22 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 869A0239B5\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Sep 2017 11:01:22 +0000 (UTC)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t07 Sep 2017 04:01:22 -0700", "from anamdev.jf.intel.com ([10.166.29.110])\n\tby FMSMGA003.fm.intel.com with ESMTP; 07 Sep 2017 04:01:16 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.42,357,1500966000\"; d=\"scan'208\";a=\"897990576\"", "From": "Amritha Nambiar <amritha.nambiar@intel.com>", "To": "intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com", "Date": "Thu, 07 Sep 2017 04:00:11 -0700", "Message-ID": "<150478201163.24662.6473874525961508125.stgit@anamdev.jf.intel.com>", "In-Reply-To": "<150478158684.24662.17975701233699487888.stgit@anamdev.jf.intel.com>", "References": "<150478158684.24662.17975701233699487888.stgit@anamdev.jf.intel.com>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Cc": "netdev@vger.kernel.org", "Subject": "[Intel-wired-lan] [RFC PATCH v3 2/6] i40e: Add macro for PF reset\n\tbit", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Introduce a macro for the bit setting the PF reset flag and\nupdate its usages. This makes it easier to use this flag\nin functions to be introduced in future without encountering\ncheckpatch issues related to alignment and line over 80\ncharacters.\n\nSigned-off-by: Amritha Nambiar <amritha.nambiar@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e.h | 2 ++\n drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 3 +--\n drivers/net/ethernet/intel/i40e/i40e_main.c | 9 ++++-----\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 5 ++---\n 4 files changed, 9 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e.h b/drivers/net/ethernet/intel/i40e/i40e.h\nindex 18c453a..d414adc 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e.h\n@@ -157,6 +157,8 @@ enum i40e_state_t {\n \t__I40E_STATE_SIZE__,\n };\n \n+#define I40E_PF_RESET_FLAG\tBIT_ULL(__I40E_PF_RESET_REQUESTED)\n+\n /* VSI state flags */\n enum i40e_vsi_state_t {\n \t__I40E_VSI_DOWN,\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c\nindex 6f2725f..2b8bbc8 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c\n@@ -798,8 +798,7 @@ static ssize_t i40e_dbg_command_write(struct file *filp,\n \t\t */\n \t\tif (!(pf->flags & I40E_FLAG_VEB_MODE_ENABLED)) {\n \t\t\tpf->flags |= I40E_FLAG_VEB_MODE_ENABLED;\n-\t\t\ti40e_do_reset_safe(pf,\n-\t\t\t\t\t BIT_ULL(__I40E_PF_RESET_REQUESTED));\n+\t\t\ti40e_do_reset_safe(pf, I40E_PF_RESET_FLAG);\n \t\t}\n \n \t\tvsi = i40e_vsi_setup(pf, I40E_VSI_VMDQ2, vsi_seid, 0);\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 76b03f7..2fdb99f 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -5753,7 +5753,7 @@ int i40e_vsi_open(struct i40e_vsi *vsi)\n err_setup_tx:\n \ti40e_vsi_free_tx_resources(vsi);\n \tif (vsi == pf->vsi[pf->lan_vsi])\n-\t\ti40e_do_reset(pf, BIT_ULL(__I40E_PF_RESET_REQUESTED), true);\n+\t\ti40e_do_reset(pf, I40E_PF_RESET_FLAG, true);\n \n \treturn err;\n }\n@@ -5881,7 +5881,7 @@ void i40e_do_reset(struct i40e_pf *pf, u32 reset_flags, bool lock_acquired)\n \t\twr32(&pf->hw, I40E_GLGEN_RTRIG, val);\n \t\ti40e_flush(&pf->hw);\n \n-\t} else if (reset_flags & BIT_ULL(__I40E_PF_RESET_REQUESTED)) {\n+\t} else if (reset_flags & I40E_PF_RESET_FLAG) {\n \n \t\t/* Request a PF Reset\n \t\t *\n@@ -9229,7 +9229,7 @@ static int i40e_set_features(struct net_device *netdev,\n \tneed_reset = i40e_set_ntuple(pf, features);\n \n \tif (need_reset)\n-\t\ti40e_do_reset(pf, BIT_ULL(__I40E_PF_RESET_REQUESTED), true);\n+\t\ti40e_do_reset(pf, I40E_PF_RESET_FLAG, true);\n \n \treturn 0;\n }\n@@ -9481,8 +9481,7 @@ static int i40e_ndo_bridge_setlink(struct net_device *dev,\n \t\t\t\tpf->flags |= I40E_FLAG_VEB_MODE_ENABLED;\n \t\t\telse\n \t\t\t\tpf->flags &= ~I40E_FLAG_VEB_MODE_ENABLED;\n-\t\t\ti40e_do_reset(pf, BIT_ULL(__I40E_PF_RESET_REQUESTED),\n-\t\t\t\t true);\n+\t\t\ti40e_do_reset(pf, I40E_PF_RESET_FLAG, true);\n \t\t\tbreak;\n \t\t}\n \t}\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex 8bedc74c..ac88d96 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -1424,8 +1424,7 @@ int i40e_pci_sriov_configure(struct pci_dev *pdev, int num_vfs)\n \tif (num_vfs) {\n \t\tif (!(pf->flags & I40E_FLAG_VEB_MODE_ENABLED)) {\n \t\t\tpf->flags |= I40E_FLAG_VEB_MODE_ENABLED;\n-\t\t\ti40e_do_reset_safe(pf,\n-\t\t\t\t\t BIT_ULL(__I40E_PF_RESET_REQUESTED));\n+\t\t\ti40e_do_reset_safe(pf, I40E_PF_RESET_FLAG);\n \t\t}\n \t\treturn i40e_pci_sriov_enable(pdev, num_vfs);\n \t}\n@@ -1433,7 +1432,7 @@ int i40e_pci_sriov_configure(struct pci_dev *pdev, int num_vfs)\n \tif (!pci_vfs_assigned(pf->pdev)) {\n \t\ti40e_free_vfs(pf);\n \t\tpf->flags &= ~I40E_FLAG_VEB_MODE_ENABLED;\n-\t\ti40e_do_reset_safe(pf, BIT_ULL(__I40E_PF_RESET_REQUESTED));\n+\t\ti40e_do_reset_safe(pf, I40E_PF_RESET_FLAG);\n \t} else {\n \t\tdev_warn(&pdev->dev, \"Unable to free VFs because some are assigned to VMs.\\n\");\n \t\treturn -EINVAL;\n", "prefixes": [ "RFC", "v3", "2/6" ] }