Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 809715,
    "url": "http://patchwork.ozlabs.org/api/patches/809715/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/1504536775-23533-1-git-send-email-mmanning@brocade.com/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<1504536775-23533-1-git-send-email-mmanning@brocade.com>",
    "list_archive_url": null,
    "date": "2017-09-04T14:52:55",
    "name": "net: ipv6: fix regression of no RTM_DELADDR sent after DAD failure",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "a4ca455e17f0449a38114255ef02fd9786354796",
    "submitter": {
        "id": 68389,
        "url": "http://patchwork.ozlabs.org/api/people/68389/?format=api",
        "name": "Mike Manning",
        "email": "mmanning@brocade.com"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/1504536775-23533-1-git-send-email-mmanning@brocade.com/mbox/",
    "series": [
        {
            "id": 1401,
            "url": "http://patchwork.ozlabs.org/api/series/1401/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=1401",
            "date": "2017-09-04T14:52:55",
            "name": "net: ipv6: fix regression of no RTM_DELADDR sent after DAD failure",
            "version": 1,
            "mbox": "http://patchwork.ozlabs.org/series/1401/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/809715/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/809715/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmCfd6sfVz9t2R\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue,  5 Sep 2017 00:59:05 +1000 (AEST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753847AbdIDO7D (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tMon, 4 Sep 2017 10:59:03 -0400",
            "from [144.49.130.148] ([144.49.130.148]:59460 \"EHLO\n\tmail.eng.vyatta.net\" rhost-flags-FAIL-FAIL-OK-FAIL) by\n\tvger.kernel.org with ESMTP id S1753838AbdIDO7D (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Mon, 4 Sep 2017 10:59:03 -0400",
            "from BRA-F155P12.brocade.com (unknown [10.252.48.4])\n\tby mail.eng.vyatta.net (Postfix) with ESMTPA id B8F823606F6;\n\tMon,  4 Sep 2017 07:53:22 -0700 (PDT)"
        ],
        "X-Greylist": "delayed 338 seconds by postgrey-1.27 at vger.kernel.org;\n\tMon, 04 Sep 2017 10:59:03 EDT",
        "From": "Mike Manning <mmanning@brocade.com>",
        "To": "netdev@vger.kernel.org",
        "Cc": "Mahesh Bandewar <maheshb@google.com>",
        "Subject": "[PATCH] net: ipv6: fix regression of no RTM_DELADDR sent after DAD\n\tfailure",
        "Date": "Mon,  4 Sep 2017 15:52:55 +0100",
        "Message-Id": "<1504536775-23533-1-git-send-email-mmanning@brocade.com>",
        "X-Mailer": "git-send-email 2.1.4",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "Commit f784ad3d79e5 (\"ipv6: do not send RTM_DELADDR for tentative\naddresses\") incorrectly assumes that no RTM_NEWADDR are sent for\naddresses in tentative state, as this does happen for the standard\nIPv6 use-case of DAD failure, see the call to ipv6_ifa_notify() in\naddconf_dad_stop(). So as a result of this change, no RTM_DELADDR is\nsent after DAD failure for a link-local when strict DAD (accept_dad=2)\nis configured, or on the next admin down in other cases. The absence\nof this notification breaks backwards compatibility and causes problems\nafter DAD failure if this notification was being relied on. The\nsolution is to allow RTM_DELADDR to still be sent after DAD failure.\n\nFixes: f784ad3d79e5(\"ipv6: do not send RTM_DELADDR for tentative addresses\")\nSigned-off-by: Mike Manning <mmanning@brocade.com>\nCc: Mahesh Bandewar <maheshb@google.com>\n---\n net/ipv6/addrconf.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c\nindex 936e9ab..ba757c2 100644\n--- a/net/ipv6/addrconf.c\n+++ b/net/ipv6/addrconf.c\n@@ -4982,9 +4982,10 @@ static void inet6_ifa_notify(int event, struct inet6_ifaddr *ifa)\n \n \t/* Don't send DELADDR notification for TENTATIVE address,\n \t * since NEWADDR notification is sent only after removing\n-\t * TENTATIVE flag.\n+\t * TENTATIVE flag, if DAD has not failed.\n \t */\n-\tif (ifa->flags & IFA_F_TENTATIVE && event == RTM_DELADDR)\n+\tif (ifa->flags & IFA_F_TENTATIVE && !(ifa->flags & IFA_F_DADFAILED) &&\n+\t    event == RTM_DELADDR)\n \t\treturn;\n \n \tskb = nlmsg_new(inet6_ifaddr_msgsize(), GFP_ATOMIC);\n",
    "prefixes": []
}