[{"id":1765044,"web_url":"http://patchwork.ozlabs.org/comment/1765044/","msgid":"<20170907.191843.836588795188250550.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-08T02:18:43","subject":"Re: [PATCH] net: ipv6: fix regression of no RTM_DELADDR sent after\n\tDAD failure","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Mike Manning \nDate: Mon, 4 Sep 2017 15:52:55 +0100\n\n> Commit f784ad3d79e5 (\"ipv6: do not send RTM_DELADDR for tentative\n> addresses\") incorrectly assumes that no RTM_NEWADDR are sent for\n> addresses in tentative state, as this does happen for the standard\n> IPv6 use-case of DAD failure, see the call to ipv6_ifa_notify() in\n> addconf_dad_stop(). So as a result of this change, no RTM_DELADDR is\n> sent after DAD failure for a link-local when strict DAD (accept_dad=2)\n> is configured, or on the next admin down in other cases. The absence\n> of this notification breaks backwards compatibility and causes problems\n> after DAD failure if this notification was being relied on. The\n> solution is to allow RTM_DELADDR to still be sent after DAD failure.\n> \n> Fixes: f784ad3d79e5(\"ipv6: do not send RTM_DELADDR for tentative addresses\")\n> Signed-off-by: Mike Manning \n> Cc: Mahesh Bandewar \n\nMahesh, please review this patch.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpLbW1PZnz9s83\n\tfor ;\n\tFri, 8 Sep 2017 12:18:47 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753242AbdIHCSp (ORCPT );\n\tThu, 7 Sep 2017 22:18:45 -0400","from shards.monkeyblade.net ([184.105.139.130]:40782 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752093AbdIHCSo (ORCPT\n\t); Thu, 7 Sep 2017 22:18:44 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 0074713408B14;\n\tThu, 7 Sep 2017 19:18:43 -0700 (PDT)"],"Date":"Thu, 07 Sep 2017 19:18:43 -0700 (PDT)","Message-Id":"<20170907.191843.836588795188250550.davem@davemloft.net>","To":"mmanning@brocade.com","Cc":"netdev@vger.kernel.org, maheshb@google.com","Subject":"Re: [PATCH] net: ipv6: fix regression of no RTM_DELADDR sent after\n\tDAD failure","From":"David Miller ","In-Reply-To":"<1504536775-23533-1-git-send-email-mmanning@brocade.com>","References":"<1504536775-23533-1-git-send-email-mmanning@brocade.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Thu, 07 Sep 2017 19:18:44 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1770173,"web_url":"http://patchwork.ozlabs.org/comment/1770173/","msgid":"","list_archive_url":null,"date":"2017-09-18T13:06:40","subject":"Re: [PATCH] net: ipv6: fix regression of no RTM_DELADDR sent after\n\tDAD failure","submitter":{"id":68389,"url":"http://patchwork.ozlabs.org/api/people/68389/","name":"Mike Manning","email":"mmanning@brocade.com"},"content":"Hi,\nIn the absence of a reply from Mahesh, I would be most grateful for\nanyone familiar with the IPv6 code to review this 1-line fix.\n\nOr if not, then I request that the commit f784ad3d79e5 is backed out,\nas its intention is to remove the redundant but harmless RTM_DELADDR\nfor addresses in tentative state, but is also incorrectly removing the\nvery necessary RTM_DELADDR when an address is deleted that was previously\nnotified with an RTM_NEWADDR as being in tentative dadfailed state.\n\nThanks\nMike\n\nOn 08/09/17 03:18, David Miller wrote:\n> From: Mike Manning \n> Date: Mon, 4 Sep 2017 15:52:55 +0100\n> \n>> Commit f784ad3d79e5 (\"ipv6: do not send RTM_DELADDR for tentative\n>> addresses\") incorrectly assumes that no RTM_NEWADDR are sent for\n>> addresses in tentative state, as this does happen for the standard\n>> IPv6 use-case of DAD failure, see the call to ipv6_ifa_notify() in\n>> addconf_dad_stop(). So as a result of this change, no RTM_DELADDR is\n>> sent after DAD failure for a link-local when strict DAD (accept_dad=2)\n>> is configured, or on the next admin down in other cases. The absence\n>> of this notification breaks backwards compatibility and causes problems\n>> after DAD failure if this notification was being relied on. The\n>> solution is to allow RTM_DELADDR to still be sent after DAD failure.\n>>\n>> Fixes: f784ad3d79e5(\"ipv6: do not send RTM_DELADDR for tentative addresses\")\n>> Signed-off-by: Mike Manning \n>> Cc: Mahesh Bandewar \n> \n> Mahesh, please review this patch.\n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwnS42Qkpz9s7G\n\tfor ;\n\tMon, 18 Sep 2017 23:49:40 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755259AbdIRNth (ORCPT );\n\tMon, 18 Sep 2017 09:49:37 -0400","from mx0b-000f0801.pphosted.com ([67.231.152.113]:41138 \"EHLO\n\tmx0a-000f0801.pphosted.com\" rhost-flags-OK-OK-OK-FAIL)\n\tby vger.kernel.org with ESMTP id S1754820AbdIRNtg (ORCPT\n\t); Mon, 18 Sep 2017 09:49:36 -0400","from pps.filterd (m0000700.ppops.net [127.0.0.1])\n\tby mx0b-000f0801.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8ID1CIO007829; Mon, 18 Sep 2017 06:07:08 -0700","from brmwp-exmb11.corp.brocade.com ([208.47.132.227])\n\tby mx0b-000f0801.pphosted.com with ESMTP id 2d2bvwrjdp-3\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); \n\tMon, 18 Sep 2017 06:07:08 -0700","from EMEAWP-EXMB12.corp.brocade.com (172.29.11.86) by\n\tBRMWP-EXMB11.corp.brocade.com (172.16.59.77) with Microsoft SMTP\n\tServer (TLS) id 15.0.1293.2; Mon, 18 Sep 2017 07:07:04 -0600","from [10.252.53.4] (10.252.53.4) by EMEAWP-EXMB12.corp.brocade.com\n\t(172.29.11.86) with Microsoft SMTP Server (TLS) id 15.0.1293.2;\n\tMon, 18 Sep 2017 15:07:01 +0200"],"X-Greylist":"delayed 2545 seconds by postgrey-1.27 at vger.kernel.org;\n\tMon, 18 Sep 2017 09:49:36 EDT","Subject":"Re: [PATCH] net: ipv6: fix regression of no RTM_DELADDR sent after\n\tDAD failure","To":"David Miller ","CC":"\"netdev@vger.kernel.org\" ,\n\t\"maheshb@google.com\" ","References":"<1504536775-23533-1-git-send-email-mmanning@brocade.com>\n\t<20170907.191843.836588795188250550.davem@davemloft.net>","From":"Mike Manning ","Message-ID":"","Date":"Mon, 18 Sep 2017 14:06:40 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170907.191843.836588795188250550.davem@davemloft.net>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Originating-IP":"[10.252.53.4]","X-ClientProxiedBy":"hq1wp-excas11.corp.brocade.com (10.70.36.102) To\n\tEMEAWP-EXMB12.corp.brocade.com (172.29.11.86)","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-18_03:, , signatures=0","X-Proofpoint-Spam-Details":"rule=notspam policy=default score=0\n\tpriorityscore=1501 malwarescore=0\n\tsuspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011\n\tlowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam\n\tadjust=0\n\treason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709180186","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1771466,"web_url":"http://patchwork.ozlabs.org/comment/1771466/","msgid":"<20170919.164328.373486119289403420.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-19T23:43:28","subject":"Re: [PATCH] net: ipv6: fix regression of no RTM_DELADDR sent after\n\tDAD failure","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Mike Manning \nDate: Mon, 18 Sep 2017 14:06:40 +0100\n\n> In the absence of a reply from Mahesh, I would be most grateful for\n> anyone familiar with the IPv6 code to review this 1-line fix.\n> \n> Or if not, then I request that the commit f784ad3d79e5 is backed out,\n> as its intention is to remove the redundant but harmless RTM_DELADDR\n> for addresses in tentative state, but is also incorrectly removing the\n> very necessary RTM_DELADDR when an address is deleted that was previously\n> notified with an RTM_NEWADDR as being in tentative dadfailed state.\n\nI've applied your patch, and queued it up for -stable, thanks.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxfZr1bVTz9sPr\n\tfor ;\n\tWed, 20 Sep 2017 09:43:32 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751361AbdISXna (ORCPT );\n\tTue, 19 Sep 2017 19:43:30 -0400","from shards.monkeyblade.net ([184.105.139.130]:51494 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751309AbdISXn3 (ORCPT\n\t); Tue, 19 Sep 2017 19:43:29 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id D00B3102CE550;\n\tTue, 19 Sep 2017 16:43:28 -0700 (PDT)"],"Date":"Tue, 19 Sep 2017 16:43:28 -0700 (PDT)","Message-Id":"<20170919.164328.373486119289403420.davem@davemloft.net>","To":"mmanning@brocade.com","Cc":"netdev@vger.kernel.org, maheshb@google.com","Subject":"Re: [PATCH] net: ipv6: fix regression of no RTM_DELADDR sent after\n\tDAD failure","From":"David Miller ","In-Reply-To":"","References":"<1504536775-23533-1-git-send-email-mmanning@brocade.com>\n\t<20170907.191843.836588795188250550.davem@davemloft.net>\n\t","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Tue, 19 Sep 2017 16:43:29 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]