Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/809325/?format=api
{ "id": 809325, "url": "http://patchwork.ozlabs.org/api/patches/809325/?format=api", "web_url": "http://patchwork.ozlabs.org/project/glibc/patch/CAMe9rOqvpS_HH6_k=rPuE3qx6oifjL8_WKzTVFhK9eZs84NvFA@mail.gmail.com/", "project": { "id": 41, "url": "http://patchwork.ozlabs.org/api/projects/41/?format=api", "name": "GNU C Library", "link_name": "glibc", "list_id": "libc-alpha.sourceware.org", "list_email": "libc-alpha@sourceware.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<CAMe9rOqvpS_HH6_k=rPuE3qx6oifjL8_WKzTVFhK9eZs84NvFA@mail.gmail.com>", "list_archive_url": null, "date": "2017-09-03T15:48:40", "name": "Silence -O3 -Wall warning in malloc/hooks.c with GCC 7 [BZ #22052]", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "94dc455581dcd2d42cd830fbf92d210beeebc298", "submitter": { "id": 4387, "url": "http://patchwork.ozlabs.org/api/people/4387/?format=api", "name": "H.J. Lu", "email": "hjl.tools@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/glibc/patch/CAMe9rOqvpS_HH6_k=rPuE3qx6oifjL8_WKzTVFhK9eZs84NvFA@mail.gmail.com/mbox/", "series": [ { "id": 1251, "url": "http://patchwork.ozlabs.org/api/series/1251/?format=api", "web_url": "http://patchwork.ozlabs.org/project/glibc/list/?series=1251", "date": "2017-09-03T15:48:40", "name": "Silence -O3 -Wall warning in malloc/hooks.c with GCC 7 [BZ #22052]", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/1251/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/809325/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/809325/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<libc-alpha-return-84146-incoming=patchwork.ozlabs.org@sourceware.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "mailing list libc-alpha@sourceware.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84146-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"r0aAKaCU\"; dkim-atps=neutral", "sourceware.org; auth=none" ], "Received": [ "from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xlcpZ1Wckz9t33\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 4 Sep 2017 01:48:53 +1000 (AEST)", "(qmail 93825 invoked by alias); 3 Sep 2017 15:48:48 -0000", "(qmail 93395 invoked by uid 89); 3 Sep 2017 15:48:47 -0000" ], "DomainKey-Signature": "a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:from:date:message-id:subject:to\n\t:cc:content-type; q=dns; s=default; b=E/rGO8bZhBZhU7pps2P/P0XLX1\n\ttiCr+rY/BXhe3H7cwWS/w7OYg0S7ENynAAZO+oCQEUPmmLDk+y659tDStT+xQv8E\n\t/KCzHX1iq2mL2vQ3b6MAM2BO84PfPrfGdJ/MkxTd2I1dfqCKT9EQNuciJ2JSu04J\n\tKxUViCNJLVCEA4QO0=", "DKIM-Signature": "v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:from:date:message-id:subject:to\n\t:cc:content-type; s=default; bh=KGbGwdYW5rMb1V2sf1igQH5qJWc=; b=\n\tr0aAKaCUYGa9k/D9B9SzFb71apWrSNhojOgOSu4dBkLnU1jZh6R64A+fgVCn6h+g\n\t5MTzN2aAMtC/PddrSdXpU5kfj+811RmqNU1CXK29eCJ0oBqkGGEeMO3tBhJ52s9t\n\tQVNu2c3QMKnQYGmiTgVTHb7pwF2ur1XJutjtHGDrKyI=", "Mailing-List": "contact libc-alpha-help@sourceware.org; run by ezmlm", "Precedence": "bulk", "List-Id": "<libc-alpha.sourceware.org>", "List-Unsubscribe": "<mailto:libc-alpha-unsubscribe-incoming=patchwork.ozlabs.org@sourceware.org>", "List-Subscribe": "<mailto:libc-alpha-subscribe@sourceware.org>", "List-Archive": "<http://sourceware.org/ml/libc-alpha/>", "List-Post": "<mailto:libc-alpha@sourceware.org>", "List-Help": "<mailto:libc-alpha-help@sourceware.org>,\n\t<http://sourceware.org/ml/#faqs>", "Sender": "libc-alpha-owner@sourceware.org", "X-Virus-Found": "No", "X-Spam-SWARE-Status": "No, score=-25.0 required=5.0 tests=AWL, BAYES_00,\n\tFREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2,\n\tGIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=", "X-HELO": "mail-oi0-f52.google.com", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; \n\tbh=ohAzAI/44MUBgjYHLNbj4W/RGOBWS9EhkzKZIYryczI=;\n\tb=acvtS579UZj14BUN5RLvqRwtVr/qbx36zp6OZp2SAMtFmnEwkscULkiGNV5AXuX1q9\n\tBv51kT3KaFWb7tE86BI+KlUGzU53fzcTdYkFGHJkKeAWFZjDPy7hRzbhQX3IHFS1uXq8\n\tL3m+vm3dWjIzYjjzWmoPoFNn3t4ACV/vIW6SKaGKlwxz4LoJ6V2Mt7GxtiRFo6X8iZlQ\n\t5hysXP6lyUAnLdNTgWEvoL5WWvKjyw/+eDqFiIdqbDHTQSDgbbWkeBUSHAt8oSZg556S\n\tu6ThNmILv2EE8aejwR9+rA6DC66VTUe2W6uzzGhZ6xAvPXLtgjUBQXgAkPphxgmzF22v\n\tQM8A==", "X-Gm-Message-State": "AHPjjUhvHJqpjaE4ioHmL4pmNhidu5OTBHJd9NgSYIz6ZCOTYUk0/GYt\n\tVDh8WeCpjUZTg/LPq08uqy/V5zUsIQ==", "X-Google-Smtp-Source": "ADKCNb5A36zCTWVm6pxeawmLa+D8sddmdfMbl7DmqB3VFQfLW0QAl3hHuYtoVkDwscnzINCNDa+e/F+HSzz4JjDFYhw=", "X-Received": "by 10.202.4.194 with SMTP id 185mr6675190oie.240.1504453721059; \n\tSun, 03 Sep 2017 08:48:41 -0700 (PDT)", "MIME-Version": "1.0", "From": "\"H.J. Lu\" <hjl.tools@gmail.com>", "Date": "Sun, 3 Sep 2017 08:48:40 -0700", "Message-ID": "<CAMe9rOqvpS_HH6_k=rPuE3qx6oifjL8_WKzTVFhK9eZs84NvFA@mail.gmail.com>", "Subject": "[PATCH] Silence -O3 -Wall warning in malloc/hooks.c with GCC 7 [BZ\n\t#22052]", "To": "Florian Weimer <fweimer@redhat.com>", "Cc": "\"Carlos O'Donell\" <carlos@redhat.com>,\n\tGNU C Library <libc-alpha@sourceware.org>", "Content-Type": "multipart/mixed; boundary=\"001a113c1f46a0134f05584aed86\"" }, "content": "On Thu, Aug 31, 2017 at 10:01 AM, Florian Weimer <fweimer@redhat.com> wrote:\n> On 08/31/2017 05:55 AM, H.J. Lu wrote:\n>\n>> One of malloc change caused:\n>>\n>> https://sourceware.org/bugzilla/show_bug.cgi?id=22052\n>\n> (uninit warning with -O3)\n>\n> I have not yet found a good way to suppress this. I don't know yet why\n> GCC loses the information that the maybe_p variable is initialized if\n> mem2chunk_check returns a non-null pointer.\n>\n\nThis patch works for me. OK for master?", "diff": "From 735efe5ebc3eb6aa877b00b10ac0046524cee6e3 Mon Sep 17 00:00:00 2001\nFrom: \"H.J. Lu\" <hjl.tools@gmail.com>\nDate: Sun, 3 Sep 2017 08:39:55 -0700\nSubject: [PATCH] Silence -O3 -Wall warning in malloc/hooks.c with GCC 7 [BZ\n #22052]\nMIME-Version: 1.0\nContent-Type: text/plain; charset=UTF-8\nContent-Transfer-Encoding: 8bit\n\nrealloc_check has\n\n unsigned char *magic_p;\n...\n __libc_lock_lock (main_arena.mutex);\n const mchunkptr oldp = mem2chunk_check (oldmem, &magic_p);\n __libc_lock_unlock (main_arena.mutex);\n if (!oldp)\n malloc_printerr (\"realloc(): invalid pointer\");\n...\n if (newmem == NULL)\n *magic_p ^= 0xFF;\n\nwith\n\nstatic void malloc_printerr(const char *str) __attribute__ ((noreturn));\n\nGCC 7 -O3 warns\n\nhooks.c: In function ‘realloc_check’:\nhooks.c:352:14: error: ‘magic_p’ may be used uninitialized in this function [-Werror=maybe-uninitialized]\n *magic_p ^= 0xFF;\n\nThis patch silences GCC 7 by initializing magic_p to NULL.\n\n\t[BZ #22052]\n\t* malloc/hooks.c (realloc_check): Initialize magic_p to NULL.\n---\n malloc/hooks.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/malloc/hooks.c b/malloc/hooks.c\nindex 01be076f5e..03bc086901 100644\n--- a/malloc/hooks.c\n+++ b/malloc/hooks.c\n@@ -287,7 +287,7 @@ realloc_check (void *oldmem, size_t bytes, const void *caller)\n {\n INTERNAL_SIZE_T nb;\n void *newmem = 0;\n- unsigned char *magic_p;\n+ unsigned char *magic_p = NULL;\n \n if (bytes + 1 == 0)\n {\n-- \n2.13.5\n\n", "prefixes": [] }