[{"id":1762298,"web_url":"http://patchwork.ozlabs.org/comment/1762298/","msgid":"","list_archive_url":null,"date":"2017-09-03T16:29:57","subject":"Re: [PATCH] Silence -O3 -Wall warning in malloc/hooks.c with GCC 7\n\t[BZ #22052]","submitter":{"id":4387,"url":"http://patchwork.ozlabs.org/api/people/4387/","name":"H.J. Lu","email":"hjl.tools@gmail.com"},"content":"On Sun, Sep 3, 2017 at 8:48 AM, H.J. Lu wrote:\n> On Thu, Aug 31, 2017 at 10:01 AM, Florian Weimer wrote:\n>> On 08/31/2017 05:55 AM, H.J. Lu wrote:\n>>\n>>> One of malloc change caused:\n>>>\n>>> https://sourceware.org/bugzilla/show_bug.cgi?id=22052\n>>\n>> (uninit warning with -O3)\n>>\n>> I have not yet found a good way to suppress this. I don't know yet why\n>> GCC loses the information that the maybe_p variable is initialized if\n>> mem2chunk_check returns a non-null pointer.\n>>\n>\n> This patch works for me. OK for master?\n>\n\nFYI, I opened a GCC bug:\n\nhttps://gcc.gnu.org/bugzilla/show_bug.cgi?id=82090","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84148-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"rX91SbqE\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xldkQ4lvqz9t33\n\tfor ;\n\tMon, 4 Sep 2017 02:30:22 +1000 (AEST)","(qmail 43016 invoked by alias); 3 Sep 2017 16:30:11 -0000","(qmail 33894 invoked by uid 89); 3 Sep 2017 16:30:04 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-type; q=dns; s=default; b=qutS\n\tTmewep0qK//gZ9jzNNgdpBPB+Z5SD4KC8S7d1igD/FuYMOenQU1ZbwW7BAk/L8VI\n\ti+yEK+d5jSLC/iksd4UwUw/6Oj51HrRHBdw8+mJc1May1/1J6mEQLRGge8fs2Qsd\n\tjsgfb2aAYf2t8oChdx5VDGPgSGL0hzd50/2oW78=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-type; s=default; bh=QZmwcC5jbg\n\tX8piHzdl5m/cFnljo=; b=rX91SbqE9rARy1YVbF+dmfmveU/4vmdZqF3HStYtSW\n\t2JoN39X+D/fLv0G20BxtH3lAWN2XkpBz+lEVc/b3zzb8cDw+pwTnaNhuod8rEeqk\n\tI7pZ2+p/4v7HHJriP3HaMPGIVKmuiIWkMPZqo4XxSZmI4iX5tEPZl+6FEzNrZqMf\n\tc=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-2.5 required=5.0 tests=AWL, BAYES_00,\n\tFREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM,\n\tSPF_PASS autolearn=no version=3.3.2 spammy=FYI","X-HELO":"mail-oi0-f45.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=1vrIm1nCcq2oOjbfuGadK0zu1ZOVwGsNI3H0U3I2Pac=;\n\tb=eipl7tMvxzhlkGg/SgSom58W2XMT+z9YTyww4yDRUs36TTYqCBDHQLU0jk/+cp7Hf6\n\t5YUrEeVEOXHZk1E8NG6yf4+4/0nl3fvlSYAdxWSIXEsWOPXYl7ZeeLqflY6GqzM6GelN\n\ttjbueJ29tPrPmOww04pxLX8+StItPIgLYFQLmIHLcIbMDm+dm/bmFtXC/Cn6XgfVEQFW\n\tN+N6wkFDdNv+0CLzsiaWl+ceLoHA3Jf41kKMX9UGrABstfWe5U1MKdH9a4wdHDQcQ/hc\n\t2NK4gOmqXxdUfjJS3c0naYmqSHavGAa34azLml3gpvCH3jai4G34zR7ugPDhxEiJVhYN\n\tqCNA==","X-Gm-Message-State":"AHPjjUhIMwTl9GUwNtMKPxZsvB3sV2g4UA92yveEm9UVuwCzzb6XBlAS\n\ttOhK9Q8NHJeMsmGqzijC5G9mA2zRDQ==","X-Google-Smtp-Source":"ADKCNb7WHeEnXHowcfmcMdzds7Sn+ckhBmzcYokYHXSRO3bWdzXI4nxKCcTDQCtlFPAkred+RBZkQ7nXPhzyQXVK06U=","X-Received":"by 10.202.84.16 with SMTP id i16mr1336975oib.103.1504456197969; \n\tSun, 03 Sep 2017 09:29:57 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"","From":"\"H.J. Lu\" ","Date":"Sun, 3 Sep 2017 09:29:57 -0700","Message-ID":"","Subject":"Re: [PATCH] Silence -O3 -Wall warning in malloc/hooks.c with GCC 7\n\t[BZ #22052]","To":"Florian Weimer ","Cc":"\"Carlos O'Donell\" ,\n\tGNU C Library ","Content-Type":"text/plain; charset=\"UTF-8\""}},{"id":1762519,"web_url":"http://patchwork.ozlabs.org/comment/1762519/","msgid":"","list_archive_url":null,"date":"2017-09-04T08:33:48","subject":"Re: [PATCH] Silence -O3 -Wall warning in malloc/hooks.c with GCC 7\n\t[BZ #22052]","submitter":{"id":14312,"url":"http://patchwork.ozlabs.org/api/people/14312/","name":"Florian Weimer","email":"fweimer@redhat.com"},"content":"On 09/03/2017 05:48 PM, H.J. Lu wrote:\n> + unsigned char *magic_p = NULL;\n\nI think the current practice is to use to suppress the\nwarning.\n\nIs the issue that the memory clobber on the inline asm makes GCC not to\nsee the conditional initialization?\n\nThanks,\nFlorian","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84156-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"G6tzHNlC\"; dkim-atps=neutral","sourceware.org; auth=none","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=fweimer@redhat.com"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xm36N2dKDz9s82\n\tfor ;\n\tMon, 4 Sep 2017 18:34:03 +1000 (AEST)","(qmail 89677 invoked by alias); 4 Sep 2017 08:33:56 -0000","(qmail 89168 invoked by uid 89); 4 Sep 2017 08:33:55 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:cc:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=FyfY1QevbKfiX+vs\n\t/BtrVTuXg3MxCpWxIaXAVtOVroOCF55btxGfD9lUIJTXeQCgc3ZQibaZqQfP/4eV\n\t+ebAxh6LDloaQbif4i7V2r2L+uE/3ebjid5RvTVAsP1xpJWJYimFNHyDru7Ihnbm\n\t++GfVULHmKKVpAdU3t5sf1bwXJc=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:cc:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=rCSHT2H61nVtUNZiK4df2k\n\tEummg=; b=G6tzHNlCggGfdf0GjEBsxa88iHizhnAL/GT7YQZrWiEkdt4gWxLfQ0\n\tLxst1UqMeMaF6FlCpJE4O0PU7meBZfBTQtpO1t+vC2gKPyaId1PUJLPdJ9BuSI0d\n\tyDl7h4yrde4nrJUGcdOCQ3frl/Hv3TEGGFjUmCj8nBk4InWzCb6oQ=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,\n\tRP_MATCHES_RCVD,\n\tSPF_HELO_PASS autolearn=ham version=3.3.2 spammy=","X-HELO":"mx1.redhat.com","DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com D1294C0587F8","Subject":"Re: [PATCH] Silence -O3 -Wall warning in malloc/hooks.c with GCC 7\n\t[BZ #22052]","To":"\"H.J. Lu\" ","Cc":"Carlos O'Donell ,\n\tGNU C Library ","References":"","From":"Florian Weimer ","Message-ID":"","Date":"Mon, 4 Sep 2017 10:33:48 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit"}},{"id":1762862,"web_url":"http://patchwork.ozlabs.org/comment/1762862/","msgid":"","list_archive_url":null,"date":"2017-09-04T20:29:56","subject":"Re: [PATCH] Silence -O3 -Wall warning in malloc/hooks.c with GCC 7\n\t[BZ #22052]","submitter":{"id":4387,"url":"http://patchwork.ozlabs.org/api/people/4387/","name":"H.J. Lu","email":"hjl.tools@gmail.com"},"content":"On Mon, Sep 4, 2017 at 1:33 AM, Florian Weimer wrote:\n> On 09/03/2017 05:48 PM, H.J. Lu wrote:\n>> + unsigned char *magic_p = NULL;\n>\n> I think the current practice is to use to suppress the\n> warning.\n\nIs there a usage example for this warning?\n\n> Is the issue that the memory clobber on the inline asm makes GCC not to\n> see the conditional initialization?\n\nPossible.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84178-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"CyC6B9D3\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmM0f48vfz9t2R\n\tfor ;\n\tTue, 5 Sep 2017 06:30:10 +1000 (AEST)","(qmail 62071 invoked by alias); 4 Sep 2017 20:30:05 -0000","(qmail 62019 invoked by uid 89); 4 Sep 2017 20:30:03 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-type; q=dns; s=default; b=KEOR\n\tmbYQLB2K452KzI2tdetglztxoVxuTno0vXiaDMrJuGAMtXeko0rutlYBpX4RyU8u\n\tXg8oltokp5oNQDbEUAKz0I3THeraAD3//KVOUgE17Wzdg3cZtXiF8foaDaWktWT4\n\tlzCIEmJ+AHakAfy/s2d2kKD52MFI1VK/f+VbBB4=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-type; s=default; bh=+/3NK9unIK\n\tCs7VRuRASjf/jtXj8=; b=CyC6B9D3h39LZBPq7809hvPQk+7U8DKowGu8uAv6+G\n\t1TNbHxrp14jUwcTSzqH/JVwy7TcIun2pWmIJfAxwA2h0gskLSFuae/YmMkRP9Ye2\n\tkpmhTiQOSEneFGbSOX9Ojf/SeUR2uhvfQI4655TgagxdTAA0Lq+VIs593vFq8NN4\n\tw=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-2.5 required=5.0 tests=AWL, BAYES_00,\n\tFREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM,\n\tSPF_PASS autolearn=no version=3.3.2 spammy=HX-Received:sk:l187mr1","X-HELO":"mail-oi0-f68.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=mw45H60YSa2JvqFNBQNzUhqCqad8W/FIwi17F1oESOc=;\n\tb=Wbr4L9838AalIy6lMoqsgJmPZkt0H3ENUI0942YbGW2R2aoPyfoyIBEl87gbzu4aAW\n\t/JAKovjX+vjHOhyF1mIOf6FNGvV4FKJ4BXSNfd32cPxOathhTa30ZLKhqdUY0U/chJ3D\n\t8ElRpiTUQK1ew2aVwZ5PrVy26nGqwi1jVSD6+smzaxcfIw2HCkBrGkqQQmnmnTPmb+Xy\n\tDHzLJsFzjS708cgZixEt+QS9rSANQdyhNOjL9F0kYx/l8g4K5gFeAL72eJr42oMXDJG0\n\t8hSQQnNqU9kLJxn0eEeYbJISB9vRSpExEgtySu1AEHVLFZMv02Hz1Hfa1svzHnfeNr6P\n\tHWEg==","X-Gm-Message-State":"AHPjjUj6VN8BIlFq0ugRBwNU2z63ds6Kteq+qOI4T6+ekRUwEpk7f59D\n\tdtfavkO92EyyEcY4RP48n3w+6pH2jw==","X-Google-Smtp-Source":"ADKCNb6Cx5NnAwqIYodxNN+gDh3xNHcGqBo6qOQ+ozzTSouSmdUsiTkY3Lr5YYNOjrlVcWFFcunO6D6tc2idB12R920=","X-Received":"by 10.202.87.196 with SMTP id l187mr1735325oib.103.1504556997393;\n\tMon, 04 Sep 2017 13:29:57 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"\n\t","From":"\"H.J. Lu\" ","Date":"Mon, 4 Sep 2017 13:29:56 -0700","Message-ID":"","Subject":"Re: [PATCH] Silence -O3 -Wall warning in malloc/hooks.c with GCC 7\n\t[BZ #22052]","To":"Florian Weimer ","Cc":"\"Carlos O'Donell\" ,\n\tGNU C Library ","Content-Type":"text/plain; charset=\"UTF-8\""}},{"id":1770185,"web_url":"http://patchwork.ozlabs.org/comment/1770185/","msgid":"","list_archive_url":null,"date":"2017-09-18T14:02:51","subject":"Re: [PATCH] Silence -O3 -Wall warning in malloc/hooks.c with GCC 7\n\t[BZ #22052]","submitter":{"id":14312,"url":"http://patchwork.ozlabs.org/api/people/14312/","name":"Florian Weimer","email":"fweimer@redhat.com"},"content":"On 09/04/2017 10:29 PM, H.J. Lu wrote:\n> On Mon, Sep 4, 2017 at 1:33 AM, Florian Weimer wrote:\n>> On 09/03/2017 05:48 PM, H.J. Lu wrote:\n>>> + unsigned char *magic_p = NULL;\n>>\n>> I think the current practice is to use to suppress the\n>> warning.\n> \n> Is there a usage example for this warning?\n\nSearch for DIAG_PUSH_NEEDS_COMMENT in the sources.\n\nThanks,\nFlorian","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84680-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"vFlR7+mH\"; dkim-atps=neutral","sourceware.org; auth=none","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=fweimer@redhat.com"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwnld5gDZz9s7c\n\tfor ;\n\tTue, 19 Sep 2017 00:03:09 +1000 (AEST)","(qmail 64841 invoked by alias); 18 Sep 2017 14:02:58 -0000","(qmail 64647 invoked by uid 89); 18 Sep 2017 14:02:57 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:cc:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=lVq48zQkTVTIW8hO\n\tA8qMlHg2GWpfTZgu76qzgCyU4hN0NYlzSMgbe/ezj8u9ayN0yUHGMsx4f4Ggt0zn\n\tEc4zdkiyZ+3V/vWyHa6bafceSOFueqwdvz4ut/b15B0fVAEmrkPBlqjvCBQtQ+aW\n\t1HjTrTDA9I+GVQhWF3hlEfSaDK4=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:cc:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=RuaC99WDfsyDsP5pDPpaMu\n\tYQURs=; b=vFlR7+mHjvZDTgstxKccSqG4aiQxH3KTPYkGxUZx/JA2e3Pu36GZvO\n\tPIHigZJCSRP5bKA2770QKLwiHnMdi2QqjdrnokfgiQrwd8keSqBBlZk/1s6PFG42\n\tyf2in9LPs84LrXWAYMkw3Se16nCl2AiZZ2g7FXiNWHNK2IMiYtRh8=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,\n\tRP_MATCHES_RCVD,\n\tSPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Silence","X-HELO":"mx1.redhat.com","DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com B35AA883CF","Subject":"Re: [PATCH] Silence -O3 -Wall warning in malloc/hooks.c with GCC 7\n\t[BZ #22052]","To":"\"H.J. Lu\" ","Cc":"Carlos O'Donell ,\n\tGNU C Library ","References":"\n\t\n\t","From":"Florian Weimer ","Message-ID":"","Date":"Mon, 18 Sep 2017 16:02:51 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit"}},{"id":1786998,"web_url":"http://patchwork.ozlabs.org/comment/1786998/","msgid":"","list_archive_url":null,"date":"2017-10-15T13:34:55","subject":"Re: [PATCH] Silence -O3 -Wall warning in malloc/hooks.c with GCC 7\n\t[BZ #22052]","submitter":{"id":4387,"url":"http://patchwork.ozlabs.org/api/people/4387/","name":"H.J. Lu","email":"hjl.tools@gmail.com"},"content":"On Mon, Sep 18, 2017 at 7:02 AM, Florian Weimer wrote:\n> On 09/04/2017 10:29 PM, H.J. Lu wrote:\n>>\n>> On Mon, Sep 4, 2017 at 1:33 AM, Florian Weimer wrote:\n>>>\n>>> On 09/03/2017 05:48 PM, H.J. Lu wrote:\n>>>>\n>>>> + unsigned char *magic_p = NULL;\n>>>\n>>>\n>>> I think the current practice is to use to suppress the\n>>> warning.\n>>\n>>\n>> Is there a usage example for this warning?\n>\n>\n> Search for DIAG_PUSH_NEEDS_COMMENT in the sources.\n>\n\nHere is a patch. Tested on x86-64. I am going to check it in.\n\nThanks.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-85837-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"aTpuPTK7\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yFMrr0K85z9sRW\n\tfor ;\n\tMon, 16 Oct 2017 00:35:07 +1100 (AEDT)","(qmail 21042 invoked by alias); 15 Oct 2017 13:35:00 -0000","(qmail 21023 invoked by uid 89); 15 Oct 2017 13:34:59 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-type; q=dns; s=default; b=LJ5E\n\tqMda3CJwlF9uElVA4n8YMrkUkgPdGtliipD/1EMgWabFYySkeX39bXD5bp0W1fwE\n\tU6YGUFo9Z5UtFOjLanZcXz5GtZnduwDf7T/beKYkzkCYupkEHvWKqt4OhmekysRK\n\t0cij95DrIJCuU/YK5BGB/7TuZXkeGBHNUoM+MhA=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-type; s=default; bh=YSKsHKr8Op\n\tzUvli41JRZlVLCcVI=; b=aTpuPTK7gHZlYtxNPAtm9K6iHSrSpWWSL5EQSNuoZ3\n\ttAIO5I8Pab1NjqBn252+eif2UNb+k44pvqByXctIElPwkDakugh95YVPV4ooYoJW\n\tvbxdISO4gkE9NxFcPnGeTNZjWif/wB6SIr1DSofqYRs56VUCx3GDat785LdA8A5q\n\tA=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-24.9 required=5.0 tests=AWL, BAYES_00,\n\tFREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2,\n\tGIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=silence, silences","X-HELO":"mail-oi0-f47.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=qdcPgotwm1tGYhgv8PJnLjM74pgU92IjZOezgLku+ss=;\n\tb=MhafT+2QixbT4BdC2ADfocnetDUdOzXwoViI3GLjAf+YWF1uc0F/QKxsre1DF8eLXe\n\t4zJsVba6pptfmpn1/W7Ua7T3y4gGnU5m0Mp/77z4ksAEdSqS1qhYb26x1MSG+SEDF4Uq\n\tXs+fMzxKF8z64dyngP2l32fXqUNSsKBuMazORbVIesv5RstcyOuTzBGocnlCTjswJeXu\n\tB3qJmrlVqtiG/UL3xemztOZEF9tGV8hT2rg9/R0pA6vG9ONnsy98tBkUax1DavyD3M0c\n\tpz/kF3QrahdHPEig9VFqNebGKkVJqPhIF4lk84fZyccf/3jfUKf6PEOaXhsL5/o4v27j\n\t2Ucg==","X-Gm-Message-State":"AMCzsaXs6220H0sey8IM4QyD0slO+2sDr8XWfhuLYbPFHNGaQL507zeH\n\t7RqvrfLUPsiviAUprRsnqteSa0Ye2tDRo8QOf4w=","X-Google-Smtp-Source":"AOwi7QDT8W2qQh30J9pEySry2U+1uYt0UImwfwC0gfQ5XYT0Q0ux9drsmczPboIxTcn+pAyz/hi+AsxstGz+5enfG1s=","X-Received":"by 10.157.43.104 with SMTP id f37mr3950703otd.491.1508074496426; \n\tSun, 15 Oct 2017 06:34:56 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"\n\t\n\t\n\t","From":"\"H.J. Lu\" ","Date":"Sun, 15 Oct 2017 06:34:55 -0700","Message-ID":"","Subject":"Re: [PATCH] Silence -O3 -Wall warning in malloc/hooks.c with GCC 7\n\t[BZ #22052]","To":"Florian Weimer ","Cc":"\"Carlos O'Donell\" ,\n\tGNU C Library ","Content-Type":"multipart/mixed; boundary=\"001a113d0caea7ace6055b95f4b8\""}}]