Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/809259/?format=api
{ "id": 809259, "url": "http://patchwork.ozlabs.org/api/patches/809259/?format=api", "web_url": "http://patchwork.ozlabs.org/project/lede/patch/20170903120129.2015-1-baptiste@bitsofnetworks.org/", "project": { "id": 54, "url": "http://patchwork.ozlabs.org/api/projects/54/?format=api", "name": "LEDE development", "link_name": "lede", "list_id": "lede-dev.lists.infradead.org", "list_email": "lede-dev@lists.infradead.org", "web_url": "http://lede-project.org/", "scm_url": "", "webscm_url": "http://git.lede-project.org/", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170903120129.2015-1-baptiste@bitsofnetworks.org>", "list_archive_url": null, "date": "2017-09-03T12:01:28", "name": "[LEDE-DEV] scripts/download.pl: fail loudly if provided hash is unsupported", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "8936116110757f04de1adb6dc3405e4d66783e0c", "submitter": { "id": 67238, "url": "http://patchwork.ozlabs.org/api/people/67238/?format=api", "name": "Baptiste Jonglez", "email": "baptiste@bitsofnetworks.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/lede/patch/20170903120129.2015-1-baptiste@bitsofnetworks.org/mbox/", "series": [ { "id": 1216, "url": "http://patchwork.ozlabs.org/api/series/1216/?format=api", "web_url": "http://patchwork.ozlabs.org/project/lede/list/?series=1216", "date": "2017-09-03T12:01:28", "name": "[LEDE-DEV] scripts/download.pl: fail loudly if provided hash is unsupported", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/1216/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/809259/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/809259/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"IteiLRAf\"; \n\tdkim-atps=neutral" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xlWpJ6t9Tz9s7v\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSun, 3 Sep 2017 22:03:20 +1000 (AEST)", "from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1doTcG-0008CI-G8; Sun, 03 Sep 2017 12:03:04 +0000", "from degre.six.polyno.me ([2a03:7220:8081:1a00::1]\n\thelo=mejis.polyno.me)\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1doTcC-00089g-9Z\n\tfor lede-dev@lists.infradead.org; Sun, 03 Sep 2017 12:03:02 +0000", "from [172.23.184.96] (helo=lud.polynome.dn42)\n\tby mejis.polyno.me with esmtp (Exim 4.80)\n\t(envelope-from <baptiste@bitsofnetworks.org>)\n\tid 1doTbi-0007MF-Pi; Sun, 03 Sep 2017 14:02:31 +0200" ], "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:Message-Id:\n\tDate:To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:\n\tResent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:\n\tList-Owner; bh=iknV0gSZ3OVowtdN+igG9ImGCjpJHUzY2YqCmiu/xkM=;\n\tb=IteiLRAf6ts7hn\n\texR12G/TpZ4f3RiyJRJsltemgVWc/Tf7YJ/L9NYb4c8SUHE5UsHAGjWXl/B+gD2ai5RIKSH7noEeJ\n\tKzC732tlYe52VS8v7Jsy2GYpYzzR3FXTzswK1A57husLLghJ2TPSmSTtE42TDIBhS68OXFtBlFiZk\n\thnphs8jlFgjFWd77T26KM9XWdgAdp/XSk2XT2yuGBuLZFc93PrmmVxlBazOATtl3+ixsyf9tbAksR\n\tTQYSlPTE7osRiD9//ThlNRFJ4msQCwFIqziHUDtj5BZM3Yhkvor1nUg87mCJu+u4yh5nKuYNCthK2\n\tkzEM2/+avUv6sTrFq3vg==;", "From": "Baptiste Jonglez <baptiste@bitsofnetworks.org>", "To": "lede-dev@lists.infradead.org,\n\tFelix Fietkau <nbd@nbd.name>", "Date": "Sun, 3 Sep 2017 14:01:28 +0200", "Message-Id": "<20170903120129.2015-1-baptiste@bitsofnetworks.org>", "X-Mailer": "git-send-email 2.14.1", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20170903_050300_507976_0DB9F08B ", "X-CRM114-Status": "UNSURE ( 6.61 )", "X-CRM114-Notice": "Please train this message.", "X-Spam-Score": "-1.9 (-)", "X-Spam-Report": "SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]", "Subject": "[LEDE-DEV] [PATCH] scripts/download.pl: fail loudly if provided\n\thash is unsupported", "X-BeenThere": "lede-dev@lists.infradead.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<lede-dev.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/lede-dev>,\n\t<mailto:lede-dev-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/lede-dev/>", "List-Post": "<mailto:lede-dev@lists.infradead.org>", "List-Help": "<mailto:lede-dev-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/lede-dev>,\n\t<mailto:lede-dev-request@lists.infradead.org?subject=subscribe>", "Cc": "Baptiste Jonglez <git@bitsofnetworks.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"Lede-dev\" <lede-dev-bounces@lists.infradead.org>", "Errors-To": "lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "From: Baptiste Jonglez <git@bitsofnetworks.org>\n\nCurrently, if the provided hash is unsupported (length different from 32\nor 64 bytes), we happily download the requested file without any kind of\nchecksum verification.\n\nThis is quite dangerous and may provide a false sense of security, because\na single typo in the hash (e.g. one character deleted by mistake) may skip\nchecksum verification entirely.\n\nInstead, fail immediately if we don't support the provided hash.\nIn particular, if an external package repository decides to change the\nhash algorithm one day, we will now fail loudly instead of skipping\nchecksum verification without complaints.\n\nNote: if some users of scripts/download.pl knowingly provide an empty hash\nbecause they don't need checksum verification, this change will break\nthem. This does not seem to be the case currently, but if this feature is\never needed, an option should be added to download.pl instead of relying\non the hash being empty.\n\nFixes: eaa4eba10a89 (\"scripts/download.pl: add SHA-256 support\")\n\nSigned-off-by: Baptiste Jonglez <git@bitsofnetworks.org>\n---\n scripts/download.pl | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/scripts/download.pl b/scripts/download.pl\nindex bf9fe8c761..775408934a 100755\n--- a/scripts/download.pl\n+++ b/scripts/download.pl\n@@ -88,6 +88,7 @@ sub download_cmd($) {\n }\n \n my $hash_cmd = hash_cmd();\n+$hash_cmd or die \"Cannot find appropriate hash command, ensure the provided hash is either a MD5 or SHA256 checksum.\\n\";\n \n sub download\n {\n", "prefixes": [ "LEDE-DEV" ] }