[{"id":1768461,"web_url":"http://patchwork.ozlabs.org/comment/1768461/","msgid":"<20170914093453.GA15727@lud.polynome.dn42>","list_archive_url":null,"date":"2017-09-14T09:34:53","subject":"Re: [LEDE-DEV] [PATCH] scripts/download.pl: fail loudly if provided\n\thash is unsupported","submitter":{"id":67238,"url":"http://patchwork.ozlabs.org/api/people/67238/","name":"Baptiste Jonglez","email":"baptiste@bitsofnetworks.org"},"content":"Thanks for merging, can this be merged to lede-17.01 as well?\n\nOn 03-09-17, Baptiste Jonglez wrote:\n> Currently, if the provided hash is unsupported (length different from 32\n> or 64 bytes), we happily download the requested file without any kind of\n> checksum verification.\n> \n> This is quite dangerous and may provide a false sense of security, because\n> a single typo in the hash (e.g. one character deleted by mistake) may skip\n> checksum verification entirely.\n> \n> Instead, fail immediately if we don't support the provided hash.\n> In particular, if an external package repository decides to change the\n> hash algorithm one day, we will now fail loudly instead of skipping\n> checksum verification without complaints.\n> \n> Note: if some users of scripts/download.pl knowingly provide an empty hash\n> because they don't need checksum verification, this change will break\n> them. This does not seem to be the case currently, but if this feature is\n> ever needed, an option should be added to download.pl instead of relying\n> on the hash being empty.\n> \n> Fixes: eaa4eba10a89 (\"scripts/download.pl: add SHA-256 support\")\n> \n> Signed-off-by: Baptiste Jonglez \n> ---\n> scripts/download.pl | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/scripts/download.pl b/scripts/download.pl\n> index bf9fe8c761..775408934a 100755\n> --- a/scripts/download.pl\n> +++ b/scripts/download.pl\n> @@ -88,6 +88,7 @@ sub download_cmd($) {\n> }\n> \n> my $hash_cmd = hash_cmd();\n> +$hash_cmd or die \"Cannot find appropriate hash command, ensure the provided hash is either a MD5 or SHA256 checksum.\\n\";\n> \n> sub download\n> {","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"eZLp2bEz\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtD0v235Wz9s0g\n\tfor ;\n\tThu, 14 Sep 2017 19:35:43 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dsQYS-0007vs-Tg; Thu, 14 Sep 2017 09:35:28 +0000","from rezine.polyno.me ([193.33.56.138]\n\thelo=mails.bitsofnetworks.org)\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dsQYO-0006f6-Dh\n\tfor lede-dev@lists.infradead.org; Thu, 14 Sep 2017 09:35:26 +0000","from [172.23.184.97] (helo=lud.polynome.dn42)\n\tby mails.bitsofnetworks.org with esmtps\n\t(TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89)\n\t(envelope-from )\n\tid 1dsQXv-00057h-GC; Thu, 14 Sep 2017 11:34:55 +0200"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:\n\tList-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:\n\tSubject:In-Reply-To:MIME-Version:References:Message-ID:To:From:Date:Reply-To:\n\tCc:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=oux4kxdBg39ASwti7NPZE3BLXpKVEUP27Fma7LQY1Jo=;\n\tb=eZLp2bEzZN/wMWTB7n516e7k+\n\tk0aJJCGzCELeJk7DYp1shPWWeXQK5B1wZx12ZAzK+a+eai4Q/x9hHzeEW9AGA5sUpmfVlmjSUGWY7\n\tMZXfoxW3wRCiuB5s4A2Vn+wX51W+ygSGRQfqzqVG+Ct6izfssFnUYjbLmT0N0wwMdDhDhRts+8k76\n\tZxV+MfJUJQPbylnZldEw/V+wjKYqUlRxFenLqg19UTJuzDkOSecHIrbpUdlkUGgWRhR2EmnA78dRX\n\t/roFqPlaeejX211gaLHLYuL6QqO+acoSqTv3cY25ptyOaggUMfps+eZbwEy81XDhhZxHv8C29L+05\n\txH9V6pHJQ==;","Date":"Thu, 14 Sep 2017 11:34:53 +0200","From":"Baptiste Jonglez ","To":"lede-dev@lists.infradead.org, Felix Fietkau ","Message-ID":"<20170914093453.GA15727@lud.polynome.dn42>","References":"<20170903120129.2015-1-baptiste@bitsofnetworks.org>","MIME-Version":"1.0","In-Reply-To":"<20170903120129.2015-1-baptiste@bitsofnetworks.org>","User-Agent":"Mutt/1.5.24 (2015-08-30)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170914_023524_711683_D8F47E2C ","X-CRM114-Status":"GOOD ( 11.72 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","Subject":"Re: [LEDE-DEV] [PATCH] scripts/download.pl: fail loudly if provided\n\thash is unsupported","X-BeenThere":"lede-dev@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============3746014718051669928==\"","Sender":"\"Lede-dev\" ","Errors-To":"lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1774287,"web_url":"http://patchwork.ozlabs.org/comment/1774287/","msgid":"","list_archive_url":null,"date":"2017-09-24T20:44:04","subject":"Re: [LEDE-DEV] [PATCH] scripts/download.pl: fail loudly if provided\n\thash is unsupported","submitter":{"id":22753,"url":"http://patchwork.ozlabs.org/api/people/22753/","name":"Stijn Tintel","email":"stijn@linux-ipv6.be"},"content":"On 03-09-17 15:01, Baptiste Jonglez wrote:\n> From: Baptiste Jonglez \n>\n> Currently, if the provided hash is unsupported (length different from 32\n> or 64 bytes), we happily download the requested file without any kind of\n> checksum verification.\n>\n> This is quite dangerous and may provide a false sense of security, because\n> a single typo in the hash (e.g. one character deleted by mistake) may skip\n> checksum verification entirely.\n>\n> Instead, fail immediately if we don't support the provided hash.\n> In particular, if an external package repository decides to change the\n> hash algorithm one day, we will now fail loudly instead of skipping\n> checksum verification without complaints.\n>\n> Note: if some users of scripts/download.pl knowingly provide an empty hash\n> because they don't need checksum verification, this change will break\n> them. This does not seem to be the case currently, but if this feature is\n> ever needed, an option should be added to download.pl instead of relying\n> on the hash being empty.\nUnfortunately this change breaks the make/foo/download feature, and\nbecause of this also the script we use to update kernel versions and\nrefresh patches for all targets. This has been discussed in #lede-dev a\nfew times, but we never agreed on a solution. Today, this is biting me\nonce again, and therefore I suggest to revert this change until we can\nagree on a solution that is both secure and doesn't break something some\nof use rather frequently.\n\nStijn","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"C2578KwU\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linux-ipv6.be header.i=@linux-ipv6.be\n\theader.b=\"INhf/DZD\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y0fP81YvMz9t3R\n\tfor ;\n\tMon, 25 Sep 2017 06:45:27 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dwDlw-0007t0-0g; Sun, 24 Sep 2017 20:45:04 +0000","from mail.tintel.eu ([2001:41d0:8:1644:0:ff:fe5c:6a54])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dwDlU-0007c1-90\n\tfor lede-dev@lists.infradead.org; Sun, 24 Sep 2017 20:44:40 +0000","from localhost (localhost [IPv6:::1])\n\tby mail.tintel.eu (Postfix) with ESMTP id 829D74309611;\n\tSun, 24 Sep 2017 22:44:07 +0200 (CEST)","from mail.tintel.eu ([IPv6:::1])\n\tby localhost (mail.tintel.eu [IPv6:::1]) (amavisd-new, port 10032)\n\twith ESMTP id jxUiSDna-YNQ; Sun, 24 Sep 2017 22:44:07 +0200 (CEST)","from localhost (localhost [IPv6:::1])\n\tby mail.tintel.eu (Postfix) with ESMTP id 01934430960F;\n\tSun, 24 Sep 2017 22:44:07 +0200 (CEST)","from mail.tintel.eu ([IPv6:::1])\n\tby localhost (mail.tintel.eu [IPv6:::1]) (amavisd-new, port 10026)\n\twith ESMTP id gm8CE3KLp87F; Sun, 24 Sep 2017 22:44:06 +0200 (CEST)","from [IPv6:2001:67c:21bc:24::adb] (unknown\n\t[IPv6:2001:67c:21bc:24::adb]) (Authenticated sender: stijn@tintel.eu)\n\tby mail.tintel.eu (Postfix) with ESMTPSA id 9E89E42AA237;\n\tSun, 24 Sep 2017 22:44:05 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:Date:\n\tMessage-ID:From:References:To:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=QKSmBs8+GJ53pVDI8pLV9V05CQXm41y8So4UJ2o+BAw=;\n\tb=C2578KwUS29UW0\n\tRWuOR/ve4j5UHZAgaq5LWxgTsCFJtxV4/7FbJgMPVFYUnHhVPGaCmYAShCk82u9HYUppjgNWEYPnR\n\tSiPfwb60oGg4P7eqdv+gFZRllQJxpaYE+oOWpREqg1y1HWuhAgF5gQgQOb9czr4heZDvjGngecPvY\n\t+ccAQAW/RlTkhWSkfry4YziqUcpa4dhxAN1GOpuyGs9mrDJ3ikm0P8zNEXwP1AWscoXFm2+xnbpbF\n\t9mEcI5GbCa/V+QNNbwOjo8BPCw21mVWIPPMsy94iLcPnDV8OvEut9lBiWlIllmOVtI53PtaTix1B8\n\tf1UGevqsVlmsUle+1q+Q==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-ipv6.be;\n\ts=502B7754-045F-11E5-BBC5-64595FD46BE8; t=1506285847;\n\tbh=iDq9qd/YFUs3mn8fqCCC9dhfczFrA3kLoEBFxn0mjtE=;\n\th=Subject:To:From:Message-ID:Date:MIME-Version:Content-Type:\n\tContent-Transfer-Encoding;\n\tb=INhf/DZDiCt2p1fwHE3Yf6pARYOVR+JKWSYzAGkjFQXQAPo/18aTYBVH7R7pW2XM5\n\t3Ct3QeEUd+3jMsm5MprEGD9JYaNpEqvC6wuueOVjPNnokENpIMbouQommiKbn04AxS\n\tchh6kXJ+vx5Cb4FhSK21vnkm00gO2pkzKZYNye/g="],"DKIM-Filter":"OpenDKIM Filter v2.9.2 mail.tintel.eu 01934430960F","X-Virus-Scanned":"amavisd-new at mail.tintel.eu","To":"Baptiste Jonglez ,\n\tlede-dev@lists.infradead.org, Felix Fietkau ","References":"<20170903120129.2015-1-baptiste@bitsofnetworks.org>","From":"Stijn Tintel ","Message-ID":"","Date":"Sun, 24 Sep 2017 23:44:04 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170903120129.2015-1-baptiste@bitsofnetworks.org>","Content-Language":"en-GB","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170924_134436_713656_21C70374 ","X-CRM114-Status":"GOOD ( 10.03 )","X-Spam-Score":"-1.8 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.8 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid","Subject":"Re: [LEDE-DEV] [PATCH] scripts/download.pl: fail loudly if provided\n\thash is unsupported","X-BeenThere":"lede-dev@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Baptiste Jonglez ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Lede-dev\" ","Errors-To":"lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1774292,"web_url":"http://patchwork.ozlabs.org/comment/1774292/","msgid":"<20170924205705.GA27620@tuxmachine.polynome.dn42>","list_archive_url":null,"date":"2017-09-24T20:57:05","subject":"Re: [LEDE-DEV] [PATCH] scripts/download.pl: fail loudly if provided\n\thash is unsupported","submitter":{"id":67238,"url":"http://patchwork.ozlabs.org/api/people/67238/","name":"Baptiste Jonglez","email":"baptiste@bitsofnetworks.org"},"content":"Hi,\n\nOn 24-09-17, Stijn Tintel wrote:\n> On 03-09-17 15:01, Baptiste Jonglez wrote:\n> > Note: if some users of scripts/download.pl knowingly provide an empty hash\n> > because they don't need checksum verification, this change will break\n> > them. This does not seem to be the case currently, but if this feature is\n> > ever needed, an option should be added to download.pl instead of relying\n> > on the hash being empty.\n>\n> Unfortunately this change breaks the make/foo/download feature,\n\nCan you elaborate on this? It seems to work fine here:\n\n $ make package/dnsmasq/download V=s\n make[1]: Entering directory '/lede/tmp/lede-project'\n make[2]: Entering directory '/lede/tmp/lede-project/package/network/services/dnsmasq'\n mkdir -p /lede/tmp/lede-project/dl\n SHELL= flock /lede/tmp/lede-project/tmp/.dnsmasq-2.77.tar.xz.flock -c '\t/lede/tmp/lede-project/scripts/download.pl \"/lede/tmp/lede-project/dl\" \"dnsmasq-2.77.tar.xz\" \"6eac3b1c50ae25170e3ff8c96ddb55236cf45007633fdb8a35b1f3e02f5f8b8a\" \"\" \"http://thekelleys.org.uk/dnsmasq/\" '\n + curl -f --connect-timeout 20 --retry 5 --location --insecure http://thekelleys.org.uk/dnsmasq/dnsmasq-2.77.tar.xz\n % Total % Received % Xferd Average Speed Time Time Time Current\n Dload Upload Total Spent Left Speed\n 100 475k 100 475k 0 0 237k 0 0:00:02 0:00:02 --:--:-- 232k\n make[2]: Leaving directory '/lede/tmp/lede-project/package/network/services/dnsmasq'\n make[1]: Leaving directory '/lede/tmp/lede-project'\n\n> and because of this also the script we use to update kernel versions and\n> refresh patches for all targets. This has been discussed in #lede-dev a\n> few times, but we never agreed on a solution. Today, this is biting me\n> once again, and therefore I suggest to revert this change until we can\n> agree on a solution that is both secure and doesn't break something some\n> of use rather frequently.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"ckP8AnEF\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y0fgs0dHzz9s7p\n\tfor ;\n\tMon, 25 Sep 2017 06:58:17 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dwDyO-0000I1-6D; Sun, 24 Sep 2017 20:57:56 +0000","from rezine.polyno.me ([193.33.56.138]\n\thelo=mails.bitsofnetworks.org)\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dwDxz-00006i-5e\n\tfor lede-dev@lists.infradead.org; Sun, 24 Sep 2017 20:57:33 +0000","from [172.23.184.97] (helo=tuxmachine.polynome.dn42)\n\tby mails.bitsofnetworks.org with esmtps\n\t(TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89)\n\t(envelope-from )\n\tid 1dwDxa-0003OY-MB; Sun, 24 Sep 2017 22:57:06 +0200"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc:\n\tList-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:\n\tSubject:In-Reply-To:MIME-Version:References:Message-ID:To:From:Date:Reply-To:\n\tContent-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=V8mKDqvdORUEd1wJLi6rclxwscONXgFrxOs5rk+GLKM=;\n\tb=ckP8AnEFXD8mePeSajtezq4RQ\n\t9o6Yx+lmUJrmfZF3kBEwMNMA0XG1o1q+kLw0f+ggqEt7PrBHyrNSdvemawDqaGtj+uenON4NHfW9k\n\tvA1Yfwp3Hh5QBSRsUtxoRDgnZ1zvnkR711UDdCN6qJeUYh/3euwO1zHOThAYQFJ809beuCPihXTCX\n\t9oQTDFNS59dsgf+aXyXZMQBGPTli38NU22S9iZl8faKBrP6bx9TLQOX97mt98UFF1Jst1jaDof0bD\n\tczBrJqVmi+4TOWdvoLIkr3VB2IniZZkwgOE5r103cuVdB9+BxESWdos9LWUD7GbFS7Q5OwkOTJbiS\n\tTThoTWKyw==;","Date":"Sun, 24 Sep 2017 22:57:05 +0200","From":"Baptiste Jonglez ","To":"Stijn Tintel ","Message-ID":"<20170924205705.GA27620@tuxmachine.polynome.dn42>","References":"<20170903120129.2015-1-baptiste@bitsofnetworks.org>\n\t","MIME-Version":"1.0","In-Reply-To":"","User-Agent":"Mutt/1.5.24 (2015-08-30)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170924_135731_406787_DB777A79 ","X-CRM114-Status":"UNSURE ( 9.36 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","Subject":"Re: [LEDE-DEV] [PATCH] scripts/download.pl: fail loudly if provided\n\thash is unsupported","X-BeenThere":"lede-dev@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"lede-dev@lists.infradead.org","Content-Type":"multipart/mixed;\n\tboundary=\"===============0547999257859258523==\"","Sender":"\"Lede-dev\" ","Errors-To":"lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1774295,"web_url":"http://patchwork.ozlabs.org/comment/1774295/","msgid":"","list_archive_url":null,"date":"2017-09-24T20:59:26","subject":"Re: [LEDE-DEV] [PATCH] scripts/download.pl: fail loudly if provided\n\thash is unsupported","submitter":{"id":22753,"url":"http://patchwork.ozlabs.org/api/people/22753/","name":"Stijn Tintel","email":"stijn@linux-ipv6.be"},"content":"On 24-09-17 23:57, Baptiste Jonglez wrote:\n> Hi,\n>\n> On 24-09-17, Stijn Tintel wrote:\n>> On 03-09-17 15:01, Baptiste Jonglez wrote:\n>>> Note: if some users of scripts/download.pl knowingly provide an empty hash\n>>> because they don't need checksum verification, this change will break\n>>> them. This does not seem to be the case currently, but if this feature is\n>>> ever needed, an option should be added to download.pl instead of relying\n>>> on the hash being empty.\n>> Unfortunately this change breaks the make/foo/download feature,\n> Can you elaborate on this? It seems to work fine here:\n>\n> $ make package/dnsmasq/download V=s\n> make[1]: Entering directory '/lede/tmp/lede-project'\n> make[2]: Entering directory '/lede/tmp/lede-project/package/network/services/dnsmasq'\n> mkdir -p /lede/tmp/lede-project/dl\n> SHELL= flock /lede/tmp/lede-project/tmp/.dnsmasq-2.77.tar.xz.flock -c '\t/lede/tmp/lede-project/scripts/download.pl \"/lede/tmp/lede-project/dl\" \"dnsmasq-2.77.tar.xz\" \"6eac3b1c50ae25170e3ff8c96ddb55236cf45007633fdb8a35b1f3e02f5f8b8a\" \"\" \"http://thekelleys.org.uk/dnsmasq/\" '\n> + curl -f --connect-timeout 20 --retry 5 --location --insecure http://thekelleys.org.uk/dnsmasq/dnsmasq-2.77.tar.xz\n> % Total % Received % Xferd Average Speed Time Time Time Current\n> Dload Upload Total Spent Left Speed\n> 100 475k 100 475k 0 0 237k 0 0:00:02 0:00:02 --:--:-- 232k\n> make[2]: Leaving directory '/lede/tmp/lede-project/package/network/services/dnsmasq'\n> make[1]: Leaving directory '/lede/tmp/lede-project'\nMy bad. When we update a package, we bump the version in the Makefile\nand remove the current hash, then run \"make package/foo/dowload; make\npackage/foo/check FIXUP=1\". This downloads the tarbal for the new\nversion, and FIXUP writes its hash to the Makefile. This is what's\nbroken since the change.\n\nStijn","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"qNfDNJZm\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linux-ipv6.be header.i=@linux-ipv6.be\n\theader.b=\"CECkF+G0\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y0fkR1DHNz9ryQ\n\tfor ;\n\tMon, 25 Sep 2017 07:00:31 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dwE0f-0001E6-55; Sun, 24 Sep 2017 21:00:17 +0000","from mail.tintel.eu ([2001:41d0:8:1644:0:ff:fe5c:6a54])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dwE0F-00015j-4Q\n\tfor lede-dev@lists.infradead.org; Sun, 24 Sep 2017 20:59:53 +0000","from localhost (localhost [IPv6:::1])\n\tby mail.tintel.eu (Postfix) with ESMTP id 650914309611;\n\tSun, 24 Sep 2017 22:59:28 +0200 (CEST)","from mail.tintel.eu ([IPv6:::1])\n\tby localhost (mail.tintel.eu [IPv6:::1]) (amavisd-new, port 10032)\n\twith ESMTP id qkITgCuXHpmh; Sun, 24 Sep 2017 22:59:28 +0200 (CEST)","from localhost (localhost [IPv6:::1])\n\tby mail.tintel.eu (Postfix) with ESMTP id E884E430960F;\n\tSun, 24 Sep 2017 22:59:27 +0200 (CEST)","from mail.tintel.eu ([IPv6:::1])\n\tby localhost (mail.tintel.eu [IPv6:::1]) (amavisd-new, port 10026)\n\twith ESMTP id Y5hgvkmXznvs; Sun, 24 Sep 2017 22:59:27 +0200 (CEST)","from [IPv6:2001:67c:21bc:24::adb] (unknown\n\t[IPv6:2001:67c:21bc:24::adb]) (Authenticated sender: stijn@tintel.eu)\n\tby mail.tintel.eu (Postfix) with ESMTPSA id A69FB430932E;\n\tSun, 24 Sep 2017 22:59:27 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:Date:\n\tMessage-ID:From:References:To:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=r/o/H/qC2xL5a7D08dUIS1XHJXje+5MPRzW+2BoMh+o=;\n\tb=qNfDNJZmIVUrYK\n\t/FDHp4lxdQ1UEvD7WKJlyxEm95hikdPaiKDgMaJ+KjgGRPg7Ho3bt9P4BawkHlyQzY3hJlWfTocOh\n\tu5QveHByfVPkTnpo5IH5+pZL/bnIS75cnZcMS5oXgZNaWeHqjdaWskhonZpJLy8wco5z4NJprUT/P\n\tRz0Aw6pwvic4AL+bI1HAWKvAT1P2pb6JojsDveqZ5j0oAWsz1kJj2bbRKJKDURAMh074IqxsoF1Hb\n\t3vFHDv0HD6M+EHZ7CAxbybYv8oML/V/lH3M2kShrprHhMKoGP6jtzMoKx2/+SK+Y0r3R3rrLBLB1Q\n\twuvfXrE8bTRRBfOC6TZw==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-ipv6.be;\n\ts=502B7754-045F-11E5-BBC5-64595FD46BE8; t=1506286767;\n\tbh=bBmuIdK8MJ5N1zspixUPqzeDUHAwlcdP/1Pk82T4lg0=;\n\th=Subject:To:From:Message-ID:Date:MIME-Version:Content-Type:\n\tContent-Transfer-Encoding;\n\tb=CECkF+G0y/vbO/RFRJJNbRvi0co4hrsYCQ2U30EPYroQ7UvuI9NYDqosfKa3Rx+LG\n\tUcfdatDvtldtrAp0YxNE3kvx1LjrQfa61KSoeOBb/XROt+xiE/GFO2vLh1VlYDDNb5\n\tgofD2RvQbVz2A1jd8iPGdq6AUkHxoYVxMQhZDn2g="],"DKIM-Filter":"OpenDKIM Filter v2.9.2 mail.tintel.eu E884E430960F","X-Virus-Scanned":"amavisd-new at mail.tintel.eu","To":"Baptiste Jonglez ","References":"<20170903120129.2015-1-baptiste@bitsofnetworks.org>\n\t\n\t<20170924205705.GA27620@tuxmachine.polynome.dn42>","From":"Stijn Tintel ","Message-ID":"","Date":"Sun, 24 Sep 2017 23:59:26 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170924205705.GA27620@tuxmachine.polynome.dn42>","Content-Language":"en-GB","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170924_135951_683676_9CE6946B ","X-CRM114-Status":"UNSURE ( 8.53 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-1.8 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.8 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid","Subject":"Re: [LEDE-DEV] [PATCH] scripts/download.pl: fail loudly if provided\n\thash is unsupported","X-BeenThere":"lede-dev@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"lede-dev@lists.infradead.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Lede-dev\" ","Errors-To":"lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1774304,"web_url":"http://patchwork.ozlabs.org/comment/1774304/","msgid":"<20170924212050.GB27620@tuxmachine.polynome.dn42>","list_archive_url":null,"date":"2017-09-24T21:20:50","subject":"Re: [LEDE-DEV] [PATCH] scripts/download.pl: fail loudly if provided\n\thash is unsupported","submitter":{"id":67238,"url":"http://patchwork.ozlabs.org/api/people/67238/","name":"Baptiste Jonglez","email":"baptiste@bitsofnetworks.org"},"content":"On 24-09-17, Stijn Tintel wrote:\n> My bad. When we update a package, we bump the version in the Makefile\n> and remove the current hash, then run \"make package/foo/dowload; make\n> package/foo/check FIXUP=1\". This downloads the tarbal for the new\n> version, and FIXUP writes its hash to the Makefile. This is what's\n> broken since the change.\n\nOk, I see the issue now.\n\nAs mentioned in the commit message, we definitely should add an explicit\noption to download.pl to skip hash verification, and then implement\nsomething like this:\n\n $ make package/foo/download SKIPHASH=1\n\nWhat do you think?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"tNkIwZFD\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y0gC66Mm8z9s7f\n\tfor ;\n\tMon, 25 Sep 2017 07:21:54 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dwELL-0000JY-OE; Sun, 24 Sep 2017 21:21:39 +0000","from rezine.polyno.me ([193.33.56.138]\n\thelo=mails.bitsofnetworks.org)\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dwEKw-00007d-VZ\n\tfor lede-dev@lists.infradead.org; Sun, 24 Sep 2017 21:21:16 +0000","from [172.23.184.97] (helo=tuxmachine.polynome.dn42)\n\tby mails.bitsofnetworks.org with esmtps\n\t(TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89)\n\t(envelope-from )\n\tid 1dwEKZ-0003b6-C7; Sun, 24 Sep 2017 23:20:51 +0200"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc:\n\tList-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:\n\tSubject:In-Reply-To:MIME-Version:References:Message-ID:To:From:Date:Reply-To:\n\tContent-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=cGawbMz/1T9g1Vloa1OEwjxhyElRQR/hrybrsLrGZEo=;\n\tb=tNkIwZFD2wlTvF1yTzWH0lnAO\n\tCMntpyNEjLp7BeZ3KEGSuV5dcDvE1yKVK5r00DeKyzSVtKYTMJDzMpRYuFDXulUweVW9eYQcOiY4G\n\th6rI1m2n3g3t5ZSplW9FW1XQBqoizIoSx5U0iMsNHlCK+GGKMsOxFMlpaiuyLAXGhPYU/TMa+w7Tr\n\tNyBbcMM7MLMOTMAU9jdD2ACW+jSdjP50nDugnk3PtsxqhDzVT43NkXC1JXLetZ8mg1FhVI4Ldrybt\n\tw5yFhj6HOayqnbhRNpfYlTgLwaOUekKEOkCmzOQ3w0ItvTli9SsKYcyBQTa+gzM1/V5fr60KkZBV+\n\tFvgdZMhfg==;","Date":"Sun, 24 Sep 2017 23:20:50 +0200","From":"Baptiste Jonglez ","To":"Stijn Tintel ","Message-ID":"<20170924212050.GB27620@tuxmachine.polynome.dn42>","References":"<20170903120129.2015-1-baptiste@bitsofnetworks.org>\n\t\n\t<20170924205705.GA27620@tuxmachine.polynome.dn42>\n\t","MIME-Version":"1.0","In-Reply-To":"","User-Agent":"Mutt/1.5.24 (2015-08-30)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170924_142115_473820_E1DBF879 ","X-CRM114-Status":"UNSURE ( 6.60 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","Subject":"Re: [LEDE-DEV] [PATCH] scripts/download.pl: fail loudly if provided\n\thash is unsupported","X-BeenThere":"lede-dev@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"lede-dev@lists.infradead.org","Content-Type":"multipart/mixed;\n\tboundary=\"===============2380156179410675633==\"","Sender":"\"Lede-dev\" ","Errors-To":"lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1774815,"web_url":"http://patchwork.ozlabs.org/comment/1774815/","msgid":"<50f36064-b8ea-2dc5-9317-558bc4695806@linux-ipv6.be>","list_archive_url":null,"date":"2017-09-25T15:43:32","subject":"Re: [LEDE-DEV] [PATCH] scripts/download.pl: fail loudly if provided\n\thash is unsupported","submitter":{"id":22753,"url":"http://patchwork.ozlabs.org/api/people/22753/","name":"Stijn Tintel","email":"stijn@linux-ipv6.be"},"content":"On 25-09-17 00:20, Baptiste Jonglez wrote:\n> On 24-09-17, Stijn Tintel wrote:\n>> My bad. When we update a package, we bump the version in the Makefile\n>> and remove the current hash, then run \"make package/foo/dowload; make\n>> package/foo/check FIXUP=1\". This downloads the tarbal for the new\n>> version, and FIXUP writes its hash to the Makefile. This is what's\n>> broken since the change.\n> Ok, I see the issue now.\n>\n> As mentioned in the commit message, we definitely should add an explicit\n> option to download.pl to skip hash verification, and then implement\n> something like this:\n>\n> $ make package/foo/download SKIPHASH=1\n>\n> What do you think?\n\nWe were thinking in that direction on #lede-dev, not sure why we\ncouldn't agree. Let's wait a bit if anybody else chimes in?\n\nStijn","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"WhRRjqgx\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linux-ipv6.be header.i=@linux-ipv6.be\n\theader.b=\"nPmCtQvK\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y17g836hjz9sRq\n\tfor ;\n\tTue, 26 Sep 2017 01:44:20 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dwVYB-0003FW-80; Mon, 25 Sep 2017 15:44:03 +0000","from mail.tintel.eu ([54.36.12.13])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dwVY7-0003Bu-A2\n\tfor lede-dev@lists.infradead.org; Mon, 25 Sep 2017 15:44:01 +0000","from localhost (localhost [IPv6:::1])\n\tby mail.tintel.eu (Postfix) with ESMTP id C40A4434FC57;\n\tMon, 25 Sep 2017 17:43:35 +0200 (CEST)","from mail.tintel.eu ([IPv6:::1])\n\tby localhost (mail.tintel.eu [IPv6:::1]) (amavisd-new, port 10032)\n\twith ESMTP id hW-ftpJoQXF0; Mon, 25 Sep 2017 17:43:35 +0200 (CEST)","from localhost (localhost [IPv6:::1])\n\tby mail.tintel.eu (Postfix) with ESMTP id 2530E434FA55;\n\tMon, 25 Sep 2017 17:43:35 +0200 (CEST)","from mail.tintel.eu ([IPv6:::1])\n\tby localhost (mail.tintel.eu [IPv6:::1]) (amavisd-new, port 10026)\n\twith ESMTP id iSKSBwAJc8FZ; Mon, 25 Sep 2017 17:43:35 +0200 (CEST)","from [IPv6:2001:67c:21bc:24::adb] (unknown\n\t[IPv6:2001:67c:21bc:24::adb]) (Authenticated sender: stijn@tintel.eu)\n\tby mail.tintel.eu (Postfix) with ESMTPSA id D5BBD437CC7F;\n\tMon, 25 Sep 2017 17:43:34 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:Date:\n\tMessage-ID:From:References:To:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=tIHBdQ9KSyht6yq1zI1T2E1Gcz5m96nMGCFNoOAPzwY=;\n\tb=WhRRjqgxxtYjEB\n\tm7H3X2bDX2RhLFc0xvbG3CrZ8BgR0uphqhwRC4Xn9wEKqyf2E+Z3lGReH07GuJ57SAUOtw0tSu9O1\n\t2BmayCG0fQ3HV+b+8eoHt+toKENMOaE7+BjqcJNrydFs7TVMuKeB6LTNfHLhzVWCuvZontaEWnkKd\n\tUt0SXXl8N2J+eYEkAnFT7gTzxQMmUSeD69an+vy9H83Tl9qQQl1wM/l1OiqVs9BRXQF/1SGgN2AF5\n\tuMr/OYfeMFL2WflgzpZPZBUgpBRmXqPpLYVqbihR4YTOoYjOIPvs0MQUR06IwrooPAOE0ICTlntdD\n\t5O3urPaPlp7yQftJdZCg==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-ipv6.be;\n\ts=502B7754-045F-11E5-BBC5-64595FD46BE8; t=1506354215;\n\tbh=CXs9Y2o2ZHWeazxQk06pbS+z5iu30tU/kacLr25w0KM=;\n\th=Subject:To:From:Message-ID:Date:MIME-Version:Content-Type:\n\tContent-Transfer-Encoding;\n\tb=nPmCtQvKfMY5SIrG7vkLH5mYb6mONQq3NVAf4x/nYam+rIsFaBvnbDYPsO6ZxgdM+\n\twAN/3fAaIGR/eGABR2mXOUrMDYNuI4RP4ldorRfoZNPFEUUOBpU/Qu6GWGXh5a2TUo\n\tBuee2mmep2bvfQjCQsAa3tXJdkj8v2yg5017taR4="],"DKIM-Filter":"OpenDKIM Filter v2.9.2 mail.tintel.eu 2530E434FA55","X-Virus-Scanned":"amavisd-new at mail.tintel.eu","To":"Baptiste Jonglez ","References":"<20170903120129.2015-1-baptiste@bitsofnetworks.org>\n\t\n\t<20170924205705.GA27620@tuxmachine.polynome.dn42>\n\t\n\t<20170924212050.GB27620@tuxmachine.polynome.dn42>","From":"Stijn Tintel ","Message-ID":"<50f36064-b8ea-2dc5-9317-558bc4695806@linux-ipv6.be>","Date":"Mon, 25 Sep 2017 18:43:32 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170924212050.GB27620@tuxmachine.polynome.dn42>","Content-Language":"en-GB","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170925_084359_643874_9C43B44F ","X-CRM114-Status":"UNSURE ( 8.98 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-1.8 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.8 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid","Subject":"Re: [LEDE-DEV] [PATCH] scripts/download.pl: fail loudly if provided\n\thash is unsupported","X-BeenThere":"lede-dev@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"lede-dev@lists.infradead.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Lede-dev\" ","Errors-To":"lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1782280,"web_url":"http://patchwork.ozlabs.org/comment/1782280/","msgid":"","list_archive_url":null,"date":"2017-10-08T15:22:22","subject":"Re: [LEDE-DEV] [PATCH] scripts/download.pl: fail loudly if provided\n\thash is unsupported","submitter":{"id":22753,"url":"http://patchwork.ozlabs.org/api/people/22753/","name":"Stijn Tintel","email":"stijn@linux-ipv6.be"},"content":"On 25-09-17 18:43, Stijn Tintel wrote:\n> On 25-09-17 00:20, Baptiste Jonglez wrote:\n>> On 24-09-17, Stijn Tintel wrote:\n>>> My bad. When we update a package, we bump the version in the Makefile\n>>> and remove the current hash, then run \"make package/foo/dowload; make\n>>> package/foo/check FIXUP=1\". This downloads the tarbal for the new\n>>> version, and FIXUP writes its hash to the Makefile. This is what's\n>>> broken since the change.\n>> Ok, I see the issue now.\n>>\n>> As mentioned in the commit message, we definitely should add an explicit\n>> option to download.pl to skip hash verification, and then implement\n>> something like this:\n>>\n>> $ make package/foo/download SKIPHASH=1\n>>\n>> What do you think?\n> We were thinking in that direction on #lede-dev, not sure why we\n> couldn't agree. Let's wait a bit if anybody else chimes in?\nMaybe just send an RFC patch with the suggested change, as nobodoy seems\nto be responding.\n\nThanks,\nStijn","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"bOXCdbiU\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linux-ipv6.be header.i=@linux-ipv6.be\n\theader.b=\"NGy/xDDC\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y96Zt0DSNz9t3C\n\tfor ;\n\tMon, 9 Oct 2017 02:23:18 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e1DPo-0005x1-1N; Sun, 08 Oct 2017 15:22:52 +0000","from mail.tintel.eu ([54.36.12.13])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e1DPj-0005oT-5i\n\tfor lede-dev@lists.infradead.org; Sun, 08 Oct 2017 15:22:50 +0000","from localhost (localhost [IPv6:::1])\n\tby mail.tintel.eu (Postfix) with ESMTP id CE27F430933A;\n\tSun, 8 Oct 2017 17:22:23 +0200 (CEST)","from mail.tintel.eu ([IPv6:::1])\n\tby localhost (mail.tintel.eu [IPv6:::1]) (amavisd-new, port 10032)\n\twith ESMTP id vtFHLKYcdkyr; Sun, 8 Oct 2017 17:22:23 +0200 (CEST)","from localhost (localhost [IPv6:::1])\n\tby mail.tintel.eu (Postfix) with ESMTP id 206DB434FC5A;\n\tSun, 8 Oct 2017 17:22:23 +0200 (CEST)","from mail.tintel.eu ([IPv6:::1])\n\tby localhost (mail.tintel.eu [IPv6:::1]) (amavisd-new, port 10026)\n\twith ESMTP id JgAqM1I1BOQ3; Sun, 8 Oct 2017 17:22:23 +0200 (CEST)","from [IPv6:2001:67c:21bc:24:9955:964e:5514:dcdf] (unknown\n\t[IPv6:2001:67c:21bc:24:9955:964e:5514:dcdf])\n\t(Authenticated sender: stijn@tintel.eu)\n\tby mail.tintel.eu (Postfix) with ESMTPSA id B881B430933A;\n\tSun, 8 Oct 2017 17:22:22 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:Date:\n\tMessage-ID:References:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=o75hBJnKlj9Gs6d6z3GO1IH6UQ3nwQAbyARQDsXYiUY=;\n\tb=bOXCdbiUbyL8t/\n\tc4QIRw85FZvRs97ufWZLk/ZTBFmIYjo1nPdRp+4HCZXZEKlNsW3jNw5xg+s1H957K4T3HpZUwkf9W\n\tSFSOsWs1sPHkgI/kO3iz8sxMz7WwznIBFd487UwLRVEUjgkvGZV0gBIkednuzg+Vw8yYL4Op1XHtC\n\t5ipkQDh+49jNRIlL2uRW0Y3zm8scDj4RlHwCz0i7xuDERSEAU9yVItybXbo3EauFl5wFEA4H+ZWmX\n\tITXY16XXVmeufVDUmbQHVFNbiAerZbO95L+Dvp8kXil4c8hmhWjD8rM+yF3lVCpi+YfsyREfqbt0C\n\tO585b+EVT8+1fDAFaQ1Q==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-ipv6.be;\n\ts=502B7754-045F-11E5-BBC5-64595FD46BE8; t=1507476143;\n\tbh=oOgcHqL/dv4DKxR0HH3nCC4OGGLKS5kNomt8GdrSCEU=;\n\th=Subject:From:To:Message-ID:Date:MIME-Version:Content-Type:\n\tContent-Transfer-Encoding;\n\tb=NGy/xDDCgmmzoEAMtiiTSwNejoURFeYNVEJHKk1SOE+XLgUL4EpY6JAXtGPYBeS4b\n\tM2IYRiXZlh5S8UCrqvqVapByqMpOCKn+21+NVl5eWhxWkS3NNTQvt5pCXkpknBD9OR\n\tOpQ/IXNC1le3IyKmSqo2lkKJF8v/0eUWAqCvrbCY="],"DKIM-Filter":"OpenDKIM Filter v2.9.2 mail.tintel.eu 206DB434FC5A","X-Virus-Scanned":"amavisd-new at mail.tintel.eu","From":"Stijn Tintel ","To":"Baptiste Jonglez ","References":"<20170903120129.2015-1-baptiste@bitsofnetworks.org>\n\t\n\t<20170924205705.GA27620@tuxmachine.polynome.dn42>\n\t\n\t<20170924212050.GB27620@tuxmachine.polynome.dn42>\n\t<50f36064-b8ea-2dc5-9317-558bc4695806@linux-ipv6.be>","Message-ID":"","Date":"Sun, 8 Oct 2017 18:22:22 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<50f36064-b8ea-2dc5-9317-558bc4695806@linux-ipv6.be>","Content-Language":"en-GB","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171008_082247_513396_AB681EAC ","X-CRM114-Status":"UNSURE ( 9.07 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-1.8 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.8 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid","Subject":"Re: [LEDE-DEV] [PATCH] scripts/download.pl: fail loudly if provided\n\thash is unsupported","X-BeenThere":"lede-dev@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"lede-dev@lists.infradead.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Lede-dev\" ","Errors-To":"lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1787199,"web_url":"http://patchwork.ozlabs.org/comment/1787199/","msgid":"<20171016074433.GA26946@lud.polynome.dn42>","list_archive_url":null,"date":"2017-10-16T07:44:33","subject":"Re: [LEDE-DEV] [PATCH] scripts/download.pl: fail loudly if provided\n\thash is unsupported","submitter":{"id":67238,"url":"http://patchwork.ozlabs.org/api/people/67238/","name":"Baptiste Jonglez","email":"baptiste@bitsofnetworks.org"},"content":"On 08-10-17, Stijn Tintel wrote:\n> On 25-09-17 18:43, Stijn Tintel wrote:\n> > On 25-09-17 00:20, Baptiste Jonglez wrote:\n> >> On 24-09-17, Stijn Tintel wrote:\n> >>> My bad. When we update a package, we bump the version in the Makefile\n> >>> and remove the current hash, then run \"make package/foo/dowload; make\n> >>> package/foo/check FIXUP=1\". This downloads the tarbal for the new\n> >>> version, and FIXUP writes its hash to the Makefile. This is what's\n> >>> broken since the change.\n> >> Ok, I see the issue now.\n> >>\n> >> As mentioned in the commit message, we definitely should add an explicit\n> >> option to download.pl to skip hash verification, and then implement\n> >> something like this:\n> >>\n> >> $ make package/foo/download SKIPHASH=1\n> >>\n> >> What do you think?\n> > We were thinking in that direction on #lede-dev, not sure why we\n> > couldn't agree. Let's wait a bit if anybody else chimes in?\n\n> Maybe just send an RFC patch with the suggested change, as nobodoy seems\n> to be responding.\n\nYes, sorry for the delay, I will submit a patch in the coming days/weeks.\n\nBaptiste","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"eq/xhgvN\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yFr2k1w38z9t1t\n\tfor ;\n\tMon, 16 Oct 2017 18:45:18 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e405B-0003DY-QB; Mon, 16 Oct 2017 07:45:05 +0000","from rezine.polyno.me ([193.33.56.138]\n\thelo=mails.bitsofnetworks.org)\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e4052-0002WG-Ng\n\tfor lede-dev@lists.infradead.org; Mon, 16 Oct 2017 07:45:02 +0000","from [172.23.184.97] (helo=lud.polynome.dn42)\n\tby mails.bitsofnetworks.org with esmtps\n\t(TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89)\n\t(envelope-from )\n\tid 1e404h-00040C-19; Mon, 16 Oct 2017 09:44:35 +0200"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc:\n\tList-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:\n\tSubject:In-Reply-To:MIME-Version:References:Message-ID:To:From:Date:Reply-To:\n\tContent-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=Ww9ha0vLII9plY2ojHXCmCUQ4jm3UeRRhT7FpgK2aMg=;\n\tb=eq/xhgvNX1rH6DG7UaO8rrAXD\n\tG9u4b2qJUHYfzE3GPUTELuCG/IwczCGHjdtPgVLgvLD1UZ7DqTF7QiUv4vRp+hLu9MdJPgRSboWZc\n\tXJ8G+labN09olk+af7VNqUkDbUu9+6WHd1uLUoeZY5VfOValrZ0aIMwvgtaf1uGrOhd8v31OtlTdi\n\tVDhK36Er4vYtjZncaK6pQCb64YzBg/kXY4xsv89qir7Miy7rbs3Kem2MYregVAKoDtNS9hKGzYlPR\n\ttt7YqyYqukG2VOjVVTItva+sJ/HDRBFZ+M3xbVraGc7E6fdOeX4LTJe0GYp8j6Aw5SVjyAMSznu+U\n\tQf/J2BjvQ==;","Date":"Mon, 16 Oct 2017 09:44:33 +0200","From":"Baptiste Jonglez ","To":"Stijn Tintel ","Message-ID":"<20171016074433.GA26946@lud.polynome.dn42>","References":"<20170903120129.2015-1-baptiste@bitsofnetworks.org>\n\t\n\t<20170924205705.GA27620@tuxmachine.polynome.dn42>\n\t\n\t<20170924212050.GB27620@tuxmachine.polynome.dn42>\n\t<50f36064-b8ea-2dc5-9317-558bc4695806@linux-ipv6.be>\n\t","MIME-Version":"1.0","In-Reply-To":"","User-Agent":"Mutt/1.5.24 (2015-08-30)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171016_004457_116129_DB00A435 ","X-CRM114-Status":"GOOD ( 10.56 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","Subject":"Re: [LEDE-DEV] [PATCH] scripts/download.pl: fail loudly if provided\n\thash is unsupported","X-BeenThere":"lede-dev@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"lede-dev@lists.infradead.org","Content-Type":"multipart/mixed;\n\tboundary=\"===============0717747991229874587==\"","Sender":"\"Lede-dev\" ","Errors-To":"lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]