Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/809247/?format=api
{ "id": 809247, "url": "http://patchwork.ozlabs.org/api/patches/809247/?format=api", "web_url": "http://patchwork.ozlabs.org/project/buildroot/patch/585dda9412d61d550fc9c6fa76a29e7e878ceec0.1504432422.git.yann.morin.1998@free.fr/", "project": { "id": 27, "url": "http://patchwork.ozlabs.org/api/projects/27/?format=api", "name": "Buildroot development", "link_name": "buildroot", "list_id": "buildroot.buildroot.org", "list_email": "buildroot@buildroot.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<585dda9412d61d550fc9c6fa76a29e7e878ceec0.1504432422.git.yann.morin.1998@free.fr>", "list_archive_url": null, "date": "2017-09-03T09:53:50", "name": "[1/3] arch/mips: inverse the NaN logic", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "997f61ceb2509fff386c7ee73c653c02131e194f", "submitter": { "id": 13903, "url": "http://patchwork.ozlabs.org/api/people/13903/?format=api", "name": "Yann E. MORIN", "email": "yann.morin.1998@free.fr" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/buildroot/patch/585dda9412d61d550fc9c6fa76a29e7e878ceec0.1504432422.git.yann.morin.1998@free.fr/mbox/", "series": [ { "id": 1207, "url": "http://patchwork.ozlabs.org/api/series/1207/?format=api", "web_url": "http://patchwork.ozlabs.org/project/buildroot/list/?series=1207", "date": "2017-09-03T09:53:50", "name": "[1/3] arch/mips: inverse the NaN logic", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/1207/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/809247/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/809247/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<buildroot-bounces@busybox.net>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "buildroot@lists.busybox.net" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "buildroot@osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"liejOK8x\"; dkim-atps=neutral" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xlSx82jR8z9s76\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSun, 3 Sep 2017 19:54:04 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 7D5B786975;\n\tSun, 3 Sep 2017 09:54:01 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id qHWm2nw5pssj; Sun, 3 Sep 2017 09:54:00 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 1AB3B86931;\n\tSun, 3 Sep 2017 09:54:00 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id EC1891C41C7\n\tfor <buildroot@lists.busybox.net>;\n\tSun, 3 Sep 2017 09:53:58 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id DFAA527550\n\tfor <buildroot@lists.busybox.net>;\n\tSun, 3 Sep 2017 09:53:58 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id RcBTz+CszK0c for <buildroot@lists.busybox.net>;\n\tSun, 3 Sep 2017 09:53:58 +0000 (UTC)", "from mail-wm0-f65.google.com (mail-wm0-f65.google.com\n\t[74.125.82.65])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 0A96723262\n\tfor <buildroot@buildroot.org>; Sun, 3 Sep 2017 09:53:58 +0000 (UTC)", "by mail-wm0-f65.google.com with SMTP id l19so3887466wmi.1\n\tfor <buildroot@buildroot.org>; Sun, 03 Sep 2017 02:53:57 -0700 (PDT)", "from localhost.localdomain\n\t(2a01cb0886107300d49b0f6dfb1eb067.ipv6.abo.wanadoo.fr.\n\t[2a01:cb08:8610:7300:d49b:f6d:fb1e:b067])\n\tby smtp.gmail.com with ESMTPSA id\n\tw16sm3777451wmw.2.2017.09.03.02.53.55\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 03 Sep 2017 02:53:55 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=ph9ZXz+Kvc89rTeTKzrO+YrwKHVK1JlPuPDcY2EmRzQ=;\n\tb=liejOK8xj4kpFlGNYzATN429X4smf5eG85vp3iAi28WIcGvOdkRSbuHRnACWds41Wo\n\txke87gGKAliDnZo2FAB97VOrg3F/v44jmj9mj7a1Tsoi9LclfFkxzNW/2SHYJ573Mp5/\n\thpLGuuCLA31xnTDrs7IcXaNOoqWjpcjFE1mCzO+RLdcT/6rWsO4J8ZnMaU4mU+8imW7F\n\tDRCInE6c6FaETJt0BLwDP2w5Tsk69gXKPzcxI7yG7gfvcn1I41QVhGbTLWlByYBsOiuB\n\t8nTT3r6nRDxA9lowHppksNeZGZtX5d9XI6qO4J5N3Hc+c4l7TnLxEuE9HP//9lTfTeP1\n\tnYyQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references;\n\tbh=ph9ZXz+Kvc89rTeTKzrO+YrwKHVK1JlPuPDcY2EmRzQ=;\n\tb=ZeYZ1Rrc9zarzJqrs9EilHW73I7QwfdKfgplj6a3c1rctXfZV0c9vJB6H1komprhue\n\tuLZ1eoMmOu+Iwob6zo9gIiTYfq9uxAqzBxFTDg0V5tYkxLj3FqXWAE3rzLXQEc7mjHIK\n\t42ffs+asqeWP9pY2XdNUU5IpDmeiQpQL2Nru5m/nJ5hFv/NjVF7F+WocIldSx4WLWofr\n\t6Xf/W3Ivs+KpeJFYwVYnBpmCe3YEXp9NMWccPHjpCEhKqynApmpnE4tDpmtjq7HmhZwM\n\txVe/E76bZ2+z4QByNeQrh/2mM/c1SAEdtFM5r2lYQkfZiCdXWW0LhfCRO/TG3hixHFsi\n\t6osA==", "X-Gm-Message-State": "AHPjjUg5N3hg/0NenhRe66Ch05ikiEhMc3NxcMlJFjJd8WkwCnalfQc9\n\tbcrhIaMdF3ycgRly", "X-Google-Smtp-Source": "ADKCNb6BSzMqcII0x5a1HoRR3He2+oHeIaP0YdHtQ7297JqN4iX+rscJiz3OEe5QD2LSjeDkv/iHiA==", "X-Received": "by 10.28.232.70 with SMTP id f67mr2407846wmh.144.1504432436290; \n\tSun, 03 Sep 2017 02:53:56 -0700 (PDT)", "From": "\"Yann E. MORIN\" <yann.morin.1998@free.fr>", "To": "buildroot@buildroot.org", "Date": "Sun, 3 Sep 2017 11:53:50 +0200", "Message-Id": "<585dda9412d61d550fc9c6fa76a29e7e878ceec0.1504432422.git.yann.morin.1998@free.fr>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": "<cover.1504432422.git.yann.morin.1998@free.fr>", "References": "<cover.1504432422.git.yann.morin.1998@free.fr>", "Cc": "Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,\n\t\"Yann E. MORIN\" <yann.morin.1998@free.fr>,\n\tVicente Olivert Riera <Vincent.Riera@imgtec.com>", "Subject": "[Buildroot] [PATCH 1/3] arch/mips: inverse the NaN logic", "X-BeenThere": "buildroot@busybox.net", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Discussion and development of buildroot <buildroot.busybox.net>", "List-Unsubscribe": "<http://lists.busybox.net/mailman/options/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=unsubscribe>", "List-Archive": "<http://lists.busybox.net/pipermail/buildroot/>", "List-Post": "<mailto:buildroot@busybox.net>", "List-Help": "<mailto:buildroot-request@busybox.net?subject=help>", "List-Subscribe": "<http://lists.busybox.net/mailman/listinfo/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "buildroot-bounces@busybox.net", "Sender": "\"buildroot\" <buildroot-bounces@busybox.net>" }, "content": "Currentlym the possibility to choose the NaN encoding is conditional to\nhaving a sufficiently recent gcc version.\n\nWhich means that the architecture selection depends on the gcc version.\n\nBut that's opposite to what we've always done in Buildroot: the software\nversions are conditional to the architecture options. There is nothing\nwe can do about the hardware: it is there, we can't change it, while we\ncan restrict ourselves to using software that is working on said\nhardware.\n\nThus, we inverse the logic, to move the condition onto the software\nside: whenever NaN-2008 are selected, we restrict the toolchain\nselection to at least a gcc-4.9.\n\nBut now, the option with the NaN type is always set, so we must enclose\nthe code in gcc.mk inside a HAS_NAN_OPTION condition, as is already done\nfor the external toolchain case.\n\nSigned-off-by: \"Yann E. MORIN\" <yann.morin.1998@free.fr>\nCc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>\nCc: Vicente Olivert Riera <Vincent.Riera@imgtec.com>\n---\n arch/Config.in.mips | 2 +-\n package/gcc/gcc.mk | 2 ++\n 2 files changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/arch/Config.in.mips b/arch/Config.in.mips\nindex c08b2a2968..13d1a477e6 100644\n--- a/arch/Config.in.mips\n+++ b/arch/Config.in.mips\n@@ -176,10 +176,10 @@ config BR2_MIPS_NAN_LEGACY\n \n config BR2_MIPS_NAN_2008\n \tbool\n+\tselect BR2_ARCH_NEEDS_GCC_AT_LEAST_4_9\n \n choice\n \tprompt \"Target NaN\"\n-\tdepends on BR2_TOOLCHAIN_HAS_MNAN_OPTION\n \tdepends on BR2_mips_32r5 || BR2_mips_64r5\n \tdefault BR2_MIPS_ENABLE_NAN_2008\n \thelp\ndiff --git a/package/gcc/gcc.mk b/package/gcc/gcc.mk\nindex 49ccccf56f..d45b6d7a06 100644\n--- a/package/gcc/gcc.mk\n+++ b/package/gcc/gcc.mk\n@@ -207,9 +207,11 @@ endif\n ifneq ($(call qstrip,$(BR2_GCC_TARGET_ABI)),)\n HOST_GCC_COMMON_CONF_OPTS += --with-abi=$(BR2_GCC_TARGET_ABI)\n endif\n+ifeq ($(BR2_TOOLCHAIN_HAS_MNAN_OPTION),y)\n ifneq ($(call qstrip,$(BR2_GCC_TARGET_NAN)),)\n HOST_GCC_COMMON_CONF_OPTS += --with-nan=$(BR2_GCC_TARGET_NAN)\n endif\n+endif\n ifneq ($(call qstrip,$(BR2_GCC_TARGET_FP32_MODE)),)\n HOST_GCC_COMMON_CONF_OPTS += --with-fp-32=$(BR2_GCC_TARGET_FP32_MODE)\n endif\n", "prefixes": [ "1/3" ] }