[{"id":1782059,"web_url":"http://patchwork.ozlabs.org/comment/1782059/","msgid":"<93faf8c9-2223-3305-308c-6da56200a61d@gmail.com>","list_archive_url":null,"date":"2017-10-07T10:18:29","subject":"Re: [Buildroot] [PATCH 1/3] arch/mips: inverse the NaN logic","submitter":{"id":67942,"url":"http://patchwork.ozlabs.org/api/people/67942/","name":"Romain Naour","email":"romain.naour@gmail.com"},"content":"Yann, All,\n\nLe 03/09/2017 à 11:53, Yann E. MORIN a écrit :\n> Currentlym the possibility to choose the NaN encoding is conditional to\n> having a sufficiently recent gcc version.\n> \n> Which means that the architecture selection depends on the gcc version.\n> \n> But that's opposite to what we've always done in Buildroot: the software\n> versions are conditional to the architecture options. There is nothing\n> we can do about the hardware: it is there, we can't change it, while we\n> can restrict ourselves to using software that is working on said\n> hardware.\n> \n> Thus, we inverse the logic, to move the condition onto the software\n> side: whenever NaN-2008 are selected, we restrict the toolchain\n> selection to at least a gcc-4.9.\n> \n> But now, the option with the NaN type is always set, so we must enclose\n> the code in gcc.mk inside a HAS_NAN_OPTION condition, as is already done\n> for the external toolchain case.\n> \n> Signed-off-by: \"Yann E. MORIN\" \n> Cc: Thomas Petazzoni \n> Cc: Vicente Olivert Riera \n> ---\n> arch/Config.in.mips | 2 +-\n> package/gcc/gcc.mk | 2 ++\n> 2 files changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/arch/Config.in.mips b/arch/Config.in.mips\n> index c08b2a2968..13d1a477e6 100644\n> --- a/arch/Config.in.mips\n> +++ b/arch/Config.in.mips\n> @@ -176,10 +176,10 @@ config BR2_MIPS_NAN_LEGACY\n> \n> config BR2_MIPS_NAN_2008\n> \tbool\n> +\tselect BR2_ARCH_NEEDS_GCC_AT_LEAST_4_9\n\nThis series require the previous series \"arch: some require a minimal gcc\nversion\" adding this option.\n\nBest regards,\nRomain\n\n> \n> choice\n> \tprompt \"Target NaN\"\n> -\tdepends on BR2_TOOLCHAIN_HAS_MNAN_OPTION\n> \tdepends on BR2_mips_32r5 || BR2_mips_64r5\n> \tdefault BR2_MIPS_ENABLE_NAN_2008\n> \thelp\n> diff --git a/package/gcc/gcc.mk b/package/gcc/gcc.mk\n> index 49ccccf56f..d45b6d7a06 100644\n> --- a/package/gcc/gcc.mk\n> +++ b/package/gcc/gcc.mk\n> @@ -207,9 +207,11 @@ endif\n> ifneq ($(call qstrip,$(BR2_GCC_TARGET_ABI)),)\n> HOST_GCC_COMMON_CONF_OPTS += --with-abi=$(BR2_GCC_TARGET_ABI)\n> endif\n> +ifeq ($(BR2_TOOLCHAIN_HAS_MNAN_OPTION),y)\n> ifneq ($(call qstrip,$(BR2_GCC_TARGET_NAN)),)\n> HOST_GCC_COMMON_CONF_OPTS += --with-nan=$(BR2_GCC_TARGET_NAN)\n> endif\n> +endif\n> ifneq ($(call qstrip,$(BR2_GCC_TARGET_FP32_MODE)),)\n> HOST_GCC_COMMON_CONF_OPTS += --with-fp-32=$(BR2_GCC_TARGET_FP32_MODE)\n> endif\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"jnfGXZU3\"; dkim-atps=neutral"],"Received":["from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y8Msq0Q3wz9t7N\n\tfor ;\n\tSat, 7 Oct 2017 21:18:39 +1100 (AEDT)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 1B1F32E24F;\n\tSat, 7 Oct 2017 10:18:21 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id OuwezUw6N9mk; Sat, 7 Oct 2017 10:18:19 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id BE7B022E53;\n\tSat, 7 Oct 2017 10:18:19 +0000 (UTC)","from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 020A21C080F\n\tfor ;\n\tSat, 7 Oct 2017 10:18:33 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id F153489473\n\tfor ;\n\tSat, 7 Oct 2017 10:18:32 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ScMPWjnXmWJh for ;\n\tSat, 7 Oct 2017 10:18:32 +0000 (UTC)","from mail-wm0-f67.google.com (mail-wm0-f67.google.com\n\t[74.125.82.67])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 36ED38946D\n\tfor ; Sat, 7 Oct 2017 10:18:32 +0000 (UTC)","by mail-wm0-f67.google.com with SMTP id l10so11062639wmg.1\n\tfor ; Sat, 07 Oct 2017 03:18:32 -0700 (PDT)","from ?IPv6:2a01:e35:1391:67d0:e6f9:2d2f:1a1e:79bf?\n\t([2a01:e35:1391:67d0:e6f9:2d2f:1a1e:79bf])\n\tby smtp.gmail.com with ESMTPSA id\n\tk57sm853645eda.53.2017.10.07.03.18.29\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSat, 07 Oct 2017 03:18:30 -0700 (PDT)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=RIKqvNkQLjqy8fGAOK9UgF2Q7LXqmuIiHEoWHIZxD6w=;\n\tb=jnfGXZU3JBJs25CZcqOFMLzHswHd6WI8+bvau7Vm03RgabzfjOTFhb4OJ0kr5AReff\n\tSP24oKjNFirXcE612VD7WkMiXiFoD1zmDV+diugOTEVQwb/rfB0DFIsTwCbSByefKJyw\n\tHroPokL1WRQ2Z4DRVOl06JMF1SZCD2g9VhWjYsKFafegjwafWvxKXEUta7JrS9YbISB+\n\t2iSu8UxkUjXxcuDa1o4T8/4gJero0EEu53gSJeYqm9+pt2B5N1+nenHFSbhcL5fn4vZA\n\tEsHYWeQF5Ir1iLRLDhxYa1+2aMrVCOoGMh9YOqbsAHqTIr8eVap3VRcWaFYUNDbHVT1R\n\tgjAg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=RIKqvNkQLjqy8fGAOK9UgF2Q7LXqmuIiHEoWHIZxD6w=;\n\tb=RdiO6hvK+Su7SWOZifZ15f06fubKnfoyiB2Z9nDJkZTkxlZCfheZsAnB7DVOh8GB9p\n\ttUKADVLX1F4SxmTYvD86U/EyjbvoZIVx4vv9THAiWxffhTFGqxUpfjJ/ZygXfulYQxRP\n\tTF4i+OsDYfzSwIHQOy/X+OIg49Ao9bKsTiI6n83jRVU/s2LogzXjgM56I+hT0sQEdOe9\n\tgo8LBfstPnICNG9iJCrOcc6OTwcVtBweOxTgjlNFoGeKHtHzsp4DSwPC5+xeXU0CAOqq\n\tm/W7ghNOlI4KveWX3vMprunVloGb79GQXAarsTLdOoDN9WVSxp3WeXMXhZ0sn+X+q6xi\n\t5Ofg==","X-Gm-Message-State":"AMCzsaVMOttpKh1dbDm8VxyeqVm5N2Qi2NiIqyPf+K6KJLWhDyPF41W6\n\tSwMiKxch8PE8hsPfzmc3Rdc=","X-Google-Smtp-Source":"AOwi7QDiu6zZOGPBigauJN6ukUTN3UDL787g3gey4FtVZ7xR0EClJJVoyfbIjZkizOmGIZr5oNDBcA==","X-Received":"by 10.80.132.101 with SMTP id 92mr6688612edp.165.1507371510680; \n\tSat, 07 Oct 2017 03:18:30 -0700 (PDT)","To":"\"Yann E. MORIN\" , buildroot@buildroot.org","References":"\n\t<585dda9412d61d550fc9c6fa76a29e7e878ceec0.1504432422.git.yann.morin.1998@free.fr>","From":"Romain Naour ","Message-ID":"<93faf8c9-2223-3305-308c-6da56200a61d@gmail.com>","Date":"Sat, 7 Oct 2017 12:18:29 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<585dda9412d61d550fc9c6fa76a29e7e878ceec0.1504432422.git.yann.morin.1998@free.fr>","Content-Language":"en-US","Cc":"Thomas Petazzoni ,\n\tVicente Olivert Riera ","Subject":"Re: [Buildroot] [PATCH 1/3] arch/mips: inverse the NaN logic","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}},{"id":1782089,"web_url":"http://patchwork.ozlabs.org/comment/1782089/","msgid":"<20171007122233.GH21901@scaer>","list_archive_url":null,"date":"2017-10-07T12:22:33","subject":"Re: [Buildroot] [PATCH 1/3] arch/mips: inverse the NaN logic","submitter":{"id":13903,"url":"http://patchwork.ozlabs.org/api/people/13903/","name":"Yann E. MORIN","email":"yann.morin.1998@free.fr"},"content":"Romain, All,\n\nOn 2017-10-07 12:18 +0200, Romain Naour spake thusly:\n> Le 03/09/2017 à 11:53, Yann E. MORIN a écrit :\n> > Currentlym the possibility to choose the NaN encoding is conditional to\n> > having a sufficiently recent gcc version.\n> > \n> > Which means that the architecture selection depends on the gcc version.\n> > \n> > But that's opposite to what we've always done in Buildroot: the software\n> > versions are conditional to the architecture options. There is nothing\n> > we can do about the hardware: it is there, we can't change it, while we\n> > can restrict ourselves to using software that is working on said\n> > hardware.\n> > \n> > Thus, we inverse the logic, to move the condition onto the software\n> > side: whenever NaN-2008 are selected, we restrict the toolchain\n> > selection to at least a gcc-4.9.\n> > \n> > But now, the option with the NaN type is always set, so we must enclose\n> > the code in gcc.mk inside a HAS_NAN_OPTION condition, as is already done\n> > for the external toolchain case.\n> > \n> > Signed-off-by: \"Yann E. MORIN\" \n> > Cc: Thomas Petazzoni \n> > Cc: Vicente Olivert Riera \n> > ---\n> > arch/Config.in.mips | 2 +-\n> > package/gcc/gcc.mk | 2 ++\n> > 2 files changed, 3 insertions(+), 1 deletion(-)\n> > \n> > diff --git a/arch/Config.in.mips b/arch/Config.in.mips\n> > index c08b2a2968..13d1a477e6 100644\n> > --- a/arch/Config.in.mips\n> > +++ b/arch/Config.in.mips\n> > @@ -176,10 +176,10 @@ config BR2_MIPS_NAN_LEGACY\n> > \n> > config BR2_MIPS_NAN_2008\n> > \tbool\n> > +\tselect BR2_ARCH_NEEDS_GCC_AT_LEAST_4_9\n> \n> This series require the previous series \"arch: some require a minimal gcc\n> version\" adding this option.\n\nYes, that's why the four series were replies one to the previous, so that\nthey are correctly threaded in your MUA. As long as you use a decent MUA,\nthat is. ;-]\n\nRegards,\nYann E. MORIN.\n\n> Best regards,\n> Romain\n> \n> > \n> > choice\n> > \tprompt \"Target NaN\"\n> > -\tdepends on BR2_TOOLCHAIN_HAS_MNAN_OPTION\n> > \tdepends on BR2_mips_32r5 || BR2_mips_64r5\n> > \tdefault BR2_MIPS_ENABLE_NAN_2008\n> > \thelp\n> > diff --git a/package/gcc/gcc.mk b/package/gcc/gcc.mk\n> > index 49ccccf56f..d45b6d7a06 100644\n> > --- a/package/gcc/gcc.mk\n> > +++ b/package/gcc/gcc.mk\n> > @@ -207,9 +207,11 @@ endif\n> > ifneq ($(call qstrip,$(BR2_GCC_TARGET_ABI)),)\n> > HOST_GCC_COMMON_CONF_OPTS += --with-abi=$(BR2_GCC_TARGET_ABI)\n> > endif\n> > +ifeq ($(BR2_TOOLCHAIN_HAS_MNAN_OPTION),y)\n> > ifneq ($(call qstrip,$(BR2_GCC_TARGET_NAN)),)\n> > HOST_GCC_COMMON_CONF_OPTS += --with-nan=$(BR2_GCC_TARGET_NAN)\n> > endif\n> > +endif\n> > ifneq ($(call qstrip,$(BR2_GCC_TARGET_FP32_MODE)),)\n> > HOST_GCC_COMMON_CONF_OPTS += --with-fp-32=$(BR2_GCC_TARGET_FP32_MODE)\n> > endif\n> > \n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Hoas+xD7\"; dkim-atps=neutral"],"Received":["from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y8Qd10LjYz9t61\n\tfor ;\n\tSat, 7 Oct 2017 23:22:44 +1100 (AEDT)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 3C4308871B;\n\tSat, 7 Oct 2017 12:22:42 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id KSEPTaqE_u12; Sat, 7 Oct 2017 12:22:40 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id A7921886E7;\n\tSat, 7 Oct 2017 12:22:40 +0000 (UTC)","from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 5B5641C03E7\n\tfor ;\n\tSat, 7 Oct 2017 12:22:39 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 37D082FA85\n\tfor ;\n\tSat, 7 Oct 2017 12:22:39 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id xI-KKPRBSlUh for ;\n\tSat, 7 Oct 2017 12:22:38 +0000 (UTC)","from mail-wm0-f68.google.com (mail-wm0-f68.google.com\n\t[74.125.82.68])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 429482660B\n\tfor ; Sat, 7 Oct 2017 12:22:38 +0000 (UTC)","by mail-wm0-f68.google.com with SMTP id l10so11357219wmg.1\n\tfor ; Sat, 07 Oct 2017 05:22:38 -0700 (PDT)","from ymorin.is-a-geek.org\n\t(2a01cb0886107300659354221a390fcc.ipv6.abo.wanadoo.fr.\n\t[2a01:cb08:8610:7300:6593:5422:1a39:fcc])\n\tby smtp.gmail.com with ESMTPSA id\n\t61sm1148754wrg.58.2017.10.07.05.22.33\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tSat, 07 Oct 2017 05:22:35 -0700 (PDT)","by ymorin.is-a-geek.org (sSMTP sendmail emulation);\n\tSat, 07 Oct 2017 14:22:33 +0200"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=wuLqLJqtrvRS8p21IoaKGmgcX3HQ93fgLQIveHiyXp4=;\n\tb=Hoas+xD7eETvbFCpEh1iwO/XzWsFmtINna99c7ztbvcWepG7tadxko2Xvq8xX1dtEr\n\tDgDiE8f0g7KMSmD2wvdvjVj1c/j44P4nAnOxhlqa1uPlPTCt1PSFMBYgAuveyeBtzpMZ\n\t5kjAUNkQ4gr6zOFYgWMQDcGXOm+Gpj2PUeFNWu5I02BFnUN+RkxvEyUGazrQrEAW0Ihh\n\t7uJ2i/KsZ3xeGw2Yb8ywYf7SprFpWN2wtGsnoKxIgpOfM12484/MO0Voq71L7U29Md09\n\tzU+H33w2lZJbJGW+qT0Icf+I7qRQx5Je5OU6LSiJ8p9sF93lZ+MAgHxYFl1P3l+HxCU5\n\tgs2A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:date:from:to:cc:subject:message-id\n\t:references:mime-version:content-disposition\n\t:content-transfer-encoding:in-reply-to:user-agent;\n\tbh=wuLqLJqtrvRS8p21IoaKGmgcX3HQ93fgLQIveHiyXp4=;\n\tb=sRurGoUGu/XVm/MEJVO2lrX0OrGvczeE26TX1JRKC6dN2+4EC+sBX+WT4ZrfhjGFdp\n\tsSII6PMQWtgJlspXqL9DZy7C17WHNAqgLQk8uwzibvnTtxwt0w5YmsO9TuwYGvBywtWN\n\tji/FL4ygCvo7AOsEU7jWH3Q3M+mgOJLLfhiuY8skFvybyKgGnchKto+geY9YIThbJgJ2\n\tftfxmLDzfVC/YJzFLY7oDF3CvW7dqkhYs9nyTPJtt7u6kmhK9/xJcnbgvB0HLDx2ek5h\n\t/LuEbLYlpMJr500cDyUS2uTflGO81jbHCBEZwmpiK2/7ntcdKF7tXTH8CdJ+7iPCDLem\n\tdY2A==","X-Gm-Message-State":"AMCzsaWQVScA7CJplkHSj/HztvWZz4jR3XrdwgrJM1UIaW6hAPZnbjy5\n\toNWVD4MyzaBOjmIgtYK0Lvo1XA==","X-Google-Smtp-Source":"AOwi7QAB2o9UyqfvoJa2sU/IW2Tsk43C5lODuqkoT2E/I/nRf1bEQU+pXHWwwB6mMohl38Jb2DNyFQ==","X-Received":"by 10.223.176.199 with SMTP id j7mr5027267wra.58.1507378956308; \n\tSat, 07 Oct 2017 05:22:36 -0700 (PDT)","Date":"Sat, 7 Oct 2017 14:22:33 +0200","From":"\"Yann E. MORIN\" ","To":"Romain Naour ","Message-ID":"<20171007122233.GH21901@scaer>","References":"\n\t<585dda9412d61d550fc9c6fa76a29e7e878ceec0.1504432422.git.yann.morin.1998@free.fr>\n\t<93faf8c9-2223-3305-308c-6da56200a61d@gmail.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<93faf8c9-2223-3305-308c-6da56200a61d@gmail.com>","User-Agent":"Mutt/1.5.22 (2013-10-16)","Cc":"Thomas Petazzoni ,\n\tVicente Olivert Riera , buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH 1/3] arch/mips: inverse the NaN logic","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}},{"id":1782158,"web_url":"http://patchwork.ozlabs.org/comment/1782158/","msgid":"<7d5da0e6-ec34-483f-631b-c59f21b82ec4@gmail.com>","list_archive_url":null,"date":"2017-10-07T18:43:33","subject":"Re: [Buildroot] [PATCH 1/3] arch/mips: inverse the NaN logic","submitter":{"id":67942,"url":"http://patchwork.ozlabs.org/api/people/67942/","name":"Romain Naour","email":"romain.naour@gmail.com"},"content":"Yann, All,\n\nLe 07/10/2017 à 14:22, Yann E. MORIN a écrit :\n> Romain, All,\n> \n> On 2017-10-07 12:18 +0200, Romain Naour spake thusly:\n>> Le 03/09/2017 à 11:53, Yann E. MORIN a écrit :\n>>> Currentlym the possibility to choose the NaN encoding is conditional to\n>>> having a sufficiently recent gcc version.\n>>>\n>>> Which means that the architecture selection depends on the gcc version.\n>>>\n>>> But that's opposite to what we've always done in Buildroot: the software\n>>> versions are conditional to the architecture options. There is nothing\n>>> we can do about the hardware: it is there, we can't change it, while we\n>>> can restrict ourselves to using software that is working on said\n>>> hardware.\n>>>\n>>> Thus, we inverse the logic, to move the condition onto the software\n>>> side: whenever NaN-2008 are selected, we restrict the toolchain\n>>> selection to at least a gcc-4.9.\n>>>\n>>> But now, the option with the NaN type is always set, so we must enclose\n>>> the code in gcc.mk inside a HAS_NAN_OPTION condition, as is already done\n>>> for the external toolchain case.\n>>>\n>>> Signed-off-by: \"Yann E. MORIN\" \n>>> Cc: Thomas Petazzoni \n>>> Cc: Vicente Olivert Riera \n>>> ---\n>>> arch/Config.in.mips | 2 +-\n>>> package/gcc/gcc.mk | 2 ++\n>>> 2 files changed, 3 insertions(+), 1 deletion(-)\n>>>\n>>> diff --git a/arch/Config.in.mips b/arch/Config.in.mips\n>>> index c08b2a2968..13d1a477e6 100644\n>>> --- a/arch/Config.in.mips\n>>> +++ b/arch/Config.in.mips\n>>> @@ -176,10 +176,10 @@ config BR2_MIPS_NAN_LEGACY\n>>> \n>>> config BR2_MIPS_NAN_2008\n>>> \tbool\n>>> +\tselect BR2_ARCH_NEEDS_GCC_AT_LEAST_4_9\n>>\n>> This series require the previous series \"arch: some require a minimal gcc\n>> version\" adding this option.\n> \n> Yes, that's why the four series were replies one to the previous, so that\n> they are correctly threaded in your MUA. As long as you use a decent MUA,\n> that is. ;-]\n\nI'm only looking at the patchwork web interface and git pwc :p\n\nBest regards,\nRomain\n\n> \n> Regards,\n> Yann E. MORIN.\n> \n>> Best regards,\n>> Romain\n>>\n>>> \n>>> choice\n>>> \tprompt \"Target NaN\"\n>>> -\tdepends on BR2_TOOLCHAIN_HAS_MNAN_OPTION\n>>> \tdepends on BR2_mips_32r5 || BR2_mips_64r5\n>>> \tdefault BR2_MIPS_ENABLE_NAN_2008\n>>> \thelp\n>>> diff --git a/package/gcc/gcc.mk b/package/gcc/gcc.mk\n>>> index 49ccccf56f..d45b6d7a06 100644\n>>> --- a/package/gcc/gcc.mk\n>>> +++ b/package/gcc/gcc.mk\n>>> @@ -207,9 +207,11 @@ endif\n>>> ifneq ($(call qstrip,$(BR2_GCC_TARGET_ABI)),)\n>>> HOST_GCC_COMMON_CONF_OPTS += --with-abi=$(BR2_GCC_TARGET_ABI)\n>>> endif\n>>> +ifeq ($(BR2_TOOLCHAIN_HAS_MNAN_OPTION),y)\n>>> ifneq ($(call qstrip,$(BR2_GCC_TARGET_NAN)),)\n>>> HOST_GCC_COMMON_CONF_OPTS += --with-nan=$(BR2_GCC_TARGET_NAN)\n>>> endif\n>>> +endif\n>>> ifneq ($(call qstrip,$(BR2_GCC_TARGET_FP32_MODE)),)\n>>> HOST_GCC_COMMON_CONF_OPTS += --with-fp-32=$(BR2_GCC_TARGET_FP32_MODE)\n>>> endif\n>>>\n>>\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"QXecu3jx\"; dkim-atps=neutral"],"Received":["from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y8b4f2ZXyz9t3n\n\tfor ;\n\tSun, 8 Oct 2017 05:43:44 +1100 (AEDT)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id DD30086FD3;\n\tSat, 7 Oct 2017 18:43:40 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id jAB7_1ecNue6; Sat, 7 Oct 2017 18:43:39 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 294DA86D10;\n\tSat, 7 Oct 2017 18:43:39 +0000 (UTC)","from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id D2FFC1C24A1\n\tfor ;\n\tSat, 7 Oct 2017 18:43:37 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id B94FD87DCC\n\tfor ;\n\tSat, 7 Oct 2017 18:43:37 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Oi2US-by0iGZ for ;\n\tSat, 7 Oct 2017 18:43:37 +0000 (UTC)","from mail-wm0-f67.google.com (mail-wm0-f67.google.com\n\t[74.125.82.67])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id E1E18872FF\n\tfor ; Sat, 7 Oct 2017 18:43:36 +0000 (UTC)","by mail-wm0-f67.google.com with SMTP id r68so2749786wmr.4\n\tfor ; Sat, 07 Oct 2017 11:43:36 -0700 (PDT)","from ?IPv6:2a01:e35:1391:67d0:e6f9:2d2f:1a1e:79bf?\n\t([2a01:e35:1391:67d0:e6f9:2d2f:1a1e:79bf])\n\tby smtp.gmail.com with ESMTPSA id\n\tp20sm4434674wma.0.2017.10.07.11.43.34\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSat, 07 Oct 2017 11:43:34 -0700 (PDT)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=L6wUelOXwJyx1XPH2K2pBOcrfkANODrdEJz0GnuiyjE=;\n\tb=QXecu3jxgxxoNvNOOPc318e51wolbg2e9p0mLe+oDHuthD5Hw5rXksnJzPRVOHQ8q/\n\tbk+aQut7APs1ckP880cXSOKwXedxSoDk5NwwcBmqsDiIJA7lHRmttmZovDVJowuS5a0+\n\tjE5IEuh+CfLeCufOYuKgxFWlwHuQNH5FHdqrBDQYrT/7qWpXWWie6cOEezfjSifvmHxO\n\txwgcR0zb5C97reBrNdgU+40uWGuYK+Be6IBlbXRM8eGvUUr8T8B4SW6BOMLKk56R1oSc\n\tv+Fq5snrldqbi5KNswTla3YbksnKHODEjOHhhDsTPFL6rj2KOpURfEkMjewPUf8blDqq\n\t+VSQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=L6wUelOXwJyx1XPH2K2pBOcrfkANODrdEJz0GnuiyjE=;\n\tb=lhyiXffCBTndH4tzKTAzVNPb4WWR59wzOfJ1fXVJTAzhIyNAXlDMSvNYqsjQ1zVCZa\n\trb3PLnMNiSRbfc/Go/n8fZb2BtsFHtP8vQP/3TdwGxt4H6YU3OiNHy4R90JWsCJnVqxJ\n\tQwxyfAm2f4S6M6X4AtO69KY+/zm+XQVG7ID7o0WAacqQF43pI+YmZmSvbc4ExoHJdogW\n\tYKvHQTKGI2BDWAfu3IPAu0oRPAcU5bgZzwssgMXjKygQwWA2bBTeF0QzAXXLHMqTvuUH\n\twHNd4ElD/fmS66XwRq5mQoiE1gzI3eOAMxAu7ChlLdH9pyYcTqm+sZ+kiCoSFzYJDtdf\n\tFWFg==","X-Gm-Message-State":"AMCzsaWg1pkNpeJqwEUrXzqIC+9BFvDdXmWluT33yVOx7H9b42mq8pZ0\n\trP+bvHtxmhuj/wqVnF3422kwftWw","X-Google-Smtp-Source":"AOwi7QAeVGGXBoIUPGDzHatSvULLQV2hEX7O3TWs38pnvD95d/OTWcw0chZWcpj1NXo2Q7+2dlewIw==","X-Received":"by 10.223.151.198 with SMTP id t6mr5631040wrb.2.1507401815242;\n\tSat, 07 Oct 2017 11:43:35 -0700 (PDT)","To":"\"Yann E. MORIN\" ","References":"\n\t<585dda9412d61d550fc9c6fa76a29e7e878ceec0.1504432422.git.yann.morin.1998@free.fr>\n\t<93faf8c9-2223-3305-308c-6da56200a61d@gmail.com>\n\t<20171007122233.GH21901@scaer>","From":"Romain Naour ","Message-ID":"<7d5da0e6-ec34-483f-631b-c59f21b82ec4@gmail.com>","Date":"Sat, 7 Oct 2017 20:43:33 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20171007122233.GH21901@scaer>","Content-Language":"en-US","Cc":"Thomas Petazzoni ,\n\tVicente Olivert Riera , buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH 1/3] arch/mips: inverse the NaN logic","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}}]