Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/808651/?format=api
{ "id": 808651, "url": "http://patchwork.ozlabs.org/api/patches/808651/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170901112829.2571-11-apahim@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170901112829.2571-11-apahim@redhat.com>", "list_archive_url": null, "date": "2017-09-01T11:28:26", "name": "[v8,10/13] qemu.py: use poll() instead of 'returncode'", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "9a5d362c62133f8cfa754463f5a4c7581096b2d2", "submitter": { "id": 71999, "url": "http://patchwork.ozlabs.org/api/people/71999/?format=api", "name": "Amador Pahim", "email": "apahim@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170901112829.2571-11-apahim@redhat.com/mbox/", "series": [ { "id": 1006, "url": "http://patchwork.ozlabs.org/api/series/1006/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=1006", "date": "2017-09-01T11:28:16", "name": "scripts/qemu.py fixes and cleanups", "version": 8, "mbox": "http://patchwork.ozlabs.org/series/1006/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/808651/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/808651/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=apahim@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkHNl5WYZz9sRV\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 1 Sep 2017 21:40:23 +1000 (AEST)", "from localhost ([::1]:36444 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dnkJB-0008FD-Pt\n\tfor incoming@patchwork.ozlabs.org; Fri, 01 Sep 2017 07:40:21 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:59842)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <apahim@redhat.com>) id 1dnkBF-0001Sh-6g\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 07:32:13 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <apahim@redhat.com>) id 1dnkBA-00070s-Kx\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 07:32:09 -0400", "from mx1.redhat.com ([209.132.183.28]:58300)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <apahim@redhat.com>) id 1dnkBA-00070c-FE\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 07:32:04 -0400", "from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 8A26881E19;\n\tFri, 1 Sep 2017 11:32:03 +0000 (UTC)", "from t460p.pahim.org.com (ovpn-204-134.brq.redhat.com\n\t[10.40.204.134])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id A7FC381881;\n\tFri, 1 Sep 2017 11:31:58 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com 8A26881E19", "From": "Amador Pahim <apahim@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Fri, 1 Sep 2017 13:28:26 +0200", "Message-Id": "<20170901112829.2571-11-apahim@redhat.com>", "In-Reply-To": "<20170901112829.2571-1-apahim@redhat.com>", "References": "<20170901112829.2571-1-apahim@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.12", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tFri, 01 Sep 2017 11:32:03 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH v8 10/13] qemu.py: use poll() instead of\n\t'returncode'", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "kwolf@redhat.com, ldoktor@redhat.com, famz@redhat.com,\n\tehabkost@redhat.com, \n\tstefanha@gmail.com, Amador Pahim <apahim@redhat.com>,\n\tarmbru@redhat.com, mreitz@redhat.com, crosa@redhat.com", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "The 'returncode' Popen attribute is not guaranteed to be updated. It\nactually depends on a call to either poll(), wait() or communicate().\n\nOn the other hand, poll() will: \"Check if child process has terminated.\nSet and return returncode attribute.\"\n\nLet's use the poll() to check whether the process is running and to get\nthe updated process exit code, when the process is finished.\n\nSigned-off-by: Amador Pahim <apahim@redhat.com>\n---\n scripts/qemu.py | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/scripts/qemu.py b/scripts/qemu.py\nindex ede734328b..87a2212b77 100644\n--- a/scripts/qemu.py\n+++ b/scripts/qemu.py\n@@ -102,12 +102,12 @@ class QEMUMachine(object):\n raise\n \n def is_running(self):\n- return self._popen is not None and self._popen.returncode is None\n+ return self._popen is not None and self._popen.poll() is None\n \n def exitcode(self):\n if self._popen is None:\n return None\n- return self._popen.returncode\n+ return self._popen.poll()\n \n def get_pid(self):\n if not self.is_running():\n", "prefixes": [ "v8", "10/13" ] }