[{"id":1762937,"web_url":"http://patchwork.ozlabs.org/comment/1762937/","msgid":"<20170905030759.GM22515@lemon.lan>","list_archive_url":null,"date":"2017-09-05T03:07:59","subject":"Re: [Qemu-devel] [PATCH v8 10/13] qemu.py: use poll() instead of\n\t'returncode'","submitter":{"id":24872,"url":"http://patchwork.ozlabs.org/api/people/24872/","name":"Fam Zheng","email":"famz@redhat.com"},"content":"On Fri, 09/01 13:28, Amador Pahim wrote:\n> The 'returncode' Popen attribute is not guaranteed to be updated. It\n> actually depends on a call to either poll(), wait() or communicate().\n> \n> On the other hand, poll() will: \"Check if child process has terminated.\n> Set and return returncode attribute.\"\n> \n> Let's use the poll() to check whether the process is running and to get\n> the updated process exit code, when the process is finished.\n> \n> Signed-off-by: Amador Pahim \n\nReviewed-by: Fam Zheng ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=famz@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmWsZ27rPz9sP3\n\tfor ;\n\tTue, 5 Sep 2017 13:09:38 +1000 (AEST)","from localhost ([::1]:56594 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dp4F6-0006Fv-C9\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 23:09:36 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:56797)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dp4Di-0005Tu-G5\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 23:08:15 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dp4Dd-0003O7-Vu\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 23:08:10 -0400","from mx1.redhat.com ([209.132.183.28]:47436)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dp4Dd-0003N2-Q5\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 23:08:05 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id E8814356C7;\n\tTue, 5 Sep 2017 03:08:04 +0000 (UTC)","from localhost (ovpn-12-97.pek2.redhat.com [10.72.12.97])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 40B817EA2C;\n\tTue, 5 Sep 2017 03:08:01 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com E8814356C7","Date":"Tue, 5 Sep 2017 11:07:59 +0800","From":"Fam Zheng ","To":"Amador Pahim ","Message-ID":"<20170905030759.GM22515@lemon.lan>","References":"<20170901112829.2571-1-apahim@redhat.com>\n\t<20170901112829.2571-11-apahim@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170901112829.2571-11-apahim@redhat.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tTue, 05 Sep 2017 03:08:05 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v8 10/13] qemu.py: use poll() instead of\n\t'returncode'","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kwolf@redhat.com, ldoktor@redhat.com, ehabkost@redhat.com,\n\tstefanha@gmail.com, qemu-devel@nongnu.org, armbru@redhat.com,\n\tcrosa@redhat.com, mreitz@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]