Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/808623/?format=api
{ "id": 808623, "url": "http://patchwork.ozlabs.org/api/patches/808623/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170901105434.3288-2-berrange@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170901105434.3288-2-berrange@redhat.com>", "list_archive_url": null, "date": "2017-09-01T10:54:33", "name": "[1/2] iotests: rewrite 192 to use _launch_qemu to fix LUKS support", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "f8a27d3d52bf88d4678a29b833f2c417dc0b2e7f", "submitter": { "id": 2694, "url": "http://patchwork.ozlabs.org/api/people/2694/?format=api", "name": "Daniel P. Berrangé", "email": "berrange@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170901105434.3288-2-berrange@redhat.com/mbox/", "series": [ { "id": 998, "url": "http://patchwork.ozlabs.org/api/series/998/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=998", "date": "2017-09-01T10:54:33", "name": "Fix / skip recent iotests with LUKS driver", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/998/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/808623/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/808623/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=berrange@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkGP775CRz9rxl\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 1 Sep 2017 20:55:39 +1000 (AEST)", "from localhost ([::1]:34986 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dnjbu-0005rf-4e\n\tfor incoming@patchwork.ozlabs.org; Fri, 01 Sep 2017 06:55:38 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:50393)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <berrange@redhat.com>) id 1dnjbG-0005kn-P2\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 06:55:03 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <berrange@redhat.com>) id 1dnjbA-0008Sp-Tl\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 06:54:58 -0400", "from mx1.redhat.com ([209.132.183.28]:50448)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <berrange@redhat.com>)\n\tid 1dnjb4-0008Pu-Ri; Fri, 01 Sep 2017 06:54:46 -0400", "from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id DBCBE61485;\n\tFri, 1 Sep 2017 10:54:45 +0000 (UTC)", "from localhost.localdomain.com (unknown [10.42.22.189])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 2C8197C883;\n\tFri, 1 Sep 2017 10:54:43 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com DBCBE61485", "From": "\"Daniel P. Berrange\" <berrange@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Fri, 1 Sep 2017 11:54:33 +0100", "Message-Id": "<20170901105434.3288-2-berrange@redhat.com>", "In-Reply-To": "<20170901105434.3288-1-berrange@redhat.com>", "References": "<20170901105434.3288-1-berrange@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.14", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tFri, 01 Sep 2017 10:54:46 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH 1/2] iotests: rewrite 192 to use _launch_qemu\n\tto fix LUKS support", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org,\n\tMax Reitz <mreitz@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, \n\tFam Zheng <famz@redhat.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "The LUKS driver requires extra args to QEMU to setup passwords.\nThe _launch_qemu function takes care of this, so convert the\ntest to use this function and use correct -drive syntax\n\nSigned-off-by: Daniel P. Berrange <berrange@redhat.com>\n---\n tests/qemu-iotests/192 | 23 ++++++++++++++++-------\n 1 file changed, 16 insertions(+), 7 deletions(-)", "diff": "diff --git a/tests/qemu-iotests/192 b/tests/qemu-iotests/192\nindex b50a2c0c8e..595f0d786a 100755\n--- a/tests/qemu-iotests/192\n+++ b/tests/qemu-iotests/192\n@@ -37,6 +37,7 @@ trap \"_cleanup; exit \\$status\" 0 1 2 3 15\n # get standard environment, filters and checks\n . ./common.rc\n . ./common.filter\n+. ./common.qemu\n \n _supported_fmt generic\n _supported_proto file\n@@ -49,13 +50,21 @@ fi\n size=64M\n _make_test_img $size\n \n-{\n-echo \"nbd_server_start unix:$TEST_DIR/nbd\"\n-echo \"nbd_server_add -w drive0\"\n-echo \"q\"\n-} | $QEMU -nodefaults -display none -monitor stdio \\\n- -drive format=$IMGFMT,file=$TEST_IMG,if=ide,id=drive0 \\\n- -incoming defer 2>&1 | _filter_testdir | _filter_qemu | _filter_hmp\n+if test \"$IMGOPTSSYNTAX\" = \"true\"\n+then\n+ DRIVE_ARG=if=ide,id=drive0,$TEST_IMG\n+else\n+ DRIVE_ARG=if=ide,id=drive0,format=$IMGFMT,file=$TEST_IMG\n+fi\n+\n+qemu_comm_method=\"monitor\"\n+_launch_qemu -drive $DRIVE_ARG -incoming defer\n+h=$QEMU_HANDLE\n+QEMU_COMM_TIMEOUT=1\n+\n+_send_qemu_cmd $h \"nbd_server_start unix:$TEST_DIR/nbd\" \"(qemu)\"\n+_send_qemu_cmd $h \"nbd_server_add -w drive0\" \"(qemu)\"\n+_send_qemu_cmd $h \"q\" \"(qemu)\"\n \n # success, all done\n echo \"*** done\"\n", "prefixes": [ "1/2" ] }