[{"id":1761725,"web_url":"http://patchwork.ozlabs.org/comment/1761725/","msgid":"","list_archive_url":null,"date":"2017-09-01T14:22:57","subject":"Re: [Qemu-devel] [PATCH 1/2] iotests: rewrite 192 to use\n\t_launch_qemu to fix LUKS support","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/01/2017 05:54 AM, Daniel P. Berrange wrote:\n> The LUKS driver requires extra args to QEMU to setup passwords.\n> The _launch_qemu function takes care of this, so convert the\n> test to use this function and use correct -drive syntax\n> \n> Signed-off-by: Daniel P. Berrange \n> ---\n> tests/qemu-iotests/192 | 23 ++++++++++++++++-------\n> 1 file changed, 16 insertions(+), 7 deletions(-)\n> \n\n> \n> -{\n> -echo \"nbd_server_start unix:$TEST_DIR/nbd\"\n> -echo \"nbd_server_add -w drive0\"\n> -echo \"q\"\n> -} | $QEMU -nodefaults -display none -monitor stdio \\\n> - -drive format=$IMGFMT,file=$TEST_IMG,if=ide,id=drive0 \\\n> - -incoming defer 2>&1 | _filter_testdir | _filter_qemu | _filter_hmp\n\nCan this test use QMP instead of HMP? But that's an independent question.\n\nReviewed-by: Eric Blake ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkM1L5RGGz9sPk\n\tfor ;\n\tSat, 2 Sep 2017 00:23:50 +1000 (AEST)","from localhost ([::1]:43488 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnmrM-0007Q6-Ab\n\tfor incoming@patchwork.ozlabs.org; Fri, 01 Sep 2017 10:23:48 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:33024)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnmqy-0007Ot-Ay\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 10:23:29 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnmqt-0000AW-KG\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 10:23:24 -0400","from mx1.redhat.com ([209.132.183.28]:40578)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dnmqk-0008UQ-7u; Fri, 01 Sep 2017 10:23:10 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 2880F68CE;\n\tFri, 1 Sep 2017 14:23:09 +0000 (UTC)","from [10.10.121.149] (ovpn-121-149.rdu2.redhat.com [10.10.121.149])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id E1551A63AD;\n\tFri, 1 Sep 2017 14:23:02 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 2880F68CE","To":"\"Daniel P. Berrange\" , qemu-devel@nongnu.org","References":"<20170901105434.3288-1-berrange@redhat.com>\n\t<20170901105434.3288-2-berrange@redhat.com>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"","Date":"Fri, 1 Sep 2017 09:22:57 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170901105434.3288-2-berrange@redhat.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"6w1w3lAECh70pWvWtdb6ioIrdvki8HHcV\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tFri, 01 Sep 2017 14:23:09 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH 1/2] iotests: rewrite 192 to use\n\t_launch_qemu to fix LUKS support","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf , Fam Zheng ,\n\tStefan Hajnoczi , qemu-block@nongnu.org,\n\tMax Reitz ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1763135,"web_url":"http://patchwork.ozlabs.org/comment/1763135/","msgid":"<20170905092952.GD4633@localhost.localdomain>","list_archive_url":null,"date":"2017-09-05T09:29:52","subject":"Re: [Qemu-devel] [PATCH 1/2] iotests: rewrite 192 to use\n\t_launch_qemu to fix LUKS support","submitter":{"id":2714,"url":"http://patchwork.ozlabs.org/api/people/2714/","name":"Kevin Wolf","email":"kwolf@redhat.com"},"content":"Am 01.09.2017 um 16:22 hat Eric Blake geschrieben:\n> On 09/01/2017 05:54 AM, Daniel P. Berrange wrote:\n> > The LUKS driver requires extra args to QEMU to setup passwords.\n> > The _launch_qemu function takes care of this, so convert the\n> > test to use this function and use correct -drive syntax\n> > \n> > Signed-off-by: Daniel P. Berrange \n> > ---\n> > tests/qemu-iotests/192 | 23 ++++++++++++++++-------\n> > 1 file changed, 16 insertions(+), 7 deletions(-)\n> > \n> \n> > \n> > -{\n> > -echo \"nbd_server_start unix:$TEST_DIR/nbd\"\n> > -echo \"nbd_server_add -w drive0\"\n> > -echo \"q\"\n> > -} | $QEMU -nodefaults -display none -monitor stdio \\\n> > - -drive format=$IMGFMT,file=$TEST_IMG,if=ide,id=drive0 \\\n> > - -incoming defer 2>&1 | _filter_testdir | _filter_qemu | _filter_hmp\n> \n> Can this test use QMP instead of HMP? But that's an independent question.\n\nAs far as I am concerned, there is nothing wrong with having HMP tests.\nHMP commands already call QMP internally (except for the generic QMP\ncode path below the command handlers), so using HMP actually increases\nthe test coverage in most cases. We should try to have a good mix of\ntest cases using QMP and test cases using HMP.\n\nKevin","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=kwolf@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmhSC5Mbjz9s1h\n\tfor ;\n\tTue, 5 Sep 2017 19:36:43 +1000 (AEST)","from localhost ([::1]:57731 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpAHh-0004U2-Mi\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 05:36:41 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:46198)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpABa-0008G2-JV\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 05:30:27 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpABT-0007oF-1j\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 05:30:22 -0400","from mx1.redhat.com ([209.132.183.28]:36722)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dpABF-0007cZ-VM; Tue, 05 Sep 2017 05:30:02 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 0C9585AFEB;\n\tTue, 5 Sep 2017 09:30:01 +0000 (UTC)","from localhost.localdomain (ovpn-117-102.ams2.redhat.com\n\t[10.36.117.102])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id E54FE989A9;\n\tTue, 5 Sep 2017 09:29:53 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 0C9585AFEB","Date":"Tue, 5 Sep 2017 11:29:52 +0200","From":"Kevin Wolf ","To":"Eric Blake ","Message-ID":"<20170905092952.GD4633@localhost.localdomain>","References":"<20170901105434.3288-1-berrange@redhat.com>\n\t<20170901105434.3288-2-berrange@redhat.com>\n\t","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"envbJBWh7q8WU6mo\"","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tTue, 05 Sep 2017 09:30:01 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 1/2] iotests: rewrite 192 to use\n\t_launch_qemu to fix LUKS support","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Fam Zheng , qemu-block@nongnu.org, qemu-devel@nongnu.org,\n\tMax Reitz , Stefan Hajnoczi ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]