Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/807950/?format=api
{ "id": 807950, "url": "http://patchwork.ozlabs.org/api/patches/807950/?format=api", "web_url": "http://patchwork.ozlabs.org/project/skiboot/patch/1504132707-10406-4-git-send-email-arbab@linux.vnet.ibm.com/", "project": { "id": 44, "url": "http://patchwork.ozlabs.org/api/projects/44/?format=api", "name": "skiboot firmware development", "link_name": "skiboot", "list_id": "skiboot.lists.ozlabs.org", "list_email": "skiboot@lists.ozlabs.org", "web_url": "http://github.com/open-power/skiboot", "scm_url": "http://github.com/open-power/skiboot", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1504132707-10406-4-git-send-email-arbab@linux.vnet.ibm.com>", "list_archive_url": null, "date": "2017-08-30T22:38:27", "name": "[3/3] npu2: hw-procedures: Update PHY DC calibration procedure", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "46172cbd0a6811035139fdb8e58a8b12d577745f", "submitter": { "id": 69358, "url": "http://patchwork.ozlabs.org/api/people/69358/?format=api", "name": "Reza Arbab", "email": "arbab@linux.vnet.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/skiboot/patch/1504132707-10406-4-git-send-email-arbab@linux.vnet.ibm.com/mbox/", "series": [ { "id": 711, "url": "http://patchwork.ozlabs.org/api/series/711/?format=api", "web_url": "http://patchwork.ozlabs.org/project/skiboot/list/?series=711", "date": "2017-08-30T22:38:27", "name": "npu2: PHY initialization updates", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/711/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/807950/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/807950/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "skiboot@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "skiboot@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjL5D1J3Mz9s83\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 08:38:40 +1000 (AEST)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xjL5D0G6yzDqR9\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 08:38:40 +1000 (AEST)", "from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n\t[148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xjL563My4zDqNY\n\tfor <skiboot@lists.ozlabs.org>; Thu, 31 Aug 2017 08:38:34 +1000 (AEST)", "from pps.filterd (m0098399.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7UMbTK8007195\n\tfor <skiboot@lists.ozlabs.org>; Wed, 30 Aug 2017 18:38:31 -0400", "from e36.co.us.ibm.com (e36.co.us.ibm.com [32.97.110.154])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2cnyf57bsg-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <skiboot@lists.ozlabs.org>; Wed, 30 Aug 2017 18:38:31 -0400", "from localhost\n\tby e36.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <skiboot@lists.ozlabs.org> from <arbab@linux.vnet.ibm.com>;\n\tWed, 30 Aug 2017 16:38:31 -0600", "from b03cxnp08025.gho.boulder.ibm.com (9.17.130.17)\n\tby e36.co.us.ibm.com (192.168.1.136) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tWed, 30 Aug 2017 16:38:29 -0600", "from b03ledav002.gho.boulder.ibm.com\n\t(b03ledav002.gho.boulder.ibm.com [9.17.130.233])\n\tby b03cxnp08025.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v7UMcTTI65929386; Wed, 30 Aug 2017 15:38:29 -0700", "from b03ledav002.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id EA8C1136040;\n\tWed, 30 Aug 2017 16:38:28 -0600 (MDT)", "from arbab-laptop.localdomain (unknown [9.53.92.213])\n\tby b03ledav002.gho.boulder.ibm.com (Postfix) with ESMTP id\n\tCBFD813603C; Wed, 30 Aug 2017 16:38:28 -0600 (MDT)", "by arbab-laptop.localdomain (Postfix, from userid 152845)\n\tid DB32746074D; Wed, 30 Aug 2017 17:38:27 -0500 (CDT)" ], "From": "Reza Arbab <arbab@linux.vnet.ibm.com>", "To": "skiboot@lists.ozlabs.org", "Date": "Wed, 30 Aug 2017 17:38:27 -0500", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1504132707-10406-1-git-send-email-arbab@linux.vnet.ibm.com>", "References": "<1504132707-10406-1-git-send-email-arbab@linux.vnet.ibm.com>", "X-TM-AS-GCONF": "00", "x-cbid": "17083022-0020-0000-0000-00000CA3AE6C", "X-IBM-SpamModules-Scores": "", "X-IBM-SpamModules-Versions": "BY=3.00007638; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000226; SDB=6.00909922; UDB=6.00456405;\n\tIPR=6.00690206; \n\tBA=6.00005562; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016933;\n\tXFM=3.00000015; UTC=2017-08-30 22:38:31", "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused", "x-cbparentid": "17083022-0021-0000-0000-00005DEF896F", "Message-Id": "<1504132707-10406-4-git-send-email-arbab@linux.vnet.ibm.com>", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-30_09:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1708300344", "Subject": "[Skiboot] [PATCH 3/3] npu2: hw-procedures: Update PHY DC\n\tcalibration procedure", "X-BeenThere": "skiboot@lists.ozlabs.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "Mailing list for skiboot development <skiboot.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/skiboot/>", "List-Post": "<mailto:skiboot@lists.ozlabs.org>", "List-Help": "<mailto:skiboot-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=subscribe>", "Cc": "Alistair Popple <alistair@popple.id.au>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org", "Sender": "\"Skiboot\"\n\t<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>" }, "content": "Per the updated programming guide (procedure 1.2.4), set\nrx_pr_edge_track_cntl and rx_pr_fw_off appropriately before and after\ncalibration.\n\nSigned-off-by: Reza Arbab <arbab@linux.vnet.ibm.com>\n---\n hw/npu2-hw-procedures.c | 10 +++++++++-\n 1 file changed, 9 insertions(+), 1 deletion(-)", "diff": "diff --git a/hw/npu2-hw-procedures.c b/hw/npu2-hw-procedures.c\nindex 5ccc1a0..a140aed 100644\n--- a/hw/npu2-hw-procedures.c\n+++ b/hw/npu2-hw-procedures.c\n@@ -59,6 +59,8 @@ struct npu2_phy_reg NPU2_PHY_TX_UNLOAD_CLK_DISABLE\t= {0x103, 56, 1};\n struct npu2_phy_reg NPU2_PHY_TX_FIFO_INIT\t\t= {0x105, 53, 1};\n struct npu2_phy_reg NPU2_PHY_TX_RXCAL\t\t\t= {0x103, 57, 1};\n struct npu2_phy_reg NPU2_PHY_RX_INIT_DONE\t\t= {0x0ca, 48, 1};\n+struct npu2_phy_reg NPU2_PHY_RX_PR_EDGE_TRACK_CNTL\t= {0x092, 48, 2};\n+struct npu2_phy_reg NPU2_PHY_RX_PR_FW_OFF\t\t= {0x08a, 56, 1};\n \n /* These registers are per-PHY, not per lane */\n struct npu2_phy_reg NPU2_PHY_TX_ZCAL_SWO_EN\t\t= {0x3c9, 48, 1};\n@@ -521,6 +523,9 @@ static uint32_t phy_rx_dccal(struct npu2_dev *ndev)\n \tint lane;\n \n \tFOR_EACH_LANE(ndev, lane)\n+\t\tphy_write_lane(ndev, &NPU2_PHY_RX_PR_FW_OFF, lane, 1);\n+\n+\tFOR_EACH_LANE(ndev, lane)\n \t\tphy_write_lane(ndev, &NPU2_PHY_RX_RUN_DCCAL, lane, 1);\n \n \treturn PROCEDURE_NEXT;\n@@ -537,8 +542,11 @@ static uint32_t phy_rx_dccal_complete(struct npu2_dev *ndev)\n \tFOR_EACH_LANE(ndev, lane)\n \t\tphy_write_lane(ndev, &NPU2_PHY_RX_RUN_DCCAL, lane, 0);\n \n-\tFOR_EACH_LANE(ndev, lane)\n+\tFOR_EACH_LANE(ndev, lane) {\n \t\tphy_write_lane(ndev, &NPU2_PHY_RX_B_BANK_CONTROLS, lane, 0);\n+\t\tphy_write_lane(ndev, &NPU2_PHY_RX_PR_EDGE_TRACK_CNTL, lane, 0);\n+\t\tphy_write_lane(ndev, &NPU2_PHY_RX_PR_FW_OFF, lane, 0);\n+\t}\n \n \treturn PROCEDURE_NEXT;\n }\n", "prefixes": [ "3/3" ] }