Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/807633/?format=api
{ "id": 807633, "url": "http://patchwork.ozlabs.org/api/patches/807633/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1504099475-241036-5-git-send-email-imammedo@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1504099475-241036-5-git-send-email-imammedo@redhat.com>", "list_archive_url": null, "date": "2017-08-30T13:24:31", "name": "[v2,4/8] ppc: make cpu alias point only to real cpu models", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "469de8455f7f24505311f7204fade6e17aab43ce", "submitter": { "id": 11305, "url": "http://patchwork.ozlabs.org/api/people/11305/?format=api", "name": "Igor Mammedov", "email": "imammedo@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1504099475-241036-5-git-send-email-imammedo@redhat.com/mbox/", "series": [ { "id": 612, "url": "http://patchwork.ozlabs.org/api/series/612/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=612", "date": "2017-08-30T13:24:29", "name": "ppc: cpu_model handling cleanups", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/612/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/807633/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/807633/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=imammedo@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xj5sx30QMz9sN7\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 30 Aug 2017 23:28:05 +1000 (AEST)", "from localhost ([::1]:50576 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dn32J-00044I-59\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 09:28:03 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:50936)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <imammedo@redhat.com>) id 1dn2z8-0001oj-0R\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 09:24:47 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <imammedo@redhat.com>) id 1dn2z6-0003XL-JT\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 09:24:46 -0400", "from mx1.redhat.com ([209.132.183.28]:47004)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <imammedo@redhat.com>)\n\tid 1dn2z6-0003Wt-9r; Wed, 30 Aug 2017 09:24:44 -0400", "from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 39B3F800AF;\n\tWed, 30 Aug 2017 13:24:43 +0000 (UTC)", "from dell-r430-03.lab.eng.brq.redhat.com\n\t(dell-r430-03.lab.eng.brq.redhat.com [10.34.112.60])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 379089B518;\n\tWed, 30 Aug 2017 13:24:42 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com 39B3F800AF", "From": "Igor Mammedov <imammedo@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Wed, 30 Aug 2017 15:24:31 +0200", "Message-Id": "<1504099475-241036-5-git-send-email-imammedo@redhat.com>", "In-Reply-To": "<1504099475-241036-1-git-send-email-imammedo@redhat.com>", "References": "<1504099475-241036-1-git-send-email-imammedo@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.12", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tWed, 30 Aug 2017 13:24:43 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH v2 4/8] ppc: make cpu alias point only to real\n\tcpu models", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>,\n\tDavid Gibson <david@gibson.dropbear.id.au>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "alias pointing to another alias forces lookup code to\ndo recurrsive translation till real cpu model is reached.\n\nDrop this nonsence and make each alias point to cpu model\nthat has corresponding CPU type. It will allow to drop\nrecurrsion in cpu model translation code and actually\nmake ppc_cpu_aliases[] content use PowerPCCPUAlias\nfields properly\n(i.e. alias goes into .alias and model goes into .model)\n\nWhile at it add TODO defines around aliases that point to\ncpu models excluded by the same TODO defines.\n\nSigned-off-by: Igor Mammedov <imammedo@redhat.com>\nAcked-by: David Gibson <david@gibson.dropbear.id.au>\n---\nv2:\n * rebase on top of lower-cased model names\n---\n target/ppc/cpu-models.h | 2 +-\n target/ppc/cpu-models.c | 56 ++++++++++++++++++++++++++-----------------------\n 2 files changed, 31 insertions(+), 27 deletions(-)", "diff": "diff --git a/target/ppc/cpu-models.h b/target/ppc/cpu-models.h\nindex b563c45..d748c68 100644\n--- a/target/ppc/cpu-models.h\n+++ b/target/ppc/cpu-models.h\n@@ -24,7 +24,7 @@\n /**\n * PowerPCCPUAlias:\n * @alias: The alias name.\n- * @model: The CPU model @alias refers to.\n+ * @model: The CPU model @alias refers to, that directly resolves into CPU type\n *\n * A mapping entry from CPU @alias to CPU @model.\n */\ndiff --git a/target/ppc/cpu-models.c b/target/ppc/cpu-models.c\nindex 6721c3e..cf878a9 100644\n--- a/target/ppc/cpu-models.c\n+++ b/target/ppc/cpu-models.c\n@@ -1235,6 +1235,7 @@ PowerPCCPUAlias ppc_cpu_aliases[] = {\n { \"x2vp50\", \"x2vp20\" },\n \n { \"440ep\", \"440epb\" },\n+#if defined(TODO_USER_ONLY)\n { \"440gp\", \"440gpc\" },\n { \"440gr\", \"440gra\" },\n { \"440gx\", \"440gxf\" },\n@@ -1272,36 +1273,37 @@ PowerPCCPUAlias ppc_cpu_aliases[] = {\n { \"mpc875\", \"mpc8xx\" },\n { \"mpc880\", \"mpc8xx\" },\n { \"mpc885\", \"mpc8xx\" },\n+#endif\n \n /* PowerPC MPC603 microcontrollers */\n { \"mpc8240\", \"603\" },\n \n- { \"mpc52xx\", \"mpc5200\" },\n+ { \"mpc52xx\", \"mpc5200_v12\" },\n { \"mpc5200\", \"mpc5200_v12\" },\n { \"mpc5200b\", \"mpc5200b_v21\" },\n \n- { \"mpc82xx\", \"mpc8280\" },\n- { \"powerquicc-ii\", \"mpc82xx\" },\n+ { \"mpc82xx\", \"g2legp3\" },\n+ { \"powerquicc-ii\", \"g2legp3\" },\n { \"mpc8241\", \"g2hip4\" },\n { \"mpc8245\", \"g2hip4\" },\n { \"mpc8247\", \"g2legp3\" },\n { \"mpc8248\", \"g2legp3\" },\n- { \"mpc8250\", \"mpc8250_hip4\" },\n+ { \"mpc8250\", \"g2hip4\" },\n { \"mpc8250_hip3\", \"g2hip3\" },\n { \"mpc8250_hip4\", \"g2hip4\" },\n- { \"mpc8255\", \"mpc8255_hip4\" },\n+ { \"mpc8255\", \"g2hip4\" },\n { \"mpc8255_hip3\", \"g2hip3\" },\n { \"mpc8255_hip4\", \"g2hip4\" },\n- { \"mpc8260\", \"mpc8260_hip4\" },\n+ { \"mpc8260\", \"g2hip4\" },\n { \"mpc8260_hip3\", \"g2hip3\" },\n { \"mpc8260_hip4\", \"g2hip4\" },\n- { \"mpc8264\", \"mpc8264_hip4\" },\n+ { \"mpc8264\", \"g2hip4\" },\n { \"mpc8264_hip3\", \"g2hip3\" },\n { \"mpc8264_hip4\", \"g2hip4\" },\n- { \"mpc8265\", \"mpc8265_hip4\" },\n+ { \"mpc8265\", \"g2hip4\" },\n { \"mpc8265_hip3\", \"g2hip3\" },\n { \"mpc8265_hip4\", \"g2hip4\" },\n- { \"mpc8266\", \"mpc8266_hip4\" },\n+ { \"mpc8266\", \"g2hip4\" },\n { \"mpc8266_hip3\", \"g2hip3\" },\n { \"mpc8266_hip4\", \"g2hip4\" },\n { \"mpc8270\", \"g2legp3\" },\n@@ -1339,18 +1341,18 @@ PowerPCCPUAlias ppc_cpu_aliases[] = {\n { \"601v\", \"601_v2\" },\n { \"vanilla\", \"603\" },\n { \"603e\", \"603e_v4.1\" },\n- { \"stretch\", \"603e\" },\n+ { \"stretch\", \"603e_v4.1\" },\n { \"vaillant\", \"603e7v\" },\n { \"603r\", \"603e7t\" },\n- { \"goldeneye\", \"603r\" },\n+ { \"goldeneye\", \"603e7t\" },\n { \"604e\", \"604e_v2.4\" },\n- { \"sirocco\", \"604e\" },\n+ { \"sirocco\", \"604e_v2.4\" },\n { \"mach5\", \"604r\" },\n { \"740\", \"740_v3.1\" },\n- { \"arthur\", \"740\" },\n+ { \"arthur\", \"740_v3.1\" },\n { \"750\", \"750_v3.1\" },\n- { \"typhoon\", \"750\" },\n- { \"g3\", \"750\" },\n+ { \"typhoon\", \"750_v3.1\" },\n+ { \"g3\", \"750_v3.1\" },\n { \"conan/doyle\", \"750p\" },\n { \"750cl\", \"750cl_v2.0\" },\n { \"750cx\", \"750cx_v2.2\" },\n@@ -1358,32 +1360,34 @@ PowerPCCPUAlias ppc_cpu_aliases[] = {\n { \"750fx\", \"750fx_v2.3\" },\n { \"750gx\", \"750gx_v1.2\" },\n { \"750l\", \"750l_v3.2\" },\n- { \"lonestar\", \"750l\" },\n+ { \"lonestar\", \"750l_v3.2\" },\n { \"745\", \"745_v2.8\" },\n { \"755\", \"755_v2.8\" },\n- { \"goldfinger\", \"755\" },\n+ { \"goldfinger\", \"755_v2.8\" },\n { \"7400\", \"7400_v2.9\" },\n- { \"max\", \"7400\" },\n- { \"g4\", \"7400\" },\n+ { \"max\", \"7400_v2.9\" },\n+ { \"g4\", \"7400_v2.9\" },\n { \"7410\", \"7410_v1.4\" },\n- { \"nitro\", \"7410\" },\n+ { \"nitro\", \"7410_v1.4\" },\n { \"7448\", \"7448_v2.1\" },\n { \"7450\", \"7450_v2.1\" },\n- { \"vger\", \"7450\" },\n+ { \"vger\", \"7450_v2.1\" },\n { \"7441\", \"7441_v2.3\" },\n { \"7451\", \"7451_v2.3\" },\n { \"7445\", \"7445_v3.2\" },\n { \"7455\", \"7455_v3.2\" },\n- { \"apollo6\", \"7455\" },\n+ { \"apollo6\", \"7455_v3.2\" },\n { \"7447\", \"7447_v1.1\" },\n { \"7457\", \"7457_v1.2\" },\n- { \"apollo7\", \"7457\" },\n+ { \"apollo7\", \"7457_v1.2\" },\n { \"7447a\", \"7447a_v1.2\" },\n { \"7457a\", \"7457a_v1.2\" },\n { \"apollo7pm\", \"7457a_v1.0\" },\n #if defined(TARGET_PPC64)\n+#if defined(TODO)\n { \"power3\", \"630\" },\n { \"power3+\", \"631\" },\n+#endif\n { \"power5+\", \"power5+_v2.1\" },\n { \"power5gs\", \"power5+_v2.1\" },\n { \"power7\", \"power7_v2.3\" },\n@@ -1399,10 +1403,10 @@ PowerPCCPUAlias ppc_cpu_aliases[] = {\n \n /* Generic PowerPCs */\n #if defined(TARGET_PPC64)\n- { \"ppc64\", \"970fx\" },\n+ { \"ppc64\", \"970fx_v3.1\" },\n #endif\n { \"ppc32\", \"604\" },\n- { \"ppc\", \"ppc32\" },\n- { \"default\", \"ppc\" },\n+ { \"ppc\", \"604\" },\n+ { \"default\", \"604\" },\n { NULL, NULL }\n };\n", "prefixes": [ "v2", "4/8" ] }