Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/807290/?format=api
{ "id": 807290, "url": "http://patchwork.ozlabs.org/api/patches/807290/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pwm/patch/20170829203434.6826-1-dbasehore@chromium.org/", "project": { "id": 38, "url": "http://patchwork.ozlabs.org/api/projects/38/?format=api", "name": "Linux PWM development", "link_name": "linux-pwm", "list_id": "linux-pwm.vger.kernel.org", "list_email": "linux-pwm@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170829203434.6826-1-dbasehore@chromium.org>", "list_archive_url": null, "date": "2017-08-29T20:34:34", "name": "[v2] pwm_bl: Fix overflow condition", "commit_ref": null, "pull_url": null, "state": "deferred", "archived": false, "hash": "f422623ac38a246d5dc4859e08848af63b1c858d", "submitter": { "id": 20364, "url": "http://patchwork.ozlabs.org/api/people/20364/?format=api", "name": "dbasehore .", "email": "dbasehore@chromium.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-pwm/patch/20170829203434.6826-1-dbasehore@chromium.org/mbox/", "series": [ { "id": 467, "url": "http://patchwork.ozlabs.org/api/series/467/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pwm/list/?series=467", "date": "2017-08-29T20:34:34", "name": "[v2] pwm_bl: Fix overflow condition", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/467/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/807290/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/807290/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linux-pwm-owner@vger.kernel.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pwm-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"fdmD2TF3\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhgNv34Xzz9s72\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 30 Aug 2017 06:34:55 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751859AbdH2Uej (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tTue, 29 Aug 2017 16:34:39 -0400", "from mail-pg0-f43.google.com ([74.125.83.43]:35696 \"EHLO\n\tmail-pg0-f43.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751290AbdH2Uei (ORCPT\n\t<rfc822; linux-pwm@vger.kernel.org>); Tue, 29 Aug 2017 16:34:38 -0400", "by mail-pg0-f43.google.com with SMTP id 63so13897123pgc.2\n\tfor <linux-pwm@vger.kernel.org>; Tue, 29 Aug 2017 13:34:38 -0700 (PDT)", "from exogeni.mtv.corp.google.com\n\t([2620:0:1000:1600:211e:5908:95bc:4888])\n\tby smtp.gmail.com with ESMTPSA id\n\tv186sm5945361pfb.50.2017.08.29.13.34.36\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 29 Aug 2017 13:34:37 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google;\n\th=from:to:cc:subject:date:message-id;\n\tbh=YlZF0NYiqo3quUbsyYo18UTyYQCxnplIh/n5JzCtNzQ=;\n\tb=fdmD2TF3dk4S923XJzBBe5MpyzphOnwXvA00di5CSvEdW9ttNSBRe9KOLI0JLQIj5g\n\tnHo87UnCunz43CUoOEFrvK3uskc9nrX30YUr7YJVQKES3Awr5oQ0NRJurMSFHo3LB1eF\n\tb6eRZGeFxLL1+Ix4FgkocSjJ6IG1kruosYpRo=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=YlZF0NYiqo3quUbsyYo18UTyYQCxnplIh/n5JzCtNzQ=;\n\tb=IhHZeC/mCbhbjFZfohfpxuEKJY+dybv4PzzYbptuFZ6IMHyhbqD9oDto+E08V/1Z6k\n\tfL5SmeepDm2xpIhgcy7abOtB+fAPP1lAJT816fWc99TcIBo/E0szBxVFu53gYBaDcY3z\n\tZhiCK3JCnJQsP1q63NdyrGfciOhkALVNADO1H/WAgWAcB7NnYBYClXd22sc7gNwrtzvk\n\ttIDqjdxpw2M1BgShn9+DyHHq5IHgNOvqwc4ttHtGZ9Ddv84whkwPRbk3gBjf5jzTIqUo\n\tRNO5UBgAMDdn3Q3qdXSTF0KJCZRzw67SbWrCXwbl1ufFOKbrFeSC4QNI39/mI1DJW/XW\n\t7pXw==", "X-Gm-Message-State": "AHYfb5hPV3OipGfOOzgnn9BFUavBWNjdwgmhxMGzeFhBS+/ky8GbPuOF\n\twIegWr12niMEeLM4", "X-Received": "by 10.99.121.14 with SMTP id u14mr1503622pgc.90.1504038878232;\n\tTue, 29 Aug 2017 13:34:38 -0700 (PDT)", "From": "Derek Basehore <dbasehore@chromium.org>", "To": "linux-kernel@vger.kernel.org", "Cc": "thierry.reding@gmail.com, jingoohan1@gmail.com,\n\tlee.jones@linaro.org, briannorris@chromium.org,\n\tlinux-pwm@vger.kernel.org, Derek Basehore <dbasehore@chromium.org>", "Subject": "[PATCH v2] pwm_bl: Fix overflow condition", "Date": "Tue, 29 Aug 2017 13:34:34 -0700", "Message-Id": "<20170829203434.6826-1-dbasehore@chromium.org>", "X-Mailer": "git-send-email 2.14.1.342.g6490525c54-goog", "Sender": "linux-pwm-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<linux-pwm.vger.kernel.org>", "X-Mailing-List": "linux-pwm@vger.kernel.org" }, "content": "This fixes an overflow condition that can happen with high max\nbrightness and period values in compute_duty_cycle. This fixes it by\nusing a 64 bit variable for computing the duty cycle.\n\nSigned-off-by: Derek Basehore <dbasehore@chromium.org>\n---\n drivers/video/backlight/pwm_bl.c | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c\nindex 76311ec5e400..5ccc8e34b7a6 100644\n--- a/drivers/video/backlight/pwm_bl.c\n+++ b/drivers/video/backlight/pwm_bl.c\n@@ -88,14 +88,17 @@ static void pwm_backlight_power_off(struct pwm_bl_data *pb)\n static int compute_duty_cycle(struct pwm_bl_data *pb, int brightness)\n {\n \tunsigned int lth = pb->lth_brightness;\n-\tint duty_cycle;\n+\tu64 duty_cycle;\n \n \tif (pb->levels)\n \t\tduty_cycle = pb->levels[brightness];\n \telse\n \t\tduty_cycle = brightness;\n \n-\treturn (duty_cycle * (pb->period - lth) / pb->scale) + lth;\n+\tduty_cycle *= pb->period - lth;\n+\tdo_div(duty_cycle, pb->scale);\n+\n+\treturn duty_cycle + lth;\n }\n \n static int pwm_backlight_update_status(struct backlight_device *bl)\n", "prefixes": [ "v2" ] }