From patchwork Tue Aug 29 20:34:34 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "dbasehore ." X-Patchwork-Id: 807290 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pwm-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="fdmD2TF3"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xhgNv34Xzz9s72 for ; Wed, 30 Aug 2017 06:34:55 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751859AbdH2Uej (ORCPT ); Tue, 29 Aug 2017 16:34:39 -0400 Received: from mail-pg0-f43.google.com ([74.125.83.43]:35696 "EHLO mail-pg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751290AbdH2Uei (ORCPT ); Tue, 29 Aug 2017 16:34:38 -0400 Received: by mail-pg0-f43.google.com with SMTP id 63so13897123pgc.2 for ; Tue, 29 Aug 2017 13:34:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id; bh=YlZF0NYiqo3quUbsyYo18UTyYQCxnplIh/n5JzCtNzQ=; b=fdmD2TF3dk4S923XJzBBe5MpyzphOnwXvA00di5CSvEdW9ttNSBRe9KOLI0JLQIj5g nHo87UnCunz43CUoOEFrvK3uskc9nrX30YUr7YJVQKES3Awr5oQ0NRJurMSFHo3LB1eF b6eRZGeFxLL1+Ix4FgkocSjJ6IG1kruosYpRo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=YlZF0NYiqo3quUbsyYo18UTyYQCxnplIh/n5JzCtNzQ=; b=IhHZeC/mCbhbjFZfohfpxuEKJY+dybv4PzzYbptuFZ6IMHyhbqD9oDto+E08V/1Z6k fL5SmeepDm2xpIhgcy7abOtB+fAPP1lAJT816fWc99TcIBo/E0szBxVFu53gYBaDcY3z ZhiCK3JCnJQsP1q63NdyrGfciOhkALVNADO1H/WAgWAcB7NnYBYClXd22sc7gNwrtzvk tIDqjdxpw2M1BgShn9+DyHHq5IHgNOvqwc4ttHtGZ9Ddv84whkwPRbk3gBjf5jzTIqUo RNO5UBgAMDdn3Q3qdXSTF0KJCZRzw67SbWrCXwbl1ufFOKbrFeSC4QNI39/mI1DJW/XW 7pXw== X-Gm-Message-State: AHYfb5hPV3OipGfOOzgnn9BFUavBWNjdwgmhxMGzeFhBS+/ky8GbPuOF wIegWr12niMEeLM4 X-Received: by 10.99.121.14 with SMTP id u14mr1503622pgc.90.1504038878232; Tue, 29 Aug 2017 13:34:38 -0700 (PDT) Received: from exogeni.mtv.corp.google.com ([2620:0:1000:1600:211e:5908:95bc:4888]) by smtp.gmail.com with ESMTPSA id v186sm5945361pfb.50.2017.08.29.13.34.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Aug 2017 13:34:37 -0700 (PDT) From: Derek Basehore To: linux-kernel@vger.kernel.org Cc: thierry.reding@gmail.com, jingoohan1@gmail.com, lee.jones@linaro.org, briannorris@chromium.org, linux-pwm@vger.kernel.org, Derek Basehore Subject: [PATCH v2] pwm_bl: Fix overflow condition Date: Tue, 29 Aug 2017 13:34:34 -0700 Message-Id: <20170829203434.6826-1-dbasehore@chromium.org> X-Mailer: git-send-email 2.14.1.342.g6490525c54-goog Sender: linux-pwm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org This fixes an overflow condition that can happen with high max brightness and period values in compute_duty_cycle. This fixes it by using a 64 bit variable for computing the duty cycle. Signed-off-by: Derek Basehore Reviewed-by: Brian Norris Acked-by: Thierry Reding --- drivers/video/backlight/pwm_bl.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c index 76311ec5e400..5ccc8e34b7a6 100644 --- a/drivers/video/backlight/pwm_bl.c +++ b/drivers/video/backlight/pwm_bl.c @@ -88,14 +88,17 @@ static void pwm_backlight_power_off(struct pwm_bl_data *pb) static int compute_duty_cycle(struct pwm_bl_data *pb, int brightness) { unsigned int lth = pb->lth_brightness; - int duty_cycle; + u64 duty_cycle; if (pb->levels) duty_cycle = pb->levels[brightness]; else duty_cycle = brightness; - return (duty_cycle * (pb->period - lth) / pb->scale) + lth; + duty_cycle *= pb->period - lth; + do_div(duty_cycle, pb->scale); + + return duty_cycle + lth; } static int pwm_backlight_update_status(struct backlight_device *bl)