Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/806448/?format=api
{ "id": 806448, "url": "http://patchwork.ozlabs.org/api/patches/806448/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170827063951.5975-1-christophe.jaillet@wanadoo.fr/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170827063951.5975-1-christophe.jaillet@wanadoo.fr>", "list_archive_url": null, "date": "2017-08-27T06:39:51", "name": "igb: check memory allocation failure", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5332a54c621d96417f7982b54966cd6f40707f27", "submitter": { "id": 66309, "url": "http://patchwork.ozlabs.org/api/people/66309/?format=api", "name": "Christophe JAILLET", "email": "christophe.jaillet@wanadoo.fr" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170827063951.5975-1-christophe.jaillet@wanadoo.fr/mbox/", "series": [ { "id": 110, "url": "http://patchwork.ozlabs.org/api/series/110/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=110", "date": "2017-08-27T06:39:51", "name": "igb: check memory allocation failure", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/110/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/806448/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/806448/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xgmFl0dDXz9sNq\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 28 Aug 2017 19:10:34 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 266B5878C5;\n\tMon, 28 Aug 2017 09:10:32 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id phGrOK1s9siN; Mon, 28 Aug 2017 09:10:30 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 35AE48788C;\n\tMon, 28 Aug 2017 09:10:30 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 9B9871C4115\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 27 Aug 2017 06:41:56 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 8E38A88F47\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 27 Aug 2017 06:41:56 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id y7ZucDDO4WGB for <intel-wired-lan@lists.osuosl.org>;\n\tSun, 27 Aug 2017 06:41:55 +0000 (UTC)", "from smtp.smtpout.orange.fr (smtp03.smtpout.orange.fr\n\t[80.12.242.125])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id E5A3F88DFB\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 27 Aug 2017 06:41:54 +0000 (UTC)", "from localhost.localdomain ([86.196.182.67]) by mwinf5d58 with ME\n\tid 26hr1w00D1TfVo6036hrGS; Sun, 27 Aug 2017 08:41:52 +0200" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ME-Helo": "localhost.localdomain", "X-ME-Auth": "Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI=", "X-ME-Date": "Sun, 27 Aug 2017 08:41:52 +0200", "X-ME-IP": "86.196.182.67", "From": "Christophe JAILLET <christophe.jaillet@wanadoo.fr>", "To": "jeffrey.t.kirsher@intel.com", "Date": "Sun, 27 Aug 2017 08:39:51 +0200", "Message-Id": "<20170827063951.5975-1-christophe.jaillet@wanadoo.fr>", "X-Mailer": "git-send-email 2.11.0", "X-Mailman-Approved-At": "Mon, 28 Aug 2017 09:10:28 +0000", "Cc": "netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,\n\tChristophe JAILLET <christophe.jaillet@wanadoo.fr>,\n\tintel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org", "Subject": "[Intel-wired-lan] [PATCH] igb: check memory allocation failure", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Check memory allocation failures and return -ENOMEM in such cases, as\nalready done for other memory allocations in this function.\n\nThis avoids NULL pointers dereference.\n\nSigned-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>\n---\n drivers/net/ethernet/intel/igb/igb_main.c | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex fd4a46b03cc8..837d9b46a390 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -3162,6 +3162,8 @@ static int igb_sw_init(struct igb_adapter *adapter)\n \t/* Setup and initialize a copy of the hw vlan table array */\n \tadapter->shadow_vfta = kcalloc(E1000_VLAN_FILTER_TBL_SIZE, sizeof(u32),\n \t\t\t\t GFP_ATOMIC);\n+\tif (!adapter->shadow_vfta)\n+\t\treturn -ENOMEM;\n \n \t/* This call may decrease the number of queues */\n \tif (igb_init_interrupt_scheme(adapter, true)) {\n", "prefixes": [] }