[{"id":1758719,"web_url":"http://patchwork.ozlabs.org/comment/1758719/","msgid":"<95a0bc80-8b41-d74f-8059-ae7181493120@wanadoo.fr>","list_archive_url":null,"date":"2017-08-28T17:12:30","subject":"Re: [Intel-wired-lan] [PATCH] igb: check memory allocation failure","submitter":{"id":66309,"url":"http://patchwork.ozlabs.org/api/people/66309/","name":"Christophe JAILLET","email":"christophe.jaillet@wanadoo.fr"},"content":"Le 28/08/2017 à 01:09, Waskiewicz Jr, Peter a écrit :\n> On 8/27/17 2:42 AM, Christophe JAILLET wrote:\n>> Check memory allocation failures and return -ENOMEM in such cases, as\n>> already done for other memory allocations in this function.\n>>\n>> This avoids NULL pointers dereference.\n>>\n>> Signed-off-by: Christophe JAILLET \n>> ---\n>> drivers/net/ethernet/intel/igb/igb_main.c | 2 ++\n>> 1 file changed, 2 insertions(+)\n>>\n>> diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\n>> index fd4a46b03cc8..837d9b46a390 100644\n>> --- a/drivers/net/ethernet/intel/igb/igb_main.c\n>> +++ b/drivers/net/ethernet/intel/igb/igb_main.c\n>> @@ -3162,6 +3162,8 @@ static int igb_sw_init(struct igb_adapter *adapter)\n>> \t/* Setup and initialize a copy of the hw vlan table array */\n>> \tadapter->shadow_vfta = kcalloc(E1000_VLAN_FILTER_TBL_SIZE, sizeof(u32),\n>> \t\t\t\t GFP_ATOMIC);\n>> +\tif (!adapter->shadow_vfta)\n>> +\t\treturn -ENOMEM;\n> Looks reasonable to me.\n>\n> A larger issue though I see in this function is that if we return\n> -ENOMEM here, and if we return -ENOMEM from igb_init_interrupt_scheme()\n> below on failure, we leak adapter->mac_table (and adapter->shadow_vfta\n> in the latter). We should add a proper unwind to free up the memory on\n> failure.\n>\n> -PJ\n>\nHi,\n\nin fact, there is no leak because the only caller of 'igb_sw_init()' \n(i.e. 'igb_probe()'), already frees these resources in case of error, \nsee [1]\n\nThese resources are also freed  in 'igb_remove()'.\n\nBest reagrds,\nCJ\n\n[1]: \nhttps://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/net/ethernet/intel/igb/igb_main.c#n2775","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=)","Received":["from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xgyy42GrDz9s03\n\tfor ;\n\tTue, 29 Aug 2017 03:12:44 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 96E9E306F5;\n\tMon, 28 Aug 2017 17:12:42 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id GMhY2mADM6OJ; Mon, 28 Aug 2017 17:12:41 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 46B93306F0;\n\tMon, 28 Aug 2017 17:12:41 +0000 (UTC)","from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id AC6C61C0589\n\tfor ;\n\tMon, 28 Aug 2017 17:12:40 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id A5C6B86B15\n\tfor ;\n\tMon, 28 Aug 2017 17:12:40 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id y3MIL-ryPEQh for ;\n\tMon, 28 Aug 2017 17:12:39 +0000 (UTC)","from smtp.smtpout.orange.fr (smtp01.smtpout.orange.fr\n\t[80.12.242.123])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id F2E2386C04\n\tfor ;\n\tMon, 28 Aug 2017 17:12:38 +0000 (UTC)","from [192.168.1.10] ([86.196.182.67]) by mwinf5d53 with ME\n\tid 2hCX1w00Y1TfVo603hCY4S; Mon, 28 Aug 2017 19:12:36 +0200"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ME-Helo":"[192.168.1.10]","X-ME-Date":"Mon, 28 Aug 2017 19:12:36 +0200","X-ME-IP":"86.196.182.67","To":"\"Waskiewicz Jr, Peter\" ,\n\t\"Kirsher, Jeffrey T\" ","Newsgroups":"gmane.linux.kernel, gmane.linux.network,\n\tgmane.linux.kernel.janitors","References":"<20170827063951.5975-1-christophe.jaillet@wanadoo.fr>\n\t","From":"Christophe JAILLET ","Message-ID":"<95a0bc80-8b41-d74f-8059-ae7181493120@wanadoo.fr>","Date":"Mon, 28 Aug 2017 19:12:30 +0200","User-Agent":"Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-US","Cc":"\"netdev@vger.kernel.org\" ,\n\t\"kernel-janitors@vger.kernel.org\" , \n\t\"intel-wired-lan@lists.osuosl.org\" ,\n\t\"linux-kernel@vger.kernel.org\" ","Subject":"Re: [Intel-wired-lan] [PATCH] igb: check memory allocation failure","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t","List-Unsubscribe":", \n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":", \n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":1768300,"web_url":"http://patchwork.ozlabs.org/comment/1768300/","msgid":"<309B89C4C689E141A5FF6A0C5FB2118B8C6A028B@ORSMSX101.amr.corp.intel.com>","list_archive_url":null,"date":"2017-09-14T02:24:37","subject":"Re: [Intel-wired-lan] [PATCH] igb: check memory allocation failure","submitter":{"id":37025,"url":"http://patchwork.ozlabs.org/api/people/37025/","name":"Brown, Aaron F","email":"aaron.f.brown@intel.com"},"content":"> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On Behalf\r\n> Of Christophe JAILLET\r\n> Sent: Monday, August 28, 2017 10:13 AM\r\n> To: Waskiewicz Jr, Peter ; Kirsher, Jeffrey T\r\n> \r\n> Cc: netdev@vger.kernel.org; kernel-janitors@vger.kernel.org; intel-wired-\r\n> lan@lists.osuosl.org; linux-kernel@vger.kernel.org\r\n> Subject: Re: [Intel-wired-lan] [PATCH] igb: check memory allocation failure\r\n> \r\n> Le 28/08/2017 à 01:09, Waskiewicz Jr, Peter a écrit :\r\n> > On 8/27/17 2:42 AM, Christophe JAILLET wrote:\r\n> >> Check memory allocation failures and return -ENOMEM in such cases, as\r\n> >> already done for other memory allocations in this function.\r\n> >>\r\n> >> This avoids NULL pointers dereference.\r\n> >>\r\n> >> Signed-off-by: Christophe JAILLET \r\n> >> ---\r\n> >> drivers/net/ethernet/intel/igb/igb_main.c | 2 ++\r\n> >> 1 file changed, 2 insertions(+)\r\n> >>\r\n\r\nThis seems to be fine from a \"it does not break in testing\" perspective, so...\r\n\r\nTested-by: Aaron Brown > -PJ\r\n> >\r\n> Hi,\r\n> \r\n> in fact, there is no leak because the only caller of 'igb_sw_init()'\r\n> (i.e. 'igb_probe()'), already frees these resources in case of error,\r\n> see [1]\r\n> \r\n> These resources are also freed  in 'igb_remove()'.\r\n> \r\n> Best reagrds,\r\n> CJ\r\n> \r\n> [1]:\r\n> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-\r\n> next.git/tree/drivers/net/ethernet/intel/igb/igb_main.c#n2775\r\n\r\nBut is PJ's comment saying that it is not really necessary? If so I tend to lean towards the don't touch it if it's not broken perspective.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=)","Received":["from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xt2Rd1xqRz9t3V\n\tfor ;\n\tThu, 14 Sep 2017 12:24:44 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 01D5930F01;\n\tThu, 14 Sep 2017 02:24:42 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 0eTzSSc5Msaw; Thu, 14 Sep 2017 02:24:41 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 1179930D3A;\n\tThu, 14 Sep 2017 02:24:41 +0000 (UTC)","from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 5E08E1C1650\n\tfor ;\n\tThu, 14 Sep 2017 02:24:40 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 510DC8A976\n\tfor ;\n\tThu, 14 Sep 2017 02:24:40 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id CmUA8nzNBBXz for ;\n\tThu, 14 Sep 2017 02:24:39 +0000 (UTC)","from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 6762B8A8D9\n\tfor ;\n\tThu, 14 Sep 2017 02:24:39 +0000 (UTC)","from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t13 Sep 2017 19:24:38 -0700","from orsmsx108.amr.corp.intel.com ([10.22.240.6])\n\tby fmsmga006.fm.intel.com with ESMTP; 13 Sep 2017 19:24:38 -0700","from orsmsx114.amr.corp.intel.com (10.22.240.10) by\n\tORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server\n\t(TLS) id 14.3.319.2; Wed, 13 Sep 2017 19:24:38 -0700","from orsmsx101.amr.corp.intel.com ([169.254.8.156]) by\n\tORSMSX114.amr.corp.intel.com ([169.254.8.209]) with mapi id\n\t14.03.0319.002; Wed, 13 Sep 2017 19:24:37 -0700"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,390,1500966000\"; d=\"scan'208\";a=\"151622500\"","From":"\"Brown, Aaron F\" ","To":"Christophe JAILLET , \"Waskiewicz Jr,\n\tPeter\" , \"Kirsher, Jeffrey T\"\n\t","Thread-Topic":"[Intel-wired-lan] [PATCH] igb: check memory allocation failure","Thread-Index":"AQHTHv+fAs763IiaBkWXRmCjnRUfm6KaeQIAgBlJM2A=","Date":"Thu, 14 Sep 2017 02:24:37 +0000","Message-ID":"<309B89C4C689E141A5FF6A0C5FB2118B8C6A028B@ORSMSX101.amr.corp.intel.com>","References":"<20170827063951.5975-1-christophe.jaillet@wanadoo.fr>\n\t\n\t<95a0bc80-8b41-d74f-8059-ae7181493120@wanadoo.fr>","In-Reply-To":"<95a0bc80-8b41-d74f-8059-ae7181493120@wanadoo.fr>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","dlp-product":"dlpe-windows","dlp-version":"11.0.0.116","dlp-reaction":"no-action","x-originating-ip":"[10.22.254.138]","MIME-Version":"1.0","Cc":"\"netdev@vger.kernel.org\" ,\n\t\"intel-wired-lan@lists.osuosl.org\" ,\n\t\"kernel-janitors@vger.kernel.org\" , \n\t\"linux-kernel@vger.kernel.org\" ","Subject":"Re: [Intel-wired-lan] [PATCH] igb: check memory allocation failure","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t","List-Unsubscribe":", \n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":", \n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":1768640,"web_url":"http://patchwork.ozlabs.org/comment/1768640/","msgid":"","list_archive_url":null,"date":"2017-09-14T14:47:17","subject":"Re: [Intel-wired-lan] [PATCH] igb: check memory allocation failure","submitter":{"id":72228,"url":"http://patchwork.ozlabs.org/api/people/72228/","name":"Waskiewicz Jr, Peter","email":"peter.waskiewicz.jr@intel.com"},"content":"On 9/13/17 7:24 PM, Brown, Aaron F wrote:\n>> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On Behalf\n>> Of Christophe JAILLET\n>> Sent: Monday, August 28, 2017 10:13 AM\n>> To: Waskiewicz Jr, Peter ; Kirsher, Jeffrey T\n>> \n>> Cc: netdev@vger.kernel.org; kernel-janitors@vger.kernel.org; intel-wired-\n>> lan@lists.osuosl.org; linux-kernel@vger.kernel.org\n>> Subject: Re: [Intel-wired-lan] [PATCH] igb: check memory allocation failure\n>>\n>> Le 28/08/2017 à 01:09, Waskiewicz Jr, Peter a écrit :\n>>> On 8/27/17 2:42 AM, Christophe JAILLET wrote:\n>>>> Check memory allocation failures and return -ENOMEM in such cases, as\n>>>> already done for other memory allocations in this function.\n>>>>\n>>>> This avoids NULL pointers dereference.\n>>>>\n>>>> Signed-off-by: Christophe JAILLET \n>>>> ---\n>>>> drivers/net/ethernet/intel/igb/igb_main.c | 2 ++\n>>>> 1 file changed, 2 insertions(+)\n>>>>\n> \n> This seems to be fine from a \"it does not break in testing\" perspective, so...\n> \n> Tested-by: Aaron Brown \n>>> -PJ\n>>>\n>> Hi,\n>>\n>> in fact, there is no leak because the only caller of 'igb_sw_init()'\n>> (i.e. 'igb_probe()'), already frees these resources in case of error,\n>> see [1]\n>>\n>> These resources are also freed  in 'igb_remove()'.\n>>\n>> Best reagrds,\n>> CJ\n>>\n>> [1]:\n>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-\n>> next.git/tree/drivers/net/ethernet/intel/igb/igb_main.c#n2775\n> \n> But is PJ's comment saying that it is not really necessary? If so I tend to lean towards the don't touch it if it's not broken perspective.\n\nI guess I didn't respond after Christophe replied, sorry about that. \nThe patch is good to me. It's definitely catching an issue where we're \nnot checking for a memory failure, then just follows the same \nde-allocation path on unwind.\n\nIf you want it:\n\nAcked-by: PJ Waskiewicz ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=)","Received":["from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtLwg1vnKz9sRW\n\tfor ;\n\tFri, 15 Sep 2017 00:47:30 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 6765488C36;\n\tThu, 14 Sep 2017 14:47:29 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id CYkXfKOHm0v3; Thu, 14 Sep 2017 14:47:27 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id D502D88C1D;\n\tThu, 14 Sep 2017 14:47:27 +0000 (UTC)","from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 88D451C001E\n\tfor ;\n\tThu, 14 Sep 2017 14:47:26 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 7E4C98AB03\n\tfor ;\n\tThu, 14 Sep 2017 14:47:26 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id HaHY8m+hYS4o for ;\n\tThu, 14 Sep 2017 14:47:25 +0000 (UTC)","from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id A741B8AB14\n\tfor ;\n\tThu, 14 Sep 2017 14:47:25 +0000 (UTC)","from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t14 Sep 2017 07:47:25 -0700","from orsmsx101.amr.corp.intel.com ([10.22.225.128])\n\tby orsmga003.jf.intel.com with ESMTP; 14 Sep 2017 07:47:19 -0700","from orsmsx156.amr.corp.intel.com (10.22.240.22) by\n\tORSMSX101.amr.corp.intel.com (10.22.225.128) with Microsoft SMTP\n\tServer (TLS) id 14.3.319.2; Thu, 14 Sep 2017 07:47:19 -0700","from orsmsx103.amr.corp.intel.com ([169.254.5.176]) by\n\tORSMSX156.amr.corp.intel.com ([169.254.8.97]) with mapi id\n\t14.03.0319.002; Thu, 14 Sep 2017 07:47:18 -0700"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos; i=\"5.42,393,1500966000\"; d=\"scan'208\";\n\ta=\"1014439488\"","From":"\"Waskiewicz Jr, Peter\" ","To":"\"Brown, Aaron F\" , Christophe JAILLET\n\t, \"Kirsher, Jeffrey T\"\n\t","Thread-Topic":"[Intel-wired-lan] [PATCH] igb: check memory allocation failure","Thread-Index":"AQHTHv+fnj5ml27UL0anrhb/WN5ubA==","Date":"Thu, 14 Sep 2017 14:47:17 +0000","Message-ID":"","References":"<20170827063951.5975-1-christophe.jaillet@wanadoo.fr>\n\t\n\t<95a0bc80-8b41-d74f-8059-ae7181493120@wanadoo.fr>\n\t<309B89C4C689E141A5FF6A0C5FB2118B8C6A028B@ORSMSX101.amr.corp.intel.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-originating-ip":"[10.252.133.10]","MIME-Version":"1.0","Cc":"\"netdev@vger.kernel.org\" ,\n\t\"intel-wired-lan@lists.osuosl.org\" ,\n\t\"kernel-janitors@vger.kernel.org\" , \n\t\"linux-kernel@vger.kernel.org\" ","Subject":"Re: [Intel-wired-lan] [PATCH] igb: check memory allocation failure","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t","List-Unsubscribe":", \n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":", \n\t","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]