Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/805947/?format=api
{ "id": 805947, "url": "http://patchwork.ozlabs.org/api/patches/805947/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170825150626.2843-1-willemdebruijn.kernel@gmail.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170825150626.2843-1-willemdebruijn.kernel@gmail.com>", "list_archive_url": null, "date": "2017-08-25T15:06:26", "name": "e1000e: apply burst mode settings only on default", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e9a4064071091e4b365c9764f8c70d3f39f30c39", "submitter": { "id": 67615, "url": "http://patchwork.ozlabs.org/api/people/67615/?format=api", "name": "Willem de Bruijn", "email": "willemdebruijn.kernel@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170825150626.2843-1-willemdebruijn.kernel@gmail.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/805947/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/805947/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"YzO7o0W2\"; dkim-atps=neutral" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xf4Hy1Vdxz9sPs\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 26 Aug 2017 01:06:37 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 3B8988879A;\n\tFri, 25 Aug 2017 15:06:35 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id rw6wT7RzZ_RD; Fri, 25 Aug 2017 15:06:33 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 6FDEA8872B;\n\tFri, 25 Aug 2017 15:06:33 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 5AB8C1C0419\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 25 Aug 2017 15:06:31 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 49DEB30D22\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 25 Aug 2017 15:06:31 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id u5B3GV12eiEx for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 25 Aug 2017 15:06:30 +0000 (UTC)", "from mail-qk0-f195.google.com (mail-qk0-f195.google.com\n\t[209.85.220.195])\n\tby silver.osuosl.org (Postfix) with ESMTPS id ADAEF2F806\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 25 Aug 2017 15:06:30 +0000 (UTC)", "by mail-qk0-f195.google.com with SMTP id o184so40178qkc.4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 25 Aug 2017 08:06:30 -0700 (PDT)", "from willemb1.nyc.corp.google.com ([100.101.212.81])\n\tby smtp.gmail.com with ESMTPSA id\n\tm3sm4061664qkb.22.2017.08.25.08.06.28\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tFri, 25 Aug 2017 08:06:28 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=wwwuOgax94Pws0NCS5M05xczVx0xTbpMEBq0cTHXiKM=;\n\tb=YzO7o0W2XpY8h0sjbjLFy6kM9PPxCwNDoSEVZK+cbr7xd6mYsGfztw9dnFrFdb8q01\n\t2YkOZBldlKJO1H70K77868ldbuj0tPxQSC1KwH8OgfFilbOVvAuT2vfcNCJEcsAeGdDO\n\teobiYo6p3DDKcvvRLC9mRXxoxGpBg3U9HDBRvTaL79E9zKbvTBP3RqUbZ0/Ev3BcrQ3U\n\t62Ik9Vh8WbFibzTHIMMYd5g7dhM19DFDjs4Oe6rkBIr9ZXrv7MYDZ+t0c6TCLBaNbht5\n\t5hBBVBNH7oZFdeykCdisSZ9j2e+KzAG/U9j5BjYLxAVKnB1sR3KlLUFwyIQ0RqvyjPwa\n\tzY5A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=wwwuOgax94Pws0NCS5M05xczVx0xTbpMEBq0cTHXiKM=;\n\tb=RzHN/t8mYT+6JWWWNpsR9GxHyeL2Ikd4I4jDyT2JLgp3Ucsyr7VTPfny3VCCJD8wST\n\tmcAvbOAgV1eZDuj6pvoC2MYpNEGTO340Bi0ULBUQOS5XGHWRRNliUzTG+QVvS0I2Hrj+\n\tpocnqKEdcKjQikH43vqIVt497K2cxq6PyxPlX2WHtcaqaSE3gn5ezAAI5JhvXzvbdB6j\n\toBHYHRHpNjLNqEyD9nOAyMXCyhmEWutZk5itpn4Vmc+5FaVczzvaspCmelvSwZ74CSkc\n\tzimXcin/Ff5pbqMH//H6mP1KmR7J4Vff+67lKZI5/qMOs9MhT+0R7fieKoKbvUqWqdhO\n\tp15A==", "X-Gm-Message-State": "AHYfb5hbo2riR0MJf/AS+mELqO/4BUMz1/wHenlVeCy54XxMcX4LmbmM\n\tBgLJ23WJVUtUOA==", "X-Received": "by 10.55.160.15 with SMTP id j15mr14653277qke.324.1503673589516; \n\tFri, 25 Aug 2017 08:06:29 -0700 (PDT)", "From": "Willem de Bruijn <willemdebruijn.kernel@gmail.com>", "To": "jeffrey.t.kirsher@intel.com", "Date": "Fri, 25 Aug 2017 11:06:26 -0400", "Message-Id": "<20170825150626.2843-1-willemdebruijn.kernel@gmail.com>", "X-Mailer": "git-send-email 2.14.1.342.g6490525c54-goog", "Cc": "netdev@vger.kernel.org, Willem de Bruijn <willemb@google.com>,\n\tintel-wired-lan@lists.osuosl.org", "Subject": "[Intel-wired-lan] [PATCH] e1000e: apply burst mode settings only on\n\tdefault", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Willem de Bruijn <willemb@google.com>\n\nDevices that support FLAG2_DMA_BURST have different default values\nfor RDTR and RADV. Apply burst mode default settings only when no\nexplicit value was passed at module load.\n\nThe RDTR default is zero. If the module is loaded for low latency\noperation with RxIntDelay=0, do not override this value with a burst\ndefault of 32.\n\nMove the decision to apply burst values earlier, where explicitly\ninitialized module variables can be distinguished from defaults.\n\nSigned-off-by: Willem de Bruijn <willemb@google.com>\n---\n drivers/net/ethernet/intel/e1000e/e1000.h | 4 ----\n drivers/net/ethernet/intel/e1000e/netdev.c | 8 --------\n drivers/net/ethernet/intel/e1000e/param.c | 16 +++++++++++++++-\n 3 files changed, 15 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000e/e1000.h b/drivers/net/ethernet/intel/e1000e/e1000.h\nindex 98e68888abb1..2311b31bdcac 100644\n--- a/drivers/net/ethernet/intel/e1000e/e1000.h\n+++ b/drivers/net/ethernet/intel/e1000e/e1000.h\n@@ -94,10 +94,6 @@ struct e1000_info;\n */\n #define E1000_CHECK_RESET_COUNT\t\t25\n \n-#define DEFAULT_RDTR\t\t\t0\n-#define DEFAULT_RADV\t\t\t8\n-#define BURST_RDTR\t\t\t0x20\n-#define BURST_RADV\t\t\t0x20\n #define PCICFG_DESC_RING_STATUS\t\t0xe4\n #define FLUSH_DESC_REQUIRED\t\t0x100\n \ndiff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c\nindex 327dfe5bedc0..47b89aac7969 100644\n--- a/drivers/net/ethernet/intel/e1000e/netdev.c\n+++ b/drivers/net/ethernet/intel/e1000e/netdev.c\n@@ -3223,14 +3223,6 @@ static void e1000_configure_rx(struct e1000_adapter *adapter)\n \t\t */\n \t\tew32(RXDCTL(0), E1000_RXDCTL_DMA_BURST_ENABLE);\n \t\tew32(RXDCTL(1), E1000_RXDCTL_DMA_BURST_ENABLE);\n-\n-\t\t/* override the delay timers for enabling bursting, only if\n-\t\t * the value was not set by the user via module options\n-\t\t */\n-\t\tif (adapter->rx_int_delay == DEFAULT_RDTR)\n-\t\t\tadapter->rx_int_delay = BURST_RDTR;\n-\t\tif (adapter->rx_abs_int_delay == DEFAULT_RADV)\n-\t\t\tadapter->rx_abs_int_delay = BURST_RADV;\n \t}\n \n \t/* set the Receive Delay Timer Register */\ndiff --git a/drivers/net/ethernet/intel/e1000e/param.c b/drivers/net/ethernet/intel/e1000e/param.c\nindex 6d8c39abee16..bb696c98f9b0 100644\n--- a/drivers/net/ethernet/intel/e1000e/param.c\n+++ b/drivers/net/ethernet/intel/e1000e/param.c\n@@ -73,17 +73,25 @@ E1000_PARAM(TxAbsIntDelay, \"Transmit Absolute Interrupt Delay\");\n /* Receive Interrupt Delay in units of 1.024 microseconds\n * hardware will likely hang if you set this to anything but zero.\n *\n+ * Burst variant is used as default if device has FLAG2_DMA_BURST.\n+ *\n * Valid Range: 0-65535\n */\n E1000_PARAM(RxIntDelay, \"Receive Interrupt Delay\");\n+#define DEFAULT_RDTR\t\t\t0\n+#define BURST_RDTR\t\t\t0x20\n #define MAX_RXDELAY 0xFFFF\n #define MIN_RXDELAY 0\n \n /* Receive Absolute Interrupt Delay in units of 1.024 microseconds\n+ *\n+ * Burst variant is used as default if device has FLAG2_DMA_BURST.\n *\n * Valid Range: 0-65535\n */\n E1000_PARAM(RxAbsIntDelay, \"Receive Absolute Interrupt Delay\");\n+#define DEFAULT_RADV\t\t\t8\n+#define BURST_RADV\t\t\t0x20\n #define MAX_RXABSDELAY 0xFFFF\n #define MIN_RXABSDELAY 0\n \n@@ -297,6 +305,9 @@ void e1000e_check_options(struct e1000_adapter *adapter)\n \t\t\t\t\t .max = MAX_RXDELAY } }\n \t\t};\n \n+\t\tif (adapter->flags2 & FLAG2_DMA_BURST)\n+\t\t\topt.def = BURST_RDTR;\n+\n \t\tif (num_RxIntDelay > bd) {\n \t\t\tadapter->rx_int_delay = RxIntDelay[bd];\n \t\t\te1000_validate_option(&adapter->rx_int_delay, &opt,\n@@ -307,7 +318,7 @@ void e1000e_check_options(struct e1000_adapter *adapter)\n \t}\n \t/* Receive Absolute Interrupt Delay */\n \t{\n-\t\tstatic const struct e1000_option opt = {\n+\t\tstatic struct e1000_option opt = {\n \t\t\t.type = range_option,\n \t\t\t.name = \"Receive Absolute Interrupt Delay\",\n \t\t\t.err = \"using default of \"\n@@ -317,6 +328,9 @@ void e1000e_check_options(struct e1000_adapter *adapter)\n \t\t\t\t\t .max = MAX_RXABSDELAY } }\n \t\t};\n \n+\t\tif (adapter->flags2 & FLAG2_DMA_BURST)\n+\t\t\topt.def = BURST_RADV;\n+\n \t\tif (num_RxAbsIntDelay > bd) {\n \t\t\tadapter->rx_abs_int_delay = RxAbsIntDelay[bd];\n \t\t\te1000_validate_option(&adapter->rx_abs_int_delay, &opt,\n", "prefixes": [] }