[{"id":1758226,"web_url":"http://patchwork.ozlabs.org/comment/1758226/","msgid":"<291b863f-552e-2f3b-f658-e812d0848949@intel.com>","list_archive_url":null,"date":"2017-08-27T08:30:58","subject":"Re: [Intel-wired-lan] [PATCH] e1000e: apply burst mode settings\n\tonly on default","submitter":{"id":69860,"url":"http://patchwork.ozlabs.org/api/people/69860/","name":"Sasha Neftin","email":"sasha.neftin@intel.com"},"content":"On 8/25/2017 18:06, Willem de Bruijn wrote:\n> From: Willem de Bruijn \n>\n> Devices that support FLAG2_DMA_BURST have different default values\n> for RDTR and RADV. Apply burst mode default settings only when no\n> explicit value was passed at module load.\n>\n> The RDTR default is zero. If the module is loaded for low latency\n> operation with RxIntDelay=0, do not override this value with a burst\n> default of 32.\n>\n> Move the decision to apply burst values earlier, where explicitly\n> initialized module variables can be distinguished from defaults.\n>\n> Signed-off-by: Willem de Bruijn \n> ---\n> drivers/net/ethernet/intel/e1000e/e1000.h | 4 ----\n> drivers/net/ethernet/intel/e1000e/netdev.c | 8 --------\n> drivers/net/ethernet/intel/e1000e/param.c | 16 +++++++++++++++-\n> 3 files changed, 15 insertions(+), 13 deletions(-)\n>\n> diff --git a/drivers/net/ethernet/intel/e1000e/e1000.h b/drivers/net/ethernet/intel/e1000e/e1000.h\n> index 98e68888abb1..2311b31bdcac 100644\n> --- a/drivers/net/ethernet/intel/e1000e/e1000.h\n> +++ b/drivers/net/ethernet/intel/e1000e/e1000.h\n> @@ -94,10 +94,6 @@ struct e1000_info;\n> */\n> #define E1000_CHECK_RESET_COUNT\t\t25\n> \n> -#define DEFAULT_RDTR\t\t\t0\n> -#define DEFAULT_RADV\t\t\t8\n> -#define BURST_RDTR\t\t\t0x20\n> -#define BURST_RADV\t\t\t0x20\n> #define PCICFG_DESC_RING_STATUS\t\t0xe4\n> #define FLUSH_DESC_REQUIRED\t\t0x100\n> \n> diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c\n> index 327dfe5bedc0..47b89aac7969 100644\n> --- a/drivers/net/ethernet/intel/e1000e/netdev.c\n> +++ b/drivers/net/ethernet/intel/e1000e/netdev.c\n> @@ -3223,14 +3223,6 @@ static void e1000_configure_rx(struct e1000_adapter *adapter)\n> \t\t */\n> \t\tew32(RXDCTL(0), E1000_RXDCTL_DMA_BURST_ENABLE);\n> \t\tew32(RXDCTL(1), E1000_RXDCTL_DMA_BURST_ENABLE);\n> -\n> -\t\t/* override the delay timers for enabling bursting, only if\n> -\t\t * the value was not set by the user via module options\n> -\t\t */\n> -\t\tif (adapter->rx_int_delay == DEFAULT_RDTR)\n> -\t\t\tadapter->rx_int_delay = BURST_RDTR;\n> -\t\tif (adapter->rx_abs_int_delay == DEFAULT_RADV)\n> -\t\t\tadapter->rx_abs_int_delay = BURST_RADV;\n> \t}\n> \n> \t/* set the Receive Delay Timer Register */\n> diff --git a/drivers/net/ethernet/intel/e1000e/param.c b/drivers/net/ethernet/intel/e1000e/param.c\n> index 6d8c39abee16..bb696c98f9b0 100644\n> --- a/drivers/net/ethernet/intel/e1000e/param.c\n> +++ b/drivers/net/ethernet/intel/e1000e/param.c\n> @@ -73,17 +73,25 @@ E1000_PARAM(TxAbsIntDelay, \"Transmit Absolute Interrupt Delay\");\n> /* Receive Interrupt Delay in units of 1.024 microseconds\n> * hardware will likely hang if you set this to anything but zero.\n> *\n> + * Burst variant is used as default if device has FLAG2_DMA_BURST.\n> + *\n> * Valid Range: 0-65535\n> */\n> E1000_PARAM(RxIntDelay, \"Receive Interrupt Delay\");\n> +#define DEFAULT_RDTR\t\t\t0\n> +#define BURST_RDTR\t\t\t0x20\n> #define MAX_RXDELAY 0xFFFF\n> #define MIN_RXDELAY 0\n> \n> /* Receive Absolute Interrupt Delay in units of 1.024 microseconds\n> + *\n> + * Burst variant is used as default if device has FLAG2_DMA_BURST.\n> *\n> * Valid Range: 0-65535\n> */\n> E1000_PARAM(RxAbsIntDelay, \"Receive Absolute Interrupt Delay\");\n> +#define DEFAULT_RADV\t\t\t8\n> +#define BURST_RADV\t\t\t0x20\n> #define MAX_RXABSDELAY 0xFFFF\n> #define MIN_RXABSDELAY 0\n> \n> @@ -297,6 +305,9 @@ void e1000e_check_options(struct e1000_adapter *adapter)\n> \t\t\t\t\t .max = MAX_RXDELAY } }\n> \t\t};\n> \n> +\t\tif (adapter->flags2 & FLAG2_DMA_BURST)\n> +\t\t\topt.def = BURST_RDTR;\n> +\n> \t\tif (num_RxIntDelay > bd) {\n> \t\t\tadapter->rx_int_delay = RxIntDelay[bd];\n> \t\t\te1000_validate_option(&adapter->rx_int_delay, &opt,\n> @@ -307,7 +318,7 @@ void e1000e_check_options(struct e1000_adapter *adapter)\n> \t}\n> \t/* Receive Absolute Interrupt Delay */\n> \t{\n> -\t\tstatic const struct e1000_option opt = {\n> +\t\tstatic struct e1000_option opt = {\n> \t\t\t.type = range_option,\n> \t\t\t.name = \"Receive Absolute Interrupt Delay\",\n> \t\t\t.err = \"using default of \"\n> @@ -317,6 +328,9 @@ void e1000e_check_options(struct e1000_adapter *adapter)\n> \t\t\t\t\t .max = MAX_RXABSDELAY } }\n> \t\t};\n> \n> +\t\tif (adapter->flags2 & FLAG2_DMA_BURST)\n> +\t\t\topt.def = BURST_RADV;\n> +\n> \t\tif (num_RxAbsIntDelay > bd) {\n> \t\t\tadapter->rx_abs_int_delay = RxAbsIntDelay[bd];\n> \t\t\te1000_validate_option(&adapter->rx_abs_int_delay, &opt,\n\nThis patch looks good for me, but I would like hear second opinion.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=)","Received":["from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xg7Qp0B29z9t33\n\tfor ;\n\tSun, 27 Aug 2017 18:31:12 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id D294486B74;\n\tSun, 27 Aug 2017 08:31:07 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id rrv5WWtXkGlT; Sun, 27 Aug 2017 08:31:05 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id ECDFB86B75;\n\tSun, 27 Aug 2017 08:31:04 +0000 (UTC)","from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 28BED1C0479\n\tfor ;\n\tSun, 27 Aug 2017 08:31:04 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 1CB2288BAE\n\tfor ;\n\tSun, 27 Aug 2017 08:31:04 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id lQPsEe2-yy+Z for ;\n\tSun, 27 Aug 2017 08:31:03 +0000 (UTC)","from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 44EA088BAD\n\tfor ;\n\tSun, 27 Aug 2017 08:31:03 +0000 (UTC)","from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby orsmga104.jf.intel.com with ESMTP; 27 Aug 2017 01:31:00 -0700","from unknown (HELO [10.185.202.95]) ([10.185.202.95])\n\tby fmsmga006.fm.intel.com with ESMTP; 27 Aug 2017 01:30:59 -0700"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.41,434,1498546800\"; d=\"scan'208\";a=\"144965766\"","To":"Willem de Bruijn ,\n\t\"jeffrey.t.kirsher@intel.com; alexander.h.duyck@intel.com;\n\traanan.avargil@intel.com; dima.ruinskiy\"@intel.com","References":"<20170825150626.2843-1-willemdebruijn.kernel@gmail.com>","From":"\"Neftin, Sasha\" ","Message-ID":"<291b863f-552e-2f3b-f658-e812d0848949@intel.com>","Date":"Sun, 27 Aug 2017 11:30:58 +0300","User-Agent":"Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101\n\tThunderbird/45.6.0","MIME-Version":"1.0","In-Reply-To":"<20170825150626.2843-1-willemdebruijn.kernel@gmail.com>","Cc":"netdev@vger.kernel.org, Willem de Bruijn ,\n\tintel-wired-lan@lists.osuosl.org","Subject":"Re: [Intel-wired-lan] [PATCH] e1000e: apply burst mode settings\n\tonly on default","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t","List-Unsubscribe":", \n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":", \n\t","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":1758230,"web_url":"http://patchwork.ozlabs.org/comment/1758230/","msgid":"","list_archive_url":null,"date":"2017-08-27T08:32:15","subject":"Re: [Intel-wired-lan] [PATCH] e1000e: apply burst mode settings\n\tonly on default","submitter":{"id":69860,"url":"http://patchwork.ozlabs.org/api/people/69860/","name":"Sasha Neftin","email":"sasha.neftin@intel.com"},"content":"On 8/27/2017 11:30, Neftin, Sasha wrote:\n> On 8/25/2017 18:06, Willem de Bruijn wrote:\n>> From: Willem de Bruijn \n>>\n>> Devices that support FLAG2_DMA_BURST have different default values\n>> for RDTR and RADV. Apply burst mode default settings only when no\n>> explicit value was passed at module load.\n>>\n>> The RDTR default is zero. If the module is loaded for low latency\n>> operation with RxIntDelay=0, do not override this value with a burst\n>> default of 32.\n>>\n>> Move the decision to apply burst values earlier, where explicitly\n>> initialized module variables can be distinguished from defaults.\n>>\n>> Signed-off-by: Willem de Bruijn \n>> ---\n>> drivers/net/ethernet/intel/e1000e/e1000.h | 4 ----\n>> drivers/net/ethernet/intel/e1000e/netdev.c | 8 --------\n>> drivers/net/ethernet/intel/e1000e/param.c | 16 +++++++++++++++-\n>> 3 files changed, 15 insertions(+), 13 deletions(-)\n>>\n>> diff --git a/drivers/net/ethernet/intel/e1000e/e1000.h \n>> b/drivers/net/ethernet/intel/e1000e/e1000.h\n>> index 98e68888abb1..2311b31bdcac 100644\n>> --- a/drivers/net/ethernet/intel/e1000e/e1000.h\n>> +++ b/drivers/net/ethernet/intel/e1000e/e1000.h\n>> @@ -94,10 +94,6 @@ struct e1000_info;\n>> */\n>> #define E1000_CHECK_RESET_COUNT 25\n>> -#define DEFAULT_RDTR 0\n>> -#define DEFAULT_RADV 8\n>> -#define BURST_RDTR 0x20\n>> -#define BURST_RADV 0x20\n>> #define PCICFG_DESC_RING_STATUS 0xe4\n>> #define FLUSH_DESC_REQUIRED 0x100\n>> diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c \n>> b/drivers/net/ethernet/intel/e1000e/netdev.c\n>> index 327dfe5bedc0..47b89aac7969 100644\n>> --- a/drivers/net/ethernet/intel/e1000e/netdev.c\n>> +++ b/drivers/net/ethernet/intel/e1000e/netdev.c\n>> @@ -3223,14 +3223,6 @@ static void e1000_configure_rx(struct \n>> e1000_adapter *adapter)\n>> */\n>> ew32(RXDCTL(0), E1000_RXDCTL_DMA_BURST_ENABLE);\n>> ew32(RXDCTL(1), E1000_RXDCTL_DMA_BURST_ENABLE);\n>> -\n>> - /* override the delay timers for enabling bursting, only if\n>> - * the value was not set by the user via module options\n>> - */\n>> - if (adapter->rx_int_delay == DEFAULT_RDTR)\n>> - adapter->rx_int_delay = BURST_RDTR;\n>> - if (adapter->rx_abs_int_delay == DEFAULT_RADV)\n>> - adapter->rx_abs_int_delay = BURST_RADV;\n>> }\n>> /* set the Receive Delay Timer Register */\n>> diff --git a/drivers/net/ethernet/intel/e1000e/param.c \n>> b/drivers/net/ethernet/intel/e1000e/param.c\n>> index 6d8c39abee16..bb696c98f9b0 100644\n>> --- a/drivers/net/ethernet/intel/e1000e/param.c\n>> +++ b/drivers/net/ethernet/intel/e1000e/param.c\n>> @@ -73,17 +73,25 @@ E1000_PARAM(TxAbsIntDelay, \"Transmit Absolute \n>> Interrupt Delay\");\n>> /* Receive Interrupt Delay in units of 1.024 microseconds\n>> * hardware will likely hang if you set this to anything but zero.\n>> *\n>> + * Burst variant is used as default if device has FLAG2_DMA_BURST.\n>> + *\n>> * Valid Range: 0-65535\n>> */\n>> E1000_PARAM(RxIntDelay, \"Receive Interrupt Delay\");\n>> +#define DEFAULT_RDTR 0\n>> +#define BURST_RDTR 0x20\n>> #define MAX_RXDELAY 0xFFFF\n>> #define MIN_RXDELAY 0\n>> /* Receive Absolute Interrupt Delay in units of 1.024 microseconds\n>> + *\n>> + * Burst variant is used as default if device has FLAG2_DMA_BURST.\n>> *\n>> * Valid Range: 0-65535\n>> */\n>> E1000_PARAM(RxAbsIntDelay, \"Receive Absolute Interrupt Delay\");\n>> +#define DEFAULT_RADV 8\n>> +#define BURST_RADV 0x20\n>> #define MAX_RXABSDELAY 0xFFFF\n>> #define MIN_RXABSDELAY 0\n>> @@ -297,6 +305,9 @@ void e1000e_check_options(struct e1000_adapter \n>> *adapter)\n>> .max = MAX_RXDELAY } }\n>> };\n>> + if (adapter->flags2 & FLAG2_DMA_BURST)\n>> + opt.def = BURST_RDTR;\n>> +\n>> if (num_RxIntDelay > bd) {\n>> adapter->rx_int_delay = RxIntDelay[bd];\n>> e1000_validate_option(&adapter->rx_int_delay, &opt,\n>> @@ -307,7 +318,7 @@ void e1000e_check_options(struct e1000_adapter \n>> *adapter)\n>> }\n>> /* Receive Absolute Interrupt Delay */\n>> {\n>> - static const struct e1000_option opt = {\n>> + static struct e1000_option opt = {\n>> .type = range_option,\n>> .name = \"Receive Absolute Interrupt Delay\",\n>> .err = \"using default of \"\n>> @@ -317,6 +328,9 @@ void e1000e_check_options(struct e1000_adapter \n>> *adapter)\n>> .max = MAX_RXABSDELAY } }\n>> };\n>> + if (adapter->flags2 & FLAG2_DMA_BURST)\n>> + opt.def = BURST_RADV;\n>> +\n>> if (num_RxAbsIntDelay > bd) {\n>> adapter->rx_abs_int_delay = RxAbsIntDelay[bd];\n>> e1000_validate_option(&adapter->rx_abs_int_delay, &opt,\n>\n> This patch looks good for me, but I would like hear second opinion.\n>\n> _______________________________________________\n> Intel-wired-lan mailing list\n> Intel-wired-lan@osuosl.org\n> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=)","Received":["from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xg7SG1Tc5z9s7h\n\tfor ;\n\tSun, 27 Aug 2017 18:32:29 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id B937E2DA7F;\n\tSun, 27 Aug 2017 08:32:27 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id g9HMzgKAgTiB; Sun, 27 Aug 2017 08:32:23 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id D83FC2CDC8;\n\tSun, 27 Aug 2017 08:32:23 +0000 (UTC)","from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id DA1621C0479\n\tfor ;\n\tSun, 27 Aug 2017 08:32:21 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id D22FC89CA4\n\tfor ;\n\tSun, 27 Aug 2017 08:32:21 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id emsQA8NM8UBI for ;\n\tSun, 27 Aug 2017 08:32:21 +0000 (UTC)","from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 128A989C99\n\tfor ;\n\tSun, 27 Aug 2017 08:32:21 +0000 (UTC)","from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t27 Aug 2017 01:32:18 -0700","from unknown (HELO [10.185.202.95]) ([10.185.202.95])\n\tby fmsmga006.fm.intel.com with ESMTP; 27 Aug 2017 01:32:16 -0700"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.41,434,1498546800\"; d=\"scan'208\";a=\"144965964\"","To":"Willem de Bruijn ,\n\t\"jeffrey.t.kirsher@intel.com; alexander.h.duyck@intel.com;\n\traanan.avargil@intel.com; dima.ruinskiy\"@intel.com","References":"<20170825150626.2843-1-willemdebruijn.kernel@gmail.com>\n\t<291b863f-552e-2f3b-f658-e812d0848949@intel.com>","From":"\"Neftin, Sasha\" ","Message-ID":"","Date":"Sun, 27 Aug 2017 11:32:15 +0300","User-Agent":"Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101\n\tThunderbird/45.6.0","MIME-Version":"1.0","In-Reply-To":"<291b863f-552e-2f3b-f658-e812d0848949@intel.com>","Cc":"netdev@vger.kernel.org, Willem de Bruijn ,\n\tintel-wired-lan@lists.osuosl.org","Subject":"Re: [Intel-wired-lan] [PATCH] e1000e: apply burst mode settings\n\tonly on default","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t","List-Unsubscribe":", \n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":", \n\t","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":1758232,"web_url":"http://patchwork.ozlabs.org/comment/1758232/","msgid":"","list_archive_url":null,"date":"2017-08-27T08:34:10","subject":"Re: [Intel-wired-lan] [PATCH] e1000e: apply burst mode settings\n\tonly on default","submitter":{"id":69860,"url":"http://patchwork.ozlabs.org/api/people/69860/","name":"Sasha Neftin","email":"sasha.neftin@intel.com"},"content":"On 8/27/2017 11:32, Neftin, Sasha wrote:\n> On 8/27/2017 11:30, Neftin, Sasha wrote:\n>> On 8/25/2017 18:06, Willem de Bruijn wrote:\n>>> From: Willem de Bruijn \n>>>\n>>> Devices that support FLAG2_DMA_BURST have different default values\n>>> for RDTR and RADV. Apply burst mode default settings only when no\n>>> explicit value was passed at module load.\n>>>\n>>> The RDTR default is zero. If the module is loaded for low latency\n>>> operation with RxIntDelay=0, do not override this value with a burst\n>>> default of 32.\n>>>\n>>> Move the decision to apply burst values earlier, where explicitly\n>>> initialized module variables can be distinguished from defaults.\n>>>\n>>> Signed-off-by: Willem de Bruijn \n>>> ---\n>>> drivers/net/ethernet/intel/e1000e/e1000.h | 4 ----\n>>> drivers/net/ethernet/intel/e1000e/netdev.c | 8 --------\n>>> drivers/net/ethernet/intel/e1000e/param.c | 16 +++++++++++++++-\n>>> 3 files changed, 15 insertions(+), 13 deletions(-)\n>>>\n>>> diff --git a/drivers/net/ethernet/intel/e1000e/e1000.h \n>>> b/drivers/net/ethernet/intel/e1000e/e1000.h\n>>> index 98e68888abb1..2311b31bdcac 100644\n>>> --- a/drivers/net/ethernet/intel/e1000e/e1000.h\n>>> +++ b/drivers/net/ethernet/intel/e1000e/e1000.h\n>>> @@ -94,10 +94,6 @@ struct e1000_info;\n>>> */\n>>> #define E1000_CHECK_RESET_COUNT 25\n>>> -#define DEFAULT_RDTR 0\n>>> -#define DEFAULT_RADV 8\n>>> -#define BURST_RDTR 0x20\n>>> -#define BURST_RADV 0x20\n>>> #define PCICFG_DESC_RING_STATUS 0xe4\n>>> #define FLUSH_DESC_REQUIRED 0x100\n>>> diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c \n>>> b/drivers/net/ethernet/intel/e1000e/netdev.c\n>>> index 327dfe5bedc0..47b89aac7969 100644\n>>> --- a/drivers/net/ethernet/intel/e1000e/netdev.c\n>>> +++ b/drivers/net/ethernet/intel/e1000e/netdev.c\n>>> @@ -3223,14 +3223,6 @@ static void e1000_configure_rx(struct \n>>> e1000_adapter *adapter)\n>>> */\n>>> ew32(RXDCTL(0), E1000_RXDCTL_DMA_BURST_ENABLE);\n>>> ew32(RXDCTL(1), E1000_RXDCTL_DMA_BURST_ENABLE);\n>>> -\n>>> - /* override the delay timers for enabling bursting, only if\n>>> - * the value was not set by the user via module options\n>>> - */\n>>> - if (adapter->rx_int_delay == DEFAULT_RDTR)\n>>> - adapter->rx_int_delay = BURST_RDTR;\n>>> - if (adapter->rx_abs_int_delay == DEFAULT_RADV)\n>>> - adapter->rx_abs_int_delay = BURST_RADV;\n>>> }\n>>> /* set the Receive Delay Timer Register */\n>>> diff --git a/drivers/net/ethernet/intel/e1000e/param.c \n>>> b/drivers/net/ethernet/intel/e1000e/param.c\n>>> index 6d8c39abee16..bb696c98f9b0 100644\n>>> --- a/drivers/net/ethernet/intel/e1000e/param.c\n>>> +++ b/drivers/net/ethernet/intel/e1000e/param.c\n>>> @@ -73,17 +73,25 @@ E1000_PARAM(TxAbsIntDelay, \"Transmit Absolute \n>>> Interrupt Delay\");\n>>> /* Receive Interrupt Delay in units of 1.024 microseconds\n>>> * hardware will likely hang if you set this to anything but zero.\n>>> *\n>>> + * Burst variant is used as default if device has FLAG2_DMA_BURST.\n>>> + *\n>>> * Valid Range: 0-65535\n>>> */\n>>> E1000_PARAM(RxIntDelay, \"Receive Interrupt Delay\");\n>>> +#define DEFAULT_RDTR 0\n>>> +#define BURST_RDTR 0x20\n>>> #define MAX_RXDELAY 0xFFFF\n>>> #define MIN_RXDELAY 0\n>>> /* Receive Absolute Interrupt Delay in units of 1.024 microseconds\n>>> + *\n>>> + * Burst variant is used as default if device has FLAG2_DMA_BURST.\n>>> *\n>>> * Valid Range: 0-65535\n>>> */\n>>> E1000_PARAM(RxAbsIntDelay, \"Receive Absolute Interrupt Delay\");\n>>> +#define DEFAULT_RADV 8\n>>> +#define BURST_RADV 0x20\n>>> #define MAX_RXABSDELAY 0xFFFF\n>>> #define MIN_RXABSDELAY 0\n>>> @@ -297,6 +305,9 @@ void e1000e_check_options(struct e1000_adapter \n>>> *adapter)\n>>> .max = MAX_RXDELAY } }\n>>> };\n>>> + if (adapter->flags2 & FLAG2_DMA_BURST)\n>>> + opt.def = BURST_RDTR;\n>>> +\n>>> if (num_RxIntDelay > bd) {\n>>> adapter->rx_int_delay = RxIntDelay[bd];\n>>> e1000_validate_option(&adapter->rx_int_delay, &opt,\n>>> @@ -307,7 +318,7 @@ void e1000e_check_options(struct e1000_adapter \n>>> *adapter)\n>>> }\n>>> /* Receive Absolute Interrupt Delay */\n>>> {\n>>> - static const struct e1000_option opt = {\n>>> + static struct e1000_option opt = {\n>>> .type = range_option,\n>>> .name = \"Receive Absolute Interrupt Delay\",\n>>> .err = \"using default of \"\n>>> @@ -317,6 +328,9 @@ void e1000e_check_options(struct e1000_adapter \n>>> *adapter)\n>>> .max = MAX_RXABSDELAY } }\n>>> };\n>>> + if (adapter->flags2 & FLAG2_DMA_BURST)\n>>> + opt.def = BURST_RADV;\n>>> +\n>>> if (num_RxAbsIntDelay > bd) {\n>>> adapter->rx_abs_int_delay = RxAbsIntDelay[bd];\n>>> e1000_validate_option(&adapter->rx_abs_int_delay, &opt,\n>>\n>> This patch looks good for me, but I would like hear second opinion.\n>>\n>> _______________________________________________\n>> Intel-wired-lan mailing list\n>> Intel-wired-lan@osuosl.org\n>> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan\n>\n>\n> _______________________________________________\n> Intel-wired-lan mailing list\n> Intel-wired-lan@osuosl.org\n> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=)","Received":["from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xg7VM20wVz9sRm\n\tfor ;\n\tSun, 27 Aug 2017 18:34:18 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 2502E88C0B;\n\tSun, 27 Aug 2017 08:34:17 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id q0hTxPJwSlpL; Sun, 27 Aug 2017 08:34:16 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 04ADD88C04;\n\tSun, 27 Aug 2017 08:34:16 +0000 (UTC)","from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 920911C0479\n\tfor ;\n\tSun, 27 Aug 2017 08:34:14 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 846EC86B75\n\tfor ;\n\tSun, 27 Aug 2017 08:34:14 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id TSZu8N6pOQiy for ;\n\tSun, 27 Aug 2017 08:34:13 +0000 (UTC)","from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 6D3A486B74\n\tfor ;\n\tSun, 27 Aug 2017 08:34:13 +0000 (UTC)","from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t27 Aug 2017 01:34:13 -0700","from unknown (HELO [10.185.202.95]) ([10.185.202.95])\n\tby fmsmga006.fm.intel.com with ESMTP; 27 Aug 2017 01:34:10 -0700"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.41,434,1498546800\"; d=\"scan'208\";a=\"144966272\"","To":"Willem de Bruijn ,\n\tjeffrey.t.kirsher@intel.com, alexander.h.duyck@intel.com,\n\traanan.avargil@intel.com, dima.ruinskiy@intel.com","References":"<20170825150626.2843-1-willemdebruijn.kernel@gmail.com>\n\t<291b863f-552e-2f3b-f658-e812d0848949@intel.com>\n\t","From":"\"Neftin, Sasha\" ","Message-ID":"","Date":"Sun, 27 Aug 2017 11:34:10 +0300","User-Agent":"Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101\n\tThunderbird/45.6.0","MIME-Version":"1.0","In-Reply-To":"","Cc":"netdev@vger.kernel.org, Willem de Bruijn ,\n\tintel-wired-lan@lists.osuosl.org","Subject":"Re: [Intel-wired-lan] [PATCH] e1000e: apply burst mode settings\n\tonly on default","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t","List-Unsubscribe":", \n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":", \n\t","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":1758695,"web_url":"http://patchwork.ozlabs.org/comment/1758695/","msgid":"","list_archive_url":null,"date":"2017-08-28T16:25:46","subject":"Re: [Intel-wired-lan] [PATCH] e1000e: apply burst mode settings\n\tonly on default","submitter":{"id":252,"url":"http://patchwork.ozlabs.org/api/people/252/","name":"Alexander Duyck","email":"alexander.duyck@gmail.com"},"content":"On Sun, Aug 27, 2017 at 1:30 AM, Neftin, Sasha wrote:\n> On 8/25/2017 18:06, Willem de Bruijn wrote:\n>>\n>> From: Willem de Bruijn \n>>\n>> Devices that support FLAG2_DMA_BURST have different default values\n>> for RDTR and RADV. Apply burst mode default settings only when no\n>> explicit value was passed at module load.\n>>\n>> The RDTR default is zero. If the module is loaded for low latency\n>> operation with RxIntDelay=0, do not override this value with a burst\n>> default of 32.\n>>\n>> Move the decision to apply burst values earlier, where explicitly\n>> initialized module variables can be distinguished from defaults.\n>>\n>> Signed-off-by: Willem de Bruijn \n>\n> This patch looks good for me, but I would like hear second opinion.\n\nThis code is an improvement over what was already there. I am good with this.\n\nAcked-by: Alexander Duyck ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"IH0yfzzM\"; dkim-atps=neutral"],"Received":["from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xgxw2373nz9sNr\n\tfor ;\n\tTue, 29 Aug 2017 02:25:52 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 0F7D4306D5;\n\tMon, 28 Aug 2017 16:25:51 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id qxDvQa3G3fMs; Mon, 28 Aug 2017 16:25:49 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id D987C306D3;\n\tMon, 28 Aug 2017 16:25:49 +0000 (UTC)","from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id E97F31BF23B\n\tfor ;\n\tMon, 28 Aug 2017 16:25:48 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id DDED0306D3\n\tfor ;\n\tMon, 28 Aug 2017 16:25:48 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Aszz6kiMdCb0 for ;\n\tMon, 28 Aug 2017 16:25:48 +0000 (UTC)","from mail-qk0-f194.google.com (mail-qk0-f194.google.com\n\t[209.85.220.194])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 394AA22F1D\n\tfor ;\n\tMon, 28 Aug 2017 16:25:48 +0000 (UTC)","by mail-qk0-f194.google.com with SMTP id m4so852431qke.4\n\tfor ;\n\tMon, 28 Aug 2017 09:25:48 -0700 (PDT)","by 10.140.88.139 with HTTP; Mon, 28 Aug 2017 09:25:46 -0700 (PDT)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=yoK8DNBLgwUExzqd773FgY+HcdqYTV/OfL10636HAq0=;\n\tb=IH0yfzzM+k9ke0XGMCXyvmymUFx+UJzxWbOpTWyUbRcbdbn4SDCjcigjRnKzPh+kMT\n\tAjeyEZxZb4LDmqg3kc6E59DumeuQVeTcqJkO9LLDCQt49txfDcqb1umMKOpB2dOChN7Q\n\tzYPQdzqU57jxD+RPJq+Zb7Qxch1Fj55kfm9nFild6HI3TQeRrUCkgVI6bLYviq9V70EV\n\tvk7F97eD8uxJxUK/jOUB1LLuNvwiKOZ3ALnE3qipxsxW+ZEZxzCdzwKm+/+QFkAVU8of\n\tLErr+xjZjwEhPoV3O4T54cbAu6G75uOOEAytBDltvRP5lYWDbWoKCM2iGIgJ0GyM9Vrl\n\tf9Wg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=yoK8DNBLgwUExzqd773FgY+HcdqYTV/OfL10636HAq0=;\n\tb=Dl9ReREytp+g1vOchHM6WTVNPxWseNZ2mQuKsTHMAwly18xk/Y6hOAbdrjTiNiuFbm\n\t3m1hWXvOE+STgNaldSckjK0O3jPiFbBmRBCN4LiWzO2RPu2UiVQvH6GN6nU5DkVps4ZX\n\tJsdQH24iVi+SOhWBzgjvcPttTUc9DrTfy2fQdkf/P7NFbi8KATEXh7IHIi9vXNfQX2rS\n\tyl1l5RYkdpaBnSZxIF5vEM2Id4dVZ4K1czFF42tt1U1SQW6ehzimhkghHtT0MFV6G9y8\n\tZ8fzsLXO0Ui6e1zyX/9FtMpWvUNJw/6UT9tMrfUcJ/TbjnNiNwkoEvrHUnjdAT8/owlX\n\tVBfQ==","X-Gm-Message-State":"AHYfb5juMt+gfNUbj/GWGUzY2W+Vrny6elXH/F0CPKHIp7qzV6cLXxSp\n\tgSnrPHZYwH9/TSzKtvpd1wjJIIWC+w==","X-Received":"by 10.55.5.133 with SMTP id 127mr1486657qkf.103.1503937547374;\n\tMon, 28 Aug 2017 09:25:47 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<291b863f-552e-2f3b-f658-e812d0848949@intel.com>","References":"<20170825150626.2843-1-willemdebruijn.kernel@gmail.com>\n\t<291b863f-552e-2f3b-f658-e812d0848949@intel.com>","From":"Alexander Duyck ","Date":"Mon, 28 Aug 2017 09:25:46 -0700","Message-ID":"","To":"\"Neftin, Sasha\" ","Cc":"Netdev ,\n\tWillem de Bruijn ,\n\tintel-wired-lan ,\n\t\"jeffrey.t.kirsher@intel.com, alexander.h.duyck@intel.com,\n\traanan.avargil@intel.com, dima.ruinskiy\"@intel.com,\n\tWillem de Bruijn ","Subject":"Re: [Intel-wired-lan] [PATCH] e1000e: apply burst mode settings\n\tonly on default","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t","List-Unsubscribe":", \n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":", \n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":1768868,"web_url":"http://patchwork.ozlabs.org/comment/1768868/","msgid":"<309B89C4C689E141A5FF6A0C5FB2118B8C6A055D@ORSMSX101.amr.corp.intel.com>","list_archive_url":null,"date":"2017-09-14T23:48:29","subject":"Re: [Intel-wired-lan] [PATCH] e1000e: apply burst mode settings\n\tonly on default","submitter":{"id":37025,"url":"http://patchwork.ozlabs.org/api/people/37025/","name":"Brown, Aaron F","email":"aaron.f.brown@intel.com"},"content":"> From: netdev-owner@vger.kernel.org [mailto:netdev-\n> owner@vger.kernel.org] On Behalf Of Willem de Bruijn\n> Sent: Friday, August 25, 2017 8:06 AM\n> To: Kirsher, Jeffrey T \n> Cc: intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; Brandeburg,\n> Jesse ; Willem de Bruijn\n> \n> Subject: [PATCH] e1000e: apply burst mode settings only on default\n> \n> From: Willem de Bruijn \n> \n> Devices that support FLAG2_DMA_BURST have different default values\n> for RDTR and RADV. Apply burst mode default settings only when no\n> explicit value was passed at module load.\n> \n> The RDTR default is zero. If the module is loaded for low latency\n> operation with RxIntDelay=0, do not override this value with a burst\n> default of 32.\n> \n> Move the decision to apply burst values earlier, where explicitly\n> initialized module variables can be distinguished from defaults.\n> \n> Signed-off-by: Willem de Bruijn \n> ---\n> drivers/net/ethernet/intel/e1000e/e1000.h | 4 ----\n> drivers/net/ethernet/intel/e1000e/netdev.c | 8 --------\n> drivers/net/ethernet/intel/e1000e/param.c | 16 +++++++++++++++-\n> 3 files changed, 15 insertions(+), 13 deletions(-)\n\nTested-by: Aaron Brown ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=)","Received":["from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtZx36GZ9z9s7h\n\tfor ;\n\tFri, 15 Sep 2017 09:48:38 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id B69C3310D0;\n\tThu, 14 Sep 2017 23:48:36 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id rwLzBdH6YT9s; Thu, 14 Sep 2017 23:48:35 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id CE80D310C1;\n\tThu, 14 Sep 2017 23:48:35 +0000 (UTC)","from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 8100A1C0A2B\n\tfor ;\n\tThu, 14 Sep 2017 23:48:34 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 7A8B18AE1E\n\tfor ;\n\tThu, 14 Sep 2017 23:48:34 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Z9O81evBueZ6 for ;\n\tThu, 14 Sep 2017 23:48:33 +0000 (UTC)","from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id E407F8ADE0\n\tfor ;\n\tThu, 14 Sep 2017 23:48:32 +0000 (UTC)","from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t14 Sep 2017 16:48:31 -0700","from orsmsx104.amr.corp.intel.com ([10.22.225.131])\n\tby orsmga002.jf.intel.com with ESMTP; 14 Sep 2017 16:48:30 -0700","from orsmsx114.amr.corp.intel.com (10.22.240.10) by\n\tORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP\n\tServer (TLS) id 14.3.319.2; Thu, 14 Sep 2017 16:48:30 -0700","from orsmsx101.amr.corp.intel.com ([169.254.8.156]) by\n\tORSMSX114.amr.corp.intel.com ([169.254.8.209]) with mapi id\n\t14.03.0319.002; Thu, 14 Sep 2017 16:48:29 -0700"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,395,1500966000\"; d=\"scan'208\";a=\"135531480\"","From":"\"Brown, Aaron F\" ","To":"Willem de Bruijn , \"Kirsher, Jeffrey T\"\n\t","Thread-Topic":"[PATCH] e1000e: apply burst mode settings only on default","Thread-Index":"AQHTHbPBL3Bj9LyfJUO6CB7WHQj1U6K1Kucg","Date":"Thu, 14 Sep 2017 23:48:29 +0000","Message-ID":"<309B89C4C689E141A5FF6A0C5FB2118B8C6A055D@ORSMSX101.amr.corp.intel.com>","References":"<20170825150626.2843-1-willemdebruijn.kernel@gmail.com>","In-Reply-To":"<20170825150626.2843-1-willemdebruijn.kernel@gmail.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","dlp-product":"dlpe-windows","dlp-version":"11.0.0.116","dlp-reaction":"no-action","x-originating-ip":"[10.22.254.139]","MIME-Version":"1.0","Cc":"\"netdev@vger.kernel.org\" ,\n\tWillem de Bruijn ,\n\t\"intel-wired-lan@lists.osuosl.org\" ","Subject":"Re: [Intel-wired-lan] [PATCH] e1000e: apply burst mode settings\n\tonly on default","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t","List-Unsubscribe":", \n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":", \n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]