Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/804246/?format=api
{ "id": 804246, "url": "http://patchwork.ozlabs.org/api/patches/804246/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/1503373600-20847-1-git-send-email-bmeng.cn@gmail.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1503373600-20847-1-git-send-email-bmeng.cn@gmail.com>", "list_archive_url": null, "date": "2017-08-22T03:46:40", "name": "[U-Boot] blk: Remove various places that do flush cache after read", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "29d0908fea5ea40277b92b55873a9f8d5ef6e7dd", "submitter": { "id": 64981, "url": "http://patchwork.ozlabs.org/api/people/64981/?format=api", "name": "Bin Meng", "email": "bmeng.cn@gmail.com" }, "delegate": { "id": 3651, "url": "http://patchwork.ozlabs.org/api/users/3651/?format=api", "username": "trini", "first_name": "Tom", "last_name": "Rini", "email": "trini@ti.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/1503373600-20847-1-git-send-email-bmeng.cn@gmail.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/804246/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/804246/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Yn/UyWyT\"; dkim-atps=neutral" ], "Received": [ "from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xbxFy1XlYz9s8J\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 22 Aug 2017 13:42:28 +1000 (AEST)", "by lists.denx.de (Postfix, from userid 105)\n\tid 2C659C21E0D; Tue, 22 Aug 2017 03:42:23 +0000 (UTC)", "from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 2287CC21D65;\n\tTue, 22 Aug 2017 03:42:21 +0000 (UTC)", "by lists.denx.de (Postfix, from userid 105)\n\tid 69205C21D65; Tue, 22 Aug 2017 03:42:19 +0000 (UTC)", "from mail-io0-f196.google.com (mail-io0-f196.google.com\n\t[209.85.223.196])\n\tby lists.denx.de (Postfix) with ESMTPS id D59DAC21C26\n\tfor <u-boot@lists.denx.de>; Tue, 22 Aug 2017 03:42:18 +0000 (UTC)", "by mail-io0-f196.google.com with SMTP id p141so4323751iop.1\n\tfor <u-boot@lists.denx.de>; Mon, 21 Aug 2017 20:42:18 -0700 (PDT)", "from ala-d2121-lx1.wrs.com (unknown-156-139.windriver.com.\n\t[147.11.156.139]) by smtp.gmail.com with ESMTPSA id\n\tj3sm6359867iob.17.2017.08.21.20.42.14\n\t(version=TLS1_1 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tMon, 21 Aug 2017 20:42:16 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.0 required=5.0 tests=FREEMAIL_FROM, KHOP_BIG_TO_CC,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:subject:date:message-id;\n\tbh=cG5WQyp2XT5KiPs6s2ZZxoP3SgccXWl/0jevn/mYk70=;\n\tb=Yn/UyWyTC2PdqBfSQmObDqWl/wJNmo8bM8UyswZ5hm+UrtPUT+jwanRibQ7i47YlSr\n\toK6Q+6YAoTs8nRtB3pLedR3W7z4z4MjwCRx+ABIXJ9+n/zVSOyf5gHKu7wFPYb0hXbbk\n\tjaPt/SbL/hkdsCHhas9Jq4rfzvCOkNzAOCEOagOmaandc4nKKaH6zBBmTm7MSi2CHCam\n\tadG4oUBDnSuhi7frTjNNxf/YJX4BJV7q+h2qYpg8a43xoVD4H6azyAwBEB+TdY+t0AMp\n\twmK4sCaR6BiQHqMUPk6mV6urQcY0txcVBGMJ9YE8Gio/EVXR4DKJE+P1dwmq4Sd6D7YJ\n\tla8w==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:subject:date:message-id;\n\tbh=cG5WQyp2XT5KiPs6s2ZZxoP3SgccXWl/0jevn/mYk70=;\n\tb=iKhrb+uLMgsBNVtUxQvUTUTVbnyLV8pE0PrWIEWJd9Bw9V4LHldGchRqF3WLxNleuT\n\tRTwLAsN/nTU2epH11q8zfloQHKLTQnbZ4TeiL1wY5/0PVw5XZPCATRI+Tb13w2V/ctcd\n\ttUAdWRiahA5IIXbVY2cUANQOcgsFBJ77792zHp40hU93tqQbEGoz63CRBWmhz1rkJWOw\n\tvTBzRkDXMHOpTLqwX++RvpsQgnC6Ik5NZcjle70kQ1BGTdauEinSOuxbbe86vyfnvfem\n\tdCnNfg+ChkUddyq/6cfUEM5f0M4BwFV//M/eWGuFHYZqjdu8bXmrqXJ7aMwvUo9cMSpl\n\tV6uQ==", "X-Gm-Message-State": "AHYfb5jgF51ani+LSLUijPhAZ1SLIWKJIOQi2PeIvBG7SRDxJEO8+j/8\n\tpi6BHMk9+vjkXQ==", "X-Received": "by 10.107.202.5 with SMTP id a5mr15877856iog.46.1503373337429;\n\tMon, 21 Aug 2017 20:42:17 -0700 (PDT)", "From": "Bin Meng <bmeng.cn@gmail.com>", "To": "Grygorii Strashko <grygorii.strashko@ti.com>,\n\tMichal Simek <michal.simek@xilinx.com>, York Sun <york.sun@nxp.com>, \n\tAngelo Dureghello <angelo@sysam.it>,\n\tKever Yang <kever.yang@rock-chips.com>,\n\tJaehoon Chung <jh80.chung@samsung.com>,\n\tAlbert Aribaud <albert.u.boot@aribaud.net>,\n\tMarcel Ziswiler <marcel.ziswiler@toradex.com>,\n\tMarkus Niebel <Markus.Niebel@tq-group.com>,\n\tHou Zhiqiang <Zhiqiang.Hou@nxp.com>, Sumit Garg <sumit.garg@nxp.com>, \n\tJoe Hershberger <joe.hershberger@ni.com>, Stefan Roese <sr@denx.de>, \n\tWenbin Song <wenbin.song@nxp.com>, Zhao Qiang <qiang.zhao@nxp.com>,\n\tSimon Glass <sjg@chromium.org>,\n\tMax Krummenacher <max.krummenacher@toradex.com>,\n\tMasahiro Yamada <yamada.masahiro@socionext.com>,\n\tTomas Melin <tomas.melin@vaisala.com>,\n\tQianyu Gong <qianyu.gong@nxp.com>, Tom Rini <trini@konsulko.com>,\n\tU-Boot Mailing List <u-boot@lists.denx.de>", "Date": "Mon, 21 Aug 2017 20:46:40 -0700", "Message-Id": "<1503373600-20847-1-git-send-email-bmeng.cn@gmail.com>", "X-Mailer": "git-send-email 1.7.9.5", "Subject": "[U-Boot] [PATCH] blk: Remove various places that do flush cache\n\tafter read", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.18", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<http://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>" }, "content": "All these places seem to inherit the codes from the MMC driver where\na FIXME was put in the comment. However the correct operation after\nread should be cache invalidate, not flush.\n\nThe underlying drivers should be responsible for the cache operation.\nRemove these codes completely.\n\nSigned-off-by: Bin Meng <bmeng.cn@gmail.com>\n---\n\n arch/arm/cpu/armv8/fsl-layerscape/ppa.c | 15 ---------------\n board/toradex/common/tdx-cfg-block.c | 2 --\n cmd/mmc.c | 2 --\n drivers/block/blk-uclass.c | 3 ---\n drivers/block/blk_legacy.c | 3 ---\n drivers/net/fm/fm.c | 2 --\n drivers/net/phy/cortina.c | 2 --\n drivers/qe/qe.c | 2 --\n 8 files changed, 31 deletions(-)", "diff": "diff --git a/arch/arm/cpu/armv8/fsl-layerscape/ppa.c b/arch/arm/cpu/armv8/fsl-layerscape/ppa.c\nindex 24ddb5d..bbf8bba 100644\n--- a/arch/arm/cpu/armv8/fsl-layerscape/ppa.c\n+++ b/arch/arm/cpu/armv8/fsl-layerscape/ppa.c\n@@ -107,9 +107,6 @@ int ppa_init(void)\n \t\treturn -EIO;\n \t}\n \n-\t/* flush cache after read */\n-\tflush_cache((ulong)fitp, cnt * 512);\n-\n \tret = fdt_check_header(fitp);\n \tif (ret) {\n \t\tfree(fitp);\n@@ -134,9 +131,6 @@ int ppa_init(void)\n \t}\n \tdebug(\"Read PPA header to 0x%p\\n\", ppa_hdr_ddr);\n \n-\t/* flush cache after read */\n-\tflush_cache((ulong)ppa_hdr_ddr, cnt * 512);\n-\n \tppa_esbc_hdr = (uintptr_t)ppa_hdr_ddr;\n #endif\n \n@@ -164,9 +158,6 @@ int ppa_init(void)\n \t\treturn -EIO;\n \t}\n \n-\t/* flush cache after read */\n-\tflush_cache((ulong)ppa_fit_addr, cnt * 512);\n-\n #elif defined(CONFIG_SYS_LS_PPA_FW_IN_NAND)\n \tstruct fdt_header fit;\n \n@@ -208,9 +199,6 @@ int ppa_init(void)\n \t}\n \tdebug(\"Read PPA header to 0x%p\\n\", ppa_hdr_ddr);\n \n-\t/* flush cache after read */\n-\tflush_cache((ulong)ppa_hdr_ddr, fw_length);\n-\n \tppa_esbc_hdr = (uintptr_t)ppa_hdr_ddr;\n #endif\n \n@@ -232,9 +220,6 @@ int ppa_init(void)\n \t\t CONFIG_SYS_LS_PPA_FW_ADDR);\n \t\treturn -EIO;\n \t}\n-\n-\t/* flush cache after read */\n-\tflush_cache((ulong)ppa_fit_addr, fw_length);\n #else\n #error \"No CONFIG_SYS_LS_PPA_FW_IN_xxx defined\"\n #endif\ndiff --git a/board/toradex/common/tdx-cfg-block.c b/board/toradex/common/tdx-cfg-block.c\nindex 328c4c0..f850a3c 100644\n--- a/board/toradex/common/tdx-cfg-block.c\n+++ b/board/toradex/common/tdx-cfg-block.c\n@@ -129,8 +129,6 @@ static int tdx_cfg_block_mmc_storage(u8 *config_block, int write)\n \t\t\tret = -EIO;\n \t\t\tgoto out;\n \t\t}\n-\t\t/* Flush cache after read */\n-\t\tflush_cache((ulong)(unsigned char *)config_block, 512);\n \t} else {\n \t\t/* Just writing one 512 byte block */\n \t\tif (blk_dwrite(mmc_get_blk_desc(mmc), blk_start, 1,\ndiff --git a/cmd/mmc.c b/cmd/mmc.c\nindex 00697fc..5def4ea 100644\n--- a/cmd/mmc.c\n+++ b/cmd/mmc.c\n@@ -293,8 +293,6 @@ static int do_mmc_read(cmd_tbl_t *cmdtp, int flag,\n \t curr_device, blk, cnt);\n \n \tn = blk_dread(mmc_get_blk_desc(mmc), blk, cnt, addr);\n-\t/* flush cache after read */\n-\tflush_cache((ulong)addr, cnt * 512); /* FIXME */\n \tprintf(\"%d blocks read: %s\\n\", n, (n == cnt) ? \"OK\" : \"ERROR\");\n \n \treturn (n == cnt) ? CMD_RET_SUCCESS : CMD_RET_FAILURE;\ndiff --git a/drivers/block/blk-uclass.c b/drivers/block/blk-uclass.c\nindex 3aec569..e5f00dc 100644\n--- a/drivers/block/blk-uclass.c\n+++ b/drivers/block/blk-uclass.c\n@@ -294,9 +294,6 @@ ulong blk_read_devnum(enum if_type if_type, int devnum, lbaint_t start,\n \tif (IS_ERR_VALUE(n))\n \t\treturn n;\n \n-\t/* flush cache after read */\n-\tflush_cache((ulong)buffer, blkcnt * desc->blksz);\n-\n \treturn n;\n }\n \ndiff --git a/drivers/block/blk_legacy.c b/drivers/block/blk_legacy.c\nindex 981872e..16d3bfe 100644\n--- a/drivers/block/blk_legacy.c\n+++ b/drivers/block/blk_legacy.c\n@@ -232,9 +232,6 @@ ulong blk_read_devnum(enum if_type if_type, int devnum, lbaint_t start,\n \tif (IS_ERR_VALUE(n))\n \t\treturn n;\n \n-\t/* flush cache after read */\n-\tflush_cache((ulong)buffer, blkcnt * desc->blksz);\n-\n \treturn n;\n }\n \ndiff --git a/drivers/net/fm/fm.c b/drivers/net/fm/fm.c\nindex 451dfde..261f1b9 100644\n--- a/drivers/net/fm/fm.c\n+++ b/drivers/net/fm/fm.c\n@@ -405,8 +405,6 @@ int fm_init_common(int index, struct ccsr_fman *reg)\n \t\tmmc_init(mmc);\n \t\t(void)mmc->block_dev.block_read(&mmc->block_dev, blk, cnt,\n \t\t\t\t\t\taddr);\n-\t\t/* flush cache after read */\n-\t\tflush_cache((ulong)addr, cnt * 512);\n \t}\n #elif defined(CONFIG_SYS_QE_FMAN_FW_IN_REMOTE)\n \tvoid *addr = (void *)CONFIG_SYS_FMAN_FW_ADDR;\ndiff --git a/drivers/net/phy/cortina.c b/drivers/net/phy/cortina.c\nindex e0e9ed9..637d89a 100644\n--- a/drivers/net/phy/cortina.c\n+++ b/drivers/net/phy/cortina.c\n@@ -177,8 +177,6 @@ void cs4340_upload_firmware(struct phy_device *phydev)\n \t\tmmc_init(mmc);\n \t\t(void)mmc->block_dev.block_read(&mmc->block_dev, blk, cnt,\n \t\t\t\t\t\taddr);\n-\t\t/* flush cache after read */\n-\t\tflush_cache((ulong)addr, cnt * 512);\n \t}\n #endif\n \ndiff --git a/drivers/qe/qe.c b/drivers/qe/qe.c\nindex 24e764d..931c9d9 100644\n--- a/drivers/qe/qe.c\n+++ b/drivers/qe/qe.c\n@@ -221,8 +221,6 @@ void u_qe_init(void)\n \t\tmmc_init(mmc);\n \t\t(void)mmc->block_dev.block_read(&mmc->block_dev, blk, cnt,\n \t\t\t\t\t\taddr);\n-\t\t/* flush cache after read */\n-\t\tflush_cache((ulong)addr, cnt * 512);\n \t}\n #endif\n \tu_qe_upload_firmware(addr);\n", "prefixes": [ "U-Boot" ] }