[{"id":1753507,"web_url":"http://patchwork.ozlabs.org/comment/1753507/","msgid":"","list_archive_url":null,"date":"2017-08-22T06:19:11","subject":"Re: [U-Boot] [PATCH] blk: Remove various places that do flush cache\n\tafter read","submitter":{"id":13,"url":"http://patchwork.ozlabs.org/api/people/13/","name":"Stefan Roese","email":"sr@denx.de"},"content":"On 22.08.2017 05:46, Bin Meng wrote:\n> All these places seem to inherit the codes from the MMC driver where\n> a FIXME was put in the comment. However the correct operation after\n> read should be cache invalidate, not flush.\n> \n> The underlying drivers should be responsible for the cache operation.\n> Remove these codes completely.\n> \n> Signed-off-by: Bin Meng \n> ---\n> \n> arch/arm/cpu/armv8/fsl-layerscape/ppa.c | 15 ---------------\n> board/toradex/common/tdx-cfg-block.c | 2 --\n> cmd/mmc.c | 2 --\n> drivers/block/blk-uclass.c | 3 ---\n> drivers/block/blk_legacy.c | 3 ---\n> drivers/net/fm/fm.c | 2 --\n> drivers/net/phy/cortina.c | 2 --\n> drivers/qe/qe.c | 2 --\n> 8 files changed, 31 deletions(-)\n> \n> diff --git a/arch/arm/cpu/armv8/fsl-layerscape/ppa.c b/arch/arm/cpu/armv8/fsl-layerscape/ppa.c\n> index 24ddb5d..bbf8bba 100644\n> --- a/arch/arm/cpu/armv8/fsl-layerscape/ppa.c\n> +++ b/arch/arm/cpu/armv8/fsl-layerscape/ppa.c\n> @@ -107,9 +107,6 @@ int ppa_init(void)\n> \t\treturn -EIO;\n> \t}\n> \n> -\t/* flush cache after read */\n> -\tflush_cache((ulong)fitp, cnt * 512);\n> -\n> \tret = fdt_check_header(fitp);\n> \tif (ret) {\n> \t\tfree(fitp);\n> @@ -134,9 +131,6 @@ int ppa_init(void)\n> \t}\n> \tdebug(\"Read PPA header to 0x%p\\n\", ppa_hdr_ddr);\n> \n> -\t/* flush cache after read */\n> -\tflush_cache((ulong)ppa_hdr_ddr, cnt * 512);\n> -\n> \tppa_esbc_hdr = (uintptr_t)ppa_hdr_ddr;\n> #endif\n> \n> @@ -164,9 +158,6 @@ int ppa_init(void)\n> \t\treturn -EIO;\n> \t}\n> \n> -\t/* flush cache after read */\n> -\tflush_cache((ulong)ppa_fit_addr, cnt * 512);\n> -\n> #elif defined(CONFIG_SYS_LS_PPA_FW_IN_NAND)\n> \tstruct fdt_header fit;\n> \n> @@ -208,9 +199,6 @@ int ppa_init(void)\n> \t}\n> \tdebug(\"Read PPA header to 0x%p\\n\", ppa_hdr_ddr);\n> \n> -\t/* flush cache after read */\n> -\tflush_cache((ulong)ppa_hdr_ddr, fw_length);\n> -\n> \tppa_esbc_hdr = (uintptr_t)ppa_hdr_ddr;\n> #endif\n> \n> @@ -232,9 +220,6 @@ int ppa_init(void)\n> \t\t CONFIG_SYS_LS_PPA_FW_ADDR);\n> \t\treturn -EIO;\n> \t}\n> -\n> -\t/* flush cache after read */\n> -\tflush_cache((ulong)ppa_fit_addr, fw_length);\n> #else\n> #error \"No CONFIG_SYS_LS_PPA_FW_IN_xxx defined\"\n> #endif\n> diff --git a/board/toradex/common/tdx-cfg-block.c b/board/toradex/common/tdx-cfg-block.c\n> index 328c4c0..f850a3c 100644\n> --- a/board/toradex/common/tdx-cfg-block.c\n> +++ b/board/toradex/common/tdx-cfg-block.c\n> @@ -129,8 +129,6 @@ static int tdx_cfg_block_mmc_storage(u8 *config_block, int write)\n> \t\t\tret = -EIO;\n> \t\t\tgoto out;\n> \t\t}\n> -\t\t/* Flush cache after read */\n> -\t\tflush_cache((ulong)(unsigned char *)config_block, 512);\n> \t} else {\n> \t\t/* Just writing one 512 byte block */\n> \t\tif (blk_dwrite(mmc_get_blk_desc(mmc), blk_start, 1,\n> diff --git a/cmd/mmc.c b/cmd/mmc.c\n> index 00697fc..5def4ea 100644\n> --- a/cmd/mmc.c\n> +++ b/cmd/mmc.c\n> @@ -293,8 +293,6 @@ static int do_mmc_read(cmd_tbl_t *cmdtp, int flag,\n> \t curr_device, blk, cnt);\n> \n> \tn = blk_dread(mmc_get_blk_desc(mmc), blk, cnt, addr);\n> -\t/* flush cache after read */\n> -\tflush_cache((ulong)addr, cnt * 512); /* FIXME */\n> \tprintf(\"%d blocks read: %s\\n\", n, (n == cnt) ? \"OK\" : \"ERROR\");\n> \n> \treturn (n == cnt) ? CMD_RET_SUCCESS : CMD_RET_FAILURE;\n> diff --git a/drivers/block/blk-uclass.c b/drivers/block/blk-uclass.c\n> index 3aec569..e5f00dc 100644\n> --- a/drivers/block/blk-uclass.c\n> +++ b/drivers/block/blk-uclass.c\n> @@ -294,9 +294,6 @@ ulong blk_read_devnum(enum if_type if_type, int devnum, lbaint_t start,\n> \tif (IS_ERR_VALUE(n))\n> \t\treturn n;\n> \n> -\t/* flush cache after read */\n> -\tflush_cache((ulong)buffer, blkcnt * desc->blksz);\n> -\n> \treturn n;\n> }\n> \n> diff --git a/drivers/block/blk_legacy.c b/drivers/block/blk_legacy.c\n> index 981872e..16d3bfe 100644\n> --- a/drivers/block/blk_legacy.c\n> +++ b/drivers/block/blk_legacy.c\n> @@ -232,9 +232,6 @@ ulong blk_read_devnum(enum if_type if_type, int devnum, lbaint_t start,\n> \tif (IS_ERR_VALUE(n))\n> \t\treturn n;\n> \n> -\t/* flush cache after read */\n> -\tflush_cache((ulong)buffer, blkcnt * desc->blksz);\n> -\n> \treturn n;\n> }\n> \n> diff --git a/drivers/net/fm/fm.c b/drivers/net/fm/fm.c\n> index 451dfde..261f1b9 100644\n> --- a/drivers/net/fm/fm.c\n> +++ b/drivers/net/fm/fm.c\n> @@ -405,8 +405,6 @@ int fm_init_common(int index, struct ccsr_fman *reg)\n> \t\tmmc_init(mmc);\n> \t\t(void)mmc->block_dev.block_read(&mmc->block_dev, blk, cnt,\n> \t\t\t\t\t\taddr);\n> -\t\t/* flush cache after read */\n> -\t\tflush_cache((ulong)addr, cnt * 512);\n> \t}\n> #elif defined(CONFIG_SYS_QE_FMAN_FW_IN_REMOTE)\n> \tvoid *addr = (void *)CONFIG_SYS_FMAN_FW_ADDR;\n> diff --git a/drivers/net/phy/cortina.c b/drivers/net/phy/cortina.c\n> index e0e9ed9..637d89a 100644\n> --- a/drivers/net/phy/cortina.c\n> +++ b/drivers/net/phy/cortina.c\n> @@ -177,8 +177,6 @@ void cs4340_upload_firmware(struct phy_device *phydev)\n> \t\tmmc_init(mmc);\n> \t\t(void)mmc->block_dev.block_read(&mmc->block_dev, blk, cnt,\n> \t\t\t\t\t\taddr);\n> -\t\t/* flush cache after read */\n> -\t\tflush_cache((ulong)addr, cnt * 512);\n> \t}\n> #endif\n> \n> diff --git a/drivers/qe/qe.c b/drivers/qe/qe.c\n> index 24e764d..931c9d9 100644\n> --- a/drivers/qe/qe.c\n> +++ b/drivers/qe/qe.c\n> @@ -221,8 +221,6 @@ void u_qe_init(void)\n> \t\tmmc_init(mmc);\n> \t\t(void)mmc->block_dev.block_read(&mmc->block_dev, blk, cnt,\n> \t\t\t\t\t\taddr);\n> -\t\t/* flush cache after read */\n> -\t\tflush_cache((ulong)addr, cnt * 512);\n> \t}\n> #endif\n> \tu_qe_upload_firmware(addr);\n> \n\nDid you experience any problems with the \"incorrect\" code in the\nMMC driver?\n\nWithout looking into the underlying driver, your explanation makes\nperfect sense and flushing is wrong after a read of course. So:\n\nReviewed-by: Stefan Roese \n\nThanks,\nStefan","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xc0lM235xz9t24\n\tfor ;\n\tTue, 22 Aug 2017 16:19:41 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 85ED3C21DCA; Tue, 22 Aug 2017 06:19:35 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 63FA8C21C4E;\n\tTue, 22 Aug 2017 06:19:32 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 38588C21C4E; Tue, 22 Aug 2017 06:19:31 +0000 (UTC)","from mx2.mailbox.org (mx2.mailbox.org [80.241.60.215])\n\tby lists.denx.de (Postfix) with ESMTPS id E9DF6C21C26\n\tfor ; Tue, 22 Aug 2017 06:19:30 +0000 (UTC)","from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mx2.mailbox.org (Postfix) with ESMTPS id 6FD5645E39;\n\tTue, 22 Aug 2017 08:19:29 +0200 (CEST)","from smtp1.mailbox.org ([80.241.60.240])\n\tby spamfilter01.heinlein-hosting.de (spamfilter01.heinlein-hosting.de\n\t[80.241.56.115]) (amavisd-new, port 10030)\n\twith ESMTP id lD4V6zbObmUp; Tue, 22 Aug 2017 08:19:16 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=KHOP_BIG_TO_CC,\n\tRCVD_IN_DNSWL_LOW autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Virus-Scanned":"amavisd-new at heinlein-support.de","To":"Bin Meng ,\n\tGrygorii Strashko ,\n\tMichal Simek , York Sun , \n\tAngelo Dureghello ,\n\tKever Yang , \n\tJaehoon Chung ,\n\tAlbert Aribaud ,\n\tMarcel Ziswiler ,\n\tMarkus Niebel ,\n\tHou Zhiqiang , Sumit Garg , \n\tJoe Hershberger ,\n\tWenbin Song , \n\tZhao Qiang , Simon Glass ,\n\tMax Krummenacher ,\n\tMasahiro Yamada ,\n\tTomas Melin ,\n\tQianyu Gong , Tom Rini ,\n\tU-Boot Mailing List ","References":"<1503373600-20847-1-git-send-email-bmeng.cn@gmail.com>","From":"Stefan Roese ","Message-ID":"","Date":"Tue, 22 Aug 2017 08:19:11 +0200","MIME-Version":"1.0","In-Reply-To":"<1503373600-20847-1-git-send-email-bmeng.cn@gmail.com>","Content-Language":"en-US","Subject":"Re: [U-Boot] [PATCH] blk: Remove various places that do flush cache\n\tafter read","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1753515,"web_url":"http://patchwork.ozlabs.org/comment/1753515/","msgid":"","list_archive_url":null,"date":"2017-08-22T06:31:05","subject":"Re: [U-Boot] [PATCH] blk: Remove various places that do flush cache\n\tafter read","submitter":{"id":64981,"url":"http://patchwork.ozlabs.org/api/people/64981/","name":"Bin Meng","email":"bmeng.cn@gmail.com"},"content":"Hi Stefan,\n\nOn Tue, Aug 22, 2017 at 2:19 PM, Stefan Roese wrote:\n> On 22.08.2017 05:46, Bin Meng wrote:\n>>\n>> All these places seem to inherit the codes from the MMC driver where\n>> a FIXME was put in the comment. However the correct operation after\n>> read should be cache invalidate, not flush.\n>>\n>> The underlying drivers should be responsible for the cache operation.\n>> Remove these codes completely.\n>>\n>> Signed-off-by: Bin Meng \n>> ---\n>>\n>> arch/arm/cpu/armv8/fsl-layerscape/ppa.c | 15 ---------------\n>> board/toradex/common/tdx-cfg-block.c | 2 --\n>> cmd/mmc.c | 2 --\n>> drivers/block/blk-uclass.c | 3 ---\n>> drivers/block/blk_legacy.c | 3 ---\n>> drivers/net/fm/fm.c | 2 --\n>> drivers/net/phy/cortina.c | 2 --\n>> drivers/qe/qe.c | 2 --\n>> 8 files changed, 31 deletions(-)\n>>\n>> diff --git a/arch/arm/cpu/armv8/fsl-layerscape/ppa.c\n>> b/arch/arm/cpu/armv8/fsl-layerscape/ppa.c\n>> index 24ddb5d..bbf8bba 100644\n>> --- a/arch/arm/cpu/armv8/fsl-layerscape/ppa.c\n>> +++ b/arch/arm/cpu/armv8/fsl-layerscape/ppa.c\n>> @@ -107,9 +107,6 @@ int ppa_init(void)\n>> return -EIO;\n>> }\n>> - /* flush cache after read */\n>> - flush_cache((ulong)fitp, cnt * 512);\n>> -\n>> ret = fdt_check_header(fitp);\n>> if (ret) {\n>> free(fitp);\n>> @@ -134,9 +131,6 @@ int ppa_init(void)\n>> }\n>> debug(\"Read PPA header to 0x%p\\n\", ppa_hdr_ddr);\n>> - /* flush cache after read */\n>> - flush_cache((ulong)ppa_hdr_ddr, cnt * 512);\n>> -\n>> ppa_esbc_hdr = (uintptr_t)ppa_hdr_ddr;\n>> #endif\n>> @@ -164,9 +158,6 @@ int ppa_init(void)\n>> return -EIO;\n>> }\n>> - /* flush cache after read */\n>> - flush_cache((ulong)ppa_fit_addr, cnt * 512);\n>> -\n>> #elif defined(CONFIG_SYS_LS_PPA_FW_IN_NAND)\n>> struct fdt_header fit;\n>> @@ -208,9 +199,6 @@ int ppa_init(void)\n>> }\n>> debug(\"Read PPA header to 0x%p\\n\", ppa_hdr_ddr);\n>> - /* flush cache after read */\n>> - flush_cache((ulong)ppa_hdr_ddr, fw_length);\n>> -\n>> ppa_esbc_hdr = (uintptr_t)ppa_hdr_ddr;\n>> #endif\n>> @@ -232,9 +220,6 @@ int ppa_init(void)\n>> CONFIG_SYS_LS_PPA_FW_ADDR);\n>> return -EIO;\n>> }\n>> -\n>> - /* flush cache after read */\n>> - flush_cache((ulong)ppa_fit_addr, fw_length);\n>> #else\n>> #error \"No CONFIG_SYS_LS_PPA_FW_IN_xxx defined\"\n>> #endif\n>> diff --git a/board/toradex/common/tdx-cfg-block.c\n>> b/board/toradex/common/tdx-cfg-block.c\n>> index 328c4c0..f850a3c 100644\n>> --- a/board/toradex/common/tdx-cfg-block.c\n>> +++ b/board/toradex/common/tdx-cfg-block.c\n>> @@ -129,8 +129,6 @@ static int tdx_cfg_block_mmc_storage(u8 *config_block,\n>> int write)\n>> ret = -EIO;\n>> goto out;\n>> }\n>> - /* Flush cache after read */\n>> - flush_cache((ulong)(unsigned char *)config_block, 512);\n>> } else {\n>> /* Just writing one 512 byte block */\n>> if (blk_dwrite(mmc_get_blk_desc(mmc), blk_start, 1,\n>> diff --git a/cmd/mmc.c b/cmd/mmc.c\n>> index 00697fc..5def4ea 100644\n>> --- a/cmd/mmc.c\n>> +++ b/cmd/mmc.c\n>> @@ -293,8 +293,6 @@ static int do_mmc_read(cmd_tbl_t *cmdtp, int flag,\n>> curr_device, blk, cnt);\n>> n = blk_dread(mmc_get_blk_desc(mmc), blk, cnt, addr);\n>> - /* flush cache after read */\n>> - flush_cache((ulong)addr, cnt * 512); /* FIXME */\n>> printf(\"%d blocks read: %s\\n\", n, (n == cnt) ? \"OK\" : \"ERROR\");\n>> return (n == cnt) ? CMD_RET_SUCCESS : CMD_RET_FAILURE;\n>> diff --git a/drivers/block/blk-uclass.c b/drivers/block/blk-uclass.c\n>> index 3aec569..e5f00dc 100644\n>> --- a/drivers/block/blk-uclass.c\n>> +++ b/drivers/block/blk-uclass.c\n>> @@ -294,9 +294,6 @@ ulong blk_read_devnum(enum if_type if_type, int\n>> devnum, lbaint_t start,\n>> if (IS_ERR_VALUE(n))\n>> return n;\n>> - /* flush cache after read */\n>> - flush_cache((ulong)buffer, blkcnt * desc->blksz);\n>> -\n>> return n;\n>> }\n>> diff --git a/drivers/block/blk_legacy.c b/drivers/block/blk_legacy.c\n>> index 981872e..16d3bfe 100644\n>> --- a/drivers/block/blk_legacy.c\n>> +++ b/drivers/block/blk_legacy.c\n>> @@ -232,9 +232,6 @@ ulong blk_read_devnum(enum if_type if_type, int\n>> devnum, lbaint_t start,\n>> if (IS_ERR_VALUE(n))\n>> return n;\n>> - /* flush cache after read */\n>> - flush_cache((ulong)buffer, blkcnt * desc->blksz);\n>> -\n>> return n;\n>> }\n>> diff --git a/drivers/net/fm/fm.c b/drivers/net/fm/fm.c\n>> index 451dfde..261f1b9 100644\n>> --- a/drivers/net/fm/fm.c\n>> +++ b/drivers/net/fm/fm.c\n>> @@ -405,8 +405,6 @@ int fm_init_common(int index, struct ccsr_fman *reg)\n>> mmc_init(mmc);\n>> (void)mmc->block_dev.block_read(&mmc->block_dev, blk, cnt,\n>> addr);\n>> - /* flush cache after read */\n>> - flush_cache((ulong)addr, cnt * 512);\n>> }\n>> #elif defined(CONFIG_SYS_QE_FMAN_FW_IN_REMOTE)\n>> void *addr = (void *)CONFIG_SYS_FMAN_FW_ADDR;\n>> diff --git a/drivers/net/phy/cortina.c b/drivers/net/phy/cortina.c\n>> index e0e9ed9..637d89a 100644\n>> --- a/drivers/net/phy/cortina.c\n>> +++ b/drivers/net/phy/cortina.c\n>> @@ -177,8 +177,6 @@ void cs4340_upload_firmware(struct phy_device *phydev)\n>> mmc_init(mmc);\n>> (void)mmc->block_dev.block_read(&mmc->block_dev, blk, cnt,\n>> addr);\n>> - /* flush cache after read */\n>> - flush_cache((ulong)addr, cnt * 512);\n>> }\n>> #endif\n>> diff --git a/drivers/qe/qe.c b/drivers/qe/qe.c\n>> index 24e764d..931c9d9 100644\n>> --- a/drivers/qe/qe.c\n>> +++ b/drivers/qe/qe.c\n>> @@ -221,8 +221,6 @@ void u_qe_init(void)\n>> mmc_init(mmc);\n>> (void)mmc->block_dev.block_read(&mmc->block_dev, blk, cnt,\n>> addr);\n>> - /* flush cache after read */\n>> - flush_cache((ulong)addr, cnt * 512);\n>> }\n>> #endif\n>> u_qe_upload_firmware(addr);\n>>\n>\n> Did you experience any problems with the \"incorrect\" code in the\n> MMC driver?\n>\n\nNo, since I have been mostly working on x86, and on x86 cache\nflush/invalidate is a nop, so no problems were seen.\n\n> Without looking into the underlying driver, your explanation makes\n> perfect sense and flushing is wrong after a read of course. So:\n>\n\nYes, I doubt how these codes were working on other platforms where\ncache operations are really needed. I just noticed that when I was\nworking on NVMe stuff.\n\n> Reviewed-by: Stefan Roese \n\nRegards,\nBin","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"PfErkXO4\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xc10f2dJjz9t2S\n\tfor ;\n\tTue, 22 Aug 2017 16:31:14 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 1F264C21DF7; Tue, 22 Aug 2017 06:31:11 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 62CDEC21D84;\n\tTue, 22 Aug 2017 06:31:08 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid CA39BC21D84; Tue, 22 Aug 2017 06:31:06 +0000 (UTC)","from mail-wr0-f196.google.com (mail-wr0-f196.google.com\n\t[209.85.128.196])\n\tby lists.denx.de (Postfix) with ESMTPS id 7ACAEC21C26\n\tfor ; Tue, 22 Aug 2017 06:31:06 +0000 (UTC)","by mail-wr0-f196.google.com with SMTP id p14so15635786wrg.1\n\tfor ; Mon, 21 Aug 2017 23:31:06 -0700 (PDT)","by 10.223.135.121 with HTTP; Mon, 21 Aug 2017 23:31:05 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=FREEMAIL_FROM, KHOP_BIG_TO_CC,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=3qM5EgAuHg5dY7A6RG9HmjkdBcasf0rvVYYt4yhCIA4=;\n\tb=PfErkXO4M1mV49oWYJ+Ybu+JJ2TulselxkjtJMOmK4AYRTUaFI1COFppuSfJWJ5Eo8\n\tHXRbMl8ucNwvXcmjgL0xyDCW02TTZHkz7iHfeba1VlsJQcEQuGEQK61IbaUn5Mo9G9fK\n\tgV4t6EMK1YF28FJ9ankOolcb9E6phowYWdRmPBF22xuwYYki3DElGNxNyg4mfKYxXNMu\n\tyyUvG6BHGCwSbZRrzpKmvjCEEgm3R6oGXmIvIJhh4HEx1eImrh2FDgmvLPsXxUR2Aoaz\n\tvETc11f19WLfzhVMNBGsiub+S2eR7IFDvwQV3x7DrzwoCbe4xoHI8uQg41uPrTdvq1Ga\n\tv1ug==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=3qM5EgAuHg5dY7A6RG9HmjkdBcasf0rvVYYt4yhCIA4=;\n\tb=TXxwYnKZuYgmJ0riqeoGzYxV9zipiybQKKi1JryxHdQEoPro5GITVzqrDPFa1UhzLR\n\t80/T8IqtJZGTeYKtHqyrbBaQx3Jce1/YtI9my5B8KlWTMor/Ffy9sp92SDcwOThFKu5f\n\tPXLN3r8KkrCHXj8s2jahRU6/lzh4cWcNDqFRoJKsHz7n8tVTjaFN4XXb72U5iSvms1vG\n\tKCCh3Idc19YFor+6VevDum5HIjLvkNp1p+GeM6d4axR5pBuNF34apdpmWy2EHrlej7Vt\n\t2ggE/9qjOCqwsnlWghD61djDIXb7JoVHW3ra2n57/IVaHKiAV2o7M7kf48a2BqkZZFmS\n\tX8iw==","X-Gm-Message-State":"AHYfb5j79MbKMqABdvJ4tOtL6oLEFuKnyjhPgTyVuYOM2BWKj7qK1WC5\n\tkFDAyrOCj0wqPMmVWgcahrnihuL0Dw==","X-Received":"by 10.28.154.215 with SMTP id c206mr2088971wme.151.1503383465997;\n\tMon, 21 Aug 2017 23:31:05 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<1503373600-20847-1-git-send-email-bmeng.cn@gmail.com>\n\t","From":"Bin Meng ","Date":"Tue, 22 Aug 2017 14:31:05 +0800","Message-ID":"","To":"Stefan Roese ","Cc":"Albert Aribaud , Tom Rini ,\n\tU-Boot Mailing List ,\n\tAngelo Dureghello ,\n\tMarcel Ziswiler ,\n\tHou Zhiqiang ,\n\tMichal Simek , \n\tWenbin Song ,\n\tJoe Hershberger , \n\tMax Krummenacher ,\n\tMarkus Niebel ","Subject":"Re: [U-Boot] [PATCH] blk: Remove various places that do flush cache\n\tafter read","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1754232,"web_url":"http://patchwork.ozlabs.org/comment/1754232/","msgid":"","list_archive_url":null,"date":"2017-08-22T16:49:10","subject":"Re: [U-Boot] [PATCH] blk: Remove various places that do flush cache\n\tafter read","submitter":{"id":67822,"url":"http://patchwork.ozlabs.org/api/people/67822/","name":"York Sun","email":"york.sun@nxp.com"},"content":"On 08/21/2017 08:42 PM, Bin Meng wrote:\n> All these places seem to inherit the codes from the MMC driver where\n> a FIXME was put in the comment. However the correct operation after\n> read should be cache invalidate, not flush.\n> \n> The underlying drivers should be responsible for the cache operation.\n> Remove these codes completely.\n> \n> Signed-off-by: Bin Meng \n> ---\n> \n> arch/arm/cpu/armv8/fsl-layerscape/ppa.c | 15 ---------------\n> board/toradex/common/tdx-cfg-block.c | 2 --\n> cmd/mmc.c | 2 --\n> drivers/block/blk-uclass.c | 3 ---\n> drivers/block/blk_legacy.c | 3 ---\n> drivers/net/fm/fm.c | 2 --\n> drivers/net/phy/cortina.c | 2 --\n> drivers/qe/qe.c | 2 --\n> 8 files changed, 31 deletions(-)\n> \n> diff --git a/arch/arm/cpu/armv8/fsl-layerscape/ppa.c b/arch/arm/cpu/armv8/fsl-layerscape/ppa.c\n> index 24ddb5d..bbf8bba 100644\n> --- a/arch/arm/cpu/armv8/fsl-layerscape/ppa.c\n> +++ b/arch/arm/cpu/armv8/fsl-layerscape/ppa.c\n> @@ -107,9 +107,6 @@ int ppa_init(void)\n> \t\treturn -EIO;\n> \t}\n> \n> -\t/* flush cache after read */\n> -\tflush_cache((ulong)fitp, cnt * 512);\n> -\n\nNACK here.\n\n\n> \tret = fdt_check_header(fitp);\n> \tif (ret) {\n> \t\tfree(fitp);\n> @@ -134,9 +131,6 @@ int ppa_init(void)\n> \t}\n> \tdebug(\"Read PPA header to 0x%p\\n\", ppa_hdr_ddr);\n> \n> -\t/* flush cache after read */\n> -\tflush_cache((ulong)ppa_hdr_ddr, cnt * 512);\n> -\n> \tppa_esbc_hdr = (uintptr_t)ppa_hdr_ddr;\n> #endif\n> \n> @@ -164,9 +158,6 @@ int ppa_init(void)\n> \t\treturn -EIO;\n> \t}\n> \n> -\t/* flush cache after read */\n> -\tflush_cache((ulong)ppa_fit_addr, cnt * 512);\n> -\n> #elif defined(CONFIG_SYS_LS_PPA_FW_IN_NAND)\n> \tstruct fdt_header fit;\n> \n> @@ -208,9 +199,6 @@ int ppa_init(void)\n> \t}\n> \tdebug(\"Read PPA header to 0x%p\\n\", ppa_hdr_ddr);\n> \n> -\t/* flush cache after read */\n> -\tflush_cache((ulong)ppa_hdr_ddr, fw_length);\n> -\n> \tppa_esbc_hdr = (uintptr_t)ppa_hdr_ddr;\n> #endif\n> \n> @@ -232,9 +220,6 @@ int ppa_init(void)\n> \t\t CONFIG_SYS_LS_PPA_FW_ADDR);\n> \t\treturn -EIO;\n> \t}\n> -\n> -\t/* flush cache after read */\n> -\tflush_cache((ulong)ppa_fit_addr, fw_length);\n> #else\n> #error \"No CONFIG_SYS_LS_PPA_FW_IN_xxx defined\"\n> #endif\n\nHold on for ppa.c. We need to flush the cache after reading PPA image \nand it header after loading. These images need to be flushed into main \nmemory. I will need to confirm with our team if we can remove flushing here.\n\nYork","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"Gf3GlT5+\";\n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=york.sun@nxp.com; "],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xcGjz5mGGz9sRq\n\tfor ;\n\tWed, 23 Aug 2017 02:49:27 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 87EEAC21EF6; Tue, 22 Aug 2017 16:49:19 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id AF0DCC21DAC;\n\tTue, 22 Aug 2017 16:49:16 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 68A8CC21DAC; Tue, 22 Aug 2017 16:49:14 +0000 (UTC)","from EUR01-DB5-obe.outbound.protection.outlook.com\n\t(mail-db5eur01on0049.outbound.protection.outlook.com [104.47.2.49])\n\tby lists.denx.de (Postfix) with ESMTPS id E6F52C21C40\n\tfor ; Tue, 22 Aug 2017 16:49:13 +0000 (UTC)","from VI1PR04MB2078.eurprd04.prod.outlook.com (10.166.43.18) by\n\tVI1PR04MB3085.eurprd04.prod.outlook.com (10.170.228.159) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.1.1341.21; Tue, 22 Aug 2017 16:49:11 +0000","from VI1PR04MB2078.eurprd04.prod.outlook.com\n\t([fe80::5ce6:46c1:8a2c:ca59]) by\n\tVI1PR04MB2078.eurprd04.prod.outlook.com\n\t([fe80::5ce6:46c1:8a2c:ca59%14]) with mapi id 15.01.1362.019;\n\tTue, 22 Aug 2017 16:49:11 +0000"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=KHOP_BIG_TO_CC,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,\n\tSPF_HELO_PASS, \n\tT_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=eZENvhUTVS7SS0rrvhsd4Z3QuCm89+gAX/5YrHLRcPo=;\n\tb=Gf3GlT5+AnzsA8MmXxKioMD8/FP8YqR92c8L71/j/pJZIiUm/GKvgdDWf+3s5O9gAIUljx+dMzx6JMq1FNN8apu7dDAlWpaFaX3+F79E6rEs9DoOBDiOxRKmDk8YEPYwzYITmwUW+q+303OOWX7BAyMkdzq8U719I/GBgjm62Nk=","From":"York Sun ","To":"Bin Meng , Grygorii Strashko\n\t, Michal Simek ,\n\t\"Angelo\n\tDureghello\" , Kever Yang ,\n\t\"Jaehoon Chung\" , Albert Aribaud\n\t,\n\tMarcel Ziswiler , \n\tMarkus Niebel , \"Z.q. Hou\"\n\t, Sumit Garg , Joe Hershberger\n\t, Stefan Roese , Wenbin Song\n\t, Qiang Zhao , Simon Glass\n\t, Max Krummenacher ,\n\tMasahiro Yamada , Tomas Melin\n\t, \"Q.y. Gong\" , Tom Rini\n\t, \"U-Boot Mailing List\" ","Thread-Topic":"[PATCH] blk: Remove various places that do flush cache after\n\tread","Thread-Index":"AQHTGvirDLgrxsdG5k+zJcYDaJ+jPw==","Date":"Tue, 22 Aug 2017 16:49:10 +0000","Message-ID":"","References":"<1503373600-20847-1-git-send-email-bmeng.cn@gmail.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"Gf3GlT5+\";\n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=york.sun@nxp.com; "],"x-originating-ip":"[192.88.168.1]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; VI1PR04MB3085;\n\t6:zPDKMkG7AMYgupTLIYpTZ8f4g/F4tT3xAsmCSufHljPkuDXTMm5C6LlYKpsSC77yDmnTIKx/ajGRWcu6wZotGVe+so0Ubte3rq4xZA+EVhXDXb0HX/hfSt5gkcbb2kGF6wk+6eybrkJm2basVkfVjgMUpeO555ZTn9jpnXnWZHPHuVhc3UlLqfjvgGGWsVAoG0QPdJ5AHtPCMYPiy02sZRMV1fUkc7d/Q7nQVpJMiPht4rmgct7sKkirmAPAnRDWYWa136hO/IwgYIzILfshtHW6a0EL6pcJM1H9Q70fx/RDAioqoblcrraUuuenvVmU42tEWB21Cp8s+PDPescJsw==;\n\t5:s5fiDMENMM3w1+gkAtqpQsiNRckeF/17vDZBdqkeBvOqC3vTIwFNNf8UuTk+LIBZgD+IVGKhQPvY+NfG+blOfvQNkgAkMbOp5TMhRULE6R6N/a//mQNBdlOYNZTqL1rlBoGQ4+i4sZDnRVUIY4PldQ==;\n\t24:kkTvbcSDheQ/mfC3FUJJ19hLbhevII+proS4Y5Z2GFzjBDcmHtAxZK2+wno3F5SgtWhNuXiJIx5CC4vXMCZlA+oO/2JR6vg4PGBFwPlH9Co=;\n\t7:fpEuHz6BRkFIdHvIvtpCdL36Dw8fzMshTG3H2XoyT1VvXtoRr98SCGYtfnCG/5gVLTNmQgBcUERISFA1zb/jUcL1uc0bpHHnvkiDt/51hPgvgSaWXex701ePUA0QJ1KowHta7cnMO5TTr1Y4sDVqQ85tkQ+w6hovx4XdW9f8SwJOLoWDHKAAedBqzm365PC63MotA/AiWQfJnU+rdMFfiPm80IkpKUcGWbtijYkxuPQ=","x-ms-office365-filtering-correlation-id":"c741f30d-b4e1-47d7-8768-08d4e97db6b1","x-ms-office365-filtering-ht":"Tenant","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(48565401081)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:VI1PR04MB3085; ","x-ms-traffictypediagnostic":"VI1PR04MB3085:","x-ld-processed":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr","x-exchange-antispam-report-test":"UriScan:;","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(6055026)(6041248)(20161123558100)(20161123562025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:VI1PR04MB3085; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:VI1PR04MB3085; ","x-forefront-prvs":"04073E895A","x-forefront-antispam-report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(39860400002)(24454002)(199003)(377454003)(189002)(3450700001)(25786009)(189998001)(2906002)(101416001)(3660700001)(86362001)(3280700002)(229853002)(7696004)(7736002)(3846002)(97736004)(102836003)(43066003)(5660300001)(8656003)(54356999)(6116002)(74316002)(305945005)(76176999)(39060400002)(5250100002)(8676002)(81166006)(105586002)(66066001)(6436002)(7416002)(8936002)(6506006)(6246003)(50986999)(81156014)(478600001)(99286003)(55016002)(14454004)(2900100001)(106356001)(9686003)(68736007)(8666007)(33656002)(53936002)(53546010)(921003)(21314002)(1121003);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB3085;\n\tH:VI1PR04MB2078.eurprd04.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; A:1; MX:1; LANG:en; ","received-spf":"None (protection.outlook.com: nxp.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","MIME-Version":"1.0","X-OriginatorOrg":"nxp.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"22 Aug 2017 16:49:10.8792\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"VI1PR04MB3085","Subject":"Re: [U-Boot] [PATCH] blk: Remove various places that do flush cache\n\tafter read","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"York Sun ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1754527,"web_url":"http://patchwork.ozlabs.org/comment/1754527/","msgid":"","list_archive_url":null,"date":"2017-08-22T22:53:47","subject":"Re: [U-Boot] [PATCH] blk: Remove various places that do flush cache\n\tafter read","submitter":{"id":64981,"url":"http://patchwork.ozlabs.org/api/people/64981/","name":"Bin Meng","email":"bmeng.cn@gmail.com"},"content":"Hi York,\n\nOn Wed, Aug 23, 2017 at 12:49 AM, York Sun wrote:\n> On 08/21/2017 08:42 PM, Bin Meng wrote:\n>> All these places seem to inherit the codes from the MMC driver where\n>> a FIXME was put in the comment. However the correct operation after\n>> read should be cache invalidate, not flush.\n>>\n>> The underlying drivers should be responsible for the cache operation.\n>> Remove these codes completely.\n>>\n>> Signed-off-by: Bin Meng \n>> ---\n>>\n>> arch/arm/cpu/armv8/fsl-layerscape/ppa.c | 15 ---------------\n>> board/toradex/common/tdx-cfg-block.c | 2 --\n>> cmd/mmc.c | 2 --\n>> drivers/block/blk-uclass.c | 3 ---\n>> drivers/block/blk_legacy.c | 3 ---\n>> drivers/net/fm/fm.c | 2 --\n>> drivers/net/phy/cortina.c | 2 --\n>> drivers/qe/qe.c | 2 --\n>> 8 files changed, 31 deletions(-)\n>>\n>> diff --git a/arch/arm/cpu/armv8/fsl-layerscape/ppa.c b/arch/arm/cpu/armv8/fsl-layerscape/ppa.c\n>> index 24ddb5d..bbf8bba 100644\n>> --- a/arch/arm/cpu/armv8/fsl-layerscape/ppa.c\n>> +++ b/arch/arm/cpu/armv8/fsl-layerscape/ppa.c\n>> @@ -107,9 +107,6 @@ int ppa_init(void)\n>> return -EIO;\n>> }\n>>\n>> - /* flush cache after read */\n>> - flush_cache((ulong)fitp, cnt * 512);\n>> -\n>\n> NACK here.\n>\n>\n>> ret = fdt_check_header(fitp);\n>> if (ret) {\n>> free(fitp);\n>> @@ -134,9 +131,6 @@ int ppa_init(void)\n>> }\n>> debug(\"Read PPA header to 0x%p\\n\", ppa_hdr_ddr);\n>>\n>> - /* flush cache after read */\n>> - flush_cache((ulong)ppa_hdr_ddr, cnt * 512);\n>> -\n>> ppa_esbc_hdr = (uintptr_t)ppa_hdr_ddr;\n>> #endif\n>>\n>> @@ -164,9 +158,6 @@ int ppa_init(void)\n>> return -EIO;\n>> }\n>>\n>> - /* flush cache after read */\n>> - flush_cache((ulong)ppa_fit_addr, cnt * 512);\n>> -\n>> #elif defined(CONFIG_SYS_LS_PPA_FW_IN_NAND)\n>> struct fdt_header fit;\n>>\n>> @@ -208,9 +199,6 @@ int ppa_init(void)\n>> }\n>> debug(\"Read PPA header to 0x%p\\n\", ppa_hdr_ddr);\n>>\n>> - /* flush cache after read */\n>> - flush_cache((ulong)ppa_hdr_ddr, fw_length);\n>> -\n>> ppa_esbc_hdr = (uintptr_t)ppa_hdr_ddr;\n>> #endif\n>>\n>> @@ -232,9 +220,6 @@ int ppa_init(void)\n>> CONFIG_SYS_LS_PPA_FW_ADDR);\n>> return -EIO;\n>> }\n>> -\n>> - /* flush cache after read */\n>> - flush_cache((ulong)ppa_fit_addr, fw_length);\n>> #else\n>> #error \"No CONFIG_SYS_LS_PPA_FW_IN_xxx defined\"\n>> #endif\n>\n> Hold on for ppa.c. We need to flush the cache after reading PPA image\n> and it header after loading. These images need to be flushed into main\n> memory. I will need to confirm with our team if we can remove flushing here.\n>\n\nFor the first 3 parts in this ppa.c file, I see they are all reading\nPPA image from MMC while MMC driver is using DMA so this is wrong (as\nI mentioned in the commit message I suspect they are all copy/paste\nfrom the MMC driver).\n\nThe only questionable change is the last one which is reading\nsomething from NAND and if NAND driver is not using DMA, that cache\nflush is needed as you pointed out.\n\nRegards,\nBin","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"jHg9OZgG\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xcQpf0qnFz9s0Z\n\tfor ;\n\tWed, 23 Aug 2017 08:54:00 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 31385C21E6C; Tue, 22 Aug 2017 22:53:53 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 5A89BC21D93;\n\tTue, 22 Aug 2017 22:53:51 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 2CCA0C21D93; Tue, 22 Aug 2017 22:53:49 +0000 (UTC)","from mail-wm0-f67.google.com (mail-wm0-f67.google.com\n\t[74.125.82.67])\n\tby lists.denx.de (Postfix) with ESMTPS id 9A0C5C21C4F\n\tfor ; Tue, 22 Aug 2017 22:53:48 +0000 (UTC)","by mail-wm0-f67.google.com with SMTP id r187so565809wma.1\n\tfor ; Tue, 22 Aug 2017 15:53:48 -0700 (PDT)","by 10.223.135.121 with HTTP; Tue, 22 Aug 2017 15:53:47 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tKHOP_BIG_TO_CC, \n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=w6mnvux0OCTOq/vdKEDK4CA4kJCY++psUe7RwRE5+SE=;\n\tb=jHg9OZgG1AY+i+Rgwe3qKljYvnlbH5skCWNYrRQ+yb77ZVXanYHNTKuzpU4nySgZVU\n\t76gmojvCLb5umeexuQ9JY8fRaxO9KsGzJCxzRM3lpoDgBC4m1ZW9WldS5VWCmDtxyuup\n\tT+ZrMZLI6IJCvlwQEcMLnQy9lEn7M8VLKWYjCfFr9ZBa92Sp2bmfDiLC9KPwAax3Bfpa\n\tP17tsFao97y6/Eo3eEAbXYYhLR6vdLfJLT9vTxjQAsNOl/GVqxr49ofl4aE79F4aGJc9\n\tJK7MsB9/MlGVAJQEvRvaw407pVoT5TCOxBbVTCePU9NFMYSxBSgJ3ZsgVp8eJsCSVaG9\n\tuGHA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=w6mnvux0OCTOq/vdKEDK4CA4kJCY++psUe7RwRE5+SE=;\n\tb=jxsqClIMwPuObr0T/LYEUqHbNc+Gak8daK64U2k2o6L/qpKKrOIMB8sNV2Le9QpxnN\n\t+dFEQcuogm3YcBO/2jnvmDv3qnycjFIVB6chZFmF/wFO725MgsotaNubs9v4p8dNbdPC\n\trbxAib5qj5yjgi1iIuEyBb+uj4iH8ZKWeTlPOS6WtxEpyy1cIQEmRGYRbmTqqFxpPRA3\n\tpCsbLVsz8kopAweYxD2udha+TX1kwecjMvViVCb3gVJG8Q8itn4JUb9ONwT7WZ9ITkyi\n\tqjmB7ogqHc3+nQupYbUEg4FdcyXoGOWY6KT9RiP/ylYEuuUWVsesBx+QHnF2ln1duWJY\n\tBrFA==","X-Gm-Message-State":"AHYfb5gkVp4kFQ+mkeBhYK4UhcCQEXJhEWIYSoorBrE29dv+7PcFYP/B\n\t8tbU6vW3XDrivVjkC/giDU2KBgbuPg==","X-Received":"by 10.28.104.10 with SMTP id d10mr677004wmc.137.1503442428218;\n\tTue, 22 Aug 2017 15:53:48 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<1503373600-20847-1-git-send-email-bmeng.cn@gmail.com>\n\t","From":"Bin Meng ","Date":"Wed, 23 Aug 2017 06:53:47 +0800","Message-ID":"","To":"York Sun ","Cc":"Albert Aribaud , Tom Rini ,\n\tU-Boot Mailing List ,\n\tAngelo Dureghello ,\n\tMarcel Ziswiler ,\n\t\"Z.q. Hou\" ,\n\tMichal Simek , \n\tWenbin Song ,\n\tJoe Hershberger , \n\tMax Krummenacher ,\n\tStefan Roese , Markus Niebel ","Subject":"Re: [U-Boot] [PATCH] blk: Remove various places that do flush cache\n\tafter read","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1754645,"web_url":"http://patchwork.ozlabs.org/comment/1754645/","msgid":"","list_archive_url":null,"date":"2017-08-23T03:14:22","subject":"Re: [U-Boot] [PATCH] blk: Remove various places that do flush cache\n\tafter read","submitter":{"id":68014,"url":"http://patchwork.ozlabs.org/api/people/68014/","name":"Qiang Zhao","email":"qiang.zhao@nxp.com"},"content":"+Yangbo\n\nBest Regards\nQiang Zhao\n\n> -----Original Message-----\n> From: York Sun\n> Sent: Wednesday, August 23, 2017 12:49 AM\n> To: Bin Meng ; Grygorii Strashko\n> ; Michal Simek ; Angelo\n> Dureghello ; Kever Yang ;\n> Jaehoon Chung ; Albert Aribaud\n> ; Marcel Ziswiler ;\n> Markus Niebel ; Z.q. Hou\n> ; Sumit Garg ; Joe Hershberger\n> ; Stefan Roese ; Wenbin Song\n> ; Qiang Zhao ; Simon Glass\n> ; Max Krummenacher\n> ; Masahiro Yamada\n> ; Tomas Melin\n> ; Q.y. Gong ; Tom Rini\n> ; U-Boot Mailing List \n> Subject: Re: [PATCH] blk: Remove various places that do flush cache after read\n> \n> On 08/21/2017 08:42 PM, Bin Meng wrote:\n> > All these places seem to inherit the codes from the MMC driver where a\n> > FIXME was put in the comment. However the correct operation after read\n> > should be cache invalidate, not flush.\n> >\n> > The underlying drivers should be responsible for the cache operation.\n> > Remove these codes completely.\n> >\n> > Signed-off-by: Bin Meng \n> > ---\n> >\n> > arch/arm/cpu/armv8/fsl-layerscape/ppa.c | 15 ---------------\n> > board/toradex/common/tdx-cfg-block.c | 2 --\n> > cmd/mmc.c | 2 --\n> > drivers/block/blk-uclass.c | 3 ---\n> > drivers/block/blk_legacy.c | 3 ---\n> > drivers/net/fm/fm.c | 2 --\n> > drivers/net/phy/cortina.c | 2 --\n> > drivers/qe/qe.c | 2 --\n> > 8 files changed, 31 deletions(-)\n> >\n> > diff --git a/arch/arm/cpu/armv8/fsl-layerscape/ppa.c\n> > b/arch/arm/cpu/armv8/fsl-layerscape/ppa.c\n> > index 24ddb5d..bbf8bba 100644\n> > --- a/arch/arm/cpu/armv8/fsl-layerscape/ppa.c\n> > +++ b/arch/arm/cpu/armv8/fsl-layerscape/ppa.c\n> > @@ -107,9 +107,6 @@ int ppa_init(void)\n> > \t\treturn -EIO;\n> > \t}\n> >\n> > -\t/* flush cache after read */\n> > -\tflush_cache((ulong)fitp, cnt * 512);\n> > -\n> \n> NACK here.\n> \n> \n> > \tret = fdt_check_header(fitp);\n> > \tif (ret) {\n> > \t\tfree(fitp);\n> > @@ -134,9 +131,6 @@ int ppa_init(void)\n> > \t}\n> > \tdebug(\"Read PPA header to 0x%p\\n\", ppa_hdr_ddr);\n> >\n> > -\t/* flush cache after read */\n> > -\tflush_cache((ulong)ppa_hdr_ddr, cnt * 512);\n> > -\n> > \tppa_esbc_hdr = (uintptr_t)ppa_hdr_ddr;\n> > #endif\n> >\n> > @@ -164,9 +158,6 @@ int ppa_init(void)\n> > \t\treturn -EIO;\n> > \t}\n> >\n> > -\t/* flush cache after read */\n> > -\tflush_cache((ulong)ppa_fit_addr, cnt * 512);\n> > -\n> > #elif defined(CONFIG_SYS_LS_PPA_FW_IN_NAND)\n> > \tstruct fdt_header fit;\n> >\n> > @@ -208,9 +199,6 @@ int ppa_init(void)\n> > \t}\n> > \tdebug(\"Read PPA header to 0x%p\\n\", ppa_hdr_ddr);\n> >\n> > -\t/* flush cache after read */\n> > -\tflush_cache((ulong)ppa_hdr_ddr, fw_length);\n> > -\n> > \tppa_esbc_hdr = (uintptr_t)ppa_hdr_ddr;\n> > #endif\n> >\n> > @@ -232,9 +220,6 @@ int ppa_init(void)\n> > \t\t CONFIG_SYS_LS_PPA_FW_ADDR);\n> > \t\treturn -EIO;\n> > \t}\n> > -\n> > -\t/* flush cache after read */\n> > -\tflush_cache((ulong)ppa_fit_addr, fw_length);\n> > #else\n> > #error \"No CONFIG_SYS_LS_PPA_FW_IN_xxx defined\"\n> > #endif\n> \n> Hold on for ppa.c. We need to flush the cache after reading PPA image and it\n> header after loading. These images need to be flushed into main memory. I will\n> need to confirm with our team if we can remove flushing here.\n> \n> York","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"f2RxscX3\";\n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=qiang.zhao@nxp.com; "],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xcXbS2yP8z9sDB\n\tfor ;\n\tWed, 23 Aug 2017 13:14:42 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 6D6C9C21ED6; Wed, 23 Aug 2017 03:14:38 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id DB039C21E0D;\n\tWed, 23 Aug 2017 03:14:32 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 2F385C21E0D; Wed, 23 Aug 2017 03:14:32 +0000 (UTC)","from EUR01-VE1-obe.outbound.protection.outlook.com\n\t(mail-ve1eur01on0073.outbound.protection.outlook.com [104.47.1.73])\n\tby lists.denx.de (Postfix) with ESMTPS id AFDCAC21C40\n\tfor ; Wed, 23 Aug 2017 03:14:30 +0000 (UTC)","from AM3PR04MB1185.eurprd04.prod.outlook.com (10.163.6.143) by\n\tAM3PR04MB308.eurprd04.prod.outlook.com (10.242.113.155) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.1.1362.18; Wed, 23 Aug 2017 03:14:22 +0000","from AM3PR04MB1185.eurprd04.prod.outlook.com\n\t([fe80::6826:6d96:8f16:aa04]) by\n\tAM3PR04MB1185.eurprd04.prod.outlook.com\n\t([fe80::6826:6d96:8f16:aa04%13]) with mapi id 15.01.1362.019;\n\tWed, 23 Aug 2017 03:14:22 +0000"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=KHOP_BIG_TO_CC,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,\n\tSPF_HELO_PASS, \n\tT_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=HhElCZq1VimqppDJTphwztnBheInKfFOV8urbxpbOEw=;\n\tb=f2RxscX3JN9zrM/PDdMpgv/vG4t+M5R4eETEPimTm/+dMo3OkuhqYevlK4BlmE16lc6QohsAcBF+FBRkjbleGvDuAqoQKwAyDXtiul0p1Kc4XzkZIRc4u7GAM31nWDMOVYIraWdRWsMu7NP5j/wwxPynR35ythJ7G4XOF+/eJ90=","From":"Qiang Zhao ","To":"\"Y.b. Lu\" , York Sun , Bin Meng\n\t, Grygorii Strashko ,\n\t\"Michal\n\tSimek\" , Angelo Dureghello ,\n\t\"Kever Yang\" ,\n\tJaehoon Chung , \n\tAlbert Aribaud , Marcel Ziswiler\n\t,\n\tMarkus Niebel , \n\t\"Z.q. Hou\" , Sumit Garg , \"Joe\n\tHershberger\" , Stefan Roese ,\n\tWenbin Song , Simon Glass ,\n\tMax Krummenacher , Masahiro Yamada\n\t, Tomas Melin ,\n\t\"Q.y. Gong\" , Tom Rini ,\n\t\"U-Boot Mailing List\" ","Thread-Topic":"[PATCH] blk: Remove various places that do flush cache after\n\tread","Thread-Index":"AQHTGvir4/Nuhe3zn0GgVdmfBPjEUaKRRRlA","Date":"Wed, 23 Aug 2017 03:14:22 +0000","Message-ID":"","References":"<1503373600-20847-1-git-send-email-bmeng.cn@gmail.com>\n\t","In-Reply-To":"","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"f2RxscX3\";\n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=qiang.zhao@nxp.com; "],"x-originating-ip":"[192.158.241.86]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; AM3PR04MB308;\n\t6:ccOSjE/eZ69sJYidKW8emZhsZijJk5Zl4LdxJXO3S/kNX1g+JNLSZSkg+t/o3h7x3D54NGy3dy+8KC7bJWeTuLG9Pc3LVOzXufgpbrDSQFuIVgNr29gxXg2clIOsxLUA9d/o7PlD/2lVAX1nzHV/xRJOqCB+t0jNNDiCnE/XBaPAkrg508f0ePN5hciHa4DkNxdsu8tSVGfbMw8MnFYOHtBN0mYGLpgKBB/BsPcwm7MXXgkwKyyyML/U4ZadmTRTXf93remnRgJRf22fJUfTAeAsUGac74k/3DcjRrChYzPBjfVGtfMPuAXocw2oU2k2vCuw7ZF+6lhOA0ugcAMsUg==;\n\t5:/toyARPnJ4mJImrqajf2iuiZfJJMuV6oLNrIz/kAYwPQG17rd2S/cgdEVErY+ajLiMtHutWuD5fEUJkKZsI0V7Lebx/OKV4VyurUgz9qFpBPWPRGWYt8o05FvgjLY1e7hi6/BlEuNmQouKxm3Jzb/A==;\n\t24:BacWPWBN454Xn+M/AQnqGte2GH5u7HHJSBsR3eyfjQf+7VSbtOV9k90cyahFE3zkDoawq0uPrwUDZFNEggUpBVByJd/N98S6Glcd3UOmsuU=;\n\t7:y1ezgJyv/w/43EtO69+Dk2FhYmvYJqLKp4ZI0V0aiIR1HN/TUQDV1uypRvjpJJkbGAXmzjHuTUTQHY06ajd2AOCLSyxdZ6PSwnQMDEyM3d6HjxhWq3+JBpdRNoNleTuqBWHSmRv4cpxXe7JDHR7Nwtkg01y2LTHyp2usPSJfjQUXNe45jeMUp7zmq7N75et1rI0QvAaZW66VBU6nrenvNzs6BiOp6jPu08dAsw4dEBo=","x-ms-office365-filtering-correlation-id":"7f3961d9-d7fd-4f40-4446-08d4e9d50d0d","x-ms-office365-filtering-ht":"Tenant","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:AM3PR04MB308; ","x-ms-traffictypediagnostic":"AM3PR04MB308:","x-ld-processed":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr","x-exchange-antispam-report-test":"UriScan:(31051911155226)(185117386973197)(192813158149592)(16074681357397)(7411616537696)(145744241990776);","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(6055026)(6041248)(20161123558100)(20161123562025)(20161123564025)(20161123560025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:AM3PR04MB308; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:AM3PR04MB308; ","x-forefront-prvs":"040866B734","x-forefront-antispam-report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(39860400002)(377454003)(13464003)(24454002)(199003)(189002)(86362001)(81166006)(5660300001)(6506006)(3660700001)(81156014)(7696004)(305945005)(50986999)(68736007)(8936002)(8676002)(7736002)(33656002)(3280700002)(55016002)(99286003)(9686003)(106356001)(478600001)(2906002)(2900100001)(8666007)(6436002)(53936002)(25786009)(76176999)(54356999)(229853002)(101416001)(5250100002)(7416002)(2950100002)(14454004)(6246003)(39060400002)(53546010)(74316002)(105586002)(189998001)(8656003)(6116002)(3846002)(66066001)(102836003)(97736004)(921003)(21314002)(1121003);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:AM3PR04MB308;\n\tH:AM3PR04MB1185.eurprd04.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; A:1; MX:1; LANG:en; ","received-spf":"None (protection.outlook.com: nxp.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","MIME-Version":"1.0","X-OriginatorOrg":"nxp.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"23 Aug 2017 03:14:22.1736\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"AM3PR04MB308","Subject":"Re: [U-Boot] [PATCH] blk: Remove various places that do flush cache\n\tafter read","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1754648,"web_url":"http://patchwork.ozlabs.org/comment/1754648/","msgid":"","list_archive_url":null,"date":"2017-08-23T03:29:06","subject":"Re: [U-Boot] [PATCH] blk: Remove various places that do flush cache\n\tafter read","submitter":{"id":67973,"url":"http://patchwork.ozlabs.org/api/people/67973/","name":"Yangbo Lu","email":"yangbo.lu@nxp.com"},"content":"cmd/mmc.c\n\nMaybe SD controller on some vendor platforms doesn't support SNOOP.\nflush_cache() is required to sync between DDR and cache.\nShould be careful to remove this.\n\n\n> -----Original Message-----\n> From: Qiang Zhao\n> Sent: Wednesday, August 23, 2017 11:14 AM\n> To: Y.b. Lu; York Sun; Bin Meng; Grygorii Strashko; Michal Simek; Angelo\n> Dureghello; Kever Yang; Jaehoon Chung; Albert Aribaud; Marcel Ziswiler;\n> Markus Niebel; Z.q. Hou; Sumit Garg; Joe Hershberger; Stefan Roese;\n> Wenbin Song; Simon Glass; Max Krummenacher; Masahiro Yamada; Tomas Melin;\n> Q.y. Gong; Tom Rini; U-Boot Mailing List\n> Subject: RE: [PATCH] blk: Remove various places that do flush cache after\n> read\n> \n> +Yangbo\n> \n> Best Regards\n> Qiang Zhao\n> \n> > -----Original Message-----\n> > From: York Sun\n> > Sent: Wednesday, August 23, 2017 12:49 AM\n> > To: Bin Meng ; Grygorii Strashko\n> > ; Michal Simek ;\n> > Angelo Dureghello ; Kever Yang\n> > ; Jaehoon Chung ;\n> > Albert Aribaud ; Marcel Ziswiler\n> > ; Markus Niebel\n> > ; Z.q. Hou ; Sumit\n> > Garg ; Joe Hershberger ;\n> > Stefan Roese ; Wenbin Song ; Qiang\n> > Zhao ; Simon Glass ; Max\n> > Krummenacher ; Masahiro Yamada\n> > ; Tomas Melin\n> > ; Q.y. Gong ; Tom Rini\n> > ; U-Boot Mailing List \n> > Subject: Re: [PATCH] blk: Remove various places that do flush cache\n> > after read\n> >\n> > On 08/21/2017 08:42 PM, Bin Meng wrote:\n> > > All these places seem to inherit the codes from the MMC driver where\n> > > a FIXME was put in the comment. However the correct operation after\n> > > read should be cache invalidate, not flush.\n> > >\n> > > The underlying drivers should be responsible for the cache operation.\n> > > Remove these codes completely.\n> > >\n> > > Signed-off-by: Bin Meng \n> > > ---\n> > >\n> > > arch/arm/cpu/armv8/fsl-layerscape/ppa.c | 15 ---------------\n> > > board/toradex/common/tdx-cfg-block.c | 2 --\n> > > cmd/mmc.c | 2 --\n> > > drivers/block/blk-uclass.c | 3 ---\n> > > drivers/block/blk_legacy.c | 3 ---\n> > > drivers/net/fm/fm.c | 2 --\n> > > drivers/net/phy/cortina.c | 2 --\n> > > drivers/qe/qe.c | 2 --\n> > > 8 files changed, 31 deletions(-)\n> > >\n> > > diff --git a/arch/arm/cpu/armv8/fsl-layerscape/ppa.c\n> > > b/arch/arm/cpu/armv8/fsl-layerscape/ppa.c\n> > > index 24ddb5d..bbf8bba 100644\n> > > --- a/arch/arm/cpu/armv8/fsl-layerscape/ppa.c\n> > > +++ b/arch/arm/cpu/armv8/fsl-layerscape/ppa.c\n> > > @@ -107,9 +107,6 @@ int ppa_init(void)\n> > > \t\treturn -EIO;\n> > > \t}\n> > >\n> > > -\t/* flush cache after read */\n> > > -\tflush_cache((ulong)fitp, cnt * 512);\n> > > -\n> >\n> > NACK here.\n> >\n> >\n> > > \tret = fdt_check_header(fitp);\n> > > \tif (ret) {\n> > > \t\tfree(fitp);\n> > > @@ -134,9 +131,6 @@ int ppa_init(void)\n> > > \t}\n> > > \tdebug(\"Read PPA header to 0x%p\\n\", ppa_hdr_ddr);\n> > >\n> > > -\t/* flush cache after read */\n> > > -\tflush_cache((ulong)ppa_hdr_ddr, cnt * 512);\n> > > -\n> > > \tppa_esbc_hdr = (uintptr_t)ppa_hdr_ddr;\n> > > #endif\n> > >\n> > > @@ -164,9 +158,6 @@ int ppa_init(void)\n> > > \t\treturn -EIO;\n> > > \t}\n> > >\n> > > -\t/* flush cache after read */\n> > > -\tflush_cache((ulong)ppa_fit_addr, cnt * 512);\n> > > -\n> > > #elif defined(CONFIG_SYS_LS_PPA_FW_IN_NAND)\n> > > \tstruct fdt_header fit;\n> > >\n> > > @@ -208,9 +199,6 @@ int ppa_init(void)\n> > > \t}\n> > > \tdebug(\"Read PPA header to 0x%p\\n\", ppa_hdr_ddr);\n> > >\n> > > -\t/* flush cache after read */\n> > > -\tflush_cache((ulong)ppa_hdr_ddr, fw_length);\n> > > -\n> > > \tppa_esbc_hdr = (uintptr_t)ppa_hdr_ddr;\n> > > #endif\n> > >\n> > > @@ -232,9 +220,6 @@ int ppa_init(void)\n> > > \t\t CONFIG_SYS_LS_PPA_FW_ADDR);\n> > > \t\treturn -EIO;\n> > > \t}\n> > > -\n> > > -\t/* flush cache after read */\n> > > -\tflush_cache((ulong)ppa_fit_addr, fw_length);\n> > > #else\n> > > #error \"No CONFIG_SYS_LS_PPA_FW_IN_xxx defined\"\n> > > #endif\n> >\n> > Hold on for ppa.c. We need to flush the cache after reading PPA image\n> > and it header after loading. These images need to be flushed into main\n> > memory. I will need to confirm with our team if we can remove flushing\n> here.\n> >\n> > York","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"X0YubQQr\";\n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=yangbo.lu@nxp.com; "],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xcXwG5ZCnz9s0Z\n\tfor ;\n\tWed, 23 Aug 2017 13:29:18 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 73633C21E56; Wed, 23 Aug 2017 03:29:17 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 6B12BC21E34;\n\tWed, 23 Aug 2017 03:29:12 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid BDB48C21E34; Wed, 23 Aug 2017 03:29:11 +0000 (UTC)","from EUR02-AM5-obe.outbound.protection.outlook.com\n\t(mail-eopbgr00050.outbound.protection.outlook.com [40.107.0.50])\n\tby lists.denx.de (Postfix) with ESMTPS id 069FCC21C40\n\tfor ; Wed, 23 Aug 2017 03:29:10 +0000 (UTC)","from DB6PR0401MB2536.eurprd04.prod.outlook.com (10.169.224.151) by\n\tDB6PR0401MB2342.eurprd04.prod.outlook.com (10.168.54.155) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.1.1362.18; Wed, 23 Aug 2017 03:29:06 +0000","from DB6PR0401MB2536.eurprd04.prod.outlook.com\n\t([fe80::8ca:10a:4521:3cac]) by\n\tDB6PR0401MB2536.eurprd04.prod.outlook.com\n\t([fe80::8ca:10a:4521:3cac%18]) with mapi id 15.01.1362.019;\n\tWed, 23 Aug 2017 03:29:06 +0000"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=KHOP_BIG_TO_CC,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tSPF_HELO_PASS, \n\tT_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=ZU9D0Sf274hxGlNrqYlU9AfnIIDhrafePo8KA0jNSAg=;\n\tb=X0YubQQraj3/zEu2gkbR7cFmhdxcA9Iv1rPTT0Wr/gx6VTMajenJsTUpmXu4JXiyC3T51vrFY5Sst7f2jVdWrZ1e8nRwpoKbStjDrOKK64fwdosrSXOZNJYIaQErHqKuN11jZX/0UT0+zrFVNh0FYNuFHBQFdhYXt1kHphp3UO0=","From":"\"Y.b. Lu\" ","To":"Qiang Zhao , York Sun , Bin Meng\n\t, Grygorii Strashko ,\n\t\"Michal\n\tSimek\" , Angelo Dureghello ,\n\t\"Kever Yang\" ,\n\tJaehoon Chung , \n\tAlbert Aribaud , Marcel Ziswiler\n\t,\n\tMarkus Niebel , \n\t\"Z.q. Hou\" , Sumit Garg , \"Joe\n\tHershberger\" , Stefan Roese ,\n\tWenbin Song , Simon Glass ,\n\tMax Krummenacher , Masahiro Yamada\n\t, Tomas Melin ,\n\t\"Q.y. Gong\" , Tom Rini ,\n\t\"U-Boot Mailing List\" ","Thread-Topic":"[PATCH] blk: Remove various places that do flush cache after\n\tread","Thread-Index":"AQHTG73smLLCGgAAF02AGj85Qgs0JaKRRg1A","Date":"Wed, 23 Aug 2017 03:29:06 +0000","Message-ID":"","References":"<1503373600-20847-1-git-send-email-bmeng.cn@gmail.com>\n\t\n\t","In-Reply-To":"","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"X0YubQQr\";\n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=yangbo.lu@nxp.com; "],"x-originating-ip":"[199.59.231.64]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; DB6PR0401MB2342;\n\t6:ruQnLX7rdq5FJYNoq4CaW8FECZ/cc3Eyj+reN/ermcOOdBppkNK9Z7LFxzJ5L2b42wWoYUACJwel8UnpU6yZFRzdkLwhwlq69CisUYQUXwdbGEaZUZLJZ09pWD1juFDOg9Wxu8ao/EBP1vxTt374QEHY9KSINCDCcHF/i8Gd/ArtDFFOxmfJ2QRdE50AD8gZ2F1x9Bs/qMzzyypSMpzw9tctRYq+AtTld2SefwghcOntA+0IS+2XOs8E4Cz/HvMdKcetrZ3ULjtq6ntm24lDfP0xGl/7T5esUMUP4u0XT10FczYdcze+Wjsa04qiipoapcvXAkSOh/KUMgFPVHaxUw==;\n\t5:0oo0ormDzOyeeH2M4KsZy2+Soy95+8z2Qf8NJkyXXqPwBFwtpv2Y2bfdfYTV5is59601050cDcIR3I1ZVOjzzi1gz+LCfTy5Y750P/0f/k25sRucPoss0k6tn3JbX0HVJkZmEJaB52I2XdCG816JcA==;\n\t24:R0jgSxxOcOR/L39yERZjVHOlQjYoRrFwveBiMEpGSmOxmJVaPBRzoYZOrqpmBfOMovqTiDFkNryK0e1DXEiYXry7GPl5y3cSLj+fCVwArkM=;\n\t7:s8Iut08RLgnOBh6gvATpdPlRj5YgOVCJpr4JtWv6Gba9RGhMKzYQ9tNQtyFQ6jievI9MSudAbgESEx5SXKLFmGxFEAqqtekoKI+s5/Pcy4V3SSD3xVsbVe6kzT7bRqsDFK5Jn/FCT2XXsgq/ItDHfJxq93IvRPynh9ikbrPvxlyHlaq6GEQ/a1bUwu15DKyfV2I6XG4YZGxLiM3g25evfav8Ht9jYSC0F9p/QWRoAY8=","x-ms-office365-filtering-correlation-id":"0da8a124-1cd6-447d-5877-08d4e9d71c19","x-ms-office365-filtering-ht":"Tenant","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(48565401081)(2017052603178)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:DB6PR0401MB2342; ","x-ms-traffictypediagnostic":"DB6PR0401MB2342:","x-ld-processed":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr","x-exchange-antispam-report-test":"UriScan:(31051911155226)(185117386973197)(192813158149592)(16074681357397)(7411616537696)(145744241990776);","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(6055026)(6041248)(20161123560025)(20161123564025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:DB6PR0401MB2342; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:DB6PR0401MB2342; ","x-forefront-prvs":"040866B734","x-forefront-antispam-report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(39860400002)(189002)(24454002)(377454003)(13464003)(199003)(66066001)(229853002)(68736007)(99286003)(7736002)(53936002)(305945005)(9686003)(8666007)(6436002)(55016002)(86362001)(6506006)(25786009)(81156014)(2900100001)(8676002)(14454004)(3280700002)(7696004)(7416002)(81166006)(5660300001)(74316002)(76176999)(2950100002)(189998001)(54356999)(2906002)(8936002)(50986999)(39060400002)(5250100002)(3660700001)(102836003)(105586002)(106356001)(6116002)(101416001)(478600001)(8656003)(6246003)(53546010)(97736004)(33656002)(3846002)(921003)(21314002)(1121003);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0401MB2342;\n\tH:DB6PR0401MB2536.eurprd04.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; MX:1; A:1; LANG:en; ","received-spf":"None (protection.outlook.com: nxp.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","MIME-Version":"1.0","X-OriginatorOrg":"nxp.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"23 Aug 2017 03:29:06.3964\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DB6PR0401MB2342","Subject":"Re: [U-Boot] [PATCH] blk: Remove various places that do flush cache\n\tafter read","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1754689,"web_url":"http://patchwork.ozlabs.org/comment/1754689/","msgid":"","list_archive_url":null,"date":"2017-08-23T05:28:35","subject":"Re: [U-Boot] [PATCH] blk: Remove various places that do flush cache\n\tafter read","submitter":{"id":64981,"url":"http://patchwork.ozlabs.org/api/people/64981/","name":"Bin Meng","email":"bmeng.cn@gmail.com"},"content":"Hi Yangbo,\n\nOn Wed, Aug 23, 2017 at 11:29 AM, Y.b. Lu wrote:\n> cmd/mmc.c\n>\n> Maybe SD controller on some vendor platforms doesn't support SNOOP.\n> flush_cache() is required to sync between DDR and cache.\n> Should be careful to remove this.\n>\n\nPlease do not top-posting.\n\nWhat you mentioned if snoop is not supported, flush_cache() is\nrequired, is true, however that's not the issue I am trying to fix\nhere. The flush_cache() here after a DMA read will cause issues\nbecause stale data in the cache will overwrite the correct data in the\nRAM that is DMAed by hardware (in this case, MMC controller).\n\nRegards,\nBin","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"vgDHmap8\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xcbZ32PQgz9s7h\n\tfor ;\n\tWed, 23 Aug 2017 15:28:43 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 094B1C21E4B; Wed, 23 Aug 2017 05:28:40 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 1E567C21E11;\n\tWed, 23 Aug 2017 05:28:38 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 8D2C7C21E11; Wed, 23 Aug 2017 05:28:36 +0000 (UTC)","from mail-wr0-f177.google.com (mail-wr0-f177.google.com\n\t[209.85.128.177])\n\tby lists.denx.de (Postfix) with ESMTPS id 39E4BC21C39\n\tfor ; Wed, 23 Aug 2017 05:28:36 +0000 (UTC)","by mail-wr0-f177.google.com with SMTP id a47so1969950wra.0\n\tfor ; Tue, 22 Aug 2017 22:28:36 -0700 (PDT)","by 10.223.135.121 with HTTP; Tue, 22 Aug 2017 22:28:35 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=FREEMAIL_FROM, KHOP_BIG_TO_CC,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=2mj0iY73lyo7W1dl0uXc8qIELKJ1FVDKeYriD1mb5bM=;\n\tb=vgDHmap8iHdJDl/wAl3hzu9r1G98CG2vZVdFNI8Gudw0doPZfFsI1b6zy8QjRlOp1J\n\tQlr8cQchoP0BiOsiC2LZ6kW/7i07IQXSPLC8SxntRArsfHHiZAB3u0aqGc2NmC4782vQ\n\tEZIf+G9Tby3rYFRs46lBMHToOkSZoLF7Lh+ITTrHNM2O7LIoTOO3U9Dgh7Su5pby6dN2\n\t9dk13FKhmsfsQLWdw+/oV7SloWlSd+9uU09WuKyzlAjJZi6tFHUpsSpbJetdzaxgfQnJ\n\t21EmTvb3OOxGObFJCohEMBfq6CdxbUhB19bqcjOTNpqXlmM7l2enZBpFHox/hxP4pI3B\n\thYjg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=2mj0iY73lyo7W1dl0uXc8qIELKJ1FVDKeYriD1mb5bM=;\n\tb=YmHqpuWq3MGEE6jafFjFuQ+QRC/2Ubs4z91CPZw6neOIGF6DTS5bjh5Ln1PufPWqzx\n\tSqk9h/yiEnji4NoqGzwUvHqpfjZr7MXuxHdP/oziDqDI8JG96iqTbquPYs5k9kNqDCKG\n\t1/NF9ru91ib02LIncNiV+hs6vWEGs97xNiGi6vCDo8NKi5vM2NaXK/i56A4QCGhiNcZw\n\twBxlbqCgJC0iNn/8r3l3JqOR49JzmM665lKXuJoPUAqgonUmtXcVXnDfkt6kE9ybu+jM\n\tENOlP621aP5joE+t7nm+gooqYBfwPzcRQ0Yfes8938ZCACnJVX1x7Tb+hPSUUehnB/f3\n\tV5ow==","X-Gm-Message-State":"AHYfb5jofYbl1CA/QXhw/qlp4pdfWH9XG/8Yj9wNgB06ILsG1TTdKxAV\n\t9aMDN1TzL5krYlnx0SX8LQdd2Mmy2Q==","X-Received":"by 10.223.128.204 with SMTP id 70mr958281wrl.207.1503466115775; \n\tTue, 22 Aug 2017 22:28:35 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<1503373600-20847-1-git-send-email-bmeng.cn@gmail.com>\n\t\n\t\n\t","From":"Bin Meng ","Date":"Wed, 23 Aug 2017 13:28:35 +0800","Message-ID":"","To":"\"Y.b. Lu\" ","Cc":"Marcel Ziswiler ,\n\tU-Boot Mailing List ,\n\tMax Krummenacher ,\n\tStefan Roese , \n\tTom Rini , Angelo Dureghello ,\n\tMichal Simek ,\n\tWenbin Song , \"Z.q. Hou\" ,\n\tMarkus Niebel , \n\tAlbert Aribaud ,\n\tJoe Hershberger ","Subject":"Re: [U-Boot] [PATCH] blk: Remove various places that do flush cache\n\tafter read","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1755368,"web_url":"http://patchwork.ozlabs.org/comment/1755368/","msgid":"","list_archive_url":null,"date":"2017-08-23T15:01:28","subject":"Re: [U-Boot] [PATCH] blk: Remove various places that do flush cache\n\tafter read","submitter":{"id":67822,"url":"http://patchwork.ozlabs.org/api/people/67822/","name":"York Sun","email":"york.sun@nxp.com"},"content":"On 08/22/2017 03:53 PM, Bin Meng wrote:\n> Hi York,\n> \n> On Wed, Aug 23, 2017 at 12:49 AM, York Sun wrote:\n>> On 08/21/2017 08:42 PM, Bin Meng wrote:\n>>> All these places seem to inherit the codes from the MMC driver where\n>>> a FIXME was put in the comment. However the correct operation after\n>>> read should be cache invalidate, not flush.\n>>>\n>>> The underlying drivers should be responsible for the cache operation.\n>>> Remove these codes completely.\n>>>\n>>> Signed-off-by: Bin Meng \n>>> ---\n>>>\n>>> arch/arm/cpu/armv8/fsl-layerscape/ppa.c | 15 ---------------\n>>> board/toradex/common/tdx-cfg-block.c | 2 --\n>>> cmd/mmc.c | 2 --\n>>> drivers/block/blk-uclass.c | 3 ---\n>>> drivers/block/blk_legacy.c | 3 ---\n>>> drivers/net/fm/fm.c | 2 --\n>>> drivers/net/phy/cortina.c | 2 --\n>>> drivers/qe/qe.c | 2 --\n>>> 8 files changed, 31 deletions(-)\n>>>\n>>> diff --git a/arch/arm/cpu/armv8/fsl-layerscape/ppa.c b/arch/arm/cpu/armv8/fsl-layerscape/ppa.c\n>>> index 24ddb5d..bbf8bba 100644\n>>> --- a/arch/arm/cpu/armv8/fsl-layerscape/ppa.c\n>>> +++ b/arch/arm/cpu/armv8/fsl-layerscape/ppa.c\n>>> @@ -107,9 +107,6 @@ int ppa_init(void)\n>>> return -EIO;\n>>> }\n>>>\n>>> - /* flush cache after read */\n>>> - flush_cache((ulong)fitp, cnt * 512);\n>>> -\n>>\n>> NACK here.\n>>\n>>\n>>> ret = fdt_check_header(fitp);\n>>> if (ret) {\n>>> free(fitp);\n>>> @@ -134,9 +131,6 @@ int ppa_init(void)\n>>> }\n>>> debug(\"Read PPA header to 0x%p\\n\", ppa_hdr_ddr);\n>>>\n>>> - /* flush cache after read */\n>>> - flush_cache((ulong)ppa_hdr_ddr, cnt * 512);\n>>> -\n>>> ppa_esbc_hdr = (uintptr_t)ppa_hdr_ddr;\n>>> #endif\n>>>\n>>> @@ -164,9 +158,6 @@ int ppa_init(void)\n>>> return -EIO;\n>>> }\n>>>\n>>> - /* flush cache after read */\n>>> - flush_cache((ulong)ppa_fit_addr, cnt * 512);\n>>> -\n>>> #elif defined(CONFIG_SYS_LS_PPA_FW_IN_NAND)\n>>> struct fdt_header fit;\n>>>\n>>> @@ -208,9 +199,6 @@ int ppa_init(void)\n>>> }\n>>> debug(\"Read PPA header to 0x%p\\n\", ppa_hdr_ddr);\n>>>\n>>> - /* flush cache after read */\n>>> - flush_cache((ulong)ppa_hdr_ddr, fw_length);\n>>> -\n>>> ppa_esbc_hdr = (uintptr_t)ppa_hdr_ddr;\n>>> #endif\n>>>\n>>> @@ -232,9 +220,6 @@ int ppa_init(void)\n>>> CONFIG_SYS_LS_PPA_FW_ADDR);\n>>> return -EIO;\n>>> }\n>>> -\n>>> - /* flush cache after read */\n>>> - flush_cache((ulong)ppa_fit_addr, fw_length);\n>>> #else\n>>> #error \"No CONFIG_SYS_LS_PPA_FW_IN_xxx defined\"\n>>> #endif\n>>\n>> Hold on for ppa.c. We need to flush the cache after reading PPA image\n>> and it header after loading. These images need to be flushed into main\n>> memory. I will need to confirm with our team if we can remove flushing here.\n>>\n> \n> For the first 3 parts in this ppa.c file, I see they are all reading\n> PPA image from MMC while MMC driver is using DMA so this is wrong (as\n> I mentioned in the commit message I suspect they are all copy/paste\n> from the MMC driver).\n> \n> The only questionable change is the last one which is reading\n> something from NAND and if NAND driver is not using DMA, that cache\n> flush is needed as you pointed out.\n> \n\nBin,\n\nOur internal team agrees with the removing flushing for MMC.\nGive me some time to test NAND.\n\nYork","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"m/j7TmGE\";\n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=york.sun@nxp.com; "],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xcrH83D6dz9s8J\n\tfor ;\n\tThu, 24 Aug 2017 01:01:40 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid E3DDCC21D8C; Wed, 23 Aug 2017 15:01:36 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id B6531C21C2B;\n\tWed, 23 Aug 2017 15:01:33 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 4A08DC21C2B; Wed, 23 Aug 2017 15:01:33 +0000 (UTC)","from EUR01-VE1-obe.outbound.protection.outlook.com\n\t(mail-ve1eur01on0073.outbound.protection.outlook.com [104.47.1.73])\n\tby lists.denx.de (Postfix) with ESMTPS id 1F3C0C21C26\n\tfor ; Wed, 23 Aug 2017 15:01:32 +0000 (UTC)","from VI1PR04MB2078.eurprd04.prod.outlook.com (10.166.43.18) by\n\tVI1PR04MB1437.eurprd04.prod.outlook.com (10.163.166.141) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.1.1362.18; Wed, 23 Aug 2017 15:01:29 +0000","from VI1PR04MB2078.eurprd04.prod.outlook.com\n\t([fe80::5ce6:46c1:8a2c:ca59]) by\n\tVI1PR04MB2078.eurprd04.prod.outlook.com\n\t([fe80::5ce6:46c1:8a2c:ca59%14]) with mapi id 15.01.1362.019;\n\tWed, 23 Aug 2017 15:01:29 +0000"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=KHOP_BIG_TO_CC,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,\n\tSPF_HELO_PASS, \n\tT_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=ZZ6IR1ZZmR02741hhHz1etPRzimhNmRasqEx8gb57fc=;\n\tb=m/j7TmGE7pegvmCCDgwQP/pfnpdSz/8Zn4k3Xif9YGmkRMJwJ8NkzglKN01CNtbYMKJDxoBuXhBs01CcLlVdbf3Db/VmHqwLvE1/wZ9I9kYeBsi39WZE9QncWxovTzz6WqOquwAqKaglAq200iEptE8AZ4Ztfq4uFB4LPFsKD2U=","From":"York Sun ","To":"Bin Meng ","Thread-Topic":"[PATCH] blk: Remove various places that do flush cache after\n\tread","Thread-Index":"AQHTGvirDLgrxsdG5k+zJcYDaJ+jPw==","Date":"Wed, 23 Aug 2017 15:01:28 +0000","Message-ID":"","References":"<1503373600-20847-1-git-send-email-bmeng.cn@gmail.com>\n\t\n\t","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"m/j7TmGE\";\n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=york.sun@nxp.com; "],"x-originating-ip":"[192.88.168.50]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; VI1PR04MB1437;\n\t6:d97QJ+09LLovhUXlhbOvUlIgtZz6swJRRPy+AviHEDRANk0pVSQf+D2e4I2femBZrblM/fCk/mXp5Qq4DqGhC4exQfM/PO9idfUxfwNupJ8gwBL8x8aYjV4C8m9oRV0rYOCHOIgxdXZ1xywdOCu/34B4/EOw26cD9sZEO2Bb1ZeZdpNnWpEJlQIYHXVwEmL3dJPmcsXP3sNL0DjgiXBxtC91sabK0Hp7gM5acMMiRrlw6R+WbFuF0E16ijbXDgSeMKIhGsIZ4262XElrX2LwPfNf1IbkMgxOuAgy/ovwfU15XF3SuLEJGt4V9pzN58wl0uHftrQn7SLB0lxui7NLCw==;\n\t5:WL5CSTt9ELzZLboAWyLs6gR6ggVMoiI0zv5MWX3KAr/mOHhast/NmaL0vBxQniEXMdhIBBsWmBJNPYHognc+IN6qD832zLYzB74SMhe8/PijPsC/1uec2BIQyzABJACnN7mgOFH2lfn3+ld8730/5Q==;\n\t24:7PT45aMLSzsWy2b+raOKCDicLPnHROuF146sKACuWrC7lVrqxH1tJjjhAiBqxuWezn7QD9m0ruHEYWHkCFxMW5hfs6j2YOT+Eu3eWWsYxSY=;\n\t7:tgzzbFU9LzVllF4N/tmxpty8xDgIs6LG0wyryiWCIMV0q8M7Wa+pEVGWlgCmPyVYtvae8WEgF7B84ZCtFS1Nqy27wUHeDd9RNTJH1kESIUtvGrGZrdx9US5Jj47624xtBLZKGKHj7MKNjl4b+Dor1abYZn3I3jUCoE2/oPEI3voo/5AfNHaRz2iZHDok+et2lOlZujTkoGy0Lw47LjFfc0Vpm3F6IzYVuP/3Ae3FrMM=","x-ms-office365-filtering-correlation-id":"173f911f-4d80-48a2-ec5e-08d4ea37d56b","x-ms-office365-filtering-ht":"Tenant","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603185)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:VI1PR04MB1437; ","x-ms-traffictypediagnostic":"VI1PR04MB1437:","x-ld-processed":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr","x-exchange-antispam-report-test":"UriScan:(185117386973197);","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(100000703101)(100105400095)(6055026)(6041248)(20161123562025)(20161123564025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:VI1PR04MB1437; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:VI1PR04MB1437; ","x-forefront-prvs":"040866B734","x-forefront-antispam-report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(39860400002)(377454003)(199003)(189002)(24454002)(8936002)(74316002)(229853002)(6916009)(43066003)(7416002)(101416001)(5660300001)(76176999)(50986999)(54356999)(7696004)(2906002)(3846002)(6116002)(102836003)(81156014)(3450700001)(7736002)(3280700002)(68736007)(53546010)(33656002)(106356001)(8676002)(105586002)(81166006)(305945005)(3660700001)(14454004)(2900100001)(6246003)(86362001)(39060400002)(110136004)(97736004)(8656003)(478600001)(189998001)(5250100002)(6436002)(66066001)(25786009)(99286003)(55016002)(8666007)(54906002)(6506006)(9686003)(4326008)(53936002)(21314002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB1437;\n\tH:VI1PR04MB2078.eurprd04.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; A:1; MX:1; LANG:en; ","received-spf":"None (protection.outlook.com: nxp.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","MIME-Version":"1.0","X-OriginatorOrg":"nxp.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"23 Aug 2017 15:01:28.8928\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"VI1PR04MB1437","Cc":"Albert Aribaud , Tom Rini ,\n\tU-Boot Mailing List ,\n\tAngelo Dureghello ,\n\tMarcel Ziswiler ,\n\t\"Z.q. Hou\" ,\n\tMichal Simek , \n\tWenbin Song , Joe\n\tHershberger ,\n\tMax Krummenacher ,\n\tStefan Roese , Markus Niebel ","Subject":"Re: [U-Boot] [PATCH] blk: Remove various places that do flush cache\n\tafter read","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"York Sun ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1755452,"web_url":"http://patchwork.ozlabs.org/comment/1755452/","msgid":"","list_archive_url":null,"date":"2017-08-23T16:06:15","subject":"Re: [U-Boot] [PATCH] blk: Remove various places that do flush cache\n\tafter read","submitter":{"id":67822,"url":"http://patchwork.ozlabs.org/api/people/67822/","name":"York Sun","email":"york.sun@nxp.com"},"content":"On 08/21/2017 08:42 PM, Bin Meng wrote:\n> All these places seem to inherit the codes from the MMC driver where\n> a FIXME was put in the comment. However the correct operation after\n> read should be cache invalidate, not flush.\n> \n> The underlying drivers should be responsible for the cache operation.\n> Remove these codes completely.\n> \n> Signed-off-by: Bin Meng \n> ---\n> \n> arch/arm/cpu/armv8/fsl-layerscape/ppa.c | 15 ---------------\n> board/toradex/common/tdx-cfg-block.c | 2 --\n> cmd/mmc.c | 2 --\n> drivers/block/blk-uclass.c | 3 ---\n> drivers/block/blk_legacy.c | 3 ---\n> drivers/net/fm/fm.c | 2 --\n> drivers/net/phy/cortina.c | 2 --\n> drivers/qe/qe.c | 2 --\n> 8 files changed, 31 deletions(-)\n> \n\nTested on LS1043ARDB with SD and NAND boot for PPA and FM.\n\nTested-by: York Sun \nReviewed-by: York Sun ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"WmtoUd+o\";\n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=york.sun@nxp.com; "],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xcsjz0gvyz9s7M\n\tfor ;\n\tThu, 24 Aug 2017 02:06:29 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 19D86C21DFB; Wed, 23 Aug 2017 16:06:22 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 75D75C21C2B;\n\tWed, 23 Aug 2017 16:06:20 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 43E4BC21C2B; Wed, 23 Aug 2017 16:06:19 +0000 (UTC)","from EUR03-AM5-obe.outbound.protection.outlook.com\n\t(mail-eopbgr30067.outbound.protection.outlook.com [40.107.3.67])\n\tby lists.denx.de (Postfix) with ESMTPS id A7BEAC21C26\n\tfor ; Wed, 23 Aug 2017 16:06:18 +0000 (UTC)","from VI1PR04MB2078.eurprd04.prod.outlook.com (10.166.43.18) by\n\tVI1PR04MB2080.eurprd04.prod.outlook.com (10.166.43.20) with Microsoft\n\tSMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.1.1362.18; Wed, 23 Aug 2017 16:06:16 +0000","from VI1PR04MB2078.eurprd04.prod.outlook.com\n\t([fe80::5ce6:46c1:8a2c:ca59]) by\n\tVI1PR04MB2078.eurprd04.prod.outlook.com\n\t([fe80::5ce6:46c1:8a2c:ca59%14]) with mapi id 15.01.1362.019;\n\tWed, 23 Aug 2017 16:06:16 +0000"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=KHOP_BIG_TO_CC,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tSPF_HELO_PASS, \n\tT_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=UJ4aDjd0B6Iv5KPzkzivWnqpOYR8ZEFeRiT9jyl0ipI=;\n\tb=WmtoUd+o0mzXOBfzKy99QGrNgeV2YU3D5/zpWMrVvN7CVZBUIHsmG282l/0u2vIUBqcVhxV3xgpofvUMbBwrlRP8dAHQ+aRG0yxbZQAoo5xvSSyYr1ReEi1AXsu4ZN2k0xCmHxyG7g6D8hUJYFeZ4VoM4s++LFcVNwkm6cPDtd8=","From":"York Sun ","To":"Bin Meng , Grygorii Strashko\n\t, Michal Simek ,\n\t\"Angelo\n\tDureghello\" , Kever Yang ,\n\t\"Jaehoon Chung\" , Albert Aribaud\n\t,\n\tMarcel Ziswiler , \n\tMarkus Niebel , \"Z.q. Hou\"\n\t, Sumit Garg , Joe Hershberger\n\t, Stefan Roese , Wenbin Song\n\t, Qiang Zhao , Simon Glass\n\t, Max Krummenacher ,\n\tMasahiro Yamada , Tomas Melin\n\t, \"Q.y. Gong\" , Tom Rini\n\t, \"U-Boot Mailing List\" ","Thread-Topic":"[PATCH] blk: Remove various places that do flush cache after\n\tread","Thread-Index":"AQHTGvirDLgrxsdG5k+zJcYDaJ+jPw==","Date":"Wed, 23 Aug 2017 16:06:15 +0000","Message-ID":"","References":"<1503373600-20847-1-git-send-email-bmeng.cn@gmail.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"WmtoUd+o\";\n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=york.sun@nxp.com; "],"x-originating-ip":"[192.88.168.50]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; VI1PR04MB2080;\n\t6:df3ZTHWpxj4J4OhTRTFbbaMZk/ZcuT0+n18gGnW2KyMCLOq54wBlu94W6jRMLvaQjgQ67w2cO/gub5tcdVIKbUnVXLtudLMBc6UcpLS9PUZYnjEhrMq2fVc5gjQrOkMiqCs2NSsKEl/JkmOkAYE4ssbYwxlshYfhgb11ba61bcB/7D/xjDOk2gzzzGgvXzpuNcUj1eYmVCLFFjR98d0ki/vddt+5sbuEhpxyfA6Xb9saoJ6opXdK6nZm0aFqF/uuLO75R1UeHMHerrHNOdX2P6JIxAFCxRKvLySdR7suM4QjPZGD8Yx/JkoSAkbgSC3B2eDtYlLpCS+WdTkWzirVrg==;\n\t5:FQmd1olf3cIIfHPRbmgL8zDgGPWfPZIXaceTs5Wz8VWNju3yUSixLoPBKpMNlvS+lzdblDOMaWeZU8NLFHBcXjA81CQVSwaMhU7wLU0ibBp6Kw2I3tFsHfidDULRNbz0j95/pVnrnPlv6SAUf9Rn1w==;\n\t24:obPGMEmuQfBZoojuH/kVx4zpgd5gG/CNFW0r8bLQjmijF3UnHd8KTSb60lEZomJ9c1MgEZfZgxbQO675dx4fabnd+Vie4qUp03it8Ld9tiI=;\n\t7:Go+FDuVGTTpwtwZE0H+LcLq/K2k7wuazg1rjJljpBoD8d1BPJmyOMkskel1kyjPvTmwUTZ2bf/bDo8s1U3allwGr0UbS6Ne8BGDAfewlwX8MEx7CiIfNli1eGpuHbb1RvesSnQ12awdCsfAiaVZKZ6Vctucp6ThSaHES6JzK2/+YaZ1QZnBGEJ2cQKPaLm++mPA5mLqf7FfR2mArmNi+Bik1J80SckcZnYVsnluQfrM=","x-ms-office365-filtering-correlation-id":"f6cdf3e1-d87d-45b6-eed7-08d4ea40e24e","x-ms-office365-filtering-ht":"Tenant","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(48565401081)(2017052603186)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:VI1PR04MB2080; ","x-ms-traffictypediagnostic":"VI1PR04MB2080:","x-ld-processed":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr","x-exchange-antispam-report-test":"UriScan:(185117386973197);","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(100000703101)(100105400095)(6055026)(6041248)(20161123555025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123562025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:VI1PR04MB2080; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:VI1PR04MB2080; ","x-forefront-prvs":"040866B734","x-forefront-antispam-report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(39860400002)(189002)(199003)(24454002)(377454003)(3450700001)(3280700002)(54356999)(39060400002)(33656002)(50986999)(3660700001)(76176999)(101416001)(6116002)(86362001)(9686003)(8666007)(5660300001)(2906002)(53936002)(6506006)(6436002)(229853002)(7696004)(6246003)(55016002)(43066003)(102836003)(3846002)(99286003)(7416002)(25786009)(74316002)(478600001)(5250100002)(68736007)(14454004)(189998001)(105586002)(7736002)(106356001)(66066001)(2900100001)(8936002)(81166006)(305945005)(8676002)(97736004)(81156014)(8656003)(53546010)(921003)(1121003);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB2080;\n\tH:VI1PR04MB2078.eurprd04.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; MX:1; A:1; LANG:en; ","received-spf":"None (protection.outlook.com: nxp.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","MIME-Version":"1.0","X-OriginatorOrg":"nxp.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"23 Aug 2017 16:06:16.0150\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"VI1PR04MB2080","Subject":"Re: [U-Boot] [PATCH] blk: Remove various places that do flush cache\n\tafter read","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"York Sun ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1755832,"web_url":"http://patchwork.ozlabs.org/comment/1755832/","msgid":"","list_archive_url":null,"date":"2017-08-24T03:54:42","subject":"Re: [U-Boot] [PATCH] blk: Remove various places that do flush cache\n\tafter read","submitter":{"id":67973,"url":"http://patchwork.ozlabs.org/api/people/67973/","name":"Yangbo Lu","email":"yangbo.lu@nxp.com"},"content":"> -----Original Message-----\r\n> From: Bin Meng [mailto:bmeng.cn@gmail.com]\r\n> Sent: Wednesday, August 23, 2017 1:29 PM\r\n> To: Y.b. Lu\r\n> Cc: Qiang Zhao; York Sun; Grygorii Strashko; Michal Simek; Angelo\r\n> Dureghello; Kever Yang; Jaehoon Chung; Albert Aribaud; Marcel Ziswiler;\r\n> Markus Niebel; Z.q. Hou; Sumit Garg; Joe Hershberger; Stefan Roese;\r\n> Wenbin Song; Simon Glass; Max Krummenacher; Masahiro Yamada; Tomas Melin;\r\n> Q.y. Gong; Tom Rini; U-Boot Mailing List\r\n> Subject: Re: [PATCH] blk: Remove various places that do flush cache after\r\n> read\r\n> \r\n> Hi Yangbo,\r\n> \r\n> On Wed, Aug 23, 2017 at 11:29 AM, Y.b. Lu wrote:\r\n> > cmd/mmc.c\r\n> >\r\n> > Maybe SD controller on some vendor platforms doesn't support SNOOP.\r\n> > flush_cache() is required to sync between DDR and cache.\r\n> > Should be careful to remove this.\r\n> >\r\n> \r\n> Please do not top-posting.\r\n> \r\n> What you mentioned if snoop is not supported, flush_cache() is required,\r\n> is true, however that's not the issue I am trying to fix here. The\r\n> flush_cache() here after a DMA read will cause issues because stale data\r\n> in the cache will overwrite the correct data in the RAM that is DMAed by\r\n> hardware (in this case, MMC controller).\r\n> \r\n\r\n[Lu Yangbo-B47093] Sorry for my misunderstanding. It looks ok to me now.\r\nflush_cache is indeed redundant after DMA reading.\r\n\r\n\r\n> Regards,\r\n> Bin","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"AyBTtZaM\";\n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=yangbo.lu@nxp.com; "],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xd9RT70vBz9t24\n\tfor ;\n\tThu, 24 Aug 2017 13:55:01 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 9961AC21E3C; Thu, 24 Aug 2017 03:54:52 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id B6D58C21C97;\n\tThu, 24 Aug 2017 03:54:49 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid A9907C21C97; Thu, 24 Aug 2017 03:54:47 +0000 (UTC)","from EUR01-VE1-obe.outbound.protection.outlook.com\n\t(mail-ve1eur01on0070.outbound.protection.outlook.com [104.47.1.70])\n\tby lists.denx.de (Postfix) with ESMTPS id 681D2C21C62\n\tfor ; Thu, 24 Aug 2017 03:54:46 +0000 (UTC)","from DB6PR0401MB2536.eurprd04.prod.outlook.com (10.169.224.151) by\n\tDB6PR0401MB2312.eurprd04.prod.outlook.com (10.168.54.149) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.1.1362.18; Thu, 24 Aug 2017 03:54:42 +0000","from DB6PR0401MB2536.eurprd04.prod.outlook.com\n\t([fe80::8ca:10a:4521:3cac]) by\n\tDB6PR0401MB2536.eurprd04.prod.outlook.com\n\t([fe80::8ca:10a:4521:3cac%18]) with mapi id 15.01.1362.019;\n\tThu, 24 Aug 2017 03:54:42 +0000"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=KHOP_BIG_TO_CC,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,\n\tSPF_HELO_PASS, \n\tT_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=supjyP7FD+w17uni9UiauqaTrq+qBRxvXngPfeL6j10=;\n\tb=AyBTtZaMaRRBGCwPiFlGbxk9pIQeNXb1I52O8NarPoEkS4MDTphS5t1TDpNE7IRFvyh9Mnx1S1OKy2g6l5BGeHmqHxYe4KAllFKbg0ugm2bzCsSjhZZVVNTYRPsaQKb5kF2wT3uIpr470U7fUAoGyyvgonX203pezoYVN3KAdew=","From":"\"Y.b. Lu\" ","To":"Bin Meng ","Thread-Topic":"[PATCH] blk: Remove various places that do flush cache after\n\tread","Thread-Index":"AQHTG73smLLCGgAAF02AGj85Qgs0JaKRRg1AgAAjy4CAAXeSkA==","Date":"Thu, 24 Aug 2017 03:54:42 +0000","Message-ID":"","References":"<1503373600-20847-1-git-send-email-bmeng.cn@gmail.com>\n\t\n\t\n\t\n\t","In-Reply-To":"","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"AyBTtZaM\";\n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=yangbo.lu@nxp.com; "],"x-originating-ip":"[199.59.231.64]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; DB6PR0401MB2312;\n\t6:v1TRMLx2XbYyjxiFzDdFfjTDtlXi+DchkFCS1uGYXqBApIopdxRTV/VmF4YmQsbqt4AU43W2Ho8Z/LpMyWsevhwEzhRrpfm194pGBCV2s2AWbUeVNFsY5YM2G61UOr4ZpjmJqf155EZYhySdTH2kdUgCV+fxj1M90cWDGH2/90JSgbF96y18B+B3MHkyDGqrCSDyU8rhdfNy/G824RJ7lIrAsjYOJNeGolFYxOQy1t6vHLP36D8mTO6Dh29SrPjgGr6KA3NcGsBbwlRIOk/yRiOnk6v8pJJ8rmNxIkiDsU7lRtn3LKSC/Zr/Bxs6zGYsNi1HB1DqZ6X0TERXmQVxIg==;\n\t5:qZwPZnOZlyEs/vNEnsdlzrx4sS3PNyx43a5FwOXL2IaE4QwbPxytRU/eYo5aJZdc9zoCU856t3PR2wkpo9KcQgtWJzdw5r099m8Gqe+uUBIiYimPD1ZuAuEyZet/xWeKitULUEKKsXQDyNruPs59kQ==;\n\t24:Z/W+GJVBuHC8r7iKgShP56KiWFOUy6OTp9FNYNoUpynd0WsVxhV0/FXa2cPmocSjU/Wh0Gmb4hDhM0NhqIc8XF4XKM8pcUFsCMCpljJs6pw=;\n\t7:93bCj3+QNHgeAat6n23LJPOZq3c2fdxITtG9wYS7wZwIkAadv3YBdeyXq8B4kgiwCMuRF71SRLJPMsJ/FcLpPKpgbNuscyFs7H/8+bEfrAH2nqwsju3q0ZnGab8/KfJdyeg/ngP7vNzDm8ZZlznAehX6bOVVHTHdfPU249fybTWEIFwVi1zA6+Vuh0vjmNemMZEMKApbc5qkYxnEMm03sm9Tyw3dK6OqD5spPL4b0os=","x-ms-office365-filtering-correlation-id":"eff808cb-c2c7-4646-11d2-08d4eaa3da48","x-ms-office365-filtering-ht":"Tenant","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603194)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:DB6PR0401MB2312; ","x-ms-traffictypediagnostic":"DB6PR0401MB2312:","x-ld-processed":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr","x-exchange-antispam-report-test":"UriScan:(185117386973197);","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(6055026)(6041248)(20161123564025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123558100)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:DB6PR0401MB2312; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:DB6PR0401MB2312; ","x-forefront-prvs":"04097B7F7F","x-forefront-antispam-report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(39860400002)(377454003)(199003)(13464003)(189002)(24454002)(110136004)(14454004)(5250100002)(6916009)(81156014)(102836003)(189998001)(8676002)(101416001)(33656002)(81166006)(76176999)(54906002)(9686003)(66066001)(86362001)(6246003)(50986999)(4326008)(2906002)(53936002)(25786009)(6436002)(54356999)(478600001)(97736004)(93886005)(6116002)(3846002)(8656003)(2900100001)(6506006)(5660300001)(68736007)(53546010)(39060400002)(105586002)(99286003)(7736002)(74316002)(2950100002)(55016002)(229853002)(3280700002)(7696004)(305945005)(7416002)(8666007)(8936002)(3660700001)(106356001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0401MB2312;\n\tH:DB6PR0401MB2536.eurprd04.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; A:1; MX:1; LANG:en; ","received-spf":"None (protection.outlook.com: nxp.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","MIME-Version":"1.0","X-OriginatorOrg":"nxp.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"24 Aug 2017 03:54:42.7245\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DB6PR0401MB2312","Cc":"Marcel Ziswiler , U-Boot Mailing\n\tList ,\n\tMax Krummenacher , \n\tStefan Roese , Tom Rini ,\n\tAngelo Dureghello ,\n\tMichal Simek , \n\tWenbin Song , \"Z.q. Hou\" , \n\tMarkus Niebel ,\n\tAlbert Aribaud ,\n\tJoe Hershberger ","Subject":"Re: [U-Boot] [PATCH] blk: Remove various places that do flush cache\n\tafter read","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1756570,"web_url":"http://patchwork.ozlabs.org/comment/1756570/","msgid":"","list_archive_url":null,"date":"2017-08-24T16:45:07","subject":"Re: [U-Boot] [PATCH] blk: Remove various places that do flush cache\n\tafter read","submitter":{"id":8809,"url":"http://patchwork.ozlabs.org/api/people/8809/","name":"Joe Hershberger","email":"joe.hershberger@ni.com"},"content":"On Mon, Aug 21, 2017 at 10:46 PM, Bin Meng wrote:\n> All these places seem to inherit the codes from the MMC driver where\n> a FIXME was put in the comment. However the correct operation after\n> read should be cache invalidate, not flush.\n>\n> The underlying drivers should be responsible for the cache operation.\n> Remove these codes completely.\n>\n> Signed-off-by: Bin Meng \n\nReviewed-by: Joe Hershberger ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=nio365.onmicrosoft.com\n\theader.i=@nio365.onmicrosoft.com header.b=\"kxeapgMb\"; \n\tdkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xdVXt1HV1z9sCZ\n\tfor ;\n\tFri, 25 Aug 2017 02:45:50 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid D6D96C21E84; Thu, 24 Aug 2017 16:45:43 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id AFF4EC21DB9;\n\tThu, 24 Aug 2017 16:45:40 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid EF822C21DB9; Thu, 24 Aug 2017 16:45:38 +0000 (UTC)","from mx0b-00010702.pphosted.com (mx0b-00010702.pphosted.com\n\t[148.163.158.57])\n\tby lists.denx.de (Postfix) with ESMTPS id 55F73C21DA9\n\tfor ; Thu, 24 Aug 2017 16:45:38 +0000 (UTC)","from pps.filterd (m0098778.ppops.net [127.0.0.1])\n\tby mx0b-00010702.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7OGf1tW003911\n\tfor ; Thu, 24 Aug 2017 11:45:34 -0500","from nam03-co1-obe.outbound.protection.outlook.com\n\t(mail-co1nam03lp0022.outbound.protection.outlook.com [216.32.181.22])\n\tby mx0b-00010702.pphosted.com with ESMTP id 2cj2fq81cf-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n\tfor ; Thu, 24 Aug 2017 11:45:34 -0500","from mail-io0-f173.google.com (209.85.223.173) by\n\tCY4PR04MB0920.namprd04.prod.outlook.com (10.171.247.151) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.1.1362.18; Thu, 24 Aug 2017 16:45:31 +0000","by mail-io0-f173.google.com with SMTP id g71so40611ioe.1\n\tfor ; Thu, 24 Aug 2017 09:45:31 -0700 (PDT)","by 10.79.158.156 with HTTP; Thu, 24 Aug 2017 09:45:07 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=KHOP_BIG_TO_CC,\n\tRCVD_IN_DNSWL_LOW,\n\tT_DKIM_INVALID autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=nio365.onmicrosoft.com; s=selector1-ni-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=67XqeWhBM2PtZGq3pjtK0ofLF/Bi3czVtZ4PBbNXRXw=;\n\tb=kxeapgMb1GreZ2TjLhmtXqYyqIs6Qy+uyZqviIBgSb2+MW4zu9JhbWXg8XUbTmWYbtmTE7JA95TuxQ+sbfrpf+3WVcBRPL8nCnNdFR9pxwMU5Mtxg2rgE+FCxaJQRlat4aO1tbI+aaIeoxOC0r4UcFu/XAj3FnypixMytRFnEmM=","X-Gm-Message-State":"AHYfb5iUF0igB3SvF76Yzgylc6wBD6NPUFYXWnOGsR7050XMYzTQmbCB\n\totk1Bbx58fvMnIVjYlw0bWmC+Qfhug==","X-Received":"by 10.107.24.65 with SMTP id 62mr6451965ioy.127.1503593128131;\n\tThu, 24 Aug 2017 09:45:28 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1503373600-20847-1-git-send-email-bmeng.cn@gmail.com>","References":"<1503373600-20847-1-git-send-email-bmeng.cn@gmail.com>","From":"Joe Hershberger ","Date":"Thu, 24 Aug 2017 11:45:07 -0500","X-Gmail-Original-Message-ID":"","Message-ID":"","To":"Bin Meng ","X-Originating-IP":"[209.85.223.173]","X-ClientProxiedBy":"MWHPR06CA0027.namprd06.prod.outlook.com (10.174.172.168)\n\tTo\n\tCY4PR04MB0920.namprd04.prod.outlook.com (10.171.247.151)","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"ced6d0d5-f691-498c-be70-08d4eb0f8897","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:CY4PR04MB0920; ","X-Microsoft-Exchange-Diagnostics":["1; CY4PR04MB0920;\n\t3:OKrJflrD9VF2ii/vxJC2Ym6A+iqWiSvJoArpFCnrXfH7FwcJTR+tPxENbtX7hlX7uzqb2KJweFCpzBOTJkQHj4KhVWYtTOlKPAu0m2k62Ui+sjLWhBB/f22PC3l3rPk6eZrKL4YDRQAStXgZUZhtiCf2EO+b2tYit930ce9VHvSBWg317ONKUQ3mjMB13whr+Vym88FZLkl3UFTOqWWYozz0Vyn5g4p/ywgWRPk8Ou6BDSUfskQLWJrqb1df7lK5;\n\t25:M8dVeHNy1IgHkKfj3mh9TdXGPaaSPtXh3KZcuTdGUarwkKgtRUx55o+XCd3lHHPrRKeVqO/wHeR8mdv2IdVLlItz75lWY1hR0oCoAQz1yctOhK4BVy+yyP3m4EuF6x2et8EpMBIirA1oTHoGQJK8mkMw8V/zkIkHm81UnxkY+RQcaRc1IG6t4JbMJvM3T4c+j9gBVOXw624SpFtcXPQ7y9JRIF5JTbPJa6zjq/33vzbyO6CbB0/U2zjQkvW7OO5Wd/2A/qO8zhEkYXgrGXg5YcO6cD3X1Lp9Kv1YYmo5uXzLfcP+1sayH9HNuPIm751ixFPGOh6AbUytdR+xUBMfOw==;\n\t31:bKoBFT8LxDjH78FVx9BacSiUnjligcmEf229Cc4iTP/hO+CXdgglYv+weBEkqGzr/V1B0N4M91TmEoXBENl++TdYEUbdUTGZnJfCpScU/0N9zhhjJMhdC2KEELYvlixeh6ODymSQ3RYYh2MQdt/5kwynFbm5xBbDJewkHb+VINx1RuidtR0Vnbb8FT96uD0uWdhk8U0O8k3cn+/+jzpvf8phaecVuyyiFdHZrir1hf0=","1; CY4PR04MB0920;\n\t20:XFbZ6a+XEkNRy5V5Wq58exnJdYJwG/qticMblBbym/ve2emJVzB5LTGHGZMPAAVsLHFZNcC5QKrZr0fl+B6rRIHqnDdXKHJ99CPfE3QBHvzx/OBeaSpNzeCqy+fV2iW3YeahJQ9HJxKBCs/8uC/8bnjG9WakcVglfPL9TUiAOrEg8++NU+oXZiWrT5DC9XsVjJGpVijUVuGmaYKCCU1jTmBdEo60o14I1EpuWmaz0YI76JU5OTdgz1h6rIcjbBALrC6shH17fRPEMjEkJWqa+JnndETo1mwb4A6oAGjWr8UEZOiwjwOBrvd7uQjXI4J99qqf4w3yWOXU4+167Njll4s7mUCtM/DoF8G8k3vAWeiv7YmIOeKG5pLlfBTCj111dZrXPaEvT0FD500QGRL1IdP7lBCYWrfug4mBU4lDzKFgaV/ifDKCauKOyY1wUtTwSpJiLmkO2xX49UO9UJGcBhF3Kc60ZwDdcBFWFfvMv2b1wVdn9c/yagFTIln35sHpZDMC9d5pTWleQOS53vUwB6+Qld6PDz73izx7/ouUjRMoEivY4l5PudwNoFHuKcfFEc3T9Ypcp2s+kLkhnMrKC1R3CEV1OIQs6Btgyw7rpks=;\n\t4:rkFG6DbeQfygxOO+FSG6I5BjSRrvo666tTThMiQM7BbleFOwQmZ1joYn6mcnQPDImr8AZqAb5BKnkHcsUv53u8KOXU/xE25bjbQd7TG0ncVH+nWKE6NETjj810NPHamQ2iSWdUP9o/zlairRSw7NLZVeI03Vsw+SB+uU0ocdSL6KlpxoDWUGhRQOgs/udyF3KO284boHRG0HwAs3LRthKLsa6tVLv3A2YiemfxkWRZ8rcmnSh9oOJ1H7da/TlRLWkJyok8QHbKMbVWjWhqsoQ6Uww8Q2s2dZ/b8mhwuKZbs=","=?utf-8?B?MTtDWTRQUjA0TUIwOTIwOzIzOnltV3dKM2xLcTRWMWxCTlM5d1NidzRJa29H?=\n\t=?utf-8?B?V1RmOE1hdGoxdnF6SUd5Q3hta2JhakN4c3dNZW5SSkRVUTRIWDhNem5pK3ZK?=\n\t=?utf-8?B?cEpTbnp3TkU3cEpkRGRuaUgwd29TQjBmMVRrcHNoR2JHd2s1cTZweHFHWDND?=\n\t=?utf-8?B?UmJCeVJKQVNpS3U0MnZaRjBRRnFKZXVSd0JwSER6ang5OTBlbndyR3RhYUNm?=\n\t=?utf-8?B?U1FPRG1RRGZ4T01QbzBZVjZsYldnTGNOamdtM3hhMjI5a3NYV040MVVIUDdF?=\n\t=?utf-8?B?Skw1ZGtZYkgzdmFkbThBTnpsZ1BxRlMzaTNUQnpGZVNCTHk0RnNORmY5NkV4?=\n\t=?utf-8?B?djdkbFpWOHphN3FYUU9PTk9EYmZlM2pkdk9FL1YxZVZvZVVlYUIxajE5MHFC?=\n\t=?utf-8?B?SHExaUNLMysrWDZNcWZnRHhUTFhXRmp1VFp1UktnOTIvNHVUTXVHTFhKTG1P?=\n\t=?utf-8?B?M0lPM1kwbGJCWEJYSGxZQWVFTFNlTkRZQWFZdjJNOXZNaXY1STdDS3pJcWNP?=\n\t=?utf-8?B?cnNpRVFjbGxVMWNEZDFzM3hUSnM0aEo2emhVYWNZc3RFT3JLVUZuTFBsemVR?=\n\t=?utf-8?B?RHVsVXNHSUFEdUZ5Zmc0aVZQUFRmTlQ2UVRzRzlmKzJ3ZVd0L0FUZ1lYNW9s?=\n\t=?utf-8?B?OEpqNWRjdnFtQjFhRlVTNzluUnI0RjNHQlhhbkxvczRvdEhVZmlkby9WV2xv?=\n\t=?utf-8?B?aExIdDVVVmZkeDNrQml6UUFGQ3FudWYrVytuaGJ2enJWWC9ZNDYvU2xLUXh2?=\n\t=?utf-8?B?VTExV1FvRU93a1lWNWF1L3N2eVRCTnhDS3ZON3dMRzRnVzZ0YjIyaGgwNDdv?=\n\t=?utf-8?B?NUdkUm81UW0yb25JbnRLTS9iWlR4SFZvZ0RTOThYZUJJSHVtL0dRaXdXRkU1?=\n\t=?utf-8?B?UHNTNmJ6bkNDeWRmQjcyaXpVaml3S3pORExUWElpSWpRWjNpd0N0aE1PV1pO?=\n\t=?utf-8?B?cXpoWWFKQVpOdGsva0x4SCswYnM2dGJBd0JaUkcyMm0zOXNpd1BpNTQ5MEJ2?=\n\t=?utf-8?B?cERCNncrU2lqdm9hMW1jamNzMGpOL2d0UTBXWHlNcmNwZG1od0djZ3JpTUxZ?=\n\t=?utf-8?B?NUljeVcvRHR0Zy9RVkJpeXdyTTdHcXJVb1l2NUxxdHFRM1hWcWFxR1c2WFdN?=\n\t=?utf-8?B?VHZ1T0M3Q0tnekJhZEZ0V2IxZjc5ZHBvbkFVSldDRExxbTZpS3h6N1VYVit5?=\n\t=?utf-8?B?STR5UkswWHhlVHdBb1NLaHNnT3FwYmEvSDEyQ3A2dXhvbGxEb3ozUkJxNmdD?=\n\t=?utf-8?B?VXI5T0R3NVpLaDMvVU1oYkg4V0dUeVJGTldPTHRDdlJ6SDZEeVo4UnpWQlNq?=\n\t=?utf-8?B?NkJ0ZjBVZnNUcWhYa2dITlg3bzRIWW9TVUEwT2NsazRFUWpsTzdEMXIyR0ta?=\n\t=?utf-8?B?SGM5QWFhSmNqRFlsSXVGcFZSbGlSM2FFcnlWUEgrK09FUVdCWHFxbGpjQVZa?=\n\t=?utf-8?B?cVJIWnBKSEZQOXZueVdoclhab29jVGRQQUFObWx3cmtTZ3B1MjVyaFRCeGZ2?=\n\t=?utf-8?B?VG5CMVhQYm9ET3NpZ1p6L3EvSTBURDRwRFcwYUhoM1E4NldUNjRmL0Uzai9a?=\n\t=?utf-8?B?UC9xeXhYMjN1NnpxTW4rWVJ1Q0pTQzVza3paeWR2cTZvbFdIcXZQOVd3RG81?=\n\t=?utf-8?B?enpLdDQ2SzJSbWc5R3kyY1Q4Y1BqQk9JZUZmS0QxMFZwQVJlQ3B3L2FkN3lD?=\n\t=?utf-8?B?V0x1V0xhdVJPN0g5UlFyWGFkWFVPU1FzVDU0OEtFbWZZUG9PVmVYZWxncndJ?=\n\t=?utf-8?B?RmlKQzA3elZMOGQ0K2haczJBa3JiMWxqaFRVRGFkUExwalppcVc4UEtOQldh?=\n\t=?utf-8?B?OTNHU3YyWFZUekZKRnNKWWZVNXdUK3ZQclNHa3J6VU0ycStLTHV1VlFtRW1s?=\n\t=?utf-8?Q?zLqcnvX/k32LTdDUsHN5fyfXfP2C/U4t?=","1; CY4PR04MB0920;\n\t6:J2B6vhue0yjoZX2TId5MEerpVlJQj2bA01sIXmPRev8jQIc/6EcyNUY+bure/U3TSk58BXvNYYss+0xpW444JOlbt5v+aaWDtgfwMNgckdBZW2UqB5dRbjQim3g0hfnrSidAiP8icjdjr1vhC1rTI+FLavoZniw2Z/xZdvu4r3Li50qFrMmiiDEJSq2AWBZINs2MIoyxDx724atEKAnj6KuU/b1xxkP4eQo2AnaJ99daRC4DayJgoOY0F6ncQrSipenc9iaRqioB2HmdNpYL9N22HDR8jrmY+Dk5lq4mOsjwkAzsWaRCeJgMF4gIP+UkU03wqbYDrnBEM0uMRDcbmQ==;\n\t5:ctf7Kvu6ntIMeFxRdMqjhXgi0FphWsZok1H9JaGylEgRB9H1QPd1U6jWmeCqD/7xQKjWXqzoX5D0p6CI4CiCTDAVnGFhmXsFKjj8weTp88Gu12l1XVT3sBT5VUmPnHxC0T7uZhkyF51BSFOi4D+QOQ==;\n\t24:RTtKCKzSwzQX4rJHeBgS7OICOWkww/wSYNNDEiSRZnous9Cs6NPG/NrRqYI2KRZMd+oz0RCQN4k2Pale1UeNS8TC2pMLuO5aQh4y7v0ROZo=;\n\t7:d4L9swRuojCNo7mpHOrIcSbMO70/mBOJ2wjzkGwF8jyNRqtlePLzy1DUCyoAxZpUXDSZs+K/cSx4a9l4cML8IjCYhdDdBkvQJ0Vp0kXHJONdI3d1ZdWoqDBrWMNn/7iOjjZIWVpIg63YVwXt/U9L3Oj4uCZTL2RdyPrH1patCC5oJUV4C0Br+gtHgrNepVRd+QgIY/y+k4CM0flIuetzxdqtFFI3qcNkV5/Vt6weSI4="],"X-MS-TrafficTypeDiagnostic":"CY4PR04MB0920:","X-Exchange-Antispam-Report-Test":"UriScan:(145744241990776);","X-Microsoft-Antispam-PRVS":"","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(100000703101)(100105400095)(6041248)(20161123560025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123555025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:CY4PR04MB0920; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:CY4PR04MB0920; ","X-Forefront-PRVS":"04097B7F7F","X-Forefront-Antispam-Report":"SFV:NSPM;\n\tSFS:(10019020)(4630300001)(7370300001)(6009001)(377454003)(199003)(24454002)(189002)(54906002)(9686003)(81166006)(2950100002)(7736002)(8676002)(98316002)(53936002)(53546010)(305945005)(69596002)(81156014)(6862004)(61266001)(122856001)(2860700003)(50466002)(47776003)(59536001)(42186005)(6246003)(189998001)(7350300001)(68736007)(2906002)(229853002)(61726006)(76176999)(9896002)(97736004)(50986999)(4001600100001)(55446002)(4326008)(23676002)(66066001)(5820100001)(6116002)(54356999)(63696999)(43066003)(3846002)(106356001)(93516999)(5660300001)(478600001)(105586002)(101416001)(110136004)(498394004)(55456009);\n\tDIR:OUT; SFP:1102; SCL:1; SRVR:CY4PR04MB0920;\n\tH:mail-io0-f173.google.com; FPR:; \n\tSPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; ","Received-SPF":"None (protection.outlook.com: ni.com does not designate\n\tpermitted sender hosts)","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-OriginatorOrg":"ni.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"24 Aug 2017 16:45:31.4765\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"CY4PR04MB0920","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-24_06:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_policy_notspam\n\tpolicy=outbound_policy score=30\n\tpriorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0\n\tbulkscore=0\n\tspamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0\n\tadultscore=0\n\tclassifier=spam adjust=30 reason=mlx scancount=1\n\tengine=8.0.1-1707230000\n\tdefinitions=main-1708240258","Cc":"Marcel Ziswiler ,\n\tU-Boot Mailing List ,\n\tMax Krummenacher ,\n\tStefan Roese , \n\tTom Rini , Angelo Dureghello ,\n\tMichal Simek ,\n\tWenbin Song , Hou Zhiqiang ,\n\tMarkus Niebel ,\n\tAlbert Aribaud ,\n\tJoe Hershberger ","Subject":"Re: [U-Boot] [PATCH] blk: Remove various places that do flush cache\n\tafter read","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"joe.hershberger@gmail.com","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1758306,"web_url":"http://patchwork.ozlabs.org/comment/1758306/","msgid":"","list_archive_url":null,"date":"2017-08-27T20:09:53","subject":"Re: [U-Boot] [PATCH] blk: Remove various places that do flush cache\n\tafter read","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 21 August 2017 at 21:46, Bin Meng wrote:\n> All these places seem to inherit the codes from the MMC driver where\n> a FIXME was put in the comment. However the correct operation after\n> read should be cache invalidate, not flush.\n>\n> The underlying drivers should be responsible for the cache operation.\n> Remove these codes completely.\n>\n> Signed-off-by: Bin Meng \n> ---\n>\n> arch/arm/cpu/armv8/fsl-layerscape/ppa.c | 15 ---------------\n> board/toradex/common/tdx-cfg-block.c | 2 --\n> cmd/mmc.c | 2 --\n> drivers/block/blk-uclass.c | 3 ---\n> drivers/block/blk_legacy.c | 3 ---\n> drivers/net/fm/fm.c | 2 --\n> drivers/net/phy/cortina.c | 2 --\n> drivers/qe/qe.c | 2 --\n> 8 files changed, 31 deletions(-)\n\nReviewed-by: Simon Glass ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"SinraQPd\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"H89lB6Hw\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xgR2w4fDtz9s8V\n\tfor ;\n\tMon, 28 Aug 2017 06:15:04 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 25383C2230A; Sun, 27 Aug 2017 20:12:31 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id E00B5C2232B;\n\tSun, 27 Aug 2017 20:12:27 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 89EE8C22313; Sun, 27 Aug 2017 20:10:19 +0000 (UTC)","from mail-qt0-f175.google.com (mail-qt0-f175.google.com\n\t[209.85.216.175])\n\tby lists.denx.de (Postfix) with ESMTPS id 973E0C22329\n\tfor ; Sun, 27 Aug 2017 20:10:15 +0000 (UTC)","by mail-qt0-f175.google.com with SMTP id x36so17638504qtx.2\n\tfor ; Sun, 27 Aug 2017 13:10:15 -0700 (PDT)","by 10.200.52.117 with HTTP; Sun, 27 Aug 2017 13:09:53 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=KHOP_BIG_TO_CC,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=pSMeFMQCoBTLhCS345tJw8LUTXrs7jqfjepftANOdwI=;\n\tb=SinraQPdQo6e6y6s7pKJDQfjlmL7xyjrBawanVhQNzqYEyE7HEamZ917T1Gk5UiNy5\n\tkQWtdxfyNfxWjAd8bfpYg97AVSXpIHc2t9P6fnpCuAeRG3p+aMlCuHjKLSwkrYpatZd8\n\tkauJFAkGJqp/zV1hyR43qIRSYZaB/8ZAmdP62Ne4kTUx2Y0sLoPrq2kQBGuC/yGjxBec\n\tYOZYfT8qsAVE4nbHDcC87+kd/LMm3KjzvXy28TGTic8NW97+Mv+XflV0dFrsueYo0oZV\n\tbWtCAikaH1VHpRn6sn+siJJpWv2udEV+16l46CKRr8HlzDgIBNVMKypAfogRFRWKRfyu\n\tueNQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=pSMeFMQCoBTLhCS345tJw8LUTXrs7jqfjepftANOdwI=;\n\tb=H89lB6HwnNl3qRuYYQY8vw/LXUx1gtRs58+VsI8+8sef/drB3q2bjWG9UUbEzSAl65\n\tTu+8Eiep5g80p2H2O99xZPZBrzax1a6CdAYJ9DVjc+TfXLKt21QGtmYqNfOCrkRAXHYv\n\tgJnxmT9fA43iP8CKfjA6WpBkXO6SvQscHA/cA="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=pSMeFMQCoBTLhCS345tJw8LUTXrs7jqfjepftANOdwI=;\n\tb=XDNOY7pMYDCfOPr3IxK4ZqIXXmw1zUm4CGa9/QukJecIiS1FW7Z7LXaVFEQsF/VX91\n\tMjTcEmhGouDeB2IfwvTgcBkYsrDdHOfiSRWesllnjtkFo9VZLdcB4EnJMJzdQU3iVHej\n\t5dVrMfPtbE81hzUhr8fsAygM7kGT4hbZvtp1GheY6uaGuHmMLyL2yHtxOvjuyPWq4rRQ\n\tREOrFpIoNh//C9YQYrFzpXxxKBHJSnIZ7Hr2sqquyIVe5mw0RvgZJy77auwCxmW3uIZr\n\tu2ixV7U8l2fwv7g0I5lZzyd5HpyhnvhhRUE9nkVY7/6+JbeEkCxqK11xELNKQUVaT/M0\n\tSohg==","X-Gm-Message-State":"AHYfb5g1v3u+u2WuCim/evpW0Omz7P/oLzP9NQ5QD7GSePun3x1HbdER\n\tNH+qDEXNsp57X1w/x70OsdZJWzHN2Xf+","X-Google-Smtp-Source":"ADKCNb7AiQKZbQ/Y7CpubrGwjm+i4PCRYZsY1f/+wZXMV1lT2gc8PFf63axbn2VnNBy3Lo0DbamebMRbisJY+5aD7po=","X-Received":"by 10.237.47.163 with SMTP id m32mr7022610qtd.145.1503864614383; \n\tSun, 27 Aug 2017 13:10:14 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1503373600-20847-1-git-send-email-bmeng.cn@gmail.com>","References":"<1503373600-20847-1-git-send-email-bmeng.cn@gmail.com>","From":"Simon Glass ","Date":"Sun, 27 Aug 2017 14:09:53 -0600","X-Google-Sender-Auth":"PzVzawUiPZPO7_rH0UFQW-ggcQk","Message-ID":"","To":"Bin Meng ","Cc":"Albert Aribaud , Tom Rini ,\n\tU-Boot Mailing List ,\n\tAngelo Dureghello ,\n\tMarcel Ziswiler ,\n\tHou Zhiqiang ,\n\tMichal Simek , \n\tWenbin Song ,\n\tJoe Hershberger , \n\tMax Krummenacher ,\n\tStefan Roese , Markus Niebel ","Subject":"Re: [U-Boot] [PATCH] blk: Remove various places that do flush cache\n\tafter read","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]