Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/787398/?format=api
{ "id": 787398, "url": "http://patchwork.ozlabs.org/api/patches/787398/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170712094614.76501-6-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170712094614.76501-6-alice.michael@intel.com>", "list_archive_url": null, "date": "2017-07-12T09:46:09", "name": "[next,S75-V3,06/11] i40e: prevent snprintf format specifier truncation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "60960ecc71618c73496bdc44899e0c2d32023dfe", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170712094614.76501-6-alice.michael@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/787398/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/787398/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3x761w565Mz9s0Z\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 13 Jul 2017 03:51:00 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id E722330912;\n\tWed, 12 Jul 2017 17:50:58 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id S5s5JvAmCqn2; Wed, 12 Jul 2017 17:50:54 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 4739030933;\n\tWed, 12 Jul 2017 17:50:49 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 38B811C411B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 12 Jul 2017 17:50:45 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 3387889FD2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 12 Jul 2017 17:50:45 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id yd+5Q2JqkUQW for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 12 Jul 2017 17:50:42 +0000 (UTC)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 7042789FF3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 12 Jul 2017 17:50:42 +0000 (UTC)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga104.jf.intel.com with ESMTP; 12 Jul 2017 10:50:41 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.16.121])\n\tby FMSMGA003.fm.intel.com with ESMTP; 12 Jul 2017 10:50:41 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.40,350,1496127600\"; d=\"scan'208\";a=\"878118676\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Wed, 12 Jul 2017 05:46:09 -0400", "Message-Id": "<20170712094614.76501-6-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.3", "In-Reply-To": "<20170712094614.76501-1-alice.michael@intel.com>", "References": "<20170712094614.76501-1-alice.michael@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S75-V3 06/11] i40e: prevent snprintf\n\tformat specifier truncation", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jacob Keller <jacob.e.keller@intel.com>\n\nIncrease the size of the prefix buffer so that it can hold enough\ncharacters for every possible input. Although 20 is enough for all\nexpected inputs, it is possible for the values to be larger than\nexpected, resulting in a possibly truncated string. Additionally, lets\nuse sizeof(prefix) in order to ensure we use the correct size if we need\nto change the array length in the future.\n\nNew versions of GCC starting at 7 now include warnings to prevent\ntruncation unless you handle the return code. At most 27 bytes can be\nwritten here, so lets just increase the buffer size even if for all\nexpected hw->bus.* values we only needed 20.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_common.c | 4 ++--\n drivers/net/ethernet/intel/i40evf/i40e_common.c | 4 ++--\n 2 files changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_common.c b/drivers/net/ethernet/intel/i40e/i40e_common.c\nindex 5c36a18..111426b 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_common.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_common.c\n@@ -328,9 +328,9 @@ void i40e_debug_aq(struct i40e_hw *hw, enum i40e_debug_mask mask, void *desc,\n \t\t\tlen = buf_len;\n \t\t/* write the full 16-byte chunks */\n \t\tif (hw->debug_mask & mask) {\n-\t\t\tchar prefix[20];\n+\t\t\tchar prefix[27];\n \n-\t\t\tsnprintf(prefix, 20,\n+\t\t\tsnprintf(prefix, sizeof(prefix),\n \t\t\t\t \"i40e %02x:%02x.%x: \\t0x\",\n \t\t\t\t hw->bus.bus_id,\n \t\t\t\t hw->bus.device,\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40e_common.c b/drivers/net/ethernet/intel/i40evf/i40e_common.c\nindex 1dd1938..bfe9b516 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40e_common.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40e_common.c\n@@ -333,9 +333,9 @@ void i40evf_debug_aq(struct i40e_hw *hw, enum i40e_debug_mask mask, void *desc,\n \t\t\tlen = buf_len;\n \t\t/* write the full 16-byte chunks */\n \t\tif (hw->debug_mask & mask) {\n-\t\t\tchar prefix[20];\n+\t\t\tchar prefix[27];\n \n-\t\t\tsnprintf(prefix, 20,\n+\t\t\tsnprintf(prefix, sizeof(prefix),\n \t\t\t\t \"i40evf %02x:%02x.%x: \\t0x\",\n \t\t\t\t hw->bus.bus_id,\n \t\t\t\t hw->bus.device,\n", "prefixes": [ "next", "S75-V3", "06/11" ] }