[{"id":1718890,"web_url":"http://patchwork.ozlabs.org/comment/1718890/","msgid":"<26D9FDECA4FBDD4AADA65D8E2FC68A4A10DB1C30@ORSMSX104.amr.corp.intel.com>","list_archive_url":null,"date":"2017-07-14T22:34:44","subject":"Re: [Intel-wired-lan] [next PATCH S75-V3 06/11] i40e: prevent\n\tsnprintf\tformat specifier truncation","submitter":{"id":66945,"url":"http://patchwork.ozlabs.org/api/people/66945/","name":"Bowers, AndrewX","email":"andrewx.bowers@intel.com"},"content":"> -----Original Message-----\n> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On\n> Behalf Of Alice Michael\n> Sent: Wednesday, July 12, 2017 2:46 AM\n> To: Michael, Alice ; intel-wired-\n> lan@lists.osuosl.org\n> Subject: [Intel-wired-lan] [next PATCH S75-V3 06/11] i40e: prevent snprintf\n> format specifier truncation\n> \n> From: Jacob Keller \n> \n> Increase the size of the prefix buffer so that it can hold enough characters for\n> every possible input. Although 20 is enough for all expected inputs, it is\n> possible for the values to be larger than expected, resulting in a possibly\n> truncated string. Additionally, lets use sizeof(prefix) in order to ensure we\n> use the correct size if we need to change the array length in the future.\n> \n> New versions of GCC starting at 7 now include warnings to prevent\n> truncation unless you handle the return code. At most 27 bytes can be\n> written here, so lets just increase the buffer size even if for all expected hw-\n> >bus.* values we only needed 20.\n> \n> Signed-off-by: Jacob Keller \n> ---\n> drivers/net/ethernet/intel/i40e/i40e_common.c | 4 ++--\n> drivers/net/ethernet/intel/i40evf/i40e_common.c | 4 ++--\n> 2 files changed, 4 insertions(+), 4 deletions(-)\n\nTested-by: Andrew Bowers ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Received":["from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3x8SDW3PP7z9s7m\n\tfor ;\n\tSat, 15 Jul 2017 08:34:51 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id ECC1430B4D;\n\tFri, 14 Jul 2017 22:34:49 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 8ZCjtZmqR8zx; Fri, 14 Jul 2017 22:34:49 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 559F92F43C;\n\tFri, 14 Jul 2017 22:34:49 +0000 (UTC)","from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id CA6431CE81B\n\tfor ;\n\tFri, 14 Jul 2017 22:34:47 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id C3AAA883E1\n\tfor ;\n\tFri, 14 Jul 2017 22:34:47 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 1k-vAUQNDLjC for ;\n\tFri, 14 Jul 2017 22:34:46 +0000 (UTC)","from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 6FBAD883DF\n\tfor ;\n\tFri, 14 Jul 2017 22:34:46 +0000 (UTC)","from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t14 Jul 2017 15:34:45 -0700","from orsmsx102.amr.corp.intel.com ([10.22.225.129])\n\tby fmsmga002.fm.intel.com with ESMTP; 14 Jul 2017 15:34:45 -0700","from orsmsx155.amr.corp.intel.com (10.22.240.21) by\n\tORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP\n\tServer (TLS) id 14.3.319.2; Fri, 14 Jul 2017 15:34:44 -0700","from orsmsx104.amr.corp.intel.com ([169.254.4.205]) by\n\tORSMSX155.amr.corp.intel.com ([169.254.7.9]) with mapi id\n\t14.03.0319.002; Fri, 14 Jul 2017 15:34:44 -0700"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos; i=\"5.40,360,1496127600\"; d=\"scan'208\";\n\ta=\"1195564729\"","From":"\"Bowers, AndrewX\" ","To":"\"intel-wired-lan@lists.osuosl.org\" ","Thread-Topic":"[Intel-wired-lan] [next PATCH S75-V3 06/11] i40e: prevent\n\tsnprintf\tformat specifier truncation","Thread-Index":"AQHS+zd1DtOgY42ERU+Cd/79sQyV1qJT7EaA","Date":"Fri, 14 Jul 2017 22:34:44 +0000","Message-ID":"<26D9FDECA4FBDD4AADA65D8E2FC68A4A10DB1C30@ORSMSX104.amr.corp.intel.com>","References":"<20170712094614.76501-1-alice.michael@intel.com>\n\t<20170712094614.76501-6-alice.michael@intel.com>","In-Reply-To":"<20170712094614.76501-6-alice.michael@intel.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-titus-metadata-40":"eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZThmYTk1YWYtZDE0ZS00NjE3LWE4ZmQtZWE2ZTIyMGIzZjBlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Ikh1V0grS29GOWRYeVBlS0dqSkVJcFZUaFZsOE96d0JIM1BRWVZ0enI1WlU9In0=","x-ctpclassification":"CTP_IC","dlp-product":"dlpe-windows","dlp-version":"10.0.102.7","dlp-reaction":"no-action","x-originating-ip":"[10.22.254.139]","MIME-Version":"1.0","Subject":"Re: [Intel-wired-lan] [next PATCH S75-V3 06/11] i40e: prevent\n\tsnprintf\tformat specifier truncation","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t","List-Unsubscribe":", \n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":", \n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]