Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 552,
    "url": "http://patchwork.ozlabs.org/api/patches/552/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/1221773464-28845-1-git-send-email-vladislav.yasevich@hp.com/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<1221773464-28845-1-git-send-email-vladislav.yasevich@hp.com>",
    "list_archive_url": null,
    "date": "2008-09-18T21:31:03",
    "name": "[1/2] sctp: do not enable peer features if we can't do them.",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "010c122296defdd3a1ac7ea591e6bef159367fa1",
    "submitter": {
        "id": 279,
        "url": "http://patchwork.ozlabs.org/api/people/279/?format=api",
        "name": "Vlad Yasevich",
        "email": "vladislav.yasevich@hp.com"
    },
    "delegate": null,
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/1221773464-28845-1-git-send-email-vladislav.yasevich@hp.com/mbox/",
    "series": [],
    "comments": "http://patchwork.ozlabs.org/api/patches/552/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/552/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id CFB75DDF19\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 19 Sep 2008 07:31:18 +1000 (EST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755663AbYIRVbM (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 18 Sep 2008 17:31:12 -0400",
            "(majordomo@vger.kernel.org) by vger.kernel.org id S1755410AbYIRVbM\n\t(ORCPT <rfc822; netdev-outgoing>); Thu, 18 Sep 2008 17:31:12 -0400",
            "from g1t0029.austin.hp.com ([15.216.28.36]:32527 \"EHLO\n\tg1t0029.austin.hp.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1754356AbYIRVbJ (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Thu, 18 Sep 2008 17:31:09 -0400",
            "from smtp1.fc.hp.com (smtp.cnd.hp.com [15.15.136.127])\n\tby g1t0029.austin.hp.com (Postfix) with ESMTP id ECED83809B;\n\tThu, 18 Sep 2008 21:31:06 +0000 (UTC)",
            "from localhost.localdomain (squirrel.fc.hp.com [15.11.146.57])\n\tby smtp1.fc.hp.com (Postfix) with ESMTP id D016C203426;\n\tThu, 18 Sep 2008 21:16:42 +0000 (UTC)"
        ],
        "From": "Vlad Yasevich <vladislav.yasevich@hp.com>",
        "To": "davem@davemloft.net",
        "Cc": "linux-sctp@vger.kernel.org,\n\tlksctp-developers@lists.sourceforge.net, netdev@vger.kernel.org,\n\tVlad Yasevich <vladislav.yasevich@hp.com>",
        "Subject": "[PATCH 1/2] sctp: do not enable peer features if we can't do them.",
        "Date": "Thu, 18 Sep 2008 17:31:03 -0400",
        "Message-Id": "<1221773464-28845-1-git-send-email-vladislav.yasevich@hp.com>",
        "X-Mailer": "git-send-email 1.5.3.5",
        "X-Brightmail-Tracker": "AAAAAQAAAAI=",
        "X-Whitelist": "TRUE",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "Do not enable peer features like addip and auth, if they\nare administratively disabled localy.  If the peer resports\nthat he supports something that we don't, neither end can\nuse it so enabling it is pointless.  This solves a problem\nwhen talking to a peer that has auth and addip enabled while\nwe do not.  Found by Andrei Pelinescu-Onciul <andrei@iptel.org>.\n\nSigned-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>",
    "diff": "diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c\nindex e8ca4e5..fe94f42 100644\n--- a/net/sctp/sm_make_chunk.c\n+++ b/net/sctp/sm_make_chunk.c\n@@ -1886,11 +1886,13 @@ static void sctp_process_ext_param(struct sctp_association *asoc,\n \t\t\t    /* if the peer reports AUTH, assume that he\n \t\t\t     * supports AUTH.\n \t\t\t     */\n-\t\t\t    asoc->peer.auth_capable = 1;\n+\t\t\t    if (sctp_auth_enable)\n+\t\t\t\t    asoc->peer.auth_capable = 1;\n \t\t\t    break;\n \t\t    case SCTP_CID_ASCONF:\n \t\t    case SCTP_CID_ASCONF_ACK:\n-\t\t\t    asoc->peer.asconf_capable = 1;\n+\t\t\t    if (sctp_addip_enable)\n+\t\t\t\t    asoc->peer.asconf_capable = 1;\n \t\t\t    break;\n \t\t    default:\n \t\t\t    break;\n@@ -2460,6 +2462,9 @@ do_addr_param:\n \t\tbreak;\n \n \tcase SCTP_PARAM_SET_PRIMARY:\n+\t\tif (!sctp_addip_enable)\n+\t\t\tgoto fall_through;\n+\n \t\taddr_param = param.v + sizeof(sctp_addip_param_t);\n \n \t\taf = sctp_get_af_specific(param_type2af(param.p->type));\n",
    "prefixes": [
        "1/2"
    ]
}