[{"id":1232,"web_url":"http://patchwork.ozlabs.org/comment/1232/","msgid":"<48D2DDC3.3060406@hp.com>","list_archive_url":null,"date":"2008-09-18T23:01:23","subject":"Re: [Lksctp-developers] [PATCH 1/2] sctp: do not enable peer\n\tfeatures if we can't do them.","submitter":{"id":279,"url":"http://patchwork.ozlabs.org/api/people/279/","name":"Vlad Yasevich","email":"vladislav.yasevich@hp.com"},"content":"David\n\nCan you also queue this one and Patch 2/2 to stable. The problems\nare there as well.\n\nThanks\n-vlad\n\nVlad Yasevich wrote:\n> Do not enable peer features like addip and auth, if they\n> are administratively disabled localy. If the peer resports\n> that he supports something that we don't, neither end can\n> use it so enabling it is pointless. This solves a problem\n> when talking to a peer that has auth and addip enabled while\n> we do not. Found by Andrei Pelinescu-Onciul .\n> \n> Signed-off-by: Vlad Yasevich \n> ---\n> net/sctp/sm_make_chunk.c | 9 +++++++--\n> 1 files changed, 7 insertions(+), 2 deletions(-)\n> \n> diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c\n> index e8ca4e5..fe94f42 100644\n> --- a/net/sctp/sm_make_chunk.c\n> +++ b/net/sctp/sm_make_chunk.c\n> @@ -1886,11 +1886,13 @@ static void sctp_process_ext_param(struct sctp_association *asoc,\n> \t\t\t /* if the peer reports AUTH, assume that he\n> \t\t\t * supports AUTH.\n> \t\t\t */\n> -\t\t\t asoc->peer.auth_capable = 1;\n> +\t\t\t if (sctp_auth_enable)\n> +\t\t\t\t asoc->peer.auth_capable = 1;\n> \t\t\t break;\n> \t\t case SCTP_CID_ASCONF:\n> \t\t case SCTP_CID_ASCONF_ACK:\n> -\t\t\t asoc->peer.asconf_capable = 1;\n> +\t\t\t if (sctp_addip_enable)\n> +\t\t\t\t asoc->peer.asconf_capable = 1;\n> \t\t\t break;\n> \t\t default:\n> \t\t\t break;\n> @@ -2460,6 +2462,9 @@ do_addr_param:\n> \t\tbreak;\n> \n> \tcase SCTP_PARAM_SET_PRIMARY:\n> +\t\tif (!sctp_addip_enable)\n> +\t\t\tgoto fall_through;\n> +\n> \t\taddr_param = param.v + sizeof(sctp_addip_param_t);\n> \n> \t\taf = sctp_get_af_specific(param_type2af(param.p->type));","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Received":["from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id C7A95DE072\n\tfor ;\n\tFri, 19 Sep 2008 09:01:36 +1000 (EST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755473AbYIRXB1 (ORCPT );\n\tThu, 18 Sep 2008 19:01:27 -0400","(majordomo@vger.kernel.org) by vger.kernel.org id S1753368AbYIRXB1\n\t(ORCPT ); Thu, 18 Sep 2008 19:01:27 -0400","from g4t0017.houston.hp.com ([15.201.24.20]:38870 \"EHLO\n\tg4t0017.houston.hp.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1754828AbYIRXB0 (ORCPT\n\t); Thu, 18 Sep 2008 19:01:26 -0400","from mailstation.cce.hp.com (mailstation.zcce.gate.cpqcorp.net\n\t[16.104.192.124])\n\t(using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits))\n\t(No client certificate requested)\n\tby g4t0017.houston.hp.com (Postfix) with ESMTP id 0B34338035;\n\tThu, 18 Sep 2008 23:01:25 +0000 (UTC)","from [192.168.98.100] (pool-70-109-130-66.cncdnh.east.verizon.net\n\t[70.109.130.66]) by mailstation.cce.hp.com (Postfix) with ESMTP\n\tid 1D5D5C02D; Thu, 18 Sep 2008 18:01:25 -0500 (CDT)"],"Message-ID":"<48D2DDC3.3060406@hp.com>","Date":"Thu, 18 Sep 2008 19:01:23 -0400","From":"Vlad Yasevich ","User-Agent":"Thunderbird 2.0.0.4 (X11/20070604)","MIME-Version":"1.0","To":"davem@davemloft.net","Cc":"netdev@vger.kernel.org, linux-sctp@vger.kernel.org,\n\tlksctp-developers@lists.sourceforge.net","Subject":"Re: [Lksctp-developers] [PATCH 1/2] sctp: do not enable peer\n\tfeatures if we can't do them.","References":"<1221773464-28845-1-git-send-email-vladislav.yasevich@hp.com>","In-Reply-To":"<1221773464-28845-1-git-send-email-vladislav.yasevich@hp.com>","X-Enigmail-Version":"0.95.7","Content-Type":"text/plain; charset=ISO-8859-1","Content-Transfer-Encoding":"7bit","X-Brightmail-Tracker":"AAAAAQAAAAI=","X-Whitelist":"TRUE","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1237,"web_url":"http://patchwork.ozlabs.org/comment/1237/","msgid":"<20080918.161818.29564518.davem@davemloft.net>","list_archive_url":null,"date":"2008-09-18T23:18:18","subject":"Re: [Lksctp-developers] [PATCH 1/2] sctp: do not enable peer\n\tfeatures if we can't do them.","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Vlad Yasevich \nDate: Thu, 18 Sep 2008 19:01:23 -0400\n\n> Can you also queue this one and Patch 2/2 to stable. The problems\n> are there as well.\n\nSure thing.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Received":["from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id 93DF2DDEE8\n\tfor ;\n\tFri, 19 Sep 2008 09:18:37 +1000 (EST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755788AbYIRXSc (ORCPT );\n\tThu, 18 Sep 2008 19:18:32 -0400","(majordomo@vger.kernel.org) by vger.kernel.org id S1755682AbYIRXSb\n\t(ORCPT ); Thu, 18 Sep 2008 19:18:31 -0400","from 74-93-104-97-Washington.hfc.comcastbusiness.net\n\t([74.93.104.97]:35160\n\t\"EHLO sunset.davemloft.net\" rhost-flags-OK-FAIL-OK-OK)\n\tby vger.kernel.org with ESMTP id S1754570AbYIRXSb (ORCPT\n\t); Thu, 18 Sep 2008 19:18:31 -0400","from localhost (localhost [127.0.0.1])\n\tby sunset.davemloft.net (Postfix) with ESMTP id 1AFAAC8C181;\n\tThu, 18 Sep 2008 16:18:19 -0700 (PDT)"],"Date":"Thu, 18 Sep 2008 16:18:18 -0700 (PDT)","Message-Id":"<20080918.161818.29564518.davem@davemloft.net>","To":"vladislav.yasevich@hp.com","Cc":"netdev@vger.kernel.org, linux-sctp@vger.kernel.org,\n\tlksctp-developers@lists.sourceforge.net","Subject":"Re: [Lksctp-developers] [PATCH 1/2] sctp: do not enable peer\n\tfeatures if we can't do them.","From":"David Miller ","In-Reply-To":"<48D2DDC3.3060406@hp.com>","References":"<1221773464-28845-1-git-send-email-vladislav.yasevich@hp.com>\n\t<48D2DDC3.3060406@hp.com>","X-Mailer":"Mew version 6.1 on Emacs 22.1 / Mule 5.0 (SAKAKI)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1238,"web_url":"http://patchwork.ozlabs.org/comment/1238/","msgid":"<20080918.162941.157950819.davem@davemloft.net>","list_archive_url":null,"date":"2008-09-18T23:29:41","subject":"Re: [PATCH 1/2] sctp: do not enable peer features if we can't do\n\tthem.","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Vlad Yasevich \nDate: Thu, 18 Sep 2008 17:31:03 -0400\n\n> Do not enable peer features like addip and auth, if they\n> are administratively disabled localy. If the peer resports\n> that he supports something that we don't, neither end can\n> use it so enabling it is pointless. This solves a problem\n> when talking to a peer that has auth and addip enabled while\n> we do not. Found by Andrei Pelinescu-Onciul .\n> \n> Signed-off-by: Vlad Yasevich \n\nI applied this, but it is at best borderline for outside the\nmerge window. It doesn't fix an OOPS nor a security issue nor\nan entry in the 2.6.x regression list, therefore strictly speaking\nthis fix is not appropriate at this time.\n\nPlease apply this criteria when deciding whether to submit future\nfixes for net-2.6 inclusion.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Received":["from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id 99EFFDDF9C\n\tfor ;\n\tFri, 19 Sep 2008 09:29:59 +1000 (EST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755047AbYIRX3y (ORCPT );\n\tThu, 18 Sep 2008 19:29:54 -0400","(majordomo@vger.kernel.org) by vger.kernel.org id S1755221AbYIRX3y\n\t(ORCPT ); Thu, 18 Sep 2008 19:29:54 -0400","from 74-93-104-97-Washington.hfc.comcastbusiness.net\n\t([74.93.104.97]:39882\n\t\"EHLO sunset.davemloft.net\" rhost-flags-OK-FAIL-OK-OK)\n\tby vger.kernel.org with ESMTP id S1755018AbYIRX3x (ORCPT\n\t); Thu, 18 Sep 2008 19:29:53 -0400","from localhost (localhost [127.0.0.1])\n\tby sunset.davemloft.net (Postfix) with ESMTP id 64030C8C181;\n\tThu, 18 Sep 2008 16:29:41 -0700 (PDT)"],"Date":"Thu, 18 Sep 2008 16:29:41 -0700 (PDT)","Message-Id":"<20080918.162941.157950819.davem@davemloft.net>","To":"vladislav.yasevich@hp.com","Cc":"linux-sctp@vger.kernel.org,\n\tlksctp-developers@lists.sourceforge.net, netdev@vger.kernel.org","Subject":"Re: [PATCH 1/2] sctp: do not enable peer features if we can't do\n\tthem.","From":"David Miller ","In-Reply-To":"<1221773464-28845-1-git-send-email-vladislav.yasevich@hp.com>","References":"<1221773464-28845-1-git-send-email-vladislav.yasevich@hp.com>","X-Mailer":"Mew version 6.1 on Emacs 22.1 / Mule 5.0 (SAKAKI)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1273,"web_url":"http://patchwork.ozlabs.org/comment/1273/","msgid":"<48D31609.2090406@hp.com>","list_archive_url":null,"date":"2008-09-19T03:01:29","subject":"Re: [PATCH 1/2] sctp: do not enable peer features if we can't do\n\tthem.","submitter":{"id":279,"url":"http://patchwork.ozlabs.org/api/people/279/","name":"Vlad Yasevich","email":"vladislav.yasevich@hp.com"},"content":"David Miller wrote:\n> From: Vlad Yasevich \n> Date: Thu, 18 Sep 2008 17:31:03 -0400\n> \n>> Do not enable peer features like addip and auth, if they\n>> are administratively disabled localy. If the peer resports\n>> that he supports something that we don't, neither end can\n>> use it so enabling it is pointless. This solves a problem\n>> when talking to a peer that has auth and addip enabled while\n>> we do not. Found by Andrei Pelinescu-Onciul .\n>>\n>> Signed-off-by: Vlad Yasevich \n> \n> I applied this, but it is at best borderline for outside the\n> merge window. It doesn't fix an OOPS nor a security issue nor\n> an entry in the 2.6.x regression list, therefore strictly speaking\n> this fix is not appropriate at this time.\n> \n> Please apply this criteria when deciding whether to submit future\n> fixes for net-2.6 inclusion.\n> \n\nIt is a major interoperability issue. With the default sysctl settings,\nwe can not establish connection to BSD systems. Yes, there is a workaround\nof turning on the 2 required sysctl settings, but that is totally suboptimal.\n\nI've thought about this fix for a while, and in my opinion, the interoperability\nproblem is large enough to warrant the fix at this time and the backport to\ntable.\n\nOf course you are free to not include this in net-2.6, but I hope you will.\n\nThanks\n-vlad","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Received":["from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id 04256DDE09\n\tfor ;\n\tFri, 19 Sep 2008 13:01:38 +1000 (EST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755722AbYISDBd (ORCPT );\n\tThu, 18 Sep 2008 23:01:33 -0400","(majordomo@vger.kernel.org) by vger.kernel.org id S1755909AbYISDBd\n\t(ORCPT ); Thu, 18 Sep 2008 23:01:33 -0400","from g5t0007.atlanta.hp.com ([15.192.0.44]:48837 \"EHLO\n\tg5t0007.atlanta.hp.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1755324AbYISDBc (ORCPT\n\t); Thu, 18 Sep 2008 23:01:32 -0400","from mailstation.cce.hp.com (mailstation.zcce.gate.cpqcorp.net\n\t[16.104.192.124])\n\t(using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits))\n\t(No client certificate requested)\n\tby g5t0007.atlanta.hp.com (Postfix) with ESMTP id 2E51E14E7A;\n\tFri, 19 Sep 2008 03:01:32 +0000 (UTC)","from [192.168.98.100] (pool-70-109-130-66.cncdnh.east.verizon.net\n\t[70.109.130.66]) by mailstation.cce.hp.com (Postfix) with ESMTP\n\tid 08953C039; Thu, 18 Sep 2008 22:01:31 -0500 (CDT)"],"Message-ID":"<48D31609.2090406@hp.com>","Date":"Thu, 18 Sep 2008 23:01:29 -0400","From":"Vlad Yasevich ","User-Agent":"Thunderbird 2.0.0.4 (X11/20070604)","MIME-Version":"1.0","To":"David Miller ","Cc":"linux-sctp@vger.kernel.org,\n\tlksctp-developers@lists.sourceforge.net, netdev@vger.kernel.org","Subject":"Re: [PATCH 1/2] sctp: do not enable peer features if we can't do\n\tthem.","References":"<1221773464-28845-1-git-send-email-vladislav.yasevich@hp.com>\n\t<20080918.162941.157950819.davem@davemloft.net>","In-Reply-To":"<20080918.162941.157950819.davem@davemloft.net>","X-Enigmail-Version":"0.95.7","Content-Type":"text/plain; charset=ISO-8859-1","Content-Transfer-Encoding":"7bit","X-Brightmail-Tracker":"AAAAAQAAAAI=","X-Whitelist":"TRUE","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]