Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2227372/?format=api
{ "id": 2227372, "url": "http://patchwork.ozlabs.org/api/patches/2227372/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423135035.50126-7-philmd@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260423135035.50126-7-philmd@linaro.org>", "list_archive_url": null, "date": "2026-04-23T13:50:32", "name": "[6/9] target/s390x: Compile vec_helper.c as common unit", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "ccc9f84be4590a8ae88b89e6eca984e64ff09b13", "submitter": { "id": 85046, "url": "http://patchwork.ozlabs.org/api/people/85046/?format=api", "name": "Philippe Mathieu-Daudé", "email": "philmd@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423135035.50126-7-philmd@linaro.org/mbox/", "series": [ { "id": 501199, "url": "http://patchwork.ozlabs.org/api/series/501199/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501199", "date": "2026-04-23T13:50:26", "name": "target/s390x/tcg: Compile various files once", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501199/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2227372/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2227372/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=yP5ooZwI;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1cxG3yMZz1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 23:53:06 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wFuSx-0000ra-3A; Thu, 23 Apr 2026 09:51:39 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wFuSs-0000ou-Hp\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 09:51:34 -0400", "from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wFuSn-00062D-L5\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 09:51:34 -0400", "by mail-wm1-x32f.google.com with SMTP id\n 5b1f17b1804b1-488ff90d6c7so54339065e9.2\n for <qemu-devel@nongnu.org>; Thu, 23 Apr 2026 06:51:29 -0700 (PDT)", "from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4dc24cfsm52929644f8f.16.2026.04.23.06.51.25\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Thu, 23 Apr 2026 06:51:26 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776952288; x=1777557088; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=TV5SHzMGyuCZLfuGlO0hhVjuqtuLPymTcSzN76BqbEE=;\n b=yP5ooZwIdoBIWhA9Ib9jOE4izNvpinPCie2GUVNgMx8JlT+3NsgSMO/V3OZr+o17Fv\n KYotqr3EhWml3PB8VhVoouY2eUY/NRk5LsQOukthO7GhlOWqMGIhZP5N2CllAg/NmCWF\n iFk/dEjboXMLlMnVCUgbMZ7xU8KbgjXVXfRTHXTgSOuwLhlxek8FxY+7xmQmcp6YslEj\n xw0yuEjsvKnnpifJreoR/ALrjRwULXxziZwSNI462bvh3Bm2TPGIleXNCeikQJKzU02u\n DErszQveW6CrClTr2h4A+hcvNVI62PcN/lXxVwEMJQSeBamn9TQKvF2gJAzH+ftA93I3\n zN1w==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776952288; x=1777557088;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=TV5SHzMGyuCZLfuGlO0hhVjuqtuLPymTcSzN76BqbEE=;\n b=ZyY6MgJKYlW8FKMT0Bl5N9nAz5M/IzJFNhvezd/2JlA1c1vmF1VpOUQRN9jaPr/Etr\n hSPyZ/PvBcZuz7wCpuoAilFolI2APdE8f7lA5E1wSSd1RDBj/ezKpAQdejUSJx9/x6mX\n 60L1MEWjQ+x2u2ObiUSyWWIeq/NcAWIJeXdDI+kfpgm+SIWsTko3NIeFp0NAyDFLv/dc\n i2oE7GT6hNWaHvsZXea7WrpVtW2pAos1mmSd+oMSHyRUnW51r8K7w/tJLrhJVqDmiRmP\n hGBkTwv97UG3vI1gV4bkHP16dZwWz3Fs8oLB0HLc+sfaRCnaO33ZcMuiegSKSKfCuqDz\n qmQA==", "X-Gm-Message-State": "AOJu0YyUGTDB/dozYm1pFL8qggjDN7jn+tzVatMoZHAfjrGCoOOQlVvY\n z5dO+UaJuM8jsUCT09bRTcvrE27JFiHffacQW9YmdBxnZjlFBrfe1hAKd8duMOKgyvkbjldr6ln\n 0RUkIvnc=", "X-Gm-Gg": "AeBDieunzXGfJxC+Mrl4nPvNKzglYgzMhrnc6gQUNqXG1DUKULxfLo2LRc+TDbKr6EC\n Sqse03eXxoPIur51x/MAZMvHonBtyQJ4RmGuwWA7MbAYWMJ3xR3cLEDUz68fIqcQ+XZ0AT8qyHm\n Sdh25S1/k11vvLmdNvsEEDuGb0VcLDOF03kDTw8TftQ7TRdEzdBnKO5Glvca5YDA9RzhQjGSL71\n 662v9tHSHbYv1LyooEoOB9P0VlNrlT5Sd6pOiiQ38WIgVxhjIwl27MDVPBXp5yxJDbxHyeviXMz\n R0aYl5lfowd6C5XAEH9a4tYVZkidVhywl7X0EA/WbTZ/WdCME3XoY1qYTQ0HtuMCaAoTKZhG0Dv\n blDs3liCnlo1o9XfhGbrBbEIqXo08KPVqkH1OKnWJUXsfHRYR0vmkZzUzIN+6N6kbOw7SyQ2mQW\n gVjjXthAZ5wq3CpmunpAULVrMiq3FSE6BeGZoCh/n/HBq1I1+p9cvcExbvCdhajq/jXTvTaH1ue\n JOTlipXjls=", "X-Received": "by 2002:a05:600c:6296:b0:483:64b4:79da with SMTP id\n 5b1f17b1804b1-488fb7923a9mr359383085e9.26.1776952287743;\n Thu, 23 Apr 2026 06:51:27 -0700 (PDT)", "From": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>,\n Ilya Leoshkevich <iii@linux.ibm.com>, qemu-s390x@nongnu.org,\n Matthew Rosato <mjrosato@linux.ibm.com>,\n David Hildenbrand <david@kernel.org>,\n Richard Henderson <richard.henderson@linaro.org>,\n Halil Pasic <pasic@linux.ibm.com>, Cornelia Huck <cohuck@redhat.com>,\n Eric Farman <farman@linux.ibm.com>,\n Christian Borntraeger <borntraeger@linux.ibm.com>,\n Anton Johansson <anjo@rev.ng>,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "Subject": "[PATCH 6/9] target/s390x: Compile vec_helper.c as common unit", "Date": "Thu, 23 Apr 2026 15:50:32 +0200", "Message-ID": "<20260423135035.50126-7-philmd@linaro.org>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260423135035.50126-1-philmd@linaro.org>", "References": "<20260423135035.50126-1-philmd@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::32f;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32f.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "In order do build vec_helper.c as a common unit we need to\nreplace:\n\n \"accel/tcg/cpu-ldst.h\" -> \"accel/tcg/cpu-ldst-common.h\"\n\nand update the cpu_ld/st_be_data_ra() API by cpu_ld/st_mmu() one.\n\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\n---\nUnrelated but could VLL / VSTL leverage the Int128 type?\n---\n target/s390x/tcg/vec_helper.c | 34 +++++++++++++++++++++++-----------\n target/s390x/tcg/meson.build | 2 +-\n 2 files changed, 24 insertions(+), 12 deletions(-)", "diff": "diff --git a/target/s390x/tcg/vec_helper.c b/target/s390x/tcg/vec_helper.c\nindex 304745c971b..98eecd9fde6 100644\n--- a/target/s390x/tcg/vec_helper.c\n+++ b/target/s390x/tcg/vec_helper.c\n@@ -16,7 +16,8 @@\n #include \"tcg/tcg.h\"\n #include \"tcg/tcg-gvec-desc.h\"\n #include \"exec/helper-proto.h\"\n-#include \"accel/tcg/cpu-ldst.h\"\n+#include \"accel/tcg/cpu-ldst-common.h\"\n+#include \"accel/tcg/cpu-mmu-index.h\"\n \n void HELPER(gvec_vbperm)(void *v1, const void *v2, const void *v3,\n uint32_t desc)\n@@ -42,20 +43,26 @@ void HELPER(gvec_vbperm)(void *v1, const void *v2, const void *v3,\n \n void HELPER(vll)(CPUS390XState *env, void *v1, uint64_t addr, uint64_t bytes)\n {\n+ const int mmu_idx = cpu_mmu_index(env_cpu(env), false);\n+ const uintptr_t ra = GETPC();\n+ MemOpIdx oi;\n+\n if (likely(bytes >= 16)) {\n uint64_t t0, t1;\n \n- t0 = cpu_ldq_be_data_ra(env, addr, GETPC());\n+ oi = make_memop_idx(MO_BE | MO_64 | MO_UNALN, mmu_idx);\n+ t0 = cpu_ldq_mmu(env, addr, oi, ra);\n addr = wrap_address(env, addr + 8);\n- t1 = cpu_ldq_be_data_ra(env, addr, GETPC());\n+ t1 = cpu_ldq_mmu(env, addr, oi, ra);\n s390_vec_write_element64(v1, 0, t0);\n s390_vec_write_element64(v1, 1, t1);\n } else {\n S390Vector tmp = {};\n- int i;\n \n- for (i = 0; i < bytes; i++) {\n- uint8_t byte = cpu_ldub_data_ra(env, addr, GETPC());\n+ oi = make_memop_idx(MO_8, mmu_idx);\n+ for (int i = 0; i < bytes; i++) {\n+ uint8_t byte = cpu_ldb_mmu(env, addr, oi, ra);\n+\n \n s390_vec_write_element8(&tmp, i, byte);\n addr = wrap_address(env, addr + 1);\n@@ -191,20 +198,25 @@ void HELPER(gvec_vperm)(void *v1, const void *v2, const void *v3,\n void HELPER(vstl)(CPUS390XState *env, const void *v1, uint64_t addr,\n uint64_t bytes)\n {\n+ const int mmu_idx = cpu_mmu_index(env_cpu(env), false);\n+ const uintptr_t ra = GETPC();\n+ MemOpIdx oi;\n+\n /* Probe write access before actually modifying memory */\n probe_write_access(env, addr, MIN(bytes, 16), GETPC());\n \n if (likely(bytes >= 16)) {\n- cpu_stq_be_data_ra(env, addr, s390_vec_read_element64(v1, 0), GETPC());\n+ oi = make_memop_idx(MO_BE | MO_64 | MO_UNALN, mmu_idx);\n+ cpu_stq_mmu(env, addr, s390_vec_read_element64(v1, 0), oi, ra);\n addr = wrap_address(env, addr + 8);\n- cpu_stq_be_data_ra(env, addr, s390_vec_read_element64(v1, 1), GETPC());\n+ cpu_stq_mmu(env, addr, s390_vec_read_element64(v1, 1), oi, ra);\n } else {\n- int i;\n+ oi = make_memop_idx(MO_8, mmu_idx);\n \n- for (i = 0; i < bytes; i++) {\n+ for (int i = 0; i < bytes; i++) {\n uint8_t byte = s390_vec_read_element8(v1, i);\n \n- cpu_stb_data_ra(env, addr, byte, GETPC());\n+ cpu_stb_mmu(env, addr, byte, oi, ra);\n addr = wrap_address(env, addr + 1);\n }\n }\ndiff --git a/target/s390x/tcg/meson.build b/target/s390x/tcg/meson.build\nindex d1c60135411..ed6441f6f44 100644\n--- a/target/s390x/tcg/meson.build\n+++ b/target/s390x/tcg/meson.build\n@@ -3,7 +3,6 @@ s390x_ss.add(when: 'CONFIG_TCG', if_true: files(\n 'int_helper.c',\n 'mem_helper.c',\n 'misc_helper.c',\n- 'vec_helper.c',\n ))\n s390x_common_ss.add(when: 'CONFIG_TCG', if_true: files(\n 'cc_helper.c',\n@@ -11,6 +10,7 @@ s390x_common_ss.add(when: 'CONFIG_TCG', if_true: files(\n 'fpu_helper.c',\n 'translate.c',\n 'vec_fpu_helper.c',\n+ 'vec_helper.c',\n 'vec_int_helper.c',\n 'vec_string_helper.c',\n ))\n", "prefixes": [ "6/9" ] }